All of lore.kernel.org
 help / color / mirror / Atom feed
* [Reoprt] Some compile warning on ppc dts
@ 2021-03-01  2:16 ` chenjun (AM)
  0 siblings, 0 replies; 4+ messages in thread
From: chenjun (AM) @ 2021-03-01  2:16 UTC (permalink / raw)
  To: linux-kernel, linuxppc-dev, Rob Herring, Michael Ellerman,
	Benjamin Herrenschmidt, Paul Mackerras, devicetree
  Cc: Xiangrui (Euler)

Hi

After run the following commands
make distclean
make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
make oldconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
make -j64 ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-

I get some warning:
arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): 
/pci@f0000d00: missing ranges for PCI bridg
e (or not a bridge)
arch/powerpc/boot/dts/o2dnt2.dtb: Warning (pci_device_bus_num): Failed 
prerequisite 'pci_bridge'
arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning 
(spi_bus_bridge): /soc5200@f0000000/psc@2000: node name f
or SPI buses should be 'spi'
   also defined at arch/powerpc/boot/dts/o2d.dtsi:32.12-43.5
arch/powerpc/boot/dts/o2dnt2.dtb: Warning (spi_bus_reg): Failed 
prerequisite 'spi_bus_bridge'
..

For the problem about "node name for SPI buses should be 'spi'":
Rename the psc@2000 to spi@2000 in arch/powerpc/boot/dts/o2d.dtsi can 
fix it.
diff --git a/arch/powerpc/boot/dts/o2d.dtsi b/arch/powerpc/boot/dts/o2d.dtsi
index 6661955a2be4..cd3dc70cd72e 100644
--- a/arch/powerpc/boot/dts/o2d.dtsi
+++ b/arch/powerpc/boot/dts/o2d.dtsi
@@ -29,7 +29,7 @@ rtc@800 {
  >------>------->-------status = "disabled";
  >------>-------};
-
->------>-------psc@2000 {>----->-------// PSC1
+>------>-------spi@2000 {>----->-------// PSC1
  >------>------->-------compatible = 
"fsl,mpc5200b-psc-spi","fsl,mpc5200-psc-spi";
  >------>------->-------#address-cells = <1>;
  >------>------->-------#size-cells = <0>;
---

For the problem about "missing ranges for PCI bridge (or not a bridge)":
Ranges should be add in arch/powerpc/boot/dts/mpc5200b.dtsi.
 >-------pci: pci@f0000d00 {
 >------->-------#interrupt-cells = <1>;
 >------->-------#size-cells = <2>;
 >------->-------#address-cells = <3>;
 >------->-------device_type = "pci";
 >------->-------compatible = "fsl,mpc5200b-pci","fsl,mpc5200-pci";
 >------->-------reg = <0xf0000d00 0x100>;
 >------->-------// interrupt-map-mask = need to add
 >------->-------// interrupt-map = need to add
 >------->-------clock-frequency = <0>; // From boot loader
 >------->-------interrupts = <2 8 0 2 9 0 2 10 0>;
 >------->-------bus-range = <0 0>;
 >------->-------// ranges = need to add
 >-------};
I think the ranges should be add by someone who knows the mpc5200 better.

Can anyone fix this?

-- 
Regards
Chen Jun

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Reoprt] Some compile warning on ppc dts
@ 2021-03-01  2:16 ` chenjun (AM)
  0 siblings, 0 replies; 4+ messages in thread
From: chenjun (AM) @ 2021-03-01  2:16 UTC (permalink / raw)
  To: linux-kernel, linuxppc-dev, Rob Herring, Michael Ellerman,
	Benjamin Herrenschmidt, Paul Mackerras, devicetree
  Cc: Xiangrui (Euler)

Hi

After run the following commands
make distclean
make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
make oldconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
make -j64 ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-

I get some warning:
arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): 
/pci@f0000d00: missing ranges for PCI bridg
e (or not a bridge)
arch/powerpc/boot/dts/o2dnt2.dtb: Warning (pci_device_bus_num): Failed 
prerequisite 'pci_bridge'
arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning 
(spi_bus_bridge): /soc5200@f0000000/psc@2000: node name f
or SPI buses should be 'spi'
   also defined at arch/powerpc/boot/dts/o2d.dtsi:32.12-43.5
arch/powerpc/boot/dts/o2dnt2.dtb: Warning (spi_bus_reg): Failed 
prerequisite 'spi_bus_bridge'
...

For the problem about "node name for SPI buses should be 'spi'":
Rename the psc@2000 to spi@2000 in arch/powerpc/boot/dts/o2d.dtsi can 
fix it.
diff --git a/arch/powerpc/boot/dts/o2d.dtsi b/arch/powerpc/boot/dts/o2d.dtsi
index 6661955a2be4..cd3dc70cd72e 100644
--- a/arch/powerpc/boot/dts/o2d.dtsi
+++ b/arch/powerpc/boot/dts/o2d.dtsi
@@ -29,7 +29,7 @@ rtc@800 {
  >------>------->-------status = "disabled";
  >------>-------};
-
->------>-------psc@2000 {>----->-------// PSC1
+>------>-------spi@2000 {>----->-------// PSC1
  >------>------->-------compatible = 
"fsl,mpc5200b-psc-spi","fsl,mpc5200-psc-spi";
  >------>------->-------#address-cells = <1>;
  >------>------->-------#size-cells = <0>;
---

For the problem about "missing ranges for PCI bridge (or not a bridge)":
Ranges should be add in arch/powerpc/boot/dts/mpc5200b.dtsi.
 >-------pci: pci@f0000d00 {
 >------->-------#interrupt-cells = <1>;
 >------->-------#size-cells = <2>;
 >------->-------#address-cells = <3>;
 >------->-------device_type = "pci";
 >------->-------compatible = "fsl,mpc5200b-pci","fsl,mpc5200-pci";
 >------->-------reg = <0xf0000d00 0x100>;
 >------->-------// interrupt-map-mask = need to add
 >------->-------// interrupt-map = need to add
 >------->-------clock-frequency = <0>; // From boot loader
 >------->-------interrupts = <2 8 0 2 9 0 2 10 0>;
 >------->-------bus-range = <0 0>;
 >------->-------// ranges = need to add
 >-------};
I think the ranges should be add by someone who knows the mpc5200 better.

Can anyone fix this?

-- 
Regards
Chen Jun

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Reoprt] Some compile warning on ppc dts
  2021-03-01  2:16 ` chenjun (AM)
@ 2022-03-02 16:23   ` Christophe Leroy
  -1 siblings, 0 replies; 4+ messages in thread
From: Christophe Leroy @ 2022-03-02 16:23 UTC (permalink / raw)
  To: chenjun (AM),
	linux-kernel, linuxppc-dev, Rob Herring, Michael Ellerman,
	Benjamin Herrenschmidt, Paul Mackerras, devicetree
  Cc: Xiangrui (Euler)



Le 01/03/2021 à 03:16, chenjun (AM) a écrit :
> Hi
> 
> After run the following commands
> make distclean
> make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
> make oldconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
> make -j64 ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
> 
> I get some warning:
> arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge):
> /pci@f0000d00: missing ranges for PCI bridg
> e (or not a bridge)
> arch/powerpc/boot/dts/o2dnt2.dtb: Warning (pci_device_bus_num): Failed
> prerequisite 'pci_bridge'
> arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning
> (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name f
> or SPI buses should be 'spi'
>     also defined at arch/powerpc/boot/dts/o2d.dtsi:32.12-43.5
> arch/powerpc/boot/dts/o2dnt2.dtb: Warning (spi_bus_reg): Failed
> prerequisite 'spi_bus_bridge'
> ...
> 
> For the problem about "node name for SPI buses should be 'spi'":
> Rename the psc@2000 to spi@2000 in arch/powerpc/boot/dts/o2d.dtsi can
> fix it.
> diff --git a/arch/powerpc/boot/dts/o2d.dtsi b/arch/powerpc/boot/dts/o2d.dtsi
> index 6661955a2be4..cd3dc70cd72e 100644
> --- a/arch/powerpc/boot/dts/o2d.dtsi
> +++ b/arch/powerpc/boot/dts/o2d.dtsi
> @@ -29,7 +29,7 @@ rtc@800 {
>    >------>------->-------status = "disabled";
>    >------>-------};
> -
> ->------>-------psc@2000 {>----->-------// PSC1
> +>------>-------spi@2000 {>----->-------// PSC1
>    >------>------->-------compatible =
> "fsl,mpc5200b-psc-spi","fsl,mpc5200-psc-spi";
>    >------>------->-------#address-cells = <1>;
>    >------>------->-------#size-cells = <0>;
> ---
> 
> For the problem about "missing ranges for PCI bridge (or not a bridge)":
> Ranges should be add in arch/powerpc/boot/dts/mpc5200b.dtsi.
>   >-------pci: pci@f0000d00 {
>   >------->-------#interrupt-cells = <1>;
>   >------->-------#size-cells = <2>;
>   >------->-------#address-cells = <3>;
>   >------->-------device_type = "pci";
>   >------->-------compatible = "fsl,mpc5200b-pci","fsl,mpc5200-pci";
>   >------->-------reg = <0xf0000d00 0x100>;
>   >------->-------// interrupt-map-mask = need to add
>   >------->-------// interrupt-map = need to add
>   >------->-------clock-frequency = <0>; // From boot loader
>   >------->-------interrupts = <2 8 0 2 9 0 2 10 0>;
>   >------->-------bus-range = <0 0>;
>   >------->-------// ranges = need to add
>   >-------};
> I think the ranges should be add by someone who knows the mpc5200 better.
> 


This patch has garbage instead of tabs, it doesn't apply

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Reoprt] Some compile warning on ppc dts
@ 2022-03-02 16:23   ` Christophe Leroy
  0 siblings, 0 replies; 4+ messages in thread
From: Christophe Leroy @ 2022-03-02 16:23 UTC (permalink / raw)
  To: chenjun (AM),
	linux-kernel, linuxppc-dev, Rob Herring, Michael Ellerman,
	Benjamin Herrenschmidt, Paul Mackerras, devicetree
  Cc: Xiangrui (Euler)



Le 01/03/2021 à 03:16, chenjun (AM) a écrit :
> Hi
> 
> After run the following commands
> make distclean
> make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
> make oldconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
> make -j64 ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
> 
> I get some warning:
> arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge):
> /pci@f0000d00: missing ranges for PCI bridg
> e (or not a bridge)
> arch/powerpc/boot/dts/o2dnt2.dtb: Warning (pci_device_bus_num): Failed
> prerequisite 'pci_bridge'
> arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning
> (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name f
> or SPI buses should be 'spi'
>     also defined at arch/powerpc/boot/dts/o2d.dtsi:32.12-43.5
> arch/powerpc/boot/dts/o2dnt2.dtb: Warning (spi_bus_reg): Failed
> prerequisite 'spi_bus_bridge'
> ...
> 
> For the problem about "node name for SPI buses should be 'spi'":
> Rename the psc@2000 to spi@2000 in arch/powerpc/boot/dts/o2d.dtsi can
> fix it.
> diff --git a/arch/powerpc/boot/dts/o2d.dtsi b/arch/powerpc/boot/dts/o2d.dtsi
> index 6661955a2be4..cd3dc70cd72e 100644
> --- a/arch/powerpc/boot/dts/o2d.dtsi
> +++ b/arch/powerpc/boot/dts/o2d.dtsi
> @@ -29,7 +29,7 @@ rtc@800 {
>    >------>------->-------status = "disabled";
>    >------>-------};
> -
> ->------>-------psc@2000 {>----->-------// PSC1
> +>------>-------spi@2000 {>----->-------// PSC1
>    >------>------->-------compatible =
> "fsl,mpc5200b-psc-spi","fsl,mpc5200-psc-spi";
>    >------>------->-------#address-cells = <1>;
>    >------>------->-------#size-cells = <0>;
> ---
> 
> For the problem about "missing ranges for PCI bridge (or not a bridge)":
> Ranges should be add in arch/powerpc/boot/dts/mpc5200b.dtsi.
>   >-------pci: pci@f0000d00 {
>   >------->-------#interrupt-cells = <1>;
>   >------->-------#size-cells = <2>;
>   >------->-------#address-cells = <3>;
>   >------->-------device_type = "pci";
>   >------->-------compatible = "fsl,mpc5200b-pci","fsl,mpc5200-pci";
>   >------->-------reg = <0xf0000d00 0x100>;
>   >------->-------// interrupt-map-mask = need to add
>   >------->-------// interrupt-map = need to add
>   >------->-------clock-frequency = <0>; // From boot loader
>   >------->-------interrupts = <2 8 0 2 9 0 2 10 0>;
>   >------->-------bus-range = <0 0>;
>   >------->-------// ranges = need to add
>   >-------};
> I think the ranges should be add by someone who knows the mpc5200 better.
> 


This patch has garbage instead of tabs, it doesn't apply

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-02 16:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01  2:16 [Reoprt] Some compile warning on ppc dts chenjun (AM)
2021-03-01  2:16 ` chenjun (AM)
2022-03-02 16:23 ` Christophe Leroy
2022-03-02 16:23   ` Christophe Leroy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.