[PATCH 2/2] Eliminate camel case

[PATCH 2/2] Eliminate camel case

[vatsalanarang]

Issue reported by checkpatch.pl tool

Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
---
 drivers/staging/sm750fb/ddk750_display.c | 5 ++---
 drivers/staging/sm750fb/ddk750_power.h   | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
index 7f28e4cc4c79..6380e1536598 100644
--- a/drivers/staging/sm750fb/ddk750_display.c
+++ b/drivers/staging/sm750fb/ddk750_display.c
@@ -147,8 +147,8 @@ void ddk750_set_logical_disp_out(enum disp_output output)
 
 	if (output & PNL_SEQ_USAGE) {
 		/* set  panel sequence */
-		sw_panel_power_sequence
-		((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET, 4);
+		sw_panel_power_sequence((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET,
+				4);
 	}
 
 	if (output & DAC_USAGE)
@@ -156,4 +156,3 @@ void ddk750_set_logical_disp_out(enum disp_output output)
 
 	if (output & DPMS_USAGE)
 		ddk750_set_dpms((output & DPMS_MASK) >> DPMS_OFFSET);
}
diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h
index e48c74ecbbd1..7002567a47d2 100644
--- a/drivers/staging/sm750fb/ddk750_power.h
+++ b/drivers/staging/sm750fb/ddk750_power.h
@@ -9,7 +9,7 @@ enum dpms {
 	crtDPMS_OFF = 0x3,
 };
 
-#define setDAC(off) {							\
+#define set_DAC(off) {							\
 	poke32(MISC_CTRL,						\
 	       (peek32(MISC_CTRL) & ~MISC_CTRL_DAC_POWER_OFF) | (off)); \
 }
-- 
2.17.1

Re: [PATCH 2/2] Eliminate camel case

[Greg KH]

On Mon, Mar 18, 2019 at 10:29:38PM +0530, vatsalanarang wrote:
> Issue reported by checkpatch.pl tool
> 
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_display.c | 5 ++---
>  drivers/staging/sm750fb/ddk750_power.h   | 2 +-
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
> index 7f28e4cc4c79..6380e1536598 100644
> --- a/drivers/staging/sm750fb/ddk750_display.c
> +++ b/drivers/staging/sm750fb/ddk750_display.c
> @@ -147,8 +147,8 @@ void ddk750_set_logical_disp_out(enum disp_output output)
>  
>  	if (output & PNL_SEQ_USAGE) {
>  		/* set  panel sequence */
> -		sw_panel_power_sequence
> -		((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET, 4);
> +		sw_panel_power_sequence((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET,
> +				4);

This is not what your subject said it was doing :(

Also, it doesn't look correct, right?

And your From: line needs to match your signed-off-by line.

And finally, this is patch 2/2?  Where is 1/2?

thanks,

greg k-h

Re: [PATCH 2/2] Eliminate camel case

[Vatsala Narang]

[-- Attachment #1.1: Type: text/plain, Size: 536 bytes --]

Patch 1/2 is under the heading:Edit CamelCase function names to make code 
more readable; as the heading earlier was too long so I made it concise

> -                sw_panel_power_sequence 
> -                ((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET, 4); 
> +                sw_panel_power_sequence((output & PNL_SEQ_MASK) >> 
> PNL_SEQ_OFFSET, 
> +                                4); 
>  
>
I corrected its camelcase in earlier patch,if the patchset should have 
similar title, I will combine both and resend it.
thanks,
Vatsala
 

[-- Attachment #1.2: Type: text/html, Size: 857 bytes --]