imx6ul.dtsi missing ipg clock and pgc node

imx6ul.dtsi missing ipg clock and pgc node

[Stefan Wahren]

Hi,

i ran make dtbs_check for a imx6ull board and noticed that there are 
some warnings:

gpc@20dc000: 'clocks' is a required property
     From schema: 
/home/stefanw/linux-next-real/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
gpc@20dc000: 'clock-names' is a required property
     From schema: 
/home/stefanw/linux-next-real/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
gpc@20dc000: 'pgc' is a required property
     From schema: 
/home/stefanw/linux-next-real/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml

According to the i.MX6ULL reference manual the clock and the power gate 
control IP seems to exists. Adding the ipg clock should be trivial, but 
i don't have a clue which power domains are available to pgc. I also 
didn't find anything in the Linux 4.9 vendor tree.

Can anyone help here?

Best regards


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: imx6ul.dtsi missing ipg clock and pgc node

[Stefan Wahren]

Hi Dong,
hi Peng,

Am 11.02.23 um 14:35 schrieb Stefan Wahren:
> Hi,
>
> i ran make dtbs_check for a imx6ull board and noticed that there are 
> some warnings:
>
> gpc@20dc000: 'clocks' is a required property
>     From schema: 
> /home/stefanw/linux-next-real/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> gpc@20dc000: 'clock-names' is a required property
>     From schema: 
> /home/stefanw/linux-next-real/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> gpc@20dc000: 'pgc' is a required property
>     From schema: 
> /home/stefanw/linux-next-real/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
>
> According to the i.MX6ULL reference manual the clock and the power 
> gate control IP seems to exists. Adding the ipg clock should be 
> trivial, but i don't have a clue which power domains are available to 
> pgc. I also didn't find anything in the Linux 4.9 vendor tree.
>
> Can anyone help here?

originally i send this also to Anson Huang, but his email address was 
bouncing. Maybe you can help me here.

Best regards

>
> Best regards
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: imx6ul.dtsi missing ipg clock and pgc node

[Jacky Bai]

Hi Stefan,

> Subject: Re: imx6ul.dtsi missing ipg clock and pgc node
> 
> Hi Dong,
> hi Peng,
> 
> Am 11.02.23 um 14:35 schrieb Stefan Wahren:
> > Hi,
> >
> > i ran make dtbs_check for a imx6ull board and noticed that there are
> > some warnings:
> >
> > gpc@20dc000: 'clocks' is a required property
> >     From schema:
> >
> /home/stefanw/linux-next-real/Documentation/devicetree/bindings/power/
> > fsl,imx-gpc.yaml
> > gpc@20dc000: 'clock-names' is a required property
> >     From schema:
> >
> /home/stefanw/linux-next-real/Documentation/devicetree/bindings/power/
> > fsl,imx-gpc.yaml
> > gpc@20dc000: 'pgc' is a required property
> >     From schema:
> >
> /home/stefanw/linux-next-real/Documentation/devicetree/bindings/power/
> > fsl,imx-gpc.yaml
> >
> > According to the i.MX6ULL reference manual the clock and the power
> > gate control IP seems to exists. Adding the ipg clock should be
> > trivial, but i don't have a clue which power domains are available to
> > pgc. I also didn't find anything in the Linux 4.9 vendor tree.
> >
> > Can anyone help here?

ipg clock is the IMX6UL_CLK_IPG, for PGC, the arm PGC is available and can also be added to fix the dtbs_check issue.

pgc {
        #address-cells = <1>;
        #size-cells = <0>;

        power-domain@0 {
                reg = <0>;
                #power-domain-cells = <0>;
        };
};

You will submit a fix or need NXP to do that?

BR
> 
> originally i send this also to Anson Huang, but his email address was bouncing.
> Maybe you can help me here.
> 
> Best regards
> 
> >
> > Best regards
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: imx6ul.dtsi missing ipg clock and pgc node

[Stefan Wahren]

Hi Jacky,

Am 24.02.23 um 02:23 schrieb Jacky Bai:
> Hi Stefan,
>
>> Subject: Re: imx6ul.dtsi missing ipg clock and pgc node
>>
>> Hi Dong,
>> hi Peng,
>>
>> Am 11.02.23 um 14:35 schrieb Stefan Wahren:
>>> Hi,
>>>
>>> i ran make dtbs_check for a imx6ull board and noticed that there are
>>> some warnings:
>>>
>>> gpc@20dc000: 'clocks' is a required property
>>>      From schema:
>>>
>> /home/stefanw/linux-next-real/Documentation/devicetree/bindings/power/
>>> fsl,imx-gpc.yaml
>>> gpc@20dc000: 'clock-names' is a required property
>>>      From schema:
>>>
>> /home/stefanw/linux-next-real/Documentation/devicetree/bindings/power/
>>> fsl,imx-gpc.yaml
>>> gpc@20dc000: 'pgc' is a required property
>>>      From schema:
>>>
>> /home/stefanw/linux-next-real/Documentation/devicetree/bindings/power/
>>> fsl,imx-gpc.yaml
>>>
>>> According to the i.MX6ULL reference manual the clock and the power
>>> gate control IP seems to exists. Adding the ipg clock should be
>>> trivial, but i don't have a clue which power domains are available to
>>> pgc. I also didn't find anything in the Linux 4.9 vendor tree.
>>>
>>> Can anyone help here?
> ipg clock is the IMX6UL_CLK_IPG, for PGC, the arm PGC is available and can also be added to fix the dtbs_check issue.
>
> pgc {
>          #address-cells = <1>;
>          #size-cells = <0>;
>
>          power-domain@0 {
>                  reg = <0>;
>                  #power-domain-cells = <0>;
>          };
> };
>
> You will submit a fix or need NXP to do that?

i plan to submit related imx6ul DTS fixes, so i can integrate this one.

Thanks

>
> BR
>> originally i send this also to Anson Huang, but his email address was bouncing.
>> Maybe you can help me here.
>>
>> Best regards
>>
>>> Best regards
>>>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel