From: Kishon Vijay Abraham I <kishon@ti.com> To: Niklas Cassel <niklas.cassel@axis.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Bjorn Helgaas <bhelgaas@google.com> Cc: Niklas Cassel <niklass@axis.com>, <linux-omap@vger.kernel.org>, <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v6 09/18] PCI: dwc: dra7xx: Help compiler to remove unused code Date: Wed, 20 Dec 2017 11:28:55 +0530 [thread overview] Message-ID: <d6d663b1-c76e-5b1d-8bd0-95e712b690ea@ti.com> (raw) In-Reply-To: <20171219232940.659-10-niklas.cassel@axis.com> On Wednesday 20 December 2017 04:59 AM, Niklas Cassel wrote: > The dra7xx driver supports both host and ep mode. > When enabling support for only one of the modes, help the compiler > to remove code for the mode that we have not enabled in the driver. > > By adding if (!IS_ENABLED(CONFIG_PCI_DRA7XX_HOST)) return -ENODEV; > anything after that statement will get silently dropped by the compiler, > including static functions and structures that are referenced indirectly > from there. > > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Niklas Cassel <niklas.cassel@axis.com> Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > drivers/pci/dwc/pci-dra7xx.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c > index 07c74ae3614e..224ff8affdce 100644 > --- a/drivers/pci/dwc/pci-dra7xx.c > +++ b/drivers/pci/dwc/pci-dra7xx.c > @@ -694,6 +694,11 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) > > switch (mode) { > case DW_PCIE_RC_TYPE: > + if (!IS_ENABLED(CONFIG_PCI_DRA7XX_HOST)) { > + ret = -ENODEV; > + goto err_gpio; > + } > + > dra7xx_pcie_writel(dra7xx, PCIECTRL_TI_CONF_DEVICE_TYPE, > DEVICE_TYPE_RC); > ret = dra7xx_add_pcie_port(dra7xx, pdev); > @@ -701,6 +706,11 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) > goto err_gpio; > break; > case DW_PCIE_EP_TYPE: > + if (!IS_ENABLED(CONFIG_PCI_DRA7XX_EP)) { > + ret = -ENODEV; > + goto err_gpio; > + } > + > dra7xx_pcie_writel(dra7xx, PCIECTRL_TI_CONF_DEVICE_TYPE, > DEVICE_TYPE_EP); > >
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com> To: Niklas Cassel <niklas.cassel@axis.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Bjorn Helgaas <bhelgaas@google.com> Cc: Niklas Cassel <niklass@axis.com>, linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 09/18] PCI: dwc: dra7xx: Help compiler to remove unused code Date: Wed, 20 Dec 2017 11:28:55 +0530 [thread overview] Message-ID: <d6d663b1-c76e-5b1d-8bd0-95e712b690ea@ti.com> (raw) In-Reply-To: <20171219232940.659-10-niklas.cassel@axis.com> On Wednesday 20 December 2017 04:59 AM, Niklas Cassel wrote: > The dra7xx driver supports both host and ep mode. > When enabling support for only one of the modes, help the compiler > to remove code for the mode that we have not enabled in the driver. > > By adding if (!IS_ENABLED(CONFIG_PCI_DRA7XX_HOST)) return -ENODEV; > anything after that statement will get silently dropped by the compiler, > including static functions and structures that are referenced indirectly > from there. > > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Niklas Cassel <niklas.cassel@axis.com> Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > drivers/pci/dwc/pci-dra7xx.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c > index 07c74ae3614e..224ff8affdce 100644 > --- a/drivers/pci/dwc/pci-dra7xx.c > +++ b/drivers/pci/dwc/pci-dra7xx.c > @@ -694,6 +694,11 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) > > switch (mode) { > case DW_PCIE_RC_TYPE: > + if (!IS_ENABLED(CONFIG_PCI_DRA7XX_HOST)) { > + ret = -ENODEV; > + goto err_gpio; > + } > + > dra7xx_pcie_writel(dra7xx, PCIECTRL_TI_CONF_DEVICE_TYPE, > DEVICE_TYPE_RC); > ret = dra7xx_add_pcie_port(dra7xx, pdev); > @@ -701,6 +706,11 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) > goto err_gpio; > break; > case DW_PCIE_EP_TYPE: > + if (!IS_ENABLED(CONFIG_PCI_DRA7XX_EP)) { > + ret = -ENODEV; > + goto err_gpio; > + } > + > dra7xx_pcie_writel(dra7xx, PCIECTRL_TI_CONF_DEVICE_TYPE, > DEVICE_TYPE_EP); > >
next prev parent reply other threads:[~2017-12-20 5:59 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-19 23:29 [PATCH v6 00/18] dwc MSI fixes, ARTPEC-6 EP mode support, ARTPEC-7 SoC support Niklas Cassel 2017-12-19 23:29 ` Niklas Cassel 2017-12-19 23:29 ` [PATCH v6 01/18] PCI: dwc: Use the DMA-API to get the MSI address Niklas Cassel 2017-12-20 19:10 ` Joao Pinto 2017-12-21 16:43 ` Jingoo Han 2017-12-21 16:43 ` Jingoo Han 2020-09-23 23:18 ` Rob Herring 2017-12-19 23:29 ` [PATCH v6 02/18] PCI: designware-ep: dw_pcie_ep_set_msi() should only set MMC bits Niklas Cassel 2017-12-20 19:17 ` Joao Pinto 2017-12-21 16:44 ` Jingoo Han 2017-12-21 16:44 ` Jingoo Han 2017-12-19 23:29 ` [PATCH v6 03/18] PCI: designware-ep: Read-only registers need DBI_RO_WR_EN to be writable Niklas Cassel 2017-12-20 19:18 ` Joao Pinto 2017-12-21 16:45 ` Jingoo Han 2017-12-21 16:45 ` Jingoo Han 2017-12-19 23:29 ` [PATCH v6 04/18] PCI: designware-ep: Pre-allocate memory for MSI in dw_pcie_ep_init Niklas Cassel 2017-12-20 19:30 ` Joao Pinto 2017-12-21 16:46 ` Jingoo Han 2017-12-21 16:46 ` Jingoo Han 2017-12-19 23:29 ` [PATCH v6 05/18] PCI: designware-ep: Remove static keyword from dw_pcie_ep_reset_bar() Niklas Cassel 2017-12-19 23:29 ` [PATCH v6 06/18] PCI: designware-ep: Add generic function for raising MSI irq Niklas Cassel 2017-12-20 19:32 ` Joao Pinto 2017-12-21 16:47 ` Jingoo Han 2017-12-21 16:47 ` Jingoo Han 2017-12-26 12:50 ` Kishon Vijay Abraham I 2017-12-27 22:29 ` Niklas Cassel 2017-12-28 8:06 ` Kishon Vijay Abraham I 2017-12-28 14:39 ` Kishon Vijay Abraham I 2017-12-28 22:43 ` Niklas Cassel 2017-12-19 23:29 ` [PATCH v6 07/18] PCI: dwc: dra7xx: Refactor Kconfig and Makefile handling for host/ep mode Niklas Cassel 2017-12-19 23:29 ` [PATCH v6 08/18] PCI: dwc: dra7xx: Assign pp->ops in dra7xx_add_pcie_port() rather than in probe Niklas Cassel 2017-12-19 23:29 ` [PATCH v6 09/18] PCI: dwc: dra7xx: Help compiler to remove unused code Niklas Cassel 2017-12-20 5:58 ` Kishon Vijay Abraham I [this message] 2017-12-20 5:58 ` Kishon Vijay Abraham I 2017-12-19 23:29 ` [PATCH v6 10/18] PCI: dwc: artpec6: Remove unused defines Niklas Cassel 2017-12-19 23:29 ` [PATCH v6 11/18] PCI: dwc: artpec6: Use BIT and GENMASK macros Niklas Cassel 2017-12-19 23:29 ` [PATCH v6 12/18] PCI: dwc: artpec6: Split artpec6_pcie_establish_link() into smaller functions Niklas Cassel 2017-12-19 23:29 ` [PATCH v6 13/18] bindings: PCI: artpec: Add support for endpoint mode Niklas Cassel 2017-12-19 23:29 ` [PATCH v6 14/18] PCI: dwc: artpec6: " Niklas Cassel 2017-12-19 23:29 ` [PATCH v6 15/18] PCI: dwc: Make cpu_addr_fixup take struct dw_pcie as argument Niklas Cassel 2017-12-20 5:52 ` Kishon Vijay Abraham I 2017-12-20 5:52 ` Kishon Vijay Abraham I 2017-12-19 23:29 ` [PATCH v6 16/18] PCI: dwc: artpec6: Deassert the core before waiting for PHY Niklas Cassel 2017-12-19 23:29 ` [PATCH v6 17/18] bindings: PCI: artpec: Add support for the ARTPEC-7 SoC Niklas Cassel 2017-12-19 23:29 ` [PATCH v6 18/18] PCI: dwc: artpec6: " Niklas Cassel 2017-12-20 17:34 ` [PATCH v6 00/18] dwc MSI fixes, ARTPEC-6 EP mode support, ARTPEC-7 SoC support Lorenzo Pieralisi 2017-12-20 19:47 ` Joao Pinto 2017-12-20 19:47 ` Joao Pinto 2017-12-20 23:22 ` Niklas Cassel 2017-12-21 9:23 ` Joao Pinto 2017-12-21 9:23 ` Joao Pinto 2017-12-21 10:02 ` Lorenzo Pieralisi 2017-12-21 10:02 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d6d663b1-c76e-5b1d-8bd0-95e712b690ea@ti.com \ --to=kishon@ti.com \ --cc=bhelgaas@google.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=niklas.cassel@axis.com \ --cc=niklass@axis.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.