* [PATCH v2 0/3] Enable SGX on k3 (AM654x)
@ 2018-07-11 15:45 Eric Ruei
2018-07-11 15:45 ` [PATCH v2 1/3] conf: machine: k3: enable sgx Eric Ruei
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Eric Ruei @ 2018-07-11 15:45 UTC (permalink / raw)
To: meta-ti
Enable SGX on k3 (AM654x)
Eric Ruei (3):
conf: machine: k3: enable sgx
ti-sgx-ddk-um: add k3 (AM654x) support
ti-sgx-ddk-km: add k3 (AM654x) support
conf/machine/include/k3.inc | 4 +-
.../powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb | 92 ++++++----------------
.../libgles/ti-sgx-ddk-um_1.14.3699939.bb | 1 +
...14.3699939.bb => ti-sgx-ddk-um_1.17.4948957.bb} | 10 +--
4 files changed, 33 insertions(+), 74 deletions(-)
copy recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb => recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb (2%)
copy recipes-graphics/libgles/{ti-sgx-ddk-um_1.14.3699939.bb => ti-sgx-ddk-um_1.17.4948957.bb} (93%)
--
1.9.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/3] conf: machine: k3: enable sgx
2018-07-11 15:45 [PATCH v2 0/3] Enable SGX on k3 (AM654x) Eric Ruei
@ 2018-07-11 15:45 ` Eric Ruei
2018-07-11 15:45 ` [PATCH v2 2/3] ti-sgx-ddk-um: add k3 (AM654x) support Eric Ruei
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: Eric Ruei @ 2018-07-11 15:45 UTC (permalink / raw)
To: meta-ti
Signed-off-by: Eric Ruei <e-ruei1@ti.com>
---
conf/machine/include/k3.inc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/conf/machine/include/k3.inc b/conf/machine/include/k3.inc
index 96699db..1c540f3 100644
--- a/conf/machine/include/k3.inc
+++ b/conf/machine/include/k3.inc
@@ -28,5 +28,5 @@ MACHINE_GUI_CLASS = "smallscreen"
UBI_VOLNAME = "rootfs"
# List common SoC features, may need to add touchscreen for specific machines
-MACHINE_FEATURES = "kernel26 apm usbgadget usbhost vfat ext2 screen alsa ethernet pci"
-# Not ready yet - sgx dsp mmip
+MACHINE_FEATURES = "kernel26 apm usbgadget usbhost vfat ext2 screen alsa ethernet pci sgx"
+# Not ready yet - dsp mmip
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 2/3] ti-sgx-ddk-um: add k3 (AM654x) support
2018-07-11 15:45 [PATCH v2 0/3] Enable SGX on k3 (AM654x) Eric Ruei
2018-07-11 15:45 ` [PATCH v2 1/3] conf: machine: k3: enable sgx Eric Ruei
@ 2018-07-11 15:45 ` Eric Ruei
2018-07-13 17:44 ` Denys Dmytriyenko
2018-07-11 15:45 ` [PATCH v2 3/3] ti-sgx-ddk-km: " Eric Ruei
2018-07-13 17:29 ` [PATCH v2 0/3] Enable SGX on k3 (AM654x) Denys Dmytriyenko
3 siblings, 1 reply; 10+ messages in thread
From: Eric Ruei @ 2018-07-11 15:45 UTC (permalink / raw)
To: meta-ti
- add COMPATIBLE_MACHINE to distinguish AM3/4/5 with K3 (AM654x)
- add k3 support based on SGX DDK 1.17
Signed-off-by: Eric Ruei <e-ruei1@ti.com>
---
recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb | 1 +
...gx-ddk-um_1.14.3699939.bb => ti-sgx-ddk-um_1.17.4948957.bb} | 10 +++++-----
2 files changed, 6 insertions(+), 5 deletions(-)
copy recipes-graphics/libgles/{ti-sgx-ddk-um_1.14.3699939.bb => ti-sgx-ddk-um_1.17.4948957.bb} (93%)
diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
index d17411e..ef33d3a 100644
--- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
+++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
@@ -3,6 +3,7 @@ HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
LICENSE = "TI-TSPA"
LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=550702a031857e0426ef7d6f6cf2d9f4"
+COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15"
PACKAGE_ARCH = "${MACHINE_ARCH}"
BRANCH = "ti-img-sgx/rocko/${PV}"
diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
similarity index 93%
copy from recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
copy to recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
index d17411e..e26cdab 100644
--- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
+++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
@@ -1,14 +1,16 @@
DESCRIPTION = "Userspace libraries for PowerVR SGX chipset on TI SoCs"
HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
LICENSE = "TI-TSPA"
-LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=550702a031857e0426ef7d6f6cf2d9f4"
+LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=b17390502bc89535c86cfbbae961a2a8"
+
+COMPATIBLE_MACHINE = "k3"
PACKAGE_ARCH = "${MACHINE_ARCH}"
BRANCH = "ti-img-sgx/rocko/${PV}"
SRC_URI = "git://git.ti.com/graphics/omap5-sgx-ddk-um-linux.git;protocol=git;branch=${BRANCH}"
-SRCREV = "358fe42d34a7570896e5d1639869da564ddd0484"
+SRCREV = "a564d20ec1b6aed55b3e60aa9ff35f3809eca110"
# There's only hardfp version available
python __anonymous() {
@@ -22,9 +24,7 @@ python __anonymous() {
raise bb.parse.SkipPackage("%s-%s ONLY supports hardfp mode for now" % (pkgn, pkgv))
}
-TARGET_PRODUCT_omap-a15 = "jacinto6evm"
-TARGET_PRODUCT_ti33x = "ti335x"
-TARGET_PRODUCT_ti43x = "ti437x"
+TARGET_PRODUCT_k3 = "ti654x"
INITSCRIPT_NAME = "rc.pvr"
INITSCRIPT_PARAMS = "defaults 8"
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 3/3] ti-sgx-ddk-km: add k3 (AM654x) support
2018-07-11 15:45 [PATCH v2 0/3] Enable SGX on k3 (AM654x) Eric Ruei
2018-07-11 15:45 ` [PATCH v2 1/3] conf: machine: k3: enable sgx Eric Ruei
2018-07-11 15:45 ` [PATCH v2 2/3] ti-sgx-ddk-um: add k3 (AM654x) support Eric Ruei
@ 2018-07-11 15:45 ` Eric Ruei
2018-07-13 17:31 ` Denys Dmytriyenko
2018-07-13 17:29 ` [PATCH v2 0/3] Enable SGX on k3 (AM654x) Denys Dmytriyenko
3 siblings, 1 reply; 10+ messages in thread
From: Eric Ruei @ 2018-07-11 15:45 UTC (permalink / raw)
To: meta-ti
- add K3 (AM654x) support based on SGX DDK 1.17
Signed-off-by: Eric Ruei <e-ruei1@ti.com>
---
.../powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb | 41 ++++++++++++++++++++++
1 file changed, 41 insertions(+)
create mode 100644 recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb
diff --git a/recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb b/recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb
new file mode 100644
index 0000000..3ce9105
--- /dev/null
+++ b/recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb
@@ -0,0 +1,41 @@
+DESCRIPTION = "Kernel drivers for the PowerVR SGX chipset found in the TI SoCs"
+HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-linux"
+LICENSE = "MIT | GPLv2"
+LIC_FILES_CHKSUM = "file://eurasia_km/README;beginline=13;endline=22;md5=74506d9b8e5edbce66c2747c50fcef12"
+
+inherit module
+
+COMPATIBLE_MACHINE = "k3"
+
+MACHINE_KERNEL_PR_append = "o"
+PR = "${MACHINE_KERNEL_PR}"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+DEPENDS = "virtual/kernel"
+
+PROVIDES = "omapdrm-pvr"
+
+RPROVIDES_${PN} = "omapdrm-pvr"
+RREPLACES_${PN} = "omapdrm-pvr"
+RCONFLICTS_${PN} = "omapdrm-pvr"
+
+BRANCH = "ti-img-sgx/${PV}/k4.14"
+
+SRC_URI = "git://git.ti.com/graphics/omap5-sgx-ddk-linux.git;protocol=git;branch=${BRANCH}"
+
+S = "${WORKDIR}/git"
+
+SRCREV = "b630d462f5fbb86e5f98965ba1af35da1207822f"
+
+TARGET_PRODUCT_k3 = "ti654x"
+
+EXTRA_OEMAKE += 'KERNELDIR="${STAGING_KERNEL_DIR}" TARGET_PRODUCT=${TARGET_PRODUCT}'
+
+do_compile_prepend() {
+ cd ${S}/eurasia_km/eurasiacon/build/linux2/omap_linux
+}
+
+do_install() {
+ make -C ${STAGING_KERNEL_DIR} SUBDIRS=${B}/eurasia_km/eurasiacon/binary_omap_linux_xorg_release/target_aarch64/kbuild INSTALL_MOD_PATH=${D} PREFIX=${STAGING_DIR_HOST} modules_install
+}
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/3] Enable SGX on k3 (AM654x)
2018-07-11 15:45 [PATCH v2 0/3] Enable SGX on k3 (AM654x) Eric Ruei
` (2 preceding siblings ...)
2018-07-11 15:45 ` [PATCH v2 3/3] ti-sgx-ddk-km: " Eric Ruei
@ 2018-07-13 17:29 ` Denys Dmytriyenko
2018-07-13 18:11 ` Ruei, Eric
3 siblings, 1 reply; 10+ messages in thread
From: Denys Dmytriyenko @ 2018-07-13 17:29 UTC (permalink / raw)
To: Eric Ruei; +Cc: meta-ti
Eric,
Thanks for addressing most of my comments! This looks much better, but there
are still couple issues - please see inside.
On Wed, Jul 11, 2018 at 11:45:28AM -0400, Eric Ruei wrote:
> Enable SGX on k3 (AM654x)
>
> Eric Ruei (3):
> conf: machine: k3: enable sgx
> ti-sgx-ddk-um: add k3 (AM654x) support
> ti-sgx-ddk-km: add k3 (AM654x) support
>
> conf/machine/include/k3.inc | 4 +-
> .../powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb | 92 ++++++----------------
> .../libgles/ti-sgx-ddk-um_1.14.3699939.bb | 1 +
> ...14.3699939.bb => ti-sgx-ddk-um_1.17.4948957.bb} | 10 +--
> 4 files changed, 33 insertions(+), 74 deletions(-)
> copy recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb => recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb (2%)
> copy recipes-graphics/libgles/{ti-sgx-ddk-um_1.14.3699939.bb => ti-sgx-ddk-um_1.17.4948957.bb} (93%)
>
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/3] ti-sgx-ddk-km: add k3 (AM654x) support
2018-07-11 15:45 ` [PATCH v2 3/3] ti-sgx-ddk-km: " Eric Ruei
@ 2018-07-13 17:31 ` Denys Dmytriyenko
2018-07-13 18:13 ` Ruei, Eric
0 siblings, 1 reply; 10+ messages in thread
From: Denys Dmytriyenko @ 2018-07-13 17:31 UTC (permalink / raw)
To: Eric Ruei; +Cc: meta-ti
On Wed, Jul 11, 2018 at 11:45:31AM -0400, Eric Ruei wrote:
> - add K3 (AM654x) support based on SGX DDK 1.17
>
> Signed-off-by: Eric Ruei <e-ruei1@ti.com>
> ---
> .../powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb | 41 ++++++++++++++++++++++
This is still sent as a new recipe, while being very similar to existing one.
Making it a diff would really help. If git doesn't see the similarity on its
own, you can try passing --find-copies-harder flag...
> 1 file changed, 41 insertions(+)
> create mode 100644 recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb
>
> diff --git a/recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb b/recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb
> new file mode 100644
> index 0000000..3ce9105
> --- /dev/null
> +++ b/recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb
> @@ -0,0 +1,41 @@
> +DESCRIPTION = "Kernel drivers for the PowerVR SGX chipset found in the TI SoCs"
> +HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-linux"
> +LICENSE = "MIT | GPLv2"
> +LIC_FILES_CHKSUM = "file://eurasia_km/README;beginline=13;endline=22;md5=74506d9b8e5edbce66c2747c50fcef12"
> +
> +inherit module
> +
> +COMPATIBLE_MACHINE = "k3"
> +
> +MACHINE_KERNEL_PR_append = "o"
> +PR = "${MACHINE_KERNEL_PR}"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +DEPENDS = "virtual/kernel"
> +
> +PROVIDES = "omapdrm-pvr"
> +
> +RPROVIDES_${PN} = "omapdrm-pvr"
> +RREPLACES_${PN} = "omapdrm-pvr"
> +RCONFLICTS_${PN} = "omapdrm-pvr"
> +
> +BRANCH = "ti-img-sgx/${PV}/k4.14"
> +
> +SRC_URI = "git://git.ti.com/graphics/omap5-sgx-ddk-linux.git;protocol=git;branch=${BRANCH}"
> +
> +S = "${WORKDIR}/git"
> +
> +SRCREV = "b630d462f5fbb86e5f98965ba1af35da1207822f"
> +
> +TARGET_PRODUCT_k3 = "ti654x"
> +
> +EXTRA_OEMAKE += 'KERNELDIR="${STAGING_KERNEL_DIR}" TARGET_PRODUCT=${TARGET_PRODUCT}'
> +
> +do_compile_prepend() {
> + cd ${S}/eurasia_km/eurasiacon/build/linux2/omap_linux
> +}
> +
> +do_install() {
> + make -C ${STAGING_KERNEL_DIR} SUBDIRS=${B}/eurasia_km/eurasiacon/binary_omap_linux_xorg_release/target_aarch64/kbuild INSTALL_MOD_PATH=${D} PREFIX=${STAGING_DIR_HOST} modules_install
> +}
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/3] ti-sgx-ddk-um: add k3 (AM654x) support
2018-07-11 15:45 ` [PATCH v2 2/3] ti-sgx-ddk-um: add k3 (AM654x) support Eric Ruei
@ 2018-07-13 17:44 ` Denys Dmytriyenko
0 siblings, 0 replies; 10+ messages in thread
From: Denys Dmytriyenko @ 2018-07-13 17:44 UTC (permalink / raw)
To: Eric Ruei; +Cc: meta-ti
On Wed, Jul 11, 2018 at 11:45:30AM -0400, Eric Ruei wrote:
> - add COMPATIBLE_MACHINE to distinguish AM3/4/5 with K3 (AM654x)
> - add k3 support based on SGX DDK 1.17
>
> Signed-off-by: Eric Ruei <e-ruei1@ti.com>
> ---
> recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb | 1 +
> ...gx-ddk-um_1.14.3699939.bb => ti-sgx-ddk-um_1.17.4948957.bb} | 10 +++++-----
> 2 files changed, 6 insertions(+), 5 deletions(-)
> copy recipes-graphics/libgles/{ti-sgx-ddk-um_1.14.3699939.bb => ti-sgx-ddk-um_1.17.4948957.bb} (93%)
>
> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
> index d17411e..ef33d3a 100644
> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
> @@ -3,6 +3,7 @@ HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
> LICENSE = "TI-TSPA"
> LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=550702a031857e0426ef7d6f6cf2d9f4"
>
> +COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15"
> PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> BRANCH = "ti-img-sgx/rocko/${PV}"
> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> similarity index 93%
> copy from recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
> copy to recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> index d17411e..e26cdab 100644
> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> @@ -1,14 +1,16 @@
> DESCRIPTION = "Userspace libraries for PowerVR SGX chipset on TI SoCs"
> HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
> LICENSE = "TI-TSPA"
> -LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=550702a031857e0426ef7d6f6cf2d9f4"
> +LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=b17390502bc89535c86cfbbae961a2a8"
> +
> +COMPATIBLE_MACHINE = "k3"
>
> PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> BRANCH = "ti-img-sgx/rocko/${PV}"
>
> SRC_URI = "git://git.ti.com/graphics/omap5-sgx-ddk-um-linux.git;protocol=git;branch=${BRANCH}"
> -SRCREV = "358fe42d34a7570896e5d1639869da564ddd0484"
> +SRCREV = "a564d20ec1b6aed55b3e60aa9ff35f3809eca110"
>
> # There's only hardfp version available
> python __anonymous() {
> @@ -22,9 +24,7 @@ python __anonymous() {
> raise bb.parse.SkipPackage("%s-%s ONLY supports hardfp mode for now" % (pkgn, pkgv))
> }
Thank you for making it a diff against the old version - it's much easier to
review now.
But you missed my point about anonymous function checking for hardfp on
aarch64 skipping this package:
WARNING: .../ti-sgx-ddk-um_1.17.4948957.bb: ti-sgx-ddk-um-1.17.4948957 ONLY supports hardfp mode for now
You need to drop that anonymous function in this recipe, as it's not
applicable on aarch64.
> -TARGET_PRODUCT_omap-a15 = "jacinto6evm"
> -TARGET_PRODUCT_ti33x = "ti335x"
> -TARGET_PRODUCT_ti43x = "ti437x"
> +TARGET_PRODUCT_k3 = "ti654x"
>
> INITSCRIPT_NAME = "rc.pvr"
> INITSCRIPT_PARAMS = "defaults 8"
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/3] Enable SGX on k3 (AM654x)
2018-07-13 17:29 ` [PATCH v2 0/3] Enable SGX on k3 (AM654x) Denys Dmytriyenko
@ 2018-07-13 18:11 ` Ruei, Eric
2018-07-13 18:19 ` Denys Dmytriyenko
0 siblings, 1 reply; 10+ messages in thread
From: Ruei, Eric @ 2018-07-13 18:11 UTC (permalink / raw)
To: Dmytriyenko, Denys; +Cc: meta-ti
I do not see any comments on this one.
Eric
-----Original Message-----
From: Dmytriyenko, Denys
Sent: Friday, July 13, 2018 1:30 PM
To: Ruei, Eric
Cc: meta-ti@yoctoproject.org
Subject: Re: [meta-ti] [PATCH v2 0/3] Enable SGX on k3 (AM654x)
Eric,
Thanks for addressing most of my comments! This looks much better, but there
are still couple issues - please see inside.
On Wed, Jul 11, 2018 at 11:45:28AM -0400, Eric Ruei wrote:
> Enable SGX on k3 (AM654x)
>
> Eric Ruei (3):
> conf: machine: k3: enable sgx
> ti-sgx-ddk-um: add k3 (AM654x) support
> ti-sgx-ddk-km: add k3 (AM654x) support
>
> conf/machine/include/k3.inc | 4 +-
> .../powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb | 92 ++++++----------------
> .../libgles/ti-sgx-ddk-um_1.14.3699939.bb | 1 +
> ...14.3699939.bb => ti-sgx-ddk-um_1.17.4948957.bb} | 10 +--
> 4 files changed, 33 insertions(+), 74 deletions(-)
> copy recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb => recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb (2%)
> copy recipes-graphics/libgles/{ti-sgx-ddk-um_1.14.3699939.bb => ti-sgx-ddk-um_1.17.4948957.bb} (93%)
>
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/3] ti-sgx-ddk-km: add k3 (AM654x) support
2018-07-13 17:31 ` Denys Dmytriyenko
@ 2018-07-13 18:13 ` Ruei, Eric
0 siblings, 0 replies; 10+ messages in thread
From: Ruei, Eric @ 2018-07-13 18:13 UTC (permalink / raw)
To: Dmytriyenko, Denys; +Cc: meta-ti
-----Original Message-----
From: Dmytriyenko, Denys
Sent: Friday, July 13, 2018 1:32 PM
To: Ruei, Eric
Cc: meta-ti@yoctoproject.org
Subject: Re: [meta-ti] [PATCH v2 3/3] ti-sgx-ddk-km: add k3 (AM654x) support
On Wed, Jul 11, 2018 at 11:45:31AM -0400, Eric Ruei wrote:
> - add K3 (AM654x) support based on SGX DDK 1.17
>
> Signed-off-by: Eric Ruei <e-ruei1@ti.com>
> ---
> .../powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb | 41 ++++++++++++++++++++++
This is still sent as a new recipe, while being very similar to existing one.
Making it a diff would really help. If git doesn't see the similarity on its
own, you can try passing --find-copies-harder flag...
Do you mean the fit will search the data base, not just in the local commits?
> 1 file changed, 41 insertions(+)
> create mode 100644 recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb
>
> diff --git a/recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb b/recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb
> new file mode 100644
> index 0000000..3ce9105
> --- /dev/null
> +++ b/recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb
> @@ -0,0 +1,41 @@
> +DESCRIPTION = "Kernel drivers for the PowerVR SGX chipset found in the TI SoCs"
> +HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-linux"
> +LICENSE = "MIT | GPLv2"
> +LIC_FILES_CHKSUM = "file://eurasia_km/README;beginline=13;endline=22;md5=74506d9b8e5edbce66c2747c50fcef12"
> +
> +inherit module
> +
> +COMPATIBLE_MACHINE = "k3"
> +
> +MACHINE_KERNEL_PR_append = "o"
> +PR = "${MACHINE_KERNEL_PR}"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +DEPENDS = "virtual/kernel"
> +
> +PROVIDES = "omapdrm-pvr"
> +
> +RPROVIDES_${PN} = "omapdrm-pvr"
> +RREPLACES_${PN} = "omapdrm-pvr"
> +RCONFLICTS_${PN} = "omapdrm-pvr"
> +
> +BRANCH = "ti-img-sgx/${PV}/k4.14"
> +
> +SRC_URI = "git://git.ti.com/graphics/omap5-sgx-ddk-linux.git;protocol=git;branch=${BRANCH}"
> +
> +S = "${WORKDIR}/git"
> +
> +SRCREV = "b630d462f5fbb86e5f98965ba1af35da1207822f"
> +
> +TARGET_PRODUCT_k3 = "ti654x"
> +
> +EXTRA_OEMAKE += 'KERNELDIR="${STAGING_KERNEL_DIR}" TARGET_PRODUCT=${TARGET_PRODUCT}'
> +
> +do_compile_prepend() {
> + cd ${S}/eurasia_km/eurasiacon/build/linux2/omap_linux
> +}
> +
> +do_install() {
> + make -C ${STAGING_KERNEL_DIR} SUBDIRS=${B}/eurasia_km/eurasiacon/binary_omap_linux_xorg_release/target_aarch64/kbuild INSTALL_MOD_PATH=${D} PREFIX=${STAGING_DIR_HOST} modules_install
> +}
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/3] Enable SGX on k3 (AM654x)
2018-07-13 18:11 ` Ruei, Eric
@ 2018-07-13 18:19 ` Denys Dmytriyenko
0 siblings, 0 replies; 10+ messages in thread
From: Denys Dmytriyenko @ 2018-07-13 18:19 UTC (permalink / raw)
To: Ruei, Eric; +Cc: meta-ti
On Fri, Jul 13, 2018 at 02:11:18PM -0400, Ruei, Eric wrote:
> I do not see any comments on this one.
Sorry for the confusion - I meant inside the patches themselves, not the cover
letter.
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Friday, July 13, 2018 1:30 PM
> To: Ruei, Eric
> Cc: meta-ti@yoctoproject.org
> Subject: Re: [meta-ti] [PATCH v2 0/3] Enable SGX on k3 (AM654x)
>
> Eric,
>
> Thanks for addressing most of my comments! This looks much better, but there
> are still couple issues - please see inside.
>
>
> On Wed, Jul 11, 2018 at 11:45:28AM -0400, Eric Ruei wrote:
> > Enable SGX on k3 (AM654x)
> >
> > Eric Ruei (3):
> > conf: machine: k3: enable sgx
> > ti-sgx-ddk-um: add k3 (AM654x) support
> > ti-sgx-ddk-km: add k3 (AM654x) support
> >
> > conf/machine/include/k3.inc | 4 +-
> > .../powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb | 92 ++++++----------------
> > .../libgles/ti-sgx-ddk-um_1.14.3699939.bb | 1 +
> > ...14.3699939.bb => ti-sgx-ddk-um_1.17.4948957.bb} | 10 +--
> > 4 files changed, 33 insertions(+), 74 deletions(-)
> > copy recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb => recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb (2%)
> > copy recipes-graphics/libgles/{ti-sgx-ddk-um_1.14.3699939.bb => ti-sgx-ddk-um_1.17.4948957.bb} (93%)
> >
> > --
> > 1.9.1
> >
> > --
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-07-13 18:20 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-11 15:45 [PATCH v2 0/3] Enable SGX on k3 (AM654x) Eric Ruei
2018-07-11 15:45 ` [PATCH v2 1/3] conf: machine: k3: enable sgx Eric Ruei
2018-07-11 15:45 ` [PATCH v2 2/3] ti-sgx-ddk-um: add k3 (AM654x) support Eric Ruei
2018-07-13 17:44 ` Denys Dmytriyenko
2018-07-11 15:45 ` [PATCH v2 3/3] ti-sgx-ddk-km: " Eric Ruei
2018-07-13 17:31 ` Denys Dmytriyenko
2018-07-13 18:13 ` Ruei, Eric
2018-07-13 17:29 ` [PATCH v2 0/3] Enable SGX on k3 (AM654x) Denys Dmytriyenko
2018-07-13 18:11 ` Ruei, Eric
2018-07-13 18:19 ` Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.