* [PATCH v4] f2fs: stop issue discard if something wrong with f2fs
@ 2018-04-10 4:01 Yunlei He
2018-04-10 6:38 ` Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: Yunlei He @ 2018-04-10 4:01 UTC (permalink / raw)
To: jaegeuk, yuchao0, linux-f2fs-devel; +Cc: zhangdianfang
This patch stop async thread and umount process to issue discard
if something wrong with f2fs, which is similar to fstrim.
Signed-off-by: Yunlei He <heyunlei@huawei.com>
---
fs/f2fs/segment.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 5854cc4..1659985 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1202,6 +1202,9 @@ static int __issue_discard_cmd(struct f2fs_sb_info *sbi,
int i, iter = 0, issued = 0;
bool io_interrupted = false;
+ if (is_sbi_flag_set(sbi, SBI_NEED_FSCK))
+ return issued;
+
for (i = MAX_PLIST_NUM - 1; i >= 0; i--) {
if (i + 1 < dpolicy->granularity)
break;
@@ -1410,6 +1413,8 @@ static int issue_discard_thread(void *data)
continue;
if (kthread_should_stop())
return 0;
+ if (is_sbi_flag_set(sbi, SBI_NEED_FSCK))
+ continue;
if (dcc->discard_wake)
dcc->discard_wake = 0;
--
1.9.1
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4] f2fs: stop issue discard if something wrong with f2fs
2018-04-10 4:01 [PATCH v4] f2fs: stop issue discard if something wrong with f2fs Yunlei He
@ 2018-04-10 6:38 ` Chao Yu
2018-04-13 1:31 ` Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: Chao Yu @ 2018-04-10 6:38 UTC (permalink / raw)
To: Yunlei He, jaegeuk, linux-f2fs-devel; +Cc: zhangdianfang
On 2018/4/10 12:01, Yunlei He wrote:
> This patch stop async thread and umount process to issue discard
> if something wrong with f2fs, which is similar to fstrim.
>
> Signed-off-by: Yunlei He <heyunlei@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] f2fs: stop issue discard if something wrong with f2fs
2018-04-10 6:38 ` Chao Yu
@ 2018-04-13 1:31 ` Chao Yu
0 siblings, 0 replies; 3+ messages in thread
From: Chao Yu @ 2018-04-13 1:31 UTC (permalink / raw)
To: Yunlei He, jaegeuk, linux-f2fs-devel; +Cc: zhangdianfang
On 2018/4/10 14:38, Chao Yu wrote:
> On 2018/4/10 12:01, Yunlei He wrote:
>> This patch stop async thread and umount process to issue discard
>> if something wrong with f2fs, which is similar to fstrim.
>>
>> Signed-off-by: Yunlei He <heyunlei@huawei.com>
>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
Sorry, please hold on this patch before we fix the SBI_NEED_FSCK's ambiguity
sematic issue.
Thanks,
>
> Thanks,
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-13 1:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-10 4:01 [PATCH v4] f2fs: stop issue discard if something wrong with f2fs Yunlei He
2018-04-10 6:38 ` Chao Yu
2018-04-13 1:31 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.