Re: [SPDK] CRC32 optimization for ARM platform

Re: [SPDK] CRC32 optimization for ARM platform

[Sasha Kotchubievsky]

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

Hi Jim,

Sure, will fix it.

Thanks

Sasha

On 1/16/2019 1:16 AM, Harris, James R wrote:
> Hi Sasha,
>
> The patch looks OK, but has a stray change to the DPDK submodule commit ID.  Could you or Richael fix that up?
>
> Thanks,
>
> -Jim
>
>
> On 1/15/19, 12:18 AM, "SPDK on behalf of Sasha Kotchubievsky" <spdk-bounces(a)lists.01.org on behalf of sashakot(a)dev.mellanox.co.il> wrote:
>
>      Hi,
>      
>      Richael Zhuang from ARM submitted  CRC32 optimization for ARM:
>      
>      https://review.gerrithub.io/c/spdk/spdk/+/437218
>      
>      I tested  the patch and it significantly boosts NVME-OF TCP on ARM
>      platform. Can we move forward with the patch and merge it into master?
>      
>      Best regards
>      
>      Sasha
>      
>      _______________________________________________
>      SPDK mailing list
>      SPDK(a)lists.01.org
>      https://lists.01.org/mailman/listinfo/spdk
>      
>
> _______________________________________________
> SPDK mailing list
> SPDK(a)lists.01.org
> https://lists.01.org/mailman/listinfo/spdk

Re: [SPDK] CRC32 optimization for ARM platform

[Harris, James R]

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]

Hi Sasha,

The patch looks OK, but has a stray change to the DPDK submodule commit ID.  Could you or Richael fix that up?

Thanks,

-Jim


On 1/15/19, 12:18 AM, "SPDK on behalf of Sasha Kotchubievsky" <spdk-bounces(a)lists.01.org on behalf of sashakot(a)dev.mellanox.co.il> wrote:

    Hi,
    
    Richael Zhuang from ARM submitted  CRC32 optimization for ARM:
    
    https://review.gerrithub.io/c/spdk/spdk/+/437218
    
    I tested  the patch and it significantly boosts NVME-OF TCP on ARM 
    platform. Can we move forward with the patch and merge it into master?
    
    Best regards
    
    Sasha
    
    _______________________________________________
    SPDK mailing list
    SPDK(a)lists.01.org
    https://lists.01.org/mailman/listinfo/spdk
    

Re: [SPDK] CRC32 optimization for ARM platform

[Yang, Ziye]

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

Hi Sasha,

Thanks for mentioning this patch.  PS: For NVMe-oF TCP, the default behavior is that the header digest and data digest is not enabled. But definitely, if you enabled, with accelerated CRC32 function, it would be helpful.




Best Regards
Ziye Yang 

-----Original Message-----
From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Sasha Kotchubievsky
Sent: Tuesday, January 15, 2019 3:18 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: [SPDK] CRC32 optimization for ARM platform

Hi,

Richael Zhuang from ARM submitted  CRC32 optimization for ARM:

https://review.gerrithub.io/c/spdk/spdk/+/437218

I tested  the patch and it significantly boosts NVME-OF TCP on ARM platform. Can we move forward with the patch and merge it into master?

Best regards

Sasha

_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org
https://lists.01.org/mailman/listinfo/spdk

[SPDK] CRC32 optimization for ARM platform

[Sasha Kotchubievsky]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

Hi,

Richael Zhuang from ARM submitted  CRC32 optimization for ARM:

https://review.gerrithub.io/c/spdk/spdk/+/437218

I tested  the patch and it significantly boosts NVME-OF TCP on ARM 
platform. Can we move forward with the patch and merge it into master?

Best regards

Sasha