* [PATCH] bpf: remove trailing semicolon in macro definition
@ 2020-11-27 19:27 trix
2020-11-28 0:54 ` Daniel Borkmann
0 siblings, 1 reply; 3+ messages in thread
From: trix @ 2020-11-27 19:27 UTC (permalink / raw)
To: ast, daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh, rostedt, mingo, davem, kuba, hawk
Cc: netdev, bpf, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
The macro use will already have a semicolon.
Signed-off-by: Tom Rix <trix@redhat.com>
---
include/trace/events/xdp.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h
index cd24e8a59529..65ffedf8386f 100644
--- a/include/trace/events/xdp.h
+++ b/include/trace/events/xdp.h
@@ -146,13 +146,13 @@ DEFINE_EVENT(xdp_redirect_template, xdp_redirect_err,
);
#define _trace_xdp_redirect(dev, xdp, to) \
- trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to);
+ trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to)
#define _trace_xdp_redirect_err(dev, xdp, to, err) \
trace_xdp_redirect_err(dev, xdp, NULL, err, NULL, to);
#define _trace_xdp_redirect_map(dev, xdp, to, map, index) \
- trace_xdp_redirect(dev, xdp, to, 0, map, index);
+ trace_xdp_redirect(dev, xdp, to, 0, map, index)
#define _trace_xdp_redirect_map_err(dev, xdp, to, map, index, err) \
trace_xdp_redirect_err(dev, xdp, to, err, map, index);
--
2.18.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bpf: remove trailing semicolon in macro definition
2020-11-27 19:27 [PATCH] bpf: remove trailing semicolon in macro definition trix
@ 2020-11-28 0:54 ` Daniel Borkmann
2020-11-29 17:28 ` Tom Rix
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Borkmann @ 2020-11-28 0:54 UTC (permalink / raw)
To: trix, ast, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh, rostedt, mingo, davem, kuba, hawk
Cc: netdev, bpf, linux-kernel
On 11/27/20 8:27 PM, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> include/trace/events/xdp.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h
> index cd24e8a59529..65ffedf8386f 100644
> --- a/include/trace/events/xdp.h
> +++ b/include/trace/events/xdp.h
> @@ -146,13 +146,13 @@ DEFINE_EVENT(xdp_redirect_template, xdp_redirect_err,
> );
>
> #define _trace_xdp_redirect(dev, xdp, to) \
> - trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to);
> + trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to)
>
> #define _trace_xdp_redirect_err(dev, xdp, to, err) \
> trace_xdp_redirect_err(dev, xdp, NULL, err, NULL, to);
>
> #define _trace_xdp_redirect_map(dev, xdp, to, map, index) \
> - trace_xdp_redirect(dev, xdp, to, 0, map, index);
> + trace_xdp_redirect(dev, xdp, to, 0, map, index)
>
> #define _trace_xdp_redirect_map_err(dev, xdp, to, map, index, err) \
> trace_xdp_redirect_err(dev, xdp, to, err, map, index);
>
This looks random, why those but not other locations ?
Thanks,
Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bpf: remove trailing semicolon in macro definition
2020-11-28 0:54 ` Daniel Borkmann
@ 2020-11-29 17:28 ` Tom Rix
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rix @ 2020-11-29 17:28 UTC (permalink / raw)
To: Daniel Borkmann, ast, andrii, kafai, songliubraving, yhs,
john.fastabend, kpsingh, rostedt, mingo, davem, kuba, hawk
Cc: netdev, bpf, linux-kernel
On 11/27/20 4:54 PM, Daniel Borkmann wrote:
> On 11/27/20 8:27 PM, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> The macro use will already have a semicolon.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> include/trace/events/xdp.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h
>> index cd24e8a59529..65ffedf8386f 100644
>> --- a/include/trace/events/xdp.h
>> +++ b/include/trace/events/xdp.h
>> @@ -146,13 +146,13 @@ DEFINE_EVENT(xdp_redirect_template, xdp_redirect_err,
>> );
>> #define _trace_xdp_redirect(dev, xdp, to) \
>> - trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to);
>> + trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to)
>> #define _trace_xdp_redirect_err(dev, xdp, to, err) \
>> trace_xdp_redirect_err(dev, xdp, NULL, err, NULL, to);
>> #define _trace_xdp_redirect_map(dev, xdp, to, map, index) \
>> - trace_xdp_redirect(dev, xdp, to, 0, map, index);
>> + trace_xdp_redirect(dev, xdp, to, 0, map, index)
>> #define _trace_xdp_redirect_map_err(dev, xdp, to, map, index, err) \
>> trace_xdp_redirect_err(dev, xdp, to, err, map, index);
>>
>
> This looks random, why those but not other locations ?
Those other macros were never used.
Tom
>
> Thanks,
> Daniel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-29 17:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 19:27 [PATCH] bpf: remove trailing semicolon in macro definition trix
2020-11-28 0:54 ` Daniel Borkmann
2020-11-29 17:28 ` Tom Rix
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.