From: Peter Rosin <peda@axentia.se> To: "Eugen.Hristev@microchip.com" <Eugen.Hristev@microchip.com>, "wsa@the-dreams.de" <wsa@the-dreams.de>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "Ludovic.Desroches@microchip.com" <Ludovic.Desroches@microchip.com>, "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>, "robh+dt@kernel.org" <robh+dt@kernel.org> Cc: "Nicolas.Ferre@microchip.com" <Nicolas.Ferre@microchip.com> Subject: Re: [PATCH v5 3/9] i2c: add support for filters optional properties Date: Mon, 21 Oct 2019 15:20:44 +0000 [thread overview] Message-ID: <d7172480-0ba3-3412-aebf-353bfe8d6f66@axentia.se> (raw) In-Reply-To: <1568189911-31641-4-git-send-email-eugen.hristev@microchip.com> On 2019-09-11 10:24, Eugen.Hristev@microchip.com wrote: > From: Eugen Hristev <eugen.hristev@microchip.com> > > i2c-digital-filter-width-ns: > This optional timing property specifies the width of the spikes on the i2c > lines (in ns) that can be filtered out by built-in digital filters which are > embedded in some i2c controllers. > i2c-analog-filter-cutoff-frequency: > This optional timing property specifies the cutoff frequency of a low-pass > analog filter built-in i2c controllers. This low pass filter is used to filter > out high frequency noise on the i2c lines. Specified in Hz. > Include these properties in the timings structure and read them as integers. > > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> > --- > drivers/i2c/i2c-core-base.c | 6 ++++++ > include/linux/i2c.h | 6 ++++++ > 2 files changed, 12 insertions(+) > > diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c > index 9c440fa..c9fcb16 100644 > --- a/drivers/i2c/i2c-core-base.c > +++ b/drivers/i2c/i2c-core-base.c > @@ -1658,6 +1658,12 @@ void i2c_parse_fw_timings(struct device *dev, struct i2c_timings *t, bool use_de > t->sda_fall_ns = t->scl_fall_ns; > > device_property_read_u32(dev, "i2c-sda-hold-time-ns", &t->sda_hold_ns); > + > + device_property_read_u32(dev, "i2c-digital-filter-width-ns", > + &t->digital_filter_width_ns); > + > + device_property_read_u32(dev, "i2c-analog-filter-cutoff-frequency", > + &t->analog_filter_cutoff_freq_hz); > } > EXPORT_SYMBOL_GPL(i2c_parse_fw_timings); > > diff --git a/include/linux/i2c.h b/include/linux/i2c.h > index fa5552c..26ce143 100644 > --- a/include/linux/i2c.h > +++ b/include/linux/i2c.h > @@ -575,6 +575,10 @@ struct i2c_lock_operations { > * @scl_int_delay_ns: time IP core additionally needs to setup SCL in ns > * @sda_fall_ns: time SDA signal takes to fall in ns; t(f) in the I2C specification > * @sda_hold_ns: time IP core additionally needs to hold SDA in ns > + * @digital_filter_width_ns: width in ns of spikes on i2c lines that the IP core > + * digital filter can filter out > + * @analog_filter_cutoff_freq_hz: threshold frequency for the low pass IP core > + analog filter The indentation is a little bit excessive and also off. Other comments in the file just uses a single tab after the asterisk in this scenario. Also, the last of the new lines is missing that leading asterisk. Cheers, Peter > */ > struct i2c_timings { > u32 bus_freq_hz; > @@ -583,6 +587,8 @@ struct i2c_timings { > u32 scl_int_delay_ns; > u32 sda_fall_ns; > u32 sda_hold_ns; > + u32 digital_filter_width_ns; > + u32 analog_filter_cutoff_freq_hz; > }; > > /** >
WARNING: multiple messages have this Message-ID (diff)
From: Peter Rosin <peda@axentia.se> To: "Eugen.Hristev@microchip.com" <Eugen.Hristev@microchip.com>, "wsa@the-dreams.de" <wsa@the-dreams.de>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "Ludovic.Desroches@microchip.com" <Ludovic.Desroches@microchip.com>, "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>, "robh+dt@kernel.org" <robh+dt@kernel.org> Subject: Re: [PATCH v5 3/9] i2c: add support for filters optional properties Date: Mon, 21 Oct 2019 15:20:44 +0000 [thread overview] Message-ID: <d7172480-0ba3-3412-aebf-353bfe8d6f66@axentia.se> (raw) In-Reply-To: <1568189911-31641-4-git-send-email-eugen.hristev@microchip.com> On 2019-09-11 10:24, Eugen.Hristev@microchip.com wrote: > From: Eugen Hristev <eugen.hristev@microchip.com> > > i2c-digital-filter-width-ns: > This optional timing property specifies the width of the spikes on the i2c > lines (in ns) that can be filtered out by built-in digital filters which are > embedded in some i2c controllers. > i2c-analog-filter-cutoff-frequency: > This optional timing property specifies the cutoff frequency of a low-pass > analog filter built-in i2c controllers. This low pass filter is used to filter > out high frequency noise on the i2c lines. Specified in Hz. > Include these properties in the timings structure and read them as integers. > > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> > --- > drivers/i2c/i2c-core-base.c | 6 ++++++ > include/linux/i2c.h | 6 ++++++ > 2 files changed, 12 insertions(+) > > diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c > index 9c440fa..c9fcb16 100644 > --- a/drivers/i2c/i2c-core-base.c > +++ b/drivers/i2c/i2c-core-base.c > @@ -1658,6 +1658,12 @@ void i2c_parse_fw_timings(struct device *dev, struct i2c_timings *t, bool use_de > t->sda_fall_ns = t->scl_fall_ns; > > device_property_read_u32(dev, "i2c-sda-hold-time-ns", &t->sda_hold_ns); > + > + device_property_read_u32(dev, "i2c-digital-filter-width-ns", > + &t->digital_filter_width_ns); > + > + device_property_read_u32(dev, "i2c-analog-filter-cutoff-frequency", > + &t->analog_filter_cutoff_freq_hz); > } > EXPORT_SYMBOL_GPL(i2c_parse_fw_timings); > > diff --git a/include/linux/i2c.h b/include/linux/i2c.h > index fa5552c..26ce143 100644 > --- a/include/linux/i2c.h > +++ b/include/linux/i2c.h > @@ -575,6 +575,10 @@ struct i2c_lock_operations { > * @scl_int_delay_ns: time IP core additionally needs to setup SCL in ns > * @sda_fall_ns: time SDA signal takes to fall in ns; t(f) in the I2C specification > * @sda_hold_ns: time IP core additionally needs to hold SDA in ns > + * @digital_filter_width_ns: width in ns of spikes on i2c lines that the IP core > + * digital filter can filter out > + * @analog_filter_cutoff_freq_hz: threshold frequency for the low pass IP core > + analog filter The indentation is a little bit excessive and also off. Other comments in the file just uses a single tab after the asterisk in this scenario. Also, the last of the new lines is missing that leading asterisk. Cheers, Peter > */ > struct i2c_timings { > u32 bus_freq_hz; > @@ -583,6 +587,8 @@ struct i2c_timings { > u32 scl_int_delay_ns; > u32 sda_fall_ns; > u32 sda_hold_ns; > + u32 digital_filter_width_ns; > + u32 analog_filter_cutoff_freq_hz; > }; > > /** > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-21 15:20 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-11 8:24 [PATCH v5 0/9] i2c: add support for filters Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` [PATCH v5 1/9] dt-bindings: i2c: at91: add new compatible Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` [PATCH v5 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-17 14:28 ` Rob Herring 2019-09-17 14:28 ` Rob Herring 2019-09-11 8:24 ` [PATCH v5 3/9] i2c: add support for filters optional properties Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-10-21 15:20 ` Peter Rosin [this message] 2019-10-21 15:20 ` Peter Rosin 2019-10-21 15:20 ` Peter Rosin 2019-09-11 8:24 ` [PATCH v5 4/9] i2c: at91: add new platform support for sam9x60 Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` [PATCH v5 5/9] i2c: at91: add support for digital filtering Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` [PATCH v5 6/9] i2c: at91: add support for advanced " Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` [PATCH v5 7/9] i2c: at91: add support for analog filtering Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` [PATCH v5 8/9] ARM: dts: at91: sama5d2_xplained: add analog and digital filter for i2c Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` [PATCH v5 9/9] ARM: dts: at91: sama5d4_xplained: add " Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-11 8:24 ` Eugen.Hristev 2019-09-14 19:32 ` [PATCH v5 0/9] i2c: add support for filters Ludovic Desroches 2019-09-14 19:32 ` Ludovic Desroches 2019-09-14 19:32 ` Ludovic Desroches 2019-10-07 7:53 ` Eugen.Hristev 2019-10-07 7:53 ` Eugen.Hristev 2019-10-07 7:53 ` Eugen.Hristev 2019-10-14 7:01 ` Eugen.Hristev 2019-10-14 7:01 ` Eugen.Hristev 2019-10-14 7:01 ` Eugen.Hristev 2019-10-21 14:05 ` Wolfram Sang 2019-10-21 14:05 ` Wolfram Sang 2019-10-21 15:23 ` Peter Rosin 2019-10-21 15:23 ` Peter Rosin 2019-10-21 15:23 ` Peter Rosin 2019-10-23 11:01 ` Eugen.Hristev 2019-10-23 11:01 ` Eugen.Hristev 2019-10-23 11:01 ` Eugen.Hristev 2019-10-23 12:19 ` Wolfram Sang 2019-10-23 12:19 ` Wolfram Sang 2019-10-24 18:30 ` Wolfram Sang 2019-10-24 18:30 ` Wolfram Sang 2019-10-25 10:05 ` Ludovic Desroches 2019-10-25 10:05 ` Ludovic Desroches 2019-10-25 10:05 ` Ludovic Desroches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d7172480-0ba3-3412-aebf-353bfe8d6f66@axentia.se \ --to=peda@axentia.se \ --cc=Eugen.Hristev@microchip.com \ --cc=Ludovic.Desroches@microchip.com \ --cc=Nicolas.Ferre@microchip.com \ --cc=alexandre.belloni@bootlin.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.