From: Simon Horman <horms+renesas@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: shmobile: r8a7790: fix shdi resource sizes
Date: Tue, 24 Dec 2013 06:05:01 +0000 [thread overview]
Message-ID: <d721a15c300c5f638a11573a6dd492158e737d6a.1387856124.git.horms+renesas@verge.net.au> (raw)
In-Reply-To: <cover.1387856124.git.horms+renesas@verge.net.au>
From: Ben Dooks <ben.dooks@codethink.co.uk>
The r8a7790.dtsi file has four sdhi nodes which the first two have the wrong
resource size for their register block. This causes the sh_modbile_sdhi driver
to fail to communicate with card at-all.
Change sdhi{0,1} node size from 0x100 to 0x200 to correct these nodes
as per Kuninori Morimoto's response to the original patch where all four
nodes where changed. sdhi{2,3} are the correct size.
This bug has been present since sdhi resources were added to the r8a7790 by
8c9b1aa41853272a ("ARM: shmobile: r8a7790: add MMCIF and SDHI DT
templates") in v3.11-rc2.
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Tested-by: William Towle <william.towle@codethink.co.uk>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/boot/dts/r8a7790.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 46e1d7e..9987dd0e 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -241,7 +241,7 @@
sdhi0: sdhi@ee100000 {
compatible = "renesas,sdhi-r8a7790";
- reg = <0 0xee100000 0 0x100>;
+ reg = <0 0xee100000 0 0x200>;
interrupt-parent = <&gic>;
interrupts = <0 165 4>;
cap-sd-highspeed;
@@ -250,7 +250,7 @@
sdhi1: sdhi@ee120000 {
compatible = "renesas,sdhi-r8a7790";
- reg = <0 0xee120000 0 0x100>;
+ reg = <0 0xee120000 0 0x200>;
interrupt-parent = <&gic>;
interrupts = <0 166 4>;
cap-sd-highspeed;
--
1.8.4
WARNING: multiple messages have this Message-ID (diff)
From: horms+renesas@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: shmobile: r8a7790: fix shdi resource sizes
Date: Tue, 24 Dec 2013 15:05:01 +0900 [thread overview]
Message-ID: <d721a15c300c5f638a11573a6dd492158e737d6a.1387856124.git.horms+renesas@verge.net.au> (raw)
In-Reply-To: <cover.1387856124.git.horms+renesas@verge.net.au>
From: Ben Dooks <ben.dooks@codethink.co.uk>
The r8a7790.dtsi file has four sdhi nodes which the first two have the wrong
resource size for their register block. This causes the sh_modbile_sdhi driver
to fail to communicate with card at-all.
Change sdhi{0,1} node size from 0x100 to 0x200 to correct these nodes
as per Kuninori Morimoto's response to the original patch where all four
nodes where changed. sdhi{2,3} are the correct size.
This bug has been present since sdhi resources were added to the r8a7790 by
8c9b1aa41853272a ("ARM: shmobile: r8a7790: add MMCIF and SDHI DT
templates") in v3.11-rc2.
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Tested-by: William Towle <william.towle@codethink.co.uk>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/boot/dts/r8a7790.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 46e1d7e..9987dd0e 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -241,7 +241,7 @@
sdhi0: sdhi at ee100000 {
compatible = "renesas,sdhi-r8a7790";
- reg = <0 0xee100000 0 0x100>;
+ reg = <0 0xee100000 0 0x200>;
interrupt-parent = <&gic>;
interrupts = <0 165 4>;
cap-sd-highspeed;
@@ -250,7 +250,7 @@
sdhi1: sdhi at ee120000 {
compatible = "renesas,sdhi-r8a7790";
- reg = <0 0xee120000 0 0x100>;
+ reg = <0 0xee120000 0 0x200>;
interrupt-parent = <&gic>;
interrupts = <0 166 4>;
cap-sd-highspeed;
--
1.8.4
next prev parent reply other threads:[~2013-12-24 6:05 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 4:30 [GIT PULL 0/3] Second round of Renesas ARM-based SoC board updates for v3.12 Simon Horman
2013-08-07 4:30 ` Simon Horman
2013-08-07 4:30 ` [GIT PULL 1/3] ARM: shmobile: ape6evm: support GPIO switches Simon Horman
2013-08-07 4:30 ` Simon Horman
2013-08-07 4:30 ` [GIT PULL 2/3] ARM: shmobile: ape6evm: Add GPIO LEDs Simon Horman
2013-08-07 4:30 ` Simon Horman
2013-08-07 4:30 ` [GIT PULL 3/3] ARM: shmobile: lager: enable Ether Simon Horman
2013-08-07 4:30 ` Simon Horman
2013-08-21 16:01 ` Kevin Hilman
2013-08-21 16:01 ` Kevin Hilman
2013-08-21 19:13 ` Sergei Shtylyov
2013-08-21 19:13 ` Sergei Shtylyov
2013-08-22 0:16 ` Simon Horman
2013-08-22 0:16 ` Simon Horman
2013-08-22 6:53 ` Olof Johansson
2013-08-22 6:53 ` Olof Johansson
2013-08-22 7:01 ` Simon Horman
2013-08-22 7:01 ` Simon Horman
2013-08-22 7:04 ` Olof Johansson
2013-08-22 7:04 ` Olof Johansson
2013-08-22 7:37 ` Simon Horman
2013-08-22 7:37 ` Simon Horman
2013-09-06 21:32 ` Olof Johansson
2013-09-06 21:32 ` Olof Johansson
2013-09-09 0:09 ` Simon Horman
2013-09-09 0:09 ` Simon Horman
2013-08-14 8:11 ` [GIT PULL 0/3] Second round of Renesas ARM-based SoC board updates for v3.12 Olof Johansson
2013-08-14 8:11 ` Olof Johansson
2013-12-23 2:08 ` [GIT PULL 0/3] Second Round of Renesas ARM Based SoC DT Updates for v3.13 Simon Horman
2013-12-23 2:08 ` Simon Horman
2013-12-23 2:08 ` [PATCH 1/3] ARM: shmobile: sh73a0: add FSI support via DTSI Simon Horman
2013-12-23 2:08 ` Simon Horman
2013-12-23 2:08 ` [PATCH 2/3] ARM: shmobile: kzm9g: add FSI support for DTS Simon Horman
2013-12-23 2:08 ` Simon Horman
2013-12-23 13:21 ` Sergei Shtylyov
2013-12-23 13:21 ` Sergei Shtylyov
2013-12-23 14:10 ` Sergei Shtylyov
2013-12-23 14:10 ` Sergei Shtylyov
2013-12-24 5:54 ` Simon Horman
2013-12-24 5:54 ` Simon Horman
2013-12-23 2:08 ` [PATCH 3/3] ARM: shmobile: koelsch: dts: Add gpio-keys device Simon Horman
2013-12-23 2:08 ` Simon Horman
2013-12-24 3:45 ` [GIT PULL 0/3] Second Round of Renesas ARM Based SoC DT Updates for v3.14 Simon Horman
2013-12-24 3:45 ` Simon Horman
2013-12-29 21:21 ` Olof Johansson
2013-12-29 21:21 ` Olof Johansson
2013-12-24 6:04 ` [GIT PULL 0/3] Second Round of Renesas ARM based SoC Fixes for v3.13 Simon Horman
2013-12-24 6:04 ` Simon Horman
2013-12-24 6:04 ` [PATCH 1/3] ARM: shmobile: armadillo: Add PWM backlight power supply Simon Horman
2013-12-24 6:04 ` Simon Horman
2013-12-24 6:05 ` [PATCH 2/3] ARM: shmobile: bockw: fixup DMA mask Simon Horman
2013-12-24 6:05 ` Simon Horman
2013-12-24 6:05 ` Simon Horman [this message]
2013-12-24 6:05 ` [PATCH 3/3] ARM: shmobile: r8a7790: fix shdi resource sizes Simon Horman
2013-12-28 23:37 ` [GIT PULL 0/3] Second Round of Renesas ARM based SoC Fixes for v3.13 Olof Johansson
2013-12-28 23:37 ` Olof Johansson
2014-02-13 8:04 ` [GIT PULL 0/3] Second Round of Renesas ARM Based SoC DT Updates for v3.15 Simon Horman
2014-02-13 8:04 ` Simon Horman
2014-02-13 8:04 ` [PATCH 1/3] ARM: shmobile: r7s72100 dtsi: Add RSPI nodes Simon Horman
2014-02-13 8:04 ` Simon Horman
2014-02-13 8:04 ` [PATCH 2/3] ARM: shmobile: r8a7791 dtsi: Add QSPI node Simon Horman
2014-02-13 8:04 ` Simon Horman
2014-02-13 8:04 ` [PATCH 3/3] ARM: shmobile: koelsch dts: Add QSPI nodes Simon Horman
2014-02-13 8:04 ` Simon Horman
2014-02-20 9:28 ` [GIT PULL 0/3] Second Round of Renesas ARM Based SoC DT Updates for v3.15 Olof Johansson
2014-02-20 9:28 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d721a15c300c5f638a11573a6dd492158e737d6a.1387856124.git.horms+renesas@verge.net.au \
--to=horms+renesas@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.