All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Rob Herring <robh@kernel.org>, Liviu Dudau <liviu.dudau@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: arm: juno: Remove legacy Coresight 'slave-mode' property
Date: Fri, 22 Jul 2022 11:29:39 +0100	[thread overview]
Message-ID: <d73801f6-8476-074e-6af1-1b8cab95b817@arm.com> (raw)
In-Reply-To: <20220721212952.1984382-1-robh@kernel.org>

On 21/07/2022 22:29, Rob Herring wrote:
> The 'slave-mode' property is not valid under 'in-ports' as it was the
> legacy way to find input ports. Warnings are generated from the Coresight
> schema:
> 
> arch/arm64/boot/dts/arm/juno-r1.dtb: funnel@20150000: in-ports:port@0:endpoint: Unevaluated properties are not allowed ('slave-mode' was unexpected)
>          From schema: Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi b/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> index 2e43f4531308..fbcdf63ad56d 100644
> --- a/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> @@ -67,7 +67,6 @@ in-ports {
>   			port@0 {
>   				reg = <0>;
>   				csys2_funnel_in_port0: endpoint {
> -					slave-mode;
>   					remote-endpoint = <&etf0_out_port>;
>   				};
>   			};
> @@ -75,7 +74,6 @@ csys2_funnel_in_port0: endpoint {
>   			port@1 {
>   				reg = <1>;
>   				csys2_funnel_in_port1: endpoint {
> -					slave-mode;
>   					remote-endpoint = <&etf1_out_port>;
>   				};
>   			};



Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>


WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Rob Herring <robh@kernel.org>, Liviu Dudau <liviu.dudau@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: arm: juno: Remove legacy Coresight 'slave-mode' property
Date: Fri, 22 Jul 2022 11:29:39 +0100	[thread overview]
Message-ID: <d73801f6-8476-074e-6af1-1b8cab95b817@arm.com> (raw)
In-Reply-To: <20220721212952.1984382-1-robh@kernel.org>

On 21/07/2022 22:29, Rob Herring wrote:
> The 'slave-mode' property is not valid under 'in-ports' as it was the
> legacy way to find input ports. Warnings are generated from the Coresight
> schema:
> 
> arch/arm64/boot/dts/arm/juno-r1.dtb: funnel@20150000: in-ports:port@0:endpoint: Unevaluated properties are not allowed ('slave-mode' was unexpected)
>          From schema: Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi b/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> index 2e43f4531308..fbcdf63ad56d 100644
> --- a/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> @@ -67,7 +67,6 @@ in-ports {
>   			port@0 {
>   				reg = <0>;
>   				csys2_funnel_in_port0: endpoint {
> -					slave-mode;
>   					remote-endpoint = <&etf0_out_port>;
>   				};
>   			};
> @@ -75,7 +74,6 @@ csys2_funnel_in_port0: endpoint {
>   			port@1 {
>   				reg = <1>;
>   				csys2_funnel_in_port1: endpoint {
> -					slave-mode;
>   					remote-endpoint = <&etf1_out_port>;
>   				};
>   			};



Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-07-22 10:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21 21:29 [PATCH] arm64: dts: arm: juno: Remove legacy Coresight 'slave-mode' property Rob Herring
2022-07-21 21:29 ` Rob Herring
2022-07-22 10:29 ` Suzuki K Poulose [this message]
2022-07-22 10:29   ` Suzuki K Poulose
2022-08-15 14:24 ` Sudeep Holla
2022-08-15 14:24   ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d73801f6-8476-074e-6af1-1b8cab95b817@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.