Fwd: Re: [PATCH 04/10] IB/hfi1: Remove snoop/diag interface

Fwd: Re: [PATCH 04/10] IB/hfi1: Remove snoop/diag interface

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 1816 bytes --]




-------- Forwarded Message --------
Subject: Re: [PATCH 04/10] IB/hfi1: Remove snoop/diag interface
Date: Wed, 25 May 2016 16:07:38 -0400
From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Organization: Red Hat, Inc.
To: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
CC: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org jgunthorpe"@obsidianresearch.com Mike
Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Dean Luick <dean.luick-ral2JQCrhuE@public.gmane.orgm>

On 05/19/2016 08:26 AM, Dennis Dalessandro wrote:
> The snoop/diag interface is better served by an implementation which is
> more general and usable by other drivers perhaps. Go ahead and remove
> the code now and get rid of the char dev. We can put the feature back
> when we have a more agreeable solution.
> 
> Reviewed-by: Dean Luick <dean.luick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Reviewed-by: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Hi Dennis,

This series failed on this patch.  I was going to take the series in and
fixup patch 6/10 to move the ioctl numbers up to the upper end of the
0x1b range so that we won't have to worry about number collision with
the soon-to-come IB ioctl(s).  But, since this patch failed, I'll let
you fix both of those issue up.  Please make your changes relative to my
hfi1-3 branch on github:

git://github.com/dledford/linux hfi1-3


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD




-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]