[PATCH -perfbook 0/3] punctcheck.pl updates

[PATCH -perfbook 0/3] punctcheck.pl updates

[Akira Yokosawa]

Hi Paul,

So, this series adds patterns in punctcheck.pl to detect misuses
of punctuation markers "\@.", ".\@", and its friends.

Patch 1/3 adds the new pattern.
Patch 2/3 adds hint messages to help you and other contributors
see what is wrong.  Hopefully the added messages are clear enough.
Patch 3/3 fixes existing misuses detected by the added pattern.

        Thanks, Akira
--
Akira Yokosawa (3):
  punctcheck.pl: Add pattern to catch reverse use of period markers
  punctcheck.pl: Add hints in complaint messages
  Fix period markers

 glossary.tex            |  2 +-
 memorder/memorder.tex   |  2 +-
 together/applyrcu.tex   |  2 +-
 utilities/punctcheck.pl | 15 +++++++++++++++
 4 files changed, 18 insertions(+), 3 deletions(-)


base-commit: 5f28b7cb0d4c447c9d6397770906c7cb4c96832c
-- 
2.25.1

[PATCH -perfbook 1/3] punctcheck.pl: Add pattern to catch reverse use of period marker

[Akira Yokosawa]

End-of-sentence markers ("\@.", "\@?", etc.) make sense when they
follow uppercase letters.
Mid-sentence markers (".\@", "?\@", etc. ) make sense when they
follow lowercase letters.

Add patterns to cache misuses of them.

Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
---
 utilities/punctcheck.pl | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/utilities/punctcheck.pl b/utilities/punctcheck.pl
index 7d23cc57..8820bf9c 100755
--- a/utilities/punctcheck.pl
+++ b/utilities/punctcheck.pl
@@ -91,6 +91,12 @@ sub check_line {
 	if ($line =~ /^(?=[\s]*+[^%])[^%]*\\\@[\.\?\!\:][\)\}\']*\s+[^%]/){
 	    $ng += 1;
 	}
+	if ($line =~ /[a-z][\)\}\']*\\\@[\.\?\!\:][\)\}\']*\s/) {
+	    $ng += 1;
+	}
+	if ($line =~ /[A-Z][\)\}\']*[\.\?\!\:]\\\@[\)\}\']*\s/) {
+	    $ng += 1;
+	}
 	if ($ng) {
 	    print $ARGV[0], ':', $line_num, ':', $line_raw;
 	}
-- 
2.25.1

Re: [PATCH -perfbook 0/3] punctcheck.pl updates

[Akira Yokosawa]

On 2022/04/04 9:00, Akira Yokosawa wrote:
> Hi Paul,
> 
> So, this series adds patterns in punctcheck.pl to detect misuses
> of punctuation markers "\@.", ".\@", and its friends.
> 
> Patch 1/3 adds the new pattern.
> Patch 2/3 adds hint messages to help you and other contributors
> see what is wrong.  Hopefully the added messages are clear enough.

I noticed some typos in the added messages just before sending this.
I'll send a v2 soon.

        Thanks, Akira

> Patch 3/3 fixes existing misuses detected by the added pattern.
> 
>         Thanks, Akira
> --
> Akira Yokosawa (3):
>   punctcheck.pl: Add pattern to catch reverse use of period markers
>   punctcheck.pl: Add hints in complaint messages
>   Fix period markers
> 
>  glossary.tex            |  2 +-
>  memorder/memorder.tex   |  2 +-
>  together/applyrcu.tex   |  2 +-
>  utilities/punctcheck.pl | 15 +++++++++++++++
>  4 files changed, 18 insertions(+), 3 deletions(-)
> 
> 
> base-commit: 5f28b7cb0d4c447c9d6397770906c7cb4c96832c