From: Mike Kravetz <mike.kravetz@oracle.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Andrew Morton <akpm@linux-foundation.org>,
Nicholas Piggin <npiggin@gmail.com>,
Mike Rapoport <rppt@kernel.org>
Cc: linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [RFC PATCH v1 2/4] mm/hugetlb: Change parameters of arch_make_huge_pte()
Date: Thu, 29 Apr 2021 10:50:49 -0700 [thread overview]
Message-ID: <d7c516b7-4fec-dc1c-c931-e7b17272372e@oracle.com> (raw)
In-Reply-To: <e111d0d90231ae63e4b89da8efa87cde31daeeee.1619628001.git.christophe.leroy@csgroup.eu>
On 4/28/21 9:46 AM, Christophe Leroy wrote:
> At the time being, arch_make_huge_pte() has the following prototype:
>
> pte_t arch_make_huge_pte(pte_t entry, struct vm_area_struct *vma,
> struct page *page, int writable);
>
> vma is used to get the pages shift or size.
> vma is also used on Sparc to get vm_flags.
> page is not used.
> writable is not used.
>
> In order to use this function without a vma, and replace vma by shift
> and flags. Also remove the used parameters.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> arch/arm64/include/asm/hugetlb.h | 3 +--
> arch/arm64/mm/hugetlbpage.c | 5 ++---
> arch/powerpc/include/asm/nohash/32/hugetlb-8xx.h | 5 ++---
> arch/sparc/include/asm/pgtable_64.h | 3 +--
> arch/sparc/mm/hugetlbpage.c | 6 ++----
> include/linux/hugetlb.h | 4 ++--
> mm/hugetlb.c | 6 ++++--
> mm/migrate.c | 4 +++-
> 8 files changed, 17 insertions(+), 19 deletions(-)
Hi Christophe,
Sorry, no suggestion for how to make a beautiful generic implementation.
This patch is straight forward.
Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Andrew Morton <akpm@linux-foundation.org>,
Nicholas Piggin <npiggin@gmail.com>,
Mike Rapoport <rppt@kernel.org>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, sparclinux@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v1 2/4] mm/hugetlb: Change parameters of arch_make_huge_pte()
Date: Thu, 29 Apr 2021 10:50:49 -0700 [thread overview]
Message-ID: <d7c516b7-4fec-dc1c-c931-e7b17272372e@oracle.com> (raw)
In-Reply-To: <e111d0d90231ae63e4b89da8efa87cde31daeeee.1619628001.git.christophe.leroy@csgroup.eu>
On 4/28/21 9:46 AM, Christophe Leroy wrote:
> At the time being, arch_make_huge_pte() has the following prototype:
>
> pte_t arch_make_huge_pte(pte_t entry, struct vm_area_struct *vma,
> struct page *page, int writable);
>
> vma is used to get the pages shift or size.
> vma is also used on Sparc to get vm_flags.
> page is not used.
> writable is not used.
>
> In order to use this function without a vma, and replace vma by shift
> and flags. Also remove the used parameters.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> arch/arm64/include/asm/hugetlb.h | 3 +--
> arch/arm64/mm/hugetlbpage.c | 5 ++---
> arch/powerpc/include/asm/nohash/32/hugetlb-8xx.h | 5 ++---
> arch/sparc/include/asm/pgtable_64.h | 3 +--
> arch/sparc/mm/hugetlbpage.c | 6 ++----
> include/linux/hugetlb.h | 4 ++--
> mm/hugetlb.c | 6 ++++--
> mm/migrate.c | 4 +++-
> 8 files changed, 17 insertions(+), 19 deletions(-)
Hi Christophe,
Sorry, no suggestion for how to make a beautiful generic implementation.
This patch is straight forward.
Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Andrew Morton <akpm@linux-foundation.org>,
Nicholas Piggin <npiggin@gmail.com>,
Mike Rapoport <rppt@kernel.org>
Cc: linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [RFC PATCH v1 2/4] mm/hugetlb: Change parameters of arch_make_huge_pte()
Date: Thu, 29 Apr 2021 10:50:49 -0700 [thread overview]
Message-ID: <d7c516b7-4fec-dc1c-c931-e7b17272372e@oracle.com> (raw)
In-Reply-To: <e111d0d90231ae63e4b89da8efa87cde31daeeee.1619628001.git.christophe.leroy@csgroup.eu>
On 4/28/21 9:46 AM, Christophe Leroy wrote:
> At the time being, arch_make_huge_pte() has the following prototype:
>
> pte_t arch_make_huge_pte(pte_t entry, struct vm_area_struct *vma,
> struct page *page, int writable);
>
> vma is used to get the pages shift or size.
> vma is also used on Sparc to get vm_flags.
> page is not used.
> writable is not used.
>
> In order to use this function without a vma, and replace vma by shift
> and flags. Also remove the used parameters.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> arch/arm64/include/asm/hugetlb.h | 3 +--
> arch/arm64/mm/hugetlbpage.c | 5 ++---
> arch/powerpc/include/asm/nohash/32/hugetlb-8xx.h | 5 ++---
> arch/sparc/include/asm/pgtable_64.h | 3 +--
> arch/sparc/mm/hugetlbpage.c | 6 ++----
> include/linux/hugetlb.h | 4 ++--
> mm/hugetlb.c | 6 ++++--
> mm/migrate.c | 4 +++-
> 8 files changed, 17 insertions(+), 19 deletions(-)
Hi Christophe,
Sorry, no suggestion for how to make a beautiful generic implementation.
This patch is straight forward.
Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-29 17:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 16:46 [RFC PATCH v1 0/4] Implement huge VMAP and VMALLOC on powerpc 8xx Christophe Leroy
2021-04-28 16:46 ` Christophe Leroy
2021-04-28 16:46 ` Christophe Leroy
2021-04-28 16:46 ` [RFC PATCH v1 1/4] mm/ioremap: Fix iomap_max_page_shift Christophe Leroy
2021-04-28 16:46 ` Christophe Leroy
2021-04-28 16:46 ` Christophe Leroy
2021-04-28 16:46 ` [RFC PATCH v1 2/4] mm/hugetlb: Change parameters of arch_make_huge_pte() Christophe Leroy
2021-04-28 16:46 ` Christophe Leroy
2021-04-28 16:46 ` Christophe Leroy
2021-04-29 17:50 ` Mike Kravetz [this message]
2021-04-29 17:50 ` Mike Kravetz
2021-04-29 17:50 ` Mike Kravetz
2021-04-28 16:46 ` [RFC PATCH v1 3/4] mm/pgtable: Add stubs for {pmd/pub}_{set/clear}_huge Christophe Leroy
2021-04-28 16:46 ` Christophe Leroy
2021-04-28 16:46 ` Christophe Leroy
2021-04-28 16:46 ` [RFC PATCH v1 4/4] mm/vmalloc: Add support for huge pages on VMAP and VMALLOC for powerpc 8xx Christophe Leroy
2021-04-28 16:46 ` Christophe Leroy
2021-04-28 16:46 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7c516b7-4fec-dc1c-c931-e7b17272372e@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=rppt@kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.