All of lore.kernel.org
 help / color / mirror / Atom feed
* [master/zeus/thud][PATCH] docker: install init script if sysvinit
@ 2020-02-10 13:01 Jacob Stiffler
  2020-02-10 13:13 ` Stiffler, Jacob
  0 siblings, 1 reply; 2+ messages in thread
From: Jacob Stiffler @ 2020-02-10 13:01 UTC (permalink / raw)
  To: meta-arago

The docker recipe in meta-virtualization has conflicting logic for
when to install and when to enable the docker initscript. When both
systemd and sysvinit are in DISTRO_FEATURES, this causes the docker
postinst to fail, which now fails the rootfs task.

Here we install the initscript only based on if sysvinit is in the
DISTRO_FEATURES.

Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
---
 meta-arago-distro/recipes-containers/docker/docker_git.bbappend | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 meta-arago-distro/recipes-containers/docker/docker_git.bbappend

diff --git a/meta-arago-distro/recipes-containers/docker/docker_git.bbappend b/meta-arago-distro/recipes-containers/docker/docker_git.bbappend
new file mode 100644
index 0000000..dbb7b04
--- /dev/null
+++ b/meta-arago-distro/recipes-containers/docker/docker_git.bbappend
@@ -0,0 +1,8 @@
+PR_append = ".tisdk0"
+
+do_install_append() {
+	if ${@bb.utils.contains('DISTRO_FEATURES','sysvinit','true','false',d)}; then
+		install -d ${D}${sysconfdir}/init.d
+		install -m 0755 ${WORKDIR}/docker.init ${D}${sysconfdir}/init.d/docker.init
+	fi
+}
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [master/zeus/thud][PATCH] docker: install init script if sysvinit
  2020-02-10 13:01 [master/zeus/thud][PATCH] docker: install init script if sysvinit Jacob Stiffler
@ 2020-02-10 13:13 ` Stiffler, Jacob
  0 siblings, 0 replies; 2+ messages in thread
From: Stiffler, Jacob @ 2020-02-10 13:13 UTC (permalink / raw)
  To: meta-arago

I checked again, and this is only applicable for thud.

Based on inspection, the issue has persisted into zeus and master, but the recipe names have changed.

- Jake

> -----Original Message-----
> From: Stiffler, Jacob
> Sent: Monday, February 10, 2020 8:02 AM
> To: meta-arago@arago-project.org
> Cc: Stiffler, Jacob
> Subject: [master/zeus/thud][PATCH] docker: install init script if sysvinit
> 
> The docker recipe in meta-virtualization has conflicting logic for
> when to install and when to enable the docker initscript. When both
> systemd and sysvinit are in DISTRO_FEATURES, this causes the docker
> postinst to fail, which now fails the rootfs task.
> 
> Here we install the initscript only based on if sysvinit is in the
> DISTRO_FEATURES.
> 
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
>  meta-arago-distro/recipes-containers/docker/docker_git.bbappend | 8
> ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 meta-arago-distro/recipes-
> containers/docker/docker_git.bbappend
> 
> diff --git a/meta-arago-distro/recipes-
> containers/docker/docker_git.bbappend b/meta-arago-distro/recipes-
> containers/docker/docker_git.bbappend
> new file mode 100644
> index 0000000..dbb7b04
> --- /dev/null
> +++ b/meta-arago-distro/recipes-containers/docker/docker_git.bbappend
> @@ -0,0 +1,8 @@
> +PR_append = ".tisdk0"
> +
> +do_install_append() {
> +	if
> ${@bb.utils.contains('DISTRO_FEATURES','sysvinit','true','false',d)}; then
> +		install -d ${D}${sysconfdir}/init.d
> +		install -m 0755 ${WORKDIR}/docker.init
> ${D}${sysconfdir}/init.d/docker.init
> +	fi
> +}
> --
> 1.9.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-10 13:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10 13:01 [master/zeus/thud][PATCH] docker: install init script if sysvinit Jacob Stiffler
2020-02-10 13:13 ` Stiffler, Jacob

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.