* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/2] tests/kms_dither: New IGT to validate crtc Dithering
2021-07-09 11:41 [igt-dev] [i-g-t v2 1/2] tests/kms_dither: New IGT to validate crtc Dithering Bhanuprakash Modem
@ 2021-07-09 4:30 ` Patchwork
2021-07-09 6:03 ` [igt-dev] [i-g-t v2 1/2] " Shankar, Uma
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2021-07-09 4:30 UTC (permalink / raw)
To: Bhanuprakash Modem; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 9673 bytes --]
== Series Details ==
Series: series starting with [i-g-t,v2,1/2] tests/kms_dither: New IGT to validate crtc Dithering
URL : https://patchwork.freedesktop.org/series/92349/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10320 -> IGTPW_6002
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_6002:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_dither@fb-8bpc-vs-panel-6bpc@dsi-1-pipe-a} (NEW):
- {fi-tgl-dsi}: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-tgl-dsi/igt@kms_dither@fb-8bpc-vs-panel-6bpc@dsi-1-pipe-a.html
* {igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a} (NEW):
- {fi-ehl-2}: NOTRUN -> [SKIP][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-ehl-2/igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a.html
- {fi-jsl-1}: NOTRUN -> [SKIP][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-jsl-1/igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a.html
New tests
---------
New tests have been introduced between CI_DRM_10320 and IGTPW_6002:
### New IGT tests (20) ###
* igt@kms_dither@fb-8bpc-vs-panel-6bpc:
- Statuses : 10 skip(s)
- Exec time: [0.0] s
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@dp-1-pipe-a:
- Statuses : 5 pass(s)
- Exec time: [0.08, 0.22] s
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@dp-2-pipe-a:
- Statuses : 4 pass(s)
- Exec time: [0.08, 0.48] s
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@dp-3-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [0.18] s
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@dsi-1-pipe-a:
- Statuses : 3 skip(s)
- Exec time: [0.10, 0.44] s
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@dvi-d-1-pipe-a:
- Statuses : 1 skip(s)
- Exec time: [0.16] s
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@edp-1-pipe-a:
- Statuses : 8 pass(s)
- Exec time: [1.36, 2.10] s
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@lvds-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [0.28] s
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@vga-1-pipe-a:
- Statuses : 4 skip(s)
- Exec time: [0.05, 0.12] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@dp-1-pipe-a:
- Statuses : 5 pass(s)
- Exec time: [0.07, 0.22] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@dp-2-pipe-a:
- Statuses : 4 pass(s)
- Exec time: [0.06, 0.47] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@dp-3-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [0.17] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@dsi-1-pipe-a:
- Statuses : 3 pass(s)
- Exec time: [0.10, 0.47] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@dvi-d-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [0.16] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a:
- Statuses : 5 pass(s) 3 skip(s)
- Exec time: [1.41, 2.08] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@hdmi-a-1-pipe-a:
- Statuses : 5 pass(s)
- Exec time: [0.06, 0.13] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@hdmi-a-2-pipe-a:
- Statuses : 4 pass(s)
- Exec time: [0.06, 0.12] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@lvds-1-pipe-a:
- Statuses : 1 skip(s)
- Exec time: [0.29] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@vga-1-pipe-a:
- Statuses : 4 pass(s)
- Exec time: [0.04, 0.12] s
Known issues
------------
Here are the changes found in IGTPW_6002 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-soraka: [PASS][4] -> [INCOMPLETE][5] ([i915#155])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0.html
* igt@gem_exec_suspend@basic-s3:
- fi-skl-6600u: [PASS][6] -> [INCOMPLETE][7] ([i915#146] / [i915#198])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/fi-skl-6600u/igt@gem_exec_suspend@basic-s3.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-skl-6600u/igt@gem_exec_suspend@basic-s3.html
* {igt@kms_dither@fb-8bpc-vs-panel-6bpc} (NEW):
- fi-kbl-8809g: NOTRUN -> [SKIP][8] ([fdo#109271]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-kbl-8809g/igt@kms_dither@fb-8bpc-vs-panel-6bpc.html
- fi-kbl-guc: NOTRUN -> [SKIP][9] ([fdo#109271]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-kbl-guc/igt@kms_dither@fb-8bpc-vs-panel-6bpc.html
- fi-bsw-nick: NOTRUN -> [SKIP][10] ([fdo#109271]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-bsw-nick/igt@kms_dither@fb-8bpc-vs-panel-6bpc.html
- fi-bdw-5557u: NOTRUN -> [SKIP][11] ([fdo#109271])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-bdw-5557u/igt@kms_dither@fb-8bpc-vs-panel-6bpc.html
- fi-kbl-7567u: NOTRUN -> [SKIP][12] ([fdo#109271]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-kbl-7567u/igt@kms_dither@fb-8bpc-vs-panel-6bpc.html
- fi-cfl-8700k: NOTRUN -> [SKIP][13] ([fdo#109271])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-cfl-8700k/igt@kms_dither@fb-8bpc-vs-panel-6bpc.html
- fi-elk-e7500: NOTRUN -> [SKIP][14] ([fdo#109271])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-elk-e7500/igt@kms_dither@fb-8bpc-vs-panel-6bpc.html
- {fi-dg1-1}: NOTRUN -> [SKIP][15] ([i915#3717])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-dg1-1/igt@kms_dither@fb-8bpc-vs-panel-6bpc.html
- fi-cfl-guc: NOTRUN -> [SKIP][16] ([fdo#109271])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-cfl-guc/igt@kms_dither@fb-8bpc-vs-panel-6bpc.html
* {igt@kms_dither@fb-8bpc-vs-panel-6bpc@dsi-1-pipe-a} (NEW):
- fi-glk-dsi: NOTRUN -> [SKIP][17] ([fdo#109271])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-glk-dsi/igt@kms_dither@fb-8bpc-vs-panel-6bpc@dsi-1-pipe-a.html
- fi-bxt-dsi: NOTRUN -> [SKIP][18] ([fdo#109271])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-bxt-dsi/igt@kms_dither@fb-8bpc-vs-panel-6bpc@dsi-1-pipe-a.html
* {igt@kms_dither@fb-8bpc-vs-panel-6bpc@dvi-d-1-pipe-a} (NEW):
- fi-bwr-2160: NOTRUN -> [SKIP][19] ([fdo#109271])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-bwr-2160/igt@kms_dither@fb-8bpc-vs-panel-6bpc@dvi-d-1-pipe-a.html
* {igt@kms_dither@fb-8bpc-vs-panel-6bpc@vga-1-pipe-a} (NEW):
- fi-ivb-3770: NOTRUN -> [SKIP][20] ([fdo#109271])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-ivb-3770/igt@kms_dither@fb-8bpc-vs-panel-6bpc@vga-1-pipe-a.html
- fi-ilk-650: NOTRUN -> [SKIP][21] ([fdo#109271])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-ilk-650/igt@kms_dither@fb-8bpc-vs-panel-6bpc@vga-1-pipe-a.html
- fi-pnv-d510: NOTRUN -> [SKIP][22] ([fdo#109271])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-pnv-d510/igt@kms_dither@fb-8bpc-vs-panel-6bpc@vga-1-pipe-a.html
- fi-hsw-4770: NOTRUN -> [SKIP][23] ([fdo#109271])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-hsw-4770/igt@kms_dither@fb-8bpc-vs-panel-6bpc@vga-1-pipe-a.html
* {igt@kms_dither@fb-8bpc-vs-panel-8bpc} (NEW):
- {fi-hsw-gt1}: NOTRUN -> [SKIP][24] ([fdo#109271]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-hsw-gt1/igt@kms_dither@fb-8bpc-vs-panel-8bpc.html
* {igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a} (NEW):
- fi-bsw-kefka: NOTRUN -> [SKIP][25] ([fdo#109271])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-bsw-kefka/igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a.html
* {igt@kms_dither@fb-8bpc-vs-panel-8bpc@lvds-1-pipe-a} (NEW):
- fi-snb-2520m: NOTRUN -> [SKIP][26] ([fdo#109271])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/fi-snb-2520m/igt@kms_dither@fb-8bpc-vs-panel-8bpc@lvds-1-pipe-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#3717]: https://gitlab.freedesktop.org/drm/intel/issues/3717
Participating hosts (40 -> 39)
------------------------------
Missing (1): fi-bsw-cyan
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6132 -> IGTPW_6002
CI-20190529: 20190529
CI_DRM_10320: 7d61ab4a59bcbb206324b6a430748b4c15dd8adb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6002: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/index.html
IGT_6132: 61fb9cdf2a9132e3618c8b08b9d20fec0c347831 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Testlist changes ==
+igt@kms_dither@fb-8bpc-vs-panel-6bpc
+igt@kms_dither@fb-8bpc-vs-panel-8bpc
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/index.html
[-- Attachment #1.2: Type: text/html, Size: 12430 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [i-g-t v2 1/2] tests/kms_dither: New IGT to validate crtc Dithering
2021-07-09 11:41 [igt-dev] [i-g-t v2 1/2] tests/kms_dither: New IGT to validate crtc Dithering Bhanuprakash Modem
2021-07-09 4:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/2] " Patchwork
@ 2021-07-09 6:03 ` Shankar, Uma
2021-07-09 6:14 ` Modem, Bhanuprakash
2021-07-09 11:41 ` [igt-dev] [i-g-t v2 2/2] HAX: Add dither tests to fast-feedback Bhanuprakash Modem
2021-07-09 18:08 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,v2,1/2] tests/kms_dither: New IGT to validate crtc Dithering Patchwork
3 siblings, 1 reply; 7+ messages in thread
From: Shankar, Uma @ 2021-07-09 6:03 UTC (permalink / raw)
To: Modem, Bhanuprakash, igt-dev; +Cc: Varide, Nischal
> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> Sent: Friday, July 9, 2021 5:12 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Sharma, Swati2
> <swati2.sharma@intel.com>; Shankar, Uma <uma.shankar@intel.com>; Varide,
> Nischal <nischal.varide@intel.com>
> Subject: [i-g-t v2 1/2] tests/kms_dither: New IGT to validate crtc Dithering
>
> Many of the display devices have color format support less than the color format of
> the input data (Ex: 8-bit input data and 6-bit display color depth). Then the input data
> will be either truncated or rounded, but this approach usually causes loss of detail
> and also produce large banded areas of a single color that significantly differs from
> the original image.
>
> Dithering is a technique used to enhance these colors by creating the illusion of
> smoothness by adjusting the nearby pixel color.
> For Eg: Converting 8-bit to 6-bit by modifying the pixel information.
>
> Dithering should be enabled when a panel color depth is lower than the color depth
> of the framebuffer.
>
> Even though feature Dithering is there since legacy, there is no specific IGT for this.
> This patch will create New IGT for Dithering.
> And below is the truth table for CRTC Dithering.
>
> |----------------|---------|-------------|
> | Frame buffer | Panel | Dithering |
> |----------------|---------|-------------|
> | 8 BPC | 6 BPC | Yes |
> |----------------|---------|-------------|
> | 8 BPC | 8 BPC | No |
> |----------------|---------|-------------|
> | 8 BPC | 10 BPC | No |
> |----------------|---------|-------------|
> | 10 BPC | 6 BPC | Yes |
> |----------------|---------|-------------|
> | 10 BPC | 8 BPC | Yes |
> |----------------|---------|-------------|
> | 10 BPC | 10 BPC | No |
> |----------------|---------|-------------|
> | 16 BPC | 6 BPC | Yes |
> |----------------|---------|-------------|
> | 16 BPC | 8 BPC | Yes |
> |----------------|---------|-------------|
> | 16 BPC | 10 BPC | Yes |
> |----------------|---------|-------------|
>
> Note: As i915 enables dithering for 6 bpc panels only, we need to limit the execution
> to 6 & 8 bpc panels (Negative testing) only.
>
> Cc: Swati Sharma <swati2.sharma@intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com>
> Cc: Nischal Varide <nischal.varide@intel.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> tests/kms_dither.c | 242 +++++++++++++++++++++++++++++++++++++++++++++
> tests/meson.build | 1 +
> 2 files changed, 243 insertions(+)
> create mode 100644 tests/kms_dither.c
>
> diff --git a/tests/kms_dither.c b/tests/kms_dither.c new file mode 100644 index
> 000000000..50c649ca8
> --- /dev/null
> +++ b/tests/kms_dither.c
> @@ -0,0 +1,242 @@
> +/*
> + * Copyright © 2020 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person
> +obtaining a
> + * copy of this software and associated documentation files (the
> +"Software"),
> + * to deal in the Software without restriction, including without
> +limitation
> + * the rights to use, copy, modify, merge, publish, distribute,
> +sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom
> +the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the
> +next
> + * paragraph) shall be included in all copies or substantial portions
> +of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> +EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> +MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> +SHALL
> + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM,
> +DAMAGES OR
> + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
> +OTHERWISE,
> + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
> +OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + *
> + * Authors:
> + * Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> + *
> + */
> +
> +#include "igt.h"
> +#include <fcntl.h>
> +#include <termios.h>
> +#include <unistd.h>
> +
> +IGT_TEST_DESCRIPTION("Test Dithering block status");
> +
> +/* Connector BPC */
> +#define IGT_CONNECTOR_BPC_6 6
> +#define IGT_CONNECTOR_BPC_8 8
> +
> +/* Framebuffer BPC */
> +#define IGT_FRAME_BUFFER_BPC_8 8
> +
> +/* Common test data. */
> +typedef struct data {
> + igt_display_t display;
> + igt_plane_t *primary;
> + igt_output_t *output;
> + igt_pipe_t *pipe;
> + drmModeModeInfo *mode;
> + enum pipe pipe_id;
> + int drm_fd;
> + igt_fb_t fb;
> +} data_t;
> +
> +typedef struct {
> + unsigned int bpc;
> + unsigned int dither;
> +} dither_status_t;
> +
> +/* Prepare test data. */
> +static void prepare_test(data_t *data, igt_output_t *output, enum pipe
> +pipe) {
> + igt_display_t *display = &data->display;
> +
> + data->pipe_id = pipe;
> + data->pipe = &data->display.pipes[data->pipe_id];
> + igt_assert(data->pipe);
> +
> + igt_display_reset(display);
> +
> + data->output = output;
> + igt_assert(data->output);
> +
> + data->mode = igt_output_get_mode(data->output);
> + igt_assert(data->mode);
> +
> + data->primary =
> + igt_pipe_get_plane_type(data->pipe,
> DRM_PLANE_TYPE_PRIMARY);
> +
> + igt_output_set_pipe(data->output, data->pipe_id); }
> +
> +/* Returns the current state of dithering from the crtc debugfs. */
> +static dither_status_t get_dither_state(data_t *data) {
> + char buf[512], tmp[5];
> + char *start_loc;
> + int dir, res;
> + dither_status_t status;
> +
> + dir = igt_debugfs_dir(data->drm_fd);
> + igt_assert(dir >= 0);
> +
> + res = igt_debugfs_simple_read(dir, "i915_display_info", buf, sizeof(buf));
> + igt_require(res > 0);
> + close(dir);
> +
> + igt_assert(start_loc = strstr(buf, ", bpp="));
> + igt_assert_eq(sscanf(start_loc, ", bpp=%u", &status.bpc), 1);
> + status.bpc /= 3;
> +
> + igt_assert(start_loc = strstr(buf, ", dither="));
> + igt_assert_eq(sscanf(start_loc, ", dither=%s", tmp), 1);
> + status.dither = !strcmp(tmp, "yes,");
> +
> + return status;
> +}
> +
> +static void test_dithering(data_t *data, enum pipe pipe,
> + igt_output_t *output,
> + int fb_bpc, int fb_format,
> + int output_bpc)
> +{
> + igt_display_t *display = &data->display;
> + dither_status_t status;
> + int bpc = 0;
> +
> + igt_info("Dithering test execution on %s PIPE_%s\n",
> + output->name, kmstest_pipe_name(pipe));
> + prepare_test(data, output, pipe);
> +
> + igt_assert(igt_create_fb(data->drm_fd, data->mode->hdisplay,
> + data->mode->vdisplay, fb_format,
> + LOCAL_DRM_FORMAT_MOD_NONE, &data->fb));
> + igt_plane_set_fb(data->primary, &data->fb);
> + igt_plane_set_size(data->primary, data->mode->hdisplay,
> +data->mode->vdisplay);
> +
> + if (igt_output_has_prop(output, IGT_CONNECTOR_MAX_BPC)) {
> + bpc = igt_output_get_prop(output, IGT_CONNECTOR_MAX_BPC);
You can have these has_prop as igt_require before going further in the tests and skip in case
we don't get them.
> + igt_output_set_prop_value(data->output,
> IGT_CONNECTOR_MAX_BPC, output_bpc);
> + }
> + igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC :
> +COMMIT_LEGACY);
> +
> + /*
> + * Check the status of Dithering block:
> + *
> + * Preserve the result & compute later (after clean-up).
> + * If fb_bpc is greater than output_bpc, Dithering should be enabled
> + * Else disabled
> + */
> + status = get_dither_state(data);
> +
> + igt_info("FB BPC:%d, Panel BPC:%d, Pipe BPC:%d, Expected Dither:%s,
> Actual result:%s\n",
> + fb_bpc, output_bpc, status.bpc,
> + (fb_bpc > output_bpc) ? "Enable": "Disable",
> + status.dither ? "Enable": "Disable");
> +
> + /*
> + * We must update the Connector max_bpc property back
> + * Otherwise, previously updated value will stay forever and
> + * may cause the failures for next/other subtests.
> + */
> + if (bpc)
> + igt_output_set_prop_value(data->output,
> IGT_CONNECTOR_MAX_BPC, bpc);
> + igt_plane_set_fb(data->primary, NULL);
> + igt_output_set_pipe(output, PIPE_NONE);
> + igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC :
> COMMIT_LEGACY);
> + igt_remove_fb(data->drm_fd, &data->fb);
> +
> + /* Check if crtc bpc is updated with requested one. */
> + igt_require_f((status.bpc == output_bpc),
> + "%s can support max %u-bpc, but requested %d-bpc\n",
> + output->name, status.bpc, output_bpc);
> +
> + /* Compute the result. */
> + if (fb_bpc > output_bpc)
> + igt_assert_f(status.dither, "(fb_%dbpc > output_%dbpc): Dither
> should be enabled\n",
> + fb_bpc, output_bpc);
> + else
> + igt_assert_f(!status.dither, "(fb_%dbpc <= output_%dbpc): Dither
> should be disabled\n",
> + fb_bpc, output_bpc);
> +
> + return;
> +}
> +
> +static void
> +run_dither_test(data_t *data, int fb_bpc, int fb_format, int
> +output_bpc) {
> + igt_output_t *output;
> + igt_display_t *display = &data->display;
> +
> + for_each_connected_output(display, output) {
> + enum pipe pipe;
> + drmModeConnector *connector = output->config.connector;
> +
> + /* HDMI won't support 6 BPC */
> + if (output_bpc == IGT_CONNECTOR_BPC_6 &&
> + (connector->connector_type ==
> DRM_MODE_CONNECTOR_HDMIA ||
> + connector->connector_type ==
> DRM_MODE_CONNECTOR_HDMIB))
I think we already have a check in test_dithering, so we can drop this specific
encoder check here.
> + continue;
> +
> + for_each_pipe(display, pipe) {
> + if (igt_pipe_connector_valid(pipe, output)) {
> + igt_dynamic_f("%s-pipe-%s", output->name,
> kmstest_pipe_name(pipe))
> + test_dithering(data, pipe, output, fb_bpc,
> + fb_format, output_bpc);
> +
> + /* One pipe is enough */
> + break;
> + }
> + }
> + }
> +}
> +
> +igt_main
> +{
> + struct {
> + int fb_bpc;
> + int format;
> + int output_bpc;
> + } tests[] = {
> + { IGT_FRAME_BUFFER_BPC_8, DRM_FORMAT_XRGB8888,
> IGT_CONNECTOR_BPC_6 },
> + { IGT_FRAME_BUFFER_BPC_8, DRM_FORMAT_XRGB8888,
> IGT_CONNECTOR_BPC_8 },
> + };
> + int i;
> + data_t data = { 0 };
> +
> + igt_fixture {
> + data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> + kmstest_set_vt_graphics_mode();
> +
> + igt_display_require(&data.display, data.drm_fd);
> + igt_display_require_output(&data.display);
> + }
> +
> + for (i = 0; i < ARRAY_SIZE(tests); i++) {
> + igt_describe_f("Framebuffer BPC:%d, Panel BPC:%d, Expected
> Dither:%s\n",
> + tests[i].fb_bpc, tests[i].output_bpc,
> + (tests[i].fb_bpc > tests[i].output_bpc) ?
> + "Enable": "Disable");
> +
> + igt_subtest_with_dynamic_f("FB-%dBPC-Vs-Panel-%dBPC",
> + tests[i].fb_bpc, tests[i].output_bpc)
> + run_dither_test(&data,
> + tests[i].fb_bpc,
> + tests[i].format,
> + tests[i].output_bpc);
> + }
> +
> + igt_fixture {
> + igt_display_fini(&data.display);
> + }
> +}
> diff --git a/tests/meson.build b/tests/meson.build index 01911c457..d3de40be0
> 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -29,6 +29,7 @@ test_progs = [
> 'kms_cursor_crc',
> 'kms_cursor_edge_walk',
> 'kms_cursor_legacy',
> + 'kms_dither',
> 'kms_dp_aux_dev',
> 'kms_dp_dsc',
> 'kms_dp_tiled_display',
> --
> 2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [i-g-t v2 1/2] tests/kms_dither: New IGT to validate crtc Dithering
2021-07-09 6:03 ` [igt-dev] [i-g-t v2 1/2] " Shankar, Uma
@ 2021-07-09 6:14 ` Modem, Bhanuprakash
2021-07-09 7:08 ` Shankar, Uma
0 siblings, 1 reply; 7+ messages in thread
From: Modem, Bhanuprakash @ 2021-07-09 6:14 UTC (permalink / raw)
To: Shankar, Uma, igt-dev; +Cc: Varide, Nischal
> From: Shankar, Uma <uma.shankar@intel.com>
> Sent: Friday, July 9, 2021 11:33 AM
> To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; igt-
> dev@lists.freedesktop.org
> Cc: Sharma, Swati2 <swati2.sharma@intel.com>; Varide, Nischal
> <nischal.varide@intel.com>
> Subject: RE: [i-g-t v2 1/2] tests/kms_dither: New IGT to validate crtc
> Dithering
>
>
>
> > -----Original Message-----
> > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > Sent: Friday, July 9, 2021 5:12 PM
> > To: igt-dev@lists.freedesktop.org
> > Cc: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Sharma, Swati2
> > <swati2.sharma@intel.com>; Shankar, Uma <uma.shankar@intel.com>; Varide,
> > Nischal <nischal.varide@intel.com>
> > Subject: [i-g-t v2 1/2] tests/kms_dither: New IGT to validate crtc Dithering
> >
> > Many of the display devices have color format support less than the color
> format of
> > the input data (Ex: 8-bit input data and 6-bit display color depth). Then
> the input data
> > will be either truncated or rounded, but this approach usually causes loss
> of detail
> > and also produce large banded areas of a single color that significantly
> differs from
> > the original image.
> >
> > Dithering is a technique used to enhance these colors by creating the
> illusion of
> > smoothness by adjusting the nearby pixel color.
> > For Eg: Converting 8-bit to 6-bit by modifying the pixel information.
> >
> > Dithering should be enabled when a panel color depth is lower than the color
> depth
> > of the framebuffer.
> >
> > Even though feature Dithering is there since legacy, there is no specific
> IGT for this.
> > This patch will create New IGT for Dithering.
> > And below is the truth table for CRTC Dithering.
> >
> > |----------------|---------|-------------|
> > | Frame buffer | Panel | Dithering |
> > |----------------|---------|-------------|
> > | 8 BPC | 6 BPC | Yes |
> > |----------------|---------|-------------|
> > | 8 BPC | 8 BPC | No |
> > |----------------|---------|-------------|
> > | 8 BPC | 10 BPC | No |
> > |----------------|---------|-------------|
> > | 10 BPC | 6 BPC | Yes |
> > |----------------|---------|-------------|
> > | 10 BPC | 8 BPC | Yes |
> > |----------------|---------|-------------|
> > | 10 BPC | 10 BPC | No |
> > |----------------|---------|-------------|
> > | 16 BPC | 6 BPC | Yes |
> > |----------------|---------|-------------|
> > | 16 BPC | 8 BPC | Yes |
> > |----------------|---------|-------------|
> > | 16 BPC | 10 BPC | Yes |
> > |----------------|---------|-------------|
> >
> > Note: As i915 enables dithering for 6 bpc panels only, we need to limit the
> execution
> > to 6 & 8 bpc panels (Negative testing) only.
> >
> > Cc: Swati Sharma <swati2.sharma@intel.com>
> > Cc: Uma Shankar <uma.shankar@intel.com>
> > Cc: Nischal Varide <nischal.varide@intel.com>
> > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > ---
> > tests/kms_dither.c | 242 +++++++++++++++++++++++++++++++++++++++++++++
> > tests/meson.build | 1 +
> > 2 files changed, 243 insertions(+)
> > create mode 100644 tests/kms_dither.c
> >
> > diff --git a/tests/kms_dither.c b/tests/kms_dither.c new file mode 100644
> index
> > 000000000..50c649ca8
> > --- /dev/null
> > +++ b/tests/kms_dither.c
> > @@ -0,0 +1,242 @@
> > +/*
> > + * Copyright © 2020 Intel Corporation
> > + *
> > + * Permission is hereby granted, free of charge, to any person
> > +obtaining a
> > + * copy of this software and associated documentation files (the
> > +"Software"),
> > + * to deal in the Software without restriction, including without
> > +limitation
> > + * the rights to use, copy, modify, merge, publish, distribute,
> > +sublicense,
> > + * and/or sell copies of the Software, and to permit persons to whom
> > +the
> > + * Software is furnished to do so, subject to the following conditions:
> > + *
> > + * The above copyright notice and this permission notice (including the
> > +next
> > + * paragraph) shall be included in all copies or substantial portions
> > +of the
> > + * Software.
> > + *
> > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > +EXPRESS OR
> > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > +MERCHANTABILITY,
> > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> > +SHALL
> > + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM,
> > +DAMAGES OR
> > + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
> > +OTHERWISE,
> > + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
> > +OR
> > + * OTHER DEALINGS IN THE SOFTWARE.
> > + *
> > + * Authors:
> > + * Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > + *
> > + */
> > +
> > +#include "igt.h"
> > +#include <fcntl.h>
> > +#include <termios.h>
> > +#include <unistd.h>
> > +
> > +IGT_TEST_DESCRIPTION("Test Dithering block status");
> > +
> > +/* Connector BPC */
> > +#define IGT_CONNECTOR_BPC_66
> > +#define IGT_CONNECTOR_BPC_88
> > +
> > +/* Framebuffer BPC */
> > +#define IGT_FRAME_BUFFER_BPC_88
> > +
> > +/* Common test data. */
> > +typedef struct data {
> > +igt_display_t display;
> > +igt_plane_t *primary;
> > +igt_output_t *output;
> > +igt_pipe_t *pipe;
> > +drmModeModeInfo *mode;
> > +enum pipe pipe_id;
> > +int drm_fd;
> > +igt_fb_t fb;
> > +} data_t;
> > +
> > +typedef struct {
> > +unsigned int bpc;
> > +unsigned int dither;
> > +} dither_status_t;
> > +
> > +/* Prepare test data. */
> > +static void prepare_test(data_t *data, igt_output_t *output, enum pipe
> > +pipe) {
> > +igt_display_t *display = &data->display;
> > +
> > +data->pipe_id = pipe;
> > +data->pipe = &data->display.pipes[data->pipe_id];
> > +igt_assert(data->pipe);
> > +
> > +igt_display_reset(display);
> > +
> > +data->output = output;
> > +igt_assert(data->output);
> > +
> > +data->mode = igt_output_get_mode(data->output);
> > +igt_assert(data->mode);
> > +
> > +data->primary =
> > +igt_pipe_get_plane_type(data->pipe,
> > DRM_PLANE_TYPE_PRIMARY);
> > +
> > +igt_output_set_pipe(data->output, data->pipe_id); }
> > +
> > +/* Returns the current state of dithering from the crtc debugfs. */
> > +static dither_status_t get_dither_state(data_t *data) {
> > +char buf[512], tmp[5];
> > +char *start_loc;
> > +int dir, res;
> > +dither_status_t status;
> > +
> > +dir = igt_debugfs_dir(data->drm_fd);
> > +igt_assert(dir >= 0);
> > +
> > +res = igt_debugfs_simple_read(dir, "i915_display_info", buf, sizeof(buf));
> > +igt_require(res > 0);
> > +close(dir);
> > +
> > +igt_assert(start_loc = strstr(buf, ", bpp="));
> > +igt_assert_eq(sscanf(start_loc, ", bpp=%u", &status.bpc), 1);
> > +status.bpc /= 3;
> > +
> > +igt_assert(start_loc = strstr(buf, ", dither="));
> > +igt_assert_eq(sscanf(start_loc, ", dither=%s", tmp), 1);
> > +status.dither = !strcmp(tmp, "yes,");
> > +
> > +return status;
> > +}
> > +
> > +static void test_dithering(data_t *data, enum pipe pipe,
> > + igt_output_t *output,
> > + int fb_bpc, int fb_format,
> > + int output_bpc)
> > +{
> > +igt_display_t *display = &data->display;
> > +dither_status_t status;
> > +int bpc = 0;
> > +
> > +igt_info("Dithering test execution on %s PIPE_%s\n",
> > +output->name, kmstest_pipe_name(pipe));
> > +prepare_test(data, output, pipe);
> > +
> > +igt_assert(igt_create_fb(data->drm_fd, data->mode->hdisplay,
> > + data->mode->vdisplay, fb_format,
> > + LOCAL_DRM_FORMAT_MOD_NONE, &data->fb));
> > +igt_plane_set_fb(data->primary, &data->fb);
> > +igt_plane_set_size(data->primary, data->mode->hdisplay,
> > +data->mode->vdisplay);
> > +
> > +if (igt_output_has_prop(output, IGT_CONNECTOR_MAX_BPC)) {
> > +bpc = igt_output_get_prop(output, IGT_CONNECTOR_MAX_BPC);
>
> You can have these has_prop as igt_require before going further in the tests
> and skip in case
> we don't get them.
In that case we'll loose the coverage for older kernels & some connector types.
Ex: DSI & VGA are skipping with that change
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5996/bat-all.html?testfilter=kms_dither
>
> > +igt_output_set_prop_value(data->output,
> > IGT_CONNECTOR_MAX_BPC, output_bpc);
> > +}
> > +igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC :
> > +COMMIT_LEGACY);
> > +
> > +/*
> > + * Check the status of Dithering block:
> > + *
> > + * Preserve the result & compute later (after clean-up).
> > + * If fb_bpc is greater than output_bpc, Dithering should be enabled
> > + * Else disabled
> > + */
> > +status = get_dither_state(data);
> > +
> > +igt_info("FB BPC:%d, Panel BPC:%d, Pipe BPC:%d, Expected Dither:%s,
> > Actual result:%s\n",
> > + fb_bpc, output_bpc, status.bpc,
> > + (fb_bpc > output_bpc) ? "Enable": "Disable",
> > + status.dither ? "Enable": "Disable");
> > +
> > + /*
> > +* We must update the Connector max_bpc property back
> > +* Otherwise, previously updated value will stay forever and
> > +* may cause the failures for next/other subtests.
> > +*/
> > +if (bpc)
> > +igt_output_set_prop_value(data->output,
> > IGT_CONNECTOR_MAX_BPC, bpc);
> > +igt_plane_set_fb(data->primary, NULL);
> > +igt_output_set_pipe(output, PIPE_NONE);
> > +igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC :
> > COMMIT_LEGACY);
> > +igt_remove_fb(data->drm_fd, &data->fb);
> > +
> > +/* Check if crtc bpc is updated with requested one. */
> > +igt_require_f((status.bpc == output_bpc),
> > +"%s can support max %u-bpc, but requested %d-bpc\n",
> > +output->name, status.bpc, output_bpc);
> > +
> > +/* Compute the result. */
> > +if (fb_bpc > output_bpc)
> > +igt_assert_f(status.dither, "(fb_%dbpc > output_%dbpc): Dither
> > should be enabled\n",
> > +fb_bpc, output_bpc);
> > +else
> > +igt_assert_f(!status.dither, "(fb_%dbpc <= output_%dbpc): Dither
> > should be disabled\n",
> > +fb_bpc, output_bpc);
> > +
> > +return;
> > +}
> > +
> > +static void
> > +run_dither_test(data_t *data, int fb_bpc, int fb_format, int
> > +output_bpc) {
> > +igt_output_t *output;
> > +igt_display_t *display = &data->display;
> > +
> > +for_each_connected_output(display, output) {
> > +enum pipe pipe;
> > +drmModeConnector *connector = output->config.connector;
> > +
> > +/* HDMI won't support 6 BPC */
> > +if (output_bpc == IGT_CONNECTOR_BPC_6 &&
> > + (connector->connector_type ==
> > DRM_MODE_CONNECTOR_HDMIA ||
> > + connector->connector_type ==
> > DRM_MODE_CONNECTOR_HDMIB))
>
> I think we already have a check in test_dithering, so we can drop this
> specific
> encoder check here.
I guess atomic commit will fail & throws an error: -22 invalid argument
if we request to set max_bpc as 6 for HDMI connectors, because HDMI won't
support 6-bpc.
>
> > +continue;
> > +
> > +for_each_pipe(display, pipe) {
> > +if (igt_pipe_connector_valid(pipe, output)) {
> > +igt_dynamic_f("%s-pipe-%s", output->name,
> > kmstest_pipe_name(pipe))
> > +test_dithering(data, pipe, output, fb_bpc,
> > +fb_format, output_bpc);
> > +
> > +/* One pipe is enough */
> > +break;
> > +}
> > +}
> > +}
> > +}
> > +
> > +igt_main
> > +{
> > +struct {
> > +int fb_bpc;
> > +int format;
> > +int output_bpc;
> > +} tests[] = {
> > +{ IGT_FRAME_BUFFER_BPC_8, DRM_FORMAT_XRGB8888,
> > IGT_CONNECTOR_BPC_6 },
> > +{ IGT_FRAME_BUFFER_BPC_8, DRM_FORMAT_XRGB8888,
> > IGT_CONNECTOR_BPC_8 },
> > +};
> > +int i;
> > +data_t data = { 0 };
> > +
> > +igt_fixture {
> > +data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> > +kmstest_set_vt_graphics_mode();
> > +
> > +igt_display_require(&data.display, data.drm_fd);
> > +igt_display_require_output(&data.display);
> > +}
> > +
> > +for (i = 0; i < ARRAY_SIZE(tests); i++) {
> > +igt_describe_f("Framebuffer BPC:%d, Panel BPC:%d, Expected
> > Dither:%s\n",
> > + tests[i].fb_bpc, tests[i].output_bpc,
> > + (tests[i].fb_bpc > tests[i].output_bpc) ?
> > +"Enable": "Disable");
> > +
> > +igt_subtest_with_dynamic_f("FB-%dBPC-Vs-Panel-%dBPC",
> > +tests[i].fb_bpc, tests[i].output_bpc)
> > +run_dither_test(&data,
> > +tests[i].fb_bpc,
> > +tests[i].format,
> > +tests[i].output_bpc);
> > +}
> > +
> > +igt_fixture {
> > +igt_display_fini(&data.display);
> > +}
> > +}
> > diff --git a/tests/meson.build b/tests/meson.build index
> 01911c457..d3de40be0
> > 100644
> > --- a/tests/meson.build
> > +++ b/tests/meson.build
> > @@ -29,6 +29,7 @@ test_progs = [
> > 'kms_cursor_crc',
> > 'kms_cursor_edge_walk',
> > 'kms_cursor_legacy',
> > +'kms_dither',
> > 'kms_dp_aux_dev',
> > 'kms_dp_dsc',
> > 'kms_dp_tiled_display',
> > --
> > 2.20.1
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [i-g-t v2 1/2] tests/kms_dither: New IGT to validate crtc Dithering
2021-07-09 6:14 ` Modem, Bhanuprakash
@ 2021-07-09 7:08 ` Shankar, Uma
0 siblings, 0 replies; 7+ messages in thread
From: Shankar, Uma @ 2021-07-09 7:08 UTC (permalink / raw)
To: Modem, Bhanuprakash, igt-dev; +Cc: Varide, Nischal
> >
> > > -----Original Message-----
> > > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > > Sent: Friday, July 9, 2021 5:12 PM
> > > To: igt-dev@lists.freedesktop.org
> > > Cc: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Sharma,
> > > Swati2 <swati2.sharma@intel.com>; Shankar, Uma
> > > <uma.shankar@intel.com>; Varide, Nischal <nischal.varide@intel.com>
> > > Subject: [i-g-t v2 1/2] tests/kms_dither: New IGT to validate crtc
> > > Dithering
> > >
> > > Many of the display devices have color format support less than the
> > > color
> > format of
> > > the input data (Ex: 8-bit input data and 6-bit display color depth).
> > > Then
> > the input data
> > > will be either truncated or rounded, but this approach usually
> > > causes loss
> > of detail
> > > and also produce large banded areas of a single color that
> > > significantly
> > differs from
> > > the original image.
> > >
> > > Dithering is a technique used to enhance these colors by creating
> > > the
> > illusion of
> > > smoothness by adjusting the nearby pixel color.
> > > For Eg: Converting 8-bit to 6-bit by modifying the pixel information.
> > >
> > > Dithering should be enabled when a panel color depth is lower than
> > > the color
> > depth
> > > of the framebuffer.
> > >
> > > Even though feature Dithering is there since legacy, there is no
> > > specific
> > IGT for this.
> > > This patch will create New IGT for Dithering.
> > > And below is the truth table for CRTC Dithering.
> > >
> > > |----------------|---------|-------------|
> > > | Frame buffer | Panel | Dithering |
> > > |----------------|---------|-------------|
> > > | 8 BPC | 6 BPC | Yes |
> > > |----------------|---------|-------------|
> > > | 8 BPC | 8 BPC | No |
> > > |----------------|---------|-------------|
> > > | 8 BPC | 10 BPC | No |
> > > |----------------|---------|-------------|
> > > | 10 BPC | 6 BPC | Yes |
> > > |----------------|---------|-------------|
> > > | 10 BPC | 8 BPC | Yes |
> > > |----------------|---------|-------------|
> > > | 10 BPC | 10 BPC | No |
> > > |----------------|---------|-------------|
> > > | 16 BPC | 6 BPC | Yes |
> > > |----------------|---------|-------------|
> > > | 16 BPC | 8 BPC | Yes |
> > > |----------------|---------|-------------|
> > > | 16 BPC | 10 BPC | Yes |
> > > |----------------|---------|-------------|
> > >
> > > Note: As i915 enables dithering for 6 bpc panels only, we need to
> > > limit the
> > execution
> > > to 6 & 8 bpc panels (Negative testing) only.
> > >
> > > Cc: Swati Sharma <swati2.sharma@intel.com>
> > > Cc: Uma Shankar <uma.shankar@intel.com>
> > > Cc: Nischal Varide <nischal.varide@intel.com>
> > > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > > ---
> > > tests/kms_dither.c | 242 +++++++++++++++++++++++++++++++++++++++++++++
> > > tests/meson.build | 1 +
> > > 2 files changed, 243 insertions(+)
> > > create mode 100644 tests/kms_dither.c
> > >
> > > diff --git a/tests/kms_dither.c b/tests/kms_dither.c new file mode
> > > 100644
> > index
> > > 000000000..50c649ca8
> > > --- /dev/null
> > > +++ b/tests/kms_dither.c
> > > @@ -0,0 +1,242 @@
> > > +/*
> > > + * Copyright © 2020 Intel Corporation
> > > + *
> > > + * Permission is hereby granted, free of charge, to any person
> > > +obtaining a
> > > + * copy of this software and associated documentation files (the
> > > +"Software"),
> > > + * to deal in the Software without restriction, including without
> > > +limitation
> > > + * the rights to use, copy, modify, merge, publish, distribute,
> > > +sublicense,
> > > + * and/or sell copies of the Software, and to permit persons to
> > > +whom the
> > > + * Software is furnished to do so, subject to the following conditions:
> > > + *
> > > + * The above copyright notice and this permission notice (including
> > > +the next
> > > + * paragraph) shall be included in all copies or substantial
> > > +portions of the
> > > + * Software.
> > > + *
> > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > > +EXPRESS OR
> > > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > > +MERCHANTABILITY,
> > > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO
> > > +EVENT SHALL
> > > + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM,
> > > +DAMAGES OR
> > > + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
> > > +OTHERWISE,
> > > + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
> > > +USE OR
> > > + * OTHER DEALINGS IN THE SOFTWARE.
> > > + *
> > > + * Authors:
> > > + * Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > > + *
> > > + */
> > > +
> > > +#include "igt.h"
> > > +#include <fcntl.h>
> > > +#include <termios.h>
> > > +#include <unistd.h>
> > > +
> > > +IGT_TEST_DESCRIPTION("Test Dithering block status");
> > > +
> > > +/* Connector BPC */
> > > +#define IGT_CONNECTOR_BPC_66
> > > +#define IGT_CONNECTOR_BPC_88
> > > +
> > > +/* Framebuffer BPC */
> > > +#define IGT_FRAME_BUFFER_BPC_88
> > > +
> > > +/* Common test data. */
> > > +typedef struct data {
> > > +igt_display_t display;
> > > +igt_plane_t *primary;
> > > +igt_output_t *output;
> > > +igt_pipe_t *pipe;
> > > +drmModeModeInfo *mode;
> > > +enum pipe pipe_id;
> > > +int drm_fd;
> > > +igt_fb_t fb;
> > > +} data_t;
> > > +
> > > +typedef struct {
> > > +unsigned int bpc;
> > > +unsigned int dither;
> > > +} dither_status_t;
> > > +
> > > +/* Prepare test data. */
> > > +static void prepare_test(data_t *data, igt_output_t *output, enum
> > > +pipe
> > > +pipe) {
> > > +igt_display_t *display = &data->display;
> > > +
> > > +data->pipe_id = pipe;
> > > +data->pipe = &data->display.pipes[data->pipe_id];
> > > +igt_assert(data->pipe);
> > > +
> > > +igt_display_reset(display);
> > > +
> > > +data->output = output;
> > > +igt_assert(data->output);
> > > +
> > > +data->mode = igt_output_get_mode(data->output);
> > > +igt_assert(data->mode);
> > > +
> > > +data->primary =
> > > +igt_pipe_get_plane_type(data->pipe,
> > > DRM_PLANE_TYPE_PRIMARY);
> > > +
> > > +igt_output_set_pipe(data->output, data->pipe_id); }
> > > +
> > > +/* Returns the current state of dithering from the crtc debugfs. */
> > > +static dither_status_t get_dither_state(data_t *data) { char
> > > +buf[512], tmp[5]; char *start_loc; int dir, res; dither_status_t
> > > +status;
> > > +
> > > +dir = igt_debugfs_dir(data->drm_fd); igt_assert(dir >= 0);
> > > +
> > > +res = igt_debugfs_simple_read(dir, "i915_display_info", buf,
> > > +sizeof(buf)); igt_require(res > 0); close(dir);
> > > +
> > > +igt_assert(start_loc = strstr(buf, ", bpp="));
> > > +igt_assert_eq(sscanf(start_loc, ", bpp=%u", &status.bpc), 1);
> > > +status.bpc /= 3;
> > > +
> > > +igt_assert(start_loc = strstr(buf, ", dither="));
> > > +igt_assert_eq(sscanf(start_loc, ", dither=%s", tmp), 1);
> > > +status.dither = !strcmp(tmp, "yes,");
> > > +
> > > +return status;
> > > +}
> > > +
> > > +static void test_dithering(data_t *data, enum pipe pipe,
> > > + igt_output_t *output,
> > > + int fb_bpc, int fb_format,
> > > + int output_bpc)
> > > +{
> > > +igt_display_t *display = &data->display; dither_status_t status;
> > > +int bpc = 0;
> > > +
> > > +igt_info("Dithering test execution on %s PIPE_%s\n",
> > > +output->name, kmstest_pipe_name(pipe));
> > > +prepare_test(data, output, pipe);
> > > +
> > > +igt_assert(igt_create_fb(data->drm_fd, data->mode->hdisplay,
> > > + data->mode->vdisplay, fb_format,
> > > + LOCAL_DRM_FORMAT_MOD_NONE, &data->fb));
> > > +igt_plane_set_fb(data->primary, &data->fb);
> > > +igt_plane_set_size(data->primary, data->mode->hdisplay,
> > > +data->mode->vdisplay);
> > > +
> > > +if (igt_output_has_prop(output, IGT_CONNECTOR_MAX_BPC)) { bpc =
> > > +igt_output_get_prop(output, IGT_CONNECTOR_MAX_BPC);
> >
> > You can have these has_prop as igt_require before going further in the
> > tests and skip in case we don't get them.
>
> In that case we'll loose the coverage for older kernels & some connector types.
>
> Ex: DSI & VGA are skipping with that change https://intel-gfx-ci.01.org/tree/drm-
> tip/IGTPW_5996/bat-all.html?testfilter=kms_dither
But isn't it a mandatory requirement for your test ?
> >
> > > +igt_output_set_prop_value(data->output,
> > > IGT_CONNECTOR_MAX_BPC, output_bpc);
> > > +}
> > > +igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC :
> > > +COMMIT_LEGACY);
> > > +
> > > +/*
> > > + * Check the status of Dithering block:
> > > + *
> > > + * Preserve the result & compute later (after clean-up).
> > > + * If fb_bpc is greater than output_bpc, Dithering should be
> > > +enabled
> > > + * Else disabled
> > > + */
> > > +status = get_dither_state(data);
> > > +
> > > +igt_info("FB BPC:%d, Panel BPC:%d, Pipe BPC:%d, Expected Dither:%s,
> > > Actual result:%s\n",
> > > + fb_bpc, output_bpc, status.bpc,
> > > + (fb_bpc > output_bpc) ? "Enable": "Disable", status.dither ?
> > > + "Enable": "Disable");
> > > +
> > > + /*
> > > +* We must update the Connector max_bpc property back
> > > +* Otherwise, previously updated value will stay forever and
> > > +* may cause the failures for next/other subtests.
> > > +*/
> > > +if (bpc)
> > > +igt_output_set_prop_value(data->output,
> > > IGT_CONNECTOR_MAX_BPC, bpc);
> > > +igt_plane_set_fb(data->primary, NULL); igt_output_set_pipe(output,
> > > +PIPE_NONE); igt_display_commit2(display, display->is_atomic ?
> > > +COMMIT_ATOMIC :
> > > COMMIT_LEGACY);
> > > +igt_remove_fb(data->drm_fd, &data->fb);
> > > +
> > > +/* Check if crtc bpc is updated with requested one. */
> > > +igt_require_f((status.bpc == output_bpc), "%s can support max
> > > +%u-bpc, but requested %d-bpc\n",
> > > +output->name, status.bpc, output_bpc);
> > > +
> > > +/* Compute the result. */
> > > +if (fb_bpc > output_bpc)
> > > +igt_assert_f(status.dither, "(fb_%dbpc > output_%dbpc): Dither
> > > should be enabled\n",
> > > +fb_bpc, output_bpc);
> > > +else
> > > +igt_assert_f(!status.dither, "(fb_%dbpc <= output_%dbpc): Dither
> > > should be disabled\n",
> > > +fb_bpc, output_bpc);
> > > +
> > > +return;
> > > +}
> > > +
> > > +static void
> > > +run_dither_test(data_t *data, int fb_bpc, int fb_format, int
> > > +output_bpc) {
> > > +igt_output_t *output;
> > > +igt_display_t *display = &data->display;
> > > +
> > > +for_each_connected_output(display, output) { enum pipe pipe;
> > > +drmModeConnector *connector = output->config.connector;
> > > +
> > > +/* HDMI won't support 6 BPC */
> > > +if (output_bpc == IGT_CONNECTOR_BPC_6 &&
> > > + (connector->connector_type ==
> > > DRM_MODE_CONNECTOR_HDMIA ||
> > > + connector->connector_type ==
> > > DRM_MODE_CONNECTOR_HDMIB))
> >
> > I think we already have a check in test_dithering, so we can drop this
> > specific encoder check here.
>
> I guess atomic commit will fail & throws an error: -22 invalid argument if we request
> to set max_bpc as 6 for HDMI connectors, because HDMI won't support 6-bpc.
There can be other encoders/sink as well who don't support 6bpc. We can have a test commit
to determine the caps.
> >
> > > +continue;
> > > +
> > > +for_each_pipe(display, pipe) {
> > > +if (igt_pipe_connector_valid(pipe, output)) {
> > > +igt_dynamic_f("%s-pipe-%s", output->name,
> > > kmstest_pipe_name(pipe))
> > > +test_dithering(data, pipe, output, fb_bpc, fb_format, output_bpc);
> > > +
> > > +/* One pipe is enough */
> > > +break;
> > > +}
> > > +}
> > > +}
> > > +}
> > > +
> > > +igt_main
> > > +{
> > > +struct {
> > > +int fb_bpc;
> > > +int format;
> > > +int output_bpc;
> > > +} tests[] = {
> > > +{ IGT_FRAME_BUFFER_BPC_8, DRM_FORMAT_XRGB8888,
> > > IGT_CONNECTOR_BPC_6 },
> > > +{ IGT_FRAME_BUFFER_BPC_8, DRM_FORMAT_XRGB8888,
> > > IGT_CONNECTOR_BPC_8 },
> > > +};
> > > +int i;
> > > +data_t data = { 0 };
> > > +
> > > +igt_fixture {
> > > +data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> > > +kmstest_set_vt_graphics_mode();
> > > +
> > > +igt_display_require(&data.display, data.drm_fd);
> > > +igt_display_require_output(&data.display);
> > > +}
> > > +
> > > +for (i = 0; i < ARRAY_SIZE(tests); i++) {
> > > +igt_describe_f("Framebuffer BPC:%d, Panel BPC:%d, Expected
> > > Dither:%s\n",
> > > + tests[i].fb_bpc, tests[i].output_bpc,
> > > + (tests[i].fb_bpc > tests[i].output_bpc) ?
> > > +"Enable": "Disable");
> > > +
> > > +igt_subtest_with_dynamic_f("FB-%dBPC-Vs-Panel-%dBPC",
> > > +tests[i].fb_bpc, tests[i].output_bpc) run_dither_test(&data,
> > > +tests[i].fb_bpc, tests[i].format, tests[i].output_bpc); }
> > > +
> > > +igt_fixture {
> > > +igt_display_fini(&data.display);
> > > +}
> > > +}
> > > diff --git a/tests/meson.build b/tests/meson.build index
> > 01911c457..d3de40be0
> > > 100644
> > > --- a/tests/meson.build
> > > +++ b/tests/meson.build
> > > @@ -29,6 +29,7 @@ test_progs = [
> > > 'kms_cursor_crc',
> > > 'kms_cursor_edge_walk',
> > > 'kms_cursor_legacy',
> > > +'kms_dither',
> > > 'kms_dp_aux_dev',
> > > 'kms_dp_dsc',
> > > 'kms_dp_tiled_display',
> > > --
> > > 2.20.1
> >
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] [i-g-t v2 1/2] tests/kms_dither: New IGT to validate crtc Dithering
@ 2021-07-09 11:41 Bhanuprakash Modem
2021-07-09 4:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/2] " Patchwork
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Bhanuprakash Modem @ 2021-07-09 11:41 UTC (permalink / raw)
To: igt-dev; +Cc: Nischal Varide
Many of the display devices have color format support less than
the color format of the input data (Ex: 8-bit input data and 6-bit
display color depth). Then the input data will be either truncated
or rounded, but this approach usually causes loss of detail and also
produce large banded areas of a single color that significantly
differs from the original image.
Dithering is a technique used to enhance these colors by creating the
illusion of smoothness by adjusting the nearby pixel color.
For Eg: Converting 8-bit to 6-bit by modifying the pixel information.
Dithering should be enabled when a panel color depth is lower than the
color depth of the framebuffer.
Even though feature Dithering is there since legacy, there is no
specific IGT for this. This patch will create New IGT for Dithering.
And below is the truth table for CRTC Dithering.
|----------------|---------|-------------|
| Frame buffer | Panel | Dithering |
|----------------|---------|-------------|
| 8 BPC | 6 BPC | Yes |
|----------------|---------|-------------|
| 8 BPC | 8 BPC | No |
|----------------|---------|-------------|
| 8 BPC | 10 BPC | No |
|----------------|---------|-------------|
| 10 BPC | 6 BPC | Yes |
|----------------|---------|-------------|
| 10 BPC | 8 BPC | Yes |
|----------------|---------|-------------|
| 10 BPC | 10 BPC | No |
|----------------|---------|-------------|
| 16 BPC | 6 BPC | Yes |
|----------------|---------|-------------|
| 16 BPC | 8 BPC | Yes |
|----------------|---------|-------------|
| 16 BPC | 10 BPC | Yes |
|----------------|---------|-------------|
Note: As i915 enables dithering for 6 bpc panels only, we need to limit
the execution to 6 & 8 bpc panels (Negative testing) only.
Cc: Swati Sharma <swati2.sharma@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Nischal Varide <nischal.varide@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_dither.c | 242 +++++++++++++++++++++++++++++++++++++++++++++
tests/meson.build | 1 +
2 files changed, 243 insertions(+)
create mode 100644 tests/kms_dither.c
diff --git a/tests/kms_dither.c b/tests/kms_dither.c
new file mode 100644
index 000000000..50c649ca8
--- /dev/null
+++ b/tests/kms_dither.c
@@ -0,0 +1,242 @@
+/*
+ * Copyright © 2020 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ *
+ * Authors:
+ * Bhanuprakash Modem <bhanuprakash.modem@intel.com>
+ *
+ */
+
+#include "igt.h"
+#include <fcntl.h>
+#include <termios.h>
+#include <unistd.h>
+
+IGT_TEST_DESCRIPTION("Test Dithering block status");
+
+/* Connector BPC */
+#define IGT_CONNECTOR_BPC_6 6
+#define IGT_CONNECTOR_BPC_8 8
+
+/* Framebuffer BPC */
+#define IGT_FRAME_BUFFER_BPC_8 8
+
+/* Common test data. */
+typedef struct data {
+ igt_display_t display;
+ igt_plane_t *primary;
+ igt_output_t *output;
+ igt_pipe_t *pipe;
+ drmModeModeInfo *mode;
+ enum pipe pipe_id;
+ int drm_fd;
+ igt_fb_t fb;
+} data_t;
+
+typedef struct {
+ unsigned int bpc;
+ unsigned int dither;
+} dither_status_t;
+
+/* Prepare test data. */
+static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
+{
+ igt_display_t *display = &data->display;
+
+ data->pipe_id = pipe;
+ data->pipe = &data->display.pipes[data->pipe_id];
+ igt_assert(data->pipe);
+
+ igt_display_reset(display);
+
+ data->output = output;
+ igt_assert(data->output);
+
+ data->mode = igt_output_get_mode(data->output);
+ igt_assert(data->mode);
+
+ data->primary =
+ igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_PRIMARY);
+
+ igt_output_set_pipe(data->output, data->pipe_id);
+}
+
+/* Returns the current state of dithering from the crtc debugfs. */
+static dither_status_t get_dither_state(data_t *data)
+{
+ char buf[512], tmp[5];
+ char *start_loc;
+ int dir, res;
+ dither_status_t status;
+
+ dir = igt_debugfs_dir(data->drm_fd);
+ igt_assert(dir >= 0);
+
+ res = igt_debugfs_simple_read(dir, "i915_display_info", buf, sizeof(buf));
+ igt_require(res > 0);
+ close(dir);
+
+ igt_assert(start_loc = strstr(buf, ", bpp="));
+ igt_assert_eq(sscanf(start_loc, ", bpp=%u", &status.bpc), 1);
+ status.bpc /= 3;
+
+ igt_assert(start_loc = strstr(buf, ", dither="));
+ igt_assert_eq(sscanf(start_loc, ", dither=%s", tmp), 1);
+ status.dither = !strcmp(tmp, "yes,");
+
+ return status;
+}
+
+static void test_dithering(data_t *data, enum pipe pipe,
+ igt_output_t *output,
+ int fb_bpc, int fb_format,
+ int output_bpc)
+{
+ igt_display_t *display = &data->display;
+ dither_status_t status;
+ int bpc = 0;
+
+ igt_info("Dithering test execution on %s PIPE_%s\n",
+ output->name, kmstest_pipe_name(pipe));
+ prepare_test(data, output, pipe);
+
+ igt_assert(igt_create_fb(data->drm_fd, data->mode->hdisplay,
+ data->mode->vdisplay, fb_format,
+ LOCAL_DRM_FORMAT_MOD_NONE, &data->fb));
+ igt_plane_set_fb(data->primary, &data->fb);
+ igt_plane_set_size(data->primary, data->mode->hdisplay, data->mode->vdisplay);
+
+ if (igt_output_has_prop(output, IGT_CONNECTOR_MAX_BPC)) {
+ bpc = igt_output_get_prop(output, IGT_CONNECTOR_MAX_BPC);
+ igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, output_bpc);
+ }
+ igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
+
+ /*
+ * Check the status of Dithering block:
+ *
+ * Preserve the result & compute later (after clean-up).
+ * If fb_bpc is greater than output_bpc, Dithering should be enabled
+ * Else disabled
+ */
+ status = get_dither_state(data);
+
+ igt_info("FB BPC:%d, Panel BPC:%d, Pipe BPC:%d, Expected Dither:%s, Actual result:%s\n",
+ fb_bpc, output_bpc, status.bpc,
+ (fb_bpc > output_bpc) ? "Enable": "Disable",
+ status.dither ? "Enable": "Disable");
+
+ /*
+ * We must update the Connector max_bpc property back
+ * Otherwise, previously updated value will stay forever and
+ * may cause the failures for next/other subtests.
+ */
+ if (bpc)
+ igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, bpc);
+ igt_plane_set_fb(data->primary, NULL);
+ igt_output_set_pipe(output, PIPE_NONE);
+ igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
+ igt_remove_fb(data->drm_fd, &data->fb);
+
+ /* Check if crtc bpc is updated with requested one. */
+ igt_require_f((status.bpc == output_bpc),
+ "%s can support max %u-bpc, but requested %d-bpc\n",
+ output->name, status.bpc, output_bpc);
+
+ /* Compute the result. */
+ if (fb_bpc > output_bpc)
+ igt_assert_f(status.dither, "(fb_%dbpc > output_%dbpc): Dither should be enabled\n",
+ fb_bpc, output_bpc);
+ else
+ igt_assert_f(!status.dither, "(fb_%dbpc <= output_%dbpc): Dither should be disabled\n",
+ fb_bpc, output_bpc);
+
+ return;
+}
+
+static void
+run_dither_test(data_t *data, int fb_bpc, int fb_format, int output_bpc)
+{
+ igt_output_t *output;
+ igt_display_t *display = &data->display;
+
+ for_each_connected_output(display, output) {
+ enum pipe pipe;
+ drmModeConnector *connector = output->config.connector;
+
+ /* HDMI won't support 6 BPC */
+ if (output_bpc == IGT_CONNECTOR_BPC_6 &&
+ (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
+ connector->connector_type == DRM_MODE_CONNECTOR_HDMIB))
+ continue;
+
+ for_each_pipe(display, pipe) {
+ if (igt_pipe_connector_valid(pipe, output)) {
+ igt_dynamic_f("%s-pipe-%s", output->name, kmstest_pipe_name(pipe))
+ test_dithering(data, pipe, output, fb_bpc,
+ fb_format, output_bpc);
+
+ /* One pipe is enough */
+ break;
+ }
+ }
+ }
+}
+
+igt_main
+{
+ struct {
+ int fb_bpc;
+ int format;
+ int output_bpc;
+ } tests[] = {
+ { IGT_FRAME_BUFFER_BPC_8, DRM_FORMAT_XRGB8888, IGT_CONNECTOR_BPC_6 },
+ { IGT_FRAME_BUFFER_BPC_8, DRM_FORMAT_XRGB8888, IGT_CONNECTOR_BPC_8 },
+ };
+ int i;
+ data_t data = { 0 };
+
+ igt_fixture {
+ data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+ kmstest_set_vt_graphics_mode();
+
+ igt_display_require(&data.display, data.drm_fd);
+ igt_display_require_output(&data.display);
+ }
+
+ for (i = 0; i < ARRAY_SIZE(tests); i++) {
+ igt_describe_f("Framebuffer BPC:%d, Panel BPC:%d, Expected Dither:%s\n",
+ tests[i].fb_bpc, tests[i].output_bpc,
+ (tests[i].fb_bpc > tests[i].output_bpc) ?
+ "Enable": "Disable");
+
+ igt_subtest_with_dynamic_f("FB-%dBPC-Vs-Panel-%dBPC",
+ tests[i].fb_bpc, tests[i].output_bpc)
+ run_dither_test(&data,
+ tests[i].fb_bpc,
+ tests[i].format,
+ tests[i].output_bpc);
+ }
+
+ igt_fixture {
+ igt_display_fini(&data.display);
+ }
+}
diff --git a/tests/meson.build b/tests/meson.build
index 01911c457..d3de40be0 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -29,6 +29,7 @@ test_progs = [
'kms_cursor_crc',
'kms_cursor_edge_walk',
'kms_cursor_legacy',
+ 'kms_dither',
'kms_dp_aux_dev',
'kms_dp_dsc',
'kms_dp_tiled_display',
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [igt-dev] [i-g-t v2 2/2] HAX: Add dither tests to fast-feedback
2021-07-09 11:41 [igt-dev] [i-g-t v2 1/2] tests/kms_dither: New IGT to validate crtc Dithering Bhanuprakash Modem
2021-07-09 4:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/2] " Patchwork
2021-07-09 6:03 ` [igt-dev] [i-g-t v2 1/2] " Shankar, Uma
@ 2021-07-09 11:41 ` Bhanuprakash Modem
2021-07-09 18:08 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,v2,1/2] tests/kms_dither: New IGT to validate crtc Dithering Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Bhanuprakash Modem @ 2021-07-09 11:41 UTC (permalink / raw)
To: igt-dev
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/intel-ci/fast-feedback.testlist | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index fa5006d2e..493ba6862 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -107,6 +107,8 @@ igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size
igt@kms_cursor_legacy@basic-flip-before-cursor-atomic
igt@kms_cursor_legacy@basic-flip-before-cursor-legacy
igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size
+igt@kms_dither@FB-8BPC-Vs-Panel-6BPC
+igt@kms_dither@FB-8BPC-Vs-Panel-8BPC
igt@kms_flip@basic-flip-vs-dpms
igt@kms_flip@basic-flip-vs-modeset
igt@kms_flip@basic-flip-vs-wf_vblank
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,v2,1/2] tests/kms_dither: New IGT to validate crtc Dithering
2021-07-09 11:41 [igt-dev] [i-g-t v2 1/2] tests/kms_dither: New IGT to validate crtc Dithering Bhanuprakash Modem
` (2 preceding siblings ...)
2021-07-09 11:41 ` [igt-dev] [i-g-t v2 2/2] HAX: Add dither tests to fast-feedback Bhanuprakash Modem
@ 2021-07-09 18:08 ` Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2021-07-09 18:08 UTC (permalink / raw)
To: Modem, Bhanuprakash; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 30306 bytes --]
== Series Details ==
Series: series starting with [i-g-t,v2,1/2] tests/kms_dither: New IGT to validate crtc Dithering
URL : https://patchwork.freedesktop.org/series/92349/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10320_full -> IGTPW_6002_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_6002_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_6002_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_6002_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_persistence@engines-hostile@vecs0:
- shard-tglb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-tglb3/igt@gem_ctx_persistence@engines-hostile@vecs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb1/igt@gem_ctx_persistence@engines-hostile@vecs0.html
* {igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a} (NEW):
- shard-tglb: NOTRUN -> [SKIP][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb6/igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a.html
New tests
---------
New tests have been introduced between CI_DRM_10320_full and IGTPW_6002_full:
### New IGT tests (22) ###
* igt@api_intel_bb@blit-noreloc-keep-cache:
- Statuses : 5 pass(s)
- Exec time: [0.01] s
* igt@api_intel_bb@blit-noreloc-purge-cache:
- Statuses : 4 pass(s)
- Exec time: [0.01] s
* igt@api_intel_bb@blit-reloc-keep-cache:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.02] s
* igt@api_intel_bb@blit-reloc-purge-cache:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.02] s
* igt@api_intel_bb@full-batch:
- Statuses : 3 pass(s)
- Exec time: [0.00, 0.01] s
* igt@api_intel_bb@intel-bb-blit-none:
- Statuses : 6 pass(s)
- Exec time: [2.88, 4.76] s
* igt@api_intel_bb@intel-bb-blit-x:
- Statuses : 5 pass(s)
- Exec time: [2.88, 4.18] s
* igt@api_intel_bb@intel-bb-blit-y:
- Statuses : 4 pass(s)
- Exec time: [2.85, 4.34] s
* igt@api_intel_bb@offset-control:
- Statuses :
- Exec time: [None] s
* igt@api_intel_bb@simple-bb:
- Statuses : 4 pass(s)
- Exec time: [0.00] s
* igt@api_intel_bb@simple-bb-ctx:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
* igt@gem_pread@bench:
- Statuses :
- Exec time: [None] s
* igt@i915_selftest@live@gem_migrate:
- Statuses : 5 pass(s)
- Exec time: [0.55, 1.54] s
* igt@kms_dither@fb-8bpc-vs-panel-6bpc:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@dp-1-pipe-a:
- Statuses : 2 pass(s)
- Exec time: [0.18, 0.23] s
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@edp-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [1.44] s
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@vga-1-pipe-a:
- Statuses : 1 skip(s)
- Exec time: [0.05] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc:
- Statuses :
- Exec time: [None] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@dp-1-pipe-a:
- Statuses : 2 pass(s)
- Exec time: [0.21, 0.25] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a:
- Statuses : 1 pass(s) 1 skip(s)
- Exec time: [1.43, 1.46] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@hdmi-a-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [0.52] s
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@hdmi-a-2-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [0.32] s
Known issues
------------
Here are the changes found in IGTPW_6002_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- shard-kbl: [PASS][4] -> [DMESG-WARN][5] ([i915#2283])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-kbl1/igt@core_hotunplug@unbind-rebind.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl3/igt@core_hotunplug@unbind-rebind.html
- shard-iclb: [PASS][6] -> [DMESG-WARN][7] ([i915#1602] / [i915#2283])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb3/igt@core_hotunplug@unbind-rebind.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb8/igt@core_hotunplug@unbind-rebind.html
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-apl: NOTRUN -> [DMESG-WARN][8] ([i915#180])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl8/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_ctx_persistence@engines-hostile@vcs0:
- shard-iclb: [PASS][9] -> [FAIL][10] ([i915#2410])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb6/igt@gem_ctx_persistence@engines-hostile@vcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb1/igt@gem_ctx_persistence@engines-hostile@vcs0.html
* igt@gem_ctx_persistence@smoketest:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#1099]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-snb7/igt@gem_ctx_persistence@smoketest.html
* igt@gem_ctx_shared@q-in-order:
- shard-snb: NOTRUN -> [SKIP][12] ([fdo#109271]) +328 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-snb6/igt@gem_ctx_shared@q-in-order.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][13] -> [FAIL][14] ([i915#2846])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-kbl3/igt@gem_exec_fair@basic-deadline.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl2/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-iclb: [PASS][15] -> [FAIL][16] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb6/igt@gem_exec_fair@basic-pace@vcs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb8/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][17] -> [SKIP][18] ([fdo#109271])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-kbl4/igt@gem_exec_fair@basic-pace@vecs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl3/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][19] -> [FAIL][20] ([i915#2849])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_params@secure-non-master:
- shard-tglb: NOTRUN -> [SKIP][21] ([fdo#112283])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb7/igt@gem_exec_params@secure-non-master.html
* igt@gem_exec_reloc@basic-wide-active@bcs0:
- shard-apl: NOTRUN -> [FAIL][22] ([i915#3633]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl1/igt@gem_exec_reloc@basic-wide-active@bcs0.html
* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-snb: NOTRUN -> [FAIL][23] ([i915#3633]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-snb7/igt@gem_exec_reloc@basic-wide-active@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#2190])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl6/igt@gem_huc_copy@huc-copy.html
- shard-glk: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#2190])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-glk1/igt@gem_huc_copy@huc-copy.html
- shard-iclb: NOTRUN -> [SKIP][26] ([i915#2190])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb5/igt@gem_huc_copy@huc-copy.html
- shard-kbl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#2190])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl6/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_gtt@cpuset-big-copy:
- shard-iclb: [PASS][28] -> [FAIL][29] ([i915#307])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb4/igt@gem_mmap_gtt@cpuset-big-copy.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb5/igt@gem_mmap_gtt@cpuset-big-copy.html
* igt@gem_pread@exhaustion:
- shard-snb: NOTRUN -> [WARN][30] ([i915#2658])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-snb7/igt@gem_pread@exhaustion.html
* igt@gem_render_copy@yf-tiled-to-vebox-x-tiled:
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#768])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb2/igt@gem_render_copy@yf-tiled-to-vebox-x-tiled.html
* igt@gem_softpin@evict-snoop:
- shard-iclb: NOTRUN -> [SKIP][32] ([fdo#109312])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb6/igt@gem_softpin@evict-snoop.html
- shard-tglb: NOTRUN -> [SKIP][33] ([fdo#109312])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb2/igt@gem_softpin@evict-snoop.html
* igt@gem_userptr_blits@input-checking:
- shard-snb: NOTRUN -> [DMESG-WARN][34] ([i915#3002])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-snb7/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@vma-merge:
- shard-kbl: NOTRUN -> [FAIL][35] ([i915#3318])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl2/igt@gem_userptr_blits@vma-merge.html
* igt@gen3_render_tiledy_blits:
- shard-tglb: NOTRUN -> [SKIP][36] ([fdo#109289])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb5/igt@gen3_render_tiledy_blits.html
* igt@gen9_exec_parse@unaligned-jump:
- shard-iclb: NOTRUN -> [SKIP][37] ([fdo#112306]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb5/igt@gen9_exec_parse@unaligned-jump.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][38] -> [DMESG-WARN][39] ([i915#180])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-apl3/igt@i915_suspend@fence-restore-tiled2untiled.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-iclb: [PASS][40] -> [DMESG-WARN][41] ([i915#3621])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb7/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb1/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-addfb:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#111615])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb1/igt@kms_big_fb@yf-tiled-addfb.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-apl: NOTRUN -> [SKIP][43] ([fdo#109271]) +316 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl2/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#3689]) +7 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb3/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_ccs.html
* igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109278]) +9 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb7/igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@hdmi-crc-nonplanar-formats:
- shard-glk: NOTRUN -> [SKIP][46] ([fdo#109271] / [fdo#111827]) +3 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-glk3/igt@kms_chamelium@hdmi-crc-nonplanar-formats.html
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +23 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl1/igt@kms_chamelium@hdmi-edid-change-during-suspend.html
* igt@kms_chamelium@vga-hpd:
- shard-tglb: NOTRUN -> [SKIP][48] ([fdo#109284] / [fdo#111827]) +4 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb3/igt@kms_chamelium@vga-hpd.html
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-snb: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +10 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-snb5/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
- shard-kbl: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +8 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl3/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109284] / [fdo#111827]) +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb2/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html
* igt@kms_content_protection@legacy:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109300] / [fdo#111066])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb2/igt@kms_content_protection@legacy.html
- shard-tglb: NOTRUN -> [SKIP][53] ([fdo#111828])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb3/igt@kms_content_protection@legacy.html
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][54] ([i915#2105])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl7/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-a-cursor-32x10-random:
- shard-tglb: NOTRUN -> [SKIP][55] ([i915#3359]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb3/igt@kms_cursor_crc@pipe-a-cursor-32x10-random.html
* igt@kms_cursor_crc@pipe-b-cursor-512x512-offscreen:
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109278] / [fdo#109279])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb6/igt@kms_cursor_crc@pipe-b-cursor-512x512-offscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen:
- shard-glk: [PASS][57] -> [DMESG-WARN][58] ([i915#118] / [i915#95]) +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-glk5/igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-glk7/igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#533]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl8/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_flip@2x-plain-flip-ts-check:
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#111825]) +16 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb1/igt@kms_flip@2x-plain-flip-ts-check.html
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109274]) +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb1/igt@kms_flip@2x-plain-flip-ts-check.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][62] -> [DMESG-WARN][63] ([i915#180]) +8 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu:
- shard-glk: NOTRUN -> [SKIP][64] ([fdo#109271]) +33 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-glk8/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109280]) +12 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb7/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-render.html
* igt@kms_hdr@static-toggle-dpms:
- shard-tglb: NOTRUN -> [SKIP][66] ([i915#1187])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb1/igt@kms_hdr@static-toggle-dpms.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][67] ([i915#265]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][68] ([fdo#108145] / [i915#265]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][69] ([fdo#108145] / [i915#265])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl3/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_lowres@pipe-d-tiling-x:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#3536])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb7/igt@kms_plane_lowres@pipe-d-tiling-x.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-kbl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#2733])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl6/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#658]) +6 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl2/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-iclb: NOTRUN -> [SKIP][73] ([i915#658])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
- shard-kbl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#658])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
- shard-glk: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#658])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-glk5/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#2920])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][77] -> [SKIP][78] ([fdo#109642] / [fdo#111068] / [i915#658])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb4/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [PASS][79] -> [SKIP][80] ([fdo#109441])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb5/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109441]) +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
- shard-tglb: NOTRUN -> [FAIL][82] ([i915#132] / [i915#3467]) +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb5/igt@kms_psr@psr2_cursor_render.html
* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#2437]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl3/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#2437])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb5/igt@kms_writeback@writeback-invalid-parameters.html
- shard-glk: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#2437])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-glk4/igt@kms_writeback@writeback-invalid-parameters.html
- shard-iclb: NOTRUN -> [SKIP][86] ([i915#2437])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb4/igt@kms_writeback@writeback-invalid-parameters.html
* igt@nouveau_crc@pipe-c-source-outp-inactive:
- shard-tglb: NOTRUN -> [SKIP][87] ([i915#2530])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb2/igt@nouveau_crc@pipe-c-source-outp-inactive.html
- shard-iclb: NOTRUN -> [SKIP][88] ([i915#2530])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb5/igt@nouveau_crc@pipe-c-source-outp-inactive.html
* igt@perf@polling-parameterized:
- shard-glk: [PASS][89] -> [FAIL][90] ([i915#1542])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-glk7/igt@perf@polling-parameterized.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-glk5/igt@perf@polling-parameterized.html
* igt@prime_nv_pcopy@test2:
- shard-kbl: NOTRUN -> [SKIP][91] ([fdo#109271]) +70 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl3/igt@prime_nv_pcopy@test2.html
- shard-iclb: NOTRUN -> [SKIP][92] ([fdo#109291]) +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb8/igt@prime_nv_pcopy@test2.html
* igt@prime_nv_test@i915_blt_fill_nv_read:
- shard-tglb: NOTRUN -> [SKIP][93] ([fdo#109291]) +2 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb1/igt@prime_nv_test@i915_blt_fill_nv_read.html
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#2994]) +3 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl7/igt@sysfs_clients@fair-1.html
* igt@sysfs_clients@pidname:
- shard-glk: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#2994])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-glk8/igt@sysfs_clients@pidname.html
* igt@sysfs_clients@split-50:
- shard-kbl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#2994]) +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl3/igt@sysfs_clients@split-50.html
- shard-iclb: NOTRUN -> [SKIP][97] ([i915#2994]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb8/igt@sysfs_clients@split-50.html
- shard-tglb: NOTRUN -> [SKIP][98] ([i915#2994]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb5/igt@sysfs_clients@split-50.html
* igt@sysfs_heartbeat_interval@precise@vecs0:
- shard-apl: [PASS][99] -> [FAIL][100] ([i915#1755])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-apl2/igt@sysfs_heartbeat_interval@precise@vecs0.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl3/igt@sysfs_heartbeat_interval@precise@vecs0.html
* igt@vgem_basic@unload:
- shard-snb: NOTRUN -> [INCOMPLETE][101] ([i915#3744])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-snb7/igt@vgem_basic@unload.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][102] ([i915#2842]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl3/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-tglb: [FAIL][104] ([i915#2842]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-tglb6/igt@gem_exec_fair@basic-pace@vcs0.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-tglb5/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_whisper@basic-queues-all:
- shard-glk: [DMESG-WARN][106] ([i915#118] / [i915#95]) -> [PASS][107] +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-glk3/igt@gem_exec_whisper@basic-queues-all.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-glk9/igt@gem_exec_whisper@basic-queues-all.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [INCOMPLETE][108] ([i915#1982] / [i915#3698]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
* igt@i915_suspend@sysfs-reader:
- shard-kbl: [INCOMPLETE][110] ([i915#155]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-kbl2/igt@i915_suspend@sysfs-reader.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl1/igt@i915_suspend@sysfs-reader.html
* igt@kms_big_fb@linear-64bpp-rotate-0:
- shard-iclb: [FAIL][112] -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb4/igt@kms_big_fb@linear-64bpp-rotate-0.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb6/igt@kms_big_fb@linear-64bpp-rotate-0.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-apl: [DMESG-WARN][114] ([i915#180]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [SKIP][116] ([fdo#109441]) -> [PASS][117] +1 similar issue
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb7/igt@kms_psr@psr2_cursor_plane_move.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][118] ([i915#180] / [i915#295]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@perf@polling-parameterized:
- shard-iclb: [FAIL][120] ([i915#1542]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb8/igt@perf@polling-parameterized.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb7/igt@perf@polling-parameterized.html
#### Warnings ####
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][122] ([fdo#109271]) -> [FAIL][123] ([i915#3343])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-apl2/igt@i915_pm_dc@dc9-dpms.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-apl7/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][124] ([i915#1804] / [i915#2684]) -> [WARN][125] ([i915#2684])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][126] ([i915#2684]) -> [WARN][127] ([i915#1804] / [i915#2684])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb4/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-iclb: [SKIP][128] ([i915#2920]) -> [SKIP][129] ([i915#658]) +1 similar issue
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-iclb: [SKIP][130] ([i915#658]) -> [SKIP][131] ([i915#2920]) +3 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10320/shard-iclb8/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136]) ([i915#1814] / [i915#2505] /
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6002/index.html
[-- Attachment #1.2: Type: text/html, Size: 34207 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-07-09 18:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 11:41 [igt-dev] [i-g-t v2 1/2] tests/kms_dither: New IGT to validate crtc Dithering Bhanuprakash Modem
2021-07-09 4:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/2] " Patchwork
2021-07-09 6:03 ` [igt-dev] [i-g-t v2 1/2] " Shankar, Uma
2021-07-09 6:14 ` Modem, Bhanuprakash
2021-07-09 7:08 ` Shankar, Uma
2021-07-09 11:41 ` [igt-dev] [i-g-t v2 2/2] HAX: Add dither tests to fast-feedback Bhanuprakash Modem
2021-07-09 18:08 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,v2,1/2] tests/kms_dither: New IGT to validate crtc Dithering Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.