[Buildroot] [PATCH v2 0/2] External GCC12 toolchain support

[Buildroot] [PATCH v2 0/2] External GCC12 toolchain support

[Florian Fainelli]

This patch series allows us to use Linaro's GCC12 snapshot that can be
downloaded from here:

https://snapshots.linaro.org/gnu-toolchain/12.0-2021.10-1/aarch64-linux-gnu/

Changes in v2:

- rebased against master

Florian Fainelli (2):
  toolchain/Config.in: add BR2_TOOLCHAIN_GCC_AT_LEAST_12 blind option
  toolchain/toolchain-external/toolchain-external-custom: add gcc 12
    version selection

 toolchain/Config.in                                   | 11 +++++++++--
 .../toolchain-external-custom/Config.in.options       |  4 ++++
 2 files changed, 13 insertions(+), 2 deletions(-)

-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 1/2] toolchain/Config.in: add BR2_TOOLCHAIN_GCC_AT_LEAST_12 blind option

[Florian Fainelli]

In order to add gcc 12 support for internal and external toolchain
in follow-up commits, introduce BR2_TOOLCHAIN_GCC_AT_LEAST_12 symbol.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 toolchain/Config.in | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index d2c81217c84a..b572a89f2f85 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -117,7 +117,8 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_43744
 	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || \
 		BR2_TOOLCHAIN_GCC_AT_LEAST_9 || \
 		BR2_TOOLCHAIN_GCC_AT_LEAST_10 || \
-		BR2_TOOLCHAIN_GCC_AT_LEAST_11
+		BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \
+		BR2_TOOLCHAIN_GCC_AT_LEAST_12
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63261. This bug no
 # longer exists in gcc 8.x.
@@ -150,7 +151,8 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_68485
 config BR2_TOOLCHAIN_HAS_GCC_BUG_83143
 	bool
 	default y if BR2_sh
-	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_10 || BR2_TOOLCHAIN_GCC_AT_LEAST_11
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_10 || BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \
+		   BR2_TOOLCHAIN_GCC_AT_LEAST_12
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180. This bug no
 # longer exists in gcc 8.x.
@@ -698,10 +700,15 @@ config BR2_TOOLCHAIN_GCC_AT_LEAST_11
 	bool
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_10
 
+config BR2_TOOLCHAIN_GCC_AT_LEAST_12
+	bool
+	select BR2_TOOLCHAIN_GCC_AT_LEAST_11
+
 # This order guarantees that the highest version is set, as kconfig
 # stops affecting a value on the first matching default.
 config BR2_TOOLCHAIN_GCC_AT_LEAST
 	string
+	default "12"	if BR2_TOOLCHAIN_GCC_AT_LEAST_12
 	default "11"	if BR2_TOOLCHAIN_GCC_AT_LEAST_11
 	default "10"	if BR2_TOOLCHAIN_GCC_AT_LEAST_10
 	default "9"	if BR2_TOOLCHAIN_GCC_AT_LEAST_9
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 2/2] toolchain/toolchain-external/toolchain-external-custom: add gcc 12 version selection

[Florian Fainelli]

This patch allows to use an external toolchain based on gcc 12.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 .../toolchain-external-custom/Config.in.options               | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
index 9346fa3feb75..683204e56ebd 100644
--- a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
+++ b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
@@ -31,6 +31,10 @@ choice
 	  Set to the gcc version that is used by your external
 	  toolchain.
 
+config BR2_TOOLCHAIN_EXTERNAL_GCC_12
+	bool "12.x"
+	select BR2_TOOLCHAIN_GCC_AT_LEAST_12
+
 config BR2_TOOLCHAIN_EXTERNAL_GCC_11
 	bool "11.x"
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_11
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/2] toolchain/Config.in: add BR2_TOOLCHAIN_GCC_AT_LEAST_12 blind option

[Thomas Petazzoni via buildroot]

Hello Florian,

Thanks for the patch! I hope you're doing well :-)

On Tue, 26 Apr 2022 10:32:10 -0700
Florian Fainelli <f.fainelli@gmail.com> wrote:

> In order to add gcc 12 support for internal and external toolchain
> in follow-up commits, introduce BR2_TOOLCHAIN_GCC_AT_LEAST_12 symbol.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  toolchain/Config.in | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index d2c81217c84a..b572a89f2f85 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -117,7 +117,8 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_43744
>  	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || \
>  		BR2_TOOLCHAIN_GCC_AT_LEAST_9 || \
>  		BR2_TOOLCHAIN_GCC_AT_LEAST_10 || \
> -		BR2_TOOLCHAIN_GCC_AT_LEAST_11
> +		BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \
> +		BR2_TOOLCHAIN_GCC_AT_LEAST_12
>  
>  # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63261. This bug no
>  # longer exists in gcc 8.x.
> @@ -150,7 +151,8 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_68485
>  config BR2_TOOLCHAIN_HAS_GCC_BUG_83143
>  	bool
>  	default y if BR2_sh
> -	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_10 || BR2_TOOLCHAIN_GCC_AT_LEAST_11
> +	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_10 || BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \
> +		   BR2_TOOLCHAIN_GCC_AT_LEAST_12

Did you verify that these two bugs still affected gcc 12.x ?

Thanks,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/2] toolchain/Config.in: add BR2_TOOLCHAIN_GCC_AT_LEAST_12 blind option

[Florian Fainelli]

Hi Thomas,

On 4/26/22 11:42, Thomas Petazzoni wrote:
> Hello Florian,
> 
> Thanks for the patch! I hope you're doing well :-)

Doing alright thanks for asking.

> 
> On Tue, 26 Apr 2022 10:32:10 -0700
> Florian Fainelli <f.fainelli@gmail.com> wrote:
> 
>> In order to add gcc 12 support for internal and external toolchain
>> in follow-up commits, introduce BR2_TOOLCHAIN_GCC_AT_LEAST_12 symbol.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>>   toolchain/Config.in | 11 +++++++++--
>>   1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/toolchain/Config.in b/toolchain/Config.in
>> index d2c81217c84a..b572a89f2f85 100644
>> --- a/toolchain/Config.in
>> +++ b/toolchain/Config.in
>> @@ -117,7 +117,8 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_43744
>>   	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || \
>>   		BR2_TOOLCHAIN_GCC_AT_LEAST_9 || \
>>   		BR2_TOOLCHAIN_GCC_AT_LEAST_10 || \
>> -		BR2_TOOLCHAIN_GCC_AT_LEAST_11
>> +		BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \
>> +		BR2_TOOLCHAIN_GCC_AT_LEAST_12
>>   
>>   # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63261. This bug no
>>   # longer exists in gcc 8.x.
>> @@ -150,7 +151,8 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_68485
>>   config BR2_TOOLCHAIN_HAS_GCC_BUG_83143
>>   	bool
>>   	default y if BR2_sh
>> -	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_10 || BR2_TOOLCHAIN_GCC_AT_LEAST_11
>> +	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_10 || BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \
>> +		   BR2_TOOLCHAIN_GCC_AT_LEAST_12
> 
> Did you verify that these two bugs still affected gcc 12.x ?

The bug tracker entry for 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43744 does not seem to show 
a resolution for this bug so I am assuming that it is still active since 
it was not fixed in GCC 11.

Similarly it seemed like 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83143 was still not quite 
fixed.

Do you read the comments differently?
-- 
Florian
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 0/2] External GCC12 toolchain support

[Arnout Vandecappelle]

On 26/04/2022 19:32, Florian Fainelli wrote:
> This patch series allows us to use Linaro's GCC12 snapshot that can be
> downloaded from here:
> 
> https://snapshots.linaro.org/gnu-toolchain/12.0-2021.10-1/aarch64-linux-gnu/
> 
> Changes in v2:
> 
> - rebased against master
> 
> Florian Fainelli (2):
>    toolchain/Config.in: add BR2_TOOLCHAIN_GCC_AT_LEAST_12 blind option
>    toolchain/toolchain-external/toolchain-external-custom: add gcc 12
>      version selection

  Series applied to master, thanks.

  I was thinking that it would be useful to add an option 
BR2_TOOLCHAIN_GCC_NEWER and BR2_TOOLCHAIN_EXTERNAL_GCC_12_PLUS that selects it. 
That way, you can use newer GCC without changing Buildroot. Same for linux-headers.

  Note that the blind option can simply be _NEWER, but the user-visible option 
has to have the version explicit in it, so legacy handling can force the user to 
use the correct version when Buildroot is updated.

  Regards,
  Arnout


> 
>   toolchain/Config.in                                   | 11 +++++++++--
>   .../toolchain-external-custom/Config.in.options       |  4 ++++
>   2 files changed, 13 insertions(+), 2 deletions(-)
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 0/2] External GCC12 toolchain support

[Florian Fainelli]

On 4/27/2022 12:00 PM, Arnout Vandecappelle wrote:
> 
> 
> On 26/04/2022 19:32, Florian Fainelli wrote:
>> This patch series allows us to use Linaro's GCC12 snapshot that can be
>> downloaded from here:
>>
>> https://snapshots.linaro.org/gnu-toolchain/12.0-2021.10-1/aarch64-linux-gnu/ 
>>
>>
>> Changes in v2:
>>
>> - rebased against master
>>
>> Florian Fainelli (2):
>>    toolchain/Config.in: add BR2_TOOLCHAIN_GCC_AT_LEAST_12 blind option
>>    toolchain/toolchain-external/toolchain-external-custom: add gcc 12
>>      version selection
> 
>   Series applied to master, thanks.
> 
>   I was thinking that it would be useful to add an option 
> BR2_TOOLCHAIN_GCC_NEWER and BR2_TOOLCHAIN_EXTERNAL_GCC_12_PLUS that 
> selects it. That way, you can use newer GCC without changing Buildroot. 
> Same for linux-headers.
> 
>   Note that the blind option can simply be _NEWER, but the user-visible 
> option has to have the version explicit in it, so legacy handling can 
> force the user to use the correct version when Buildroot is updated.

Yes, that makes sense to me, I will submit a patch series unless you 
have started something already.
-- 
Florian
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot