From: Stefan Roese <sr@denx.de>
To: Oza Pawandeep <poza@codeaurora.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Dongdong Liu <liudongdong3@huawei.com>,
Keith Busch <keith.busch@intel.com>, Wei Zhang <wzhang@fb.com>,
Sinan Kaya <okaya@codeaurora.org>,
Timur Tabi <timur@codeaurora.org>
Subject: Re: [PATCH v6 7/7] PCI: Unify wait for link active into generic pci
Date: Fri, 19 Jan 2018 15:19:09 +0100 [thread overview]
Message-ID: <d8573bed-3517-bc9b-1e4a-c0107be9ea13@denx.de> (raw)
In-Reply-To: <1516360204-1586-8-git-send-email-poza@codeaurora.org>
On 19.01.2018 12:10, Oza Pawandeep wrote:
> Clients such as pciehp, dpc are using pcie_wait_link_active, which waits
> till the link becomes active or inactive.
>
> Made generic function and moved it to drivers/pci/pci.c
>
> Signed-off-by: Oza Pawandeep <poza@codeaurora.org>
>
> diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c
> index 7bab060..26afeff 100644
> --- a/drivers/pci/hotplug/pciehp_hpc.c
> +++ b/drivers/pci/hotplug/pciehp_hpc.c
> @@ -245,25 +245,12 @@ bool pciehp_check_link_active(struct controller *ctrl)
> return ret;
> }
>
> -static void __pcie_wait_link_active(struct controller *ctrl, bool active)
> +static bool pcie_wait_link_active(struct controller *ctrl)
> {
> - int timeout = 1000;
> -
> - if (pciehp_check_link_active(ctrl) == active)
> - return;
> - while (timeout > 0) {
> - msleep(10);
> - timeout -= 10;
> - if (pciehp_check_link_active(ctrl) == active)
> - return;
> - }
> - ctrl_dbg(ctrl, "Data Link Layer Link Active not %s in 1000 msec\n",
> - active ? "set" : "cleared");
> -}
> + struct pci_dev *pdev = ctrl_dev(ctrl);
> + bool active = true;
>
> -static void pcie_wait_link_active(struct controller *ctrl)
> -{
> - __pcie_wait_link_active(ctrl, true);
> + return pci_wait_for_link(pdev, active);
> }
>
> static bool pci_bus_check_dev(struct pci_bus *bus, int devfn)
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 4a7c686..0de83ea 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -2805,7 +2805,7 @@ static void pci_std_enable_acs(struct pci_dev *dev)
> pci_read_config_word(dev, pos + PCI_ACS_CTRL, &ctrl);
>
> /* Source Validation */
> - ctrl |= (cap & PCI_ACS_SV);
> +// ctrl |= (cap & PCI_ACS_SV);
Could it be, that you missed to fix / clean something up here?
Thanks,
Stefan
next prev parent reply other threads:[~2018-01-19 14:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 11:09 [PATCH v6 0/7] Address error and recovery for AER and DPC Oza Pawandeep
2018-01-19 11:09 ` [PATCH v6 1/7] PCI/AER: Rename error recovery to generic pci naming Oza Pawandeep
2018-01-19 11:09 ` [PATCH v6 2/7] PCI/AER: factor out error reporting from AER Oza Pawandeep
2018-01-19 11:10 ` [PATCH v6 3/7] PCI/ERR: add mutex to synchronize recovery Oza Pawandeep
2018-01-19 11:10 ` [PATCH v6 4/7] PCI/DPC: Unify and plumb error handling into DPC Oza Pawandeep
2018-01-19 11:10 ` [PATCH v6 5/7] PCI/AER: Unify aer error defines at single space Oza Pawandeep
2018-01-19 11:10 ` [PATCH v6 6/7] PCI/DPC: Enumerate the devices after DPC trigger event Oza Pawandeep
2018-01-19 11:10 ` [PATCH v6 7/7] PCI: Unify wait for link active into generic pci Oza Pawandeep
2018-01-19 14:08 ` Sinan Kaya
2018-01-19 14:17 ` Sinan Kaya
2018-01-19 16:22 ` poza
2018-01-19 14:19 ` Stefan Roese [this message]
2018-01-19 15:58 ` poza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8573bed-3517-bc9b-1e4a-c0107be9ea13@denx.de \
--to=sr@denx.de \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=keith.busch@intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=okaya@codeaurora.org \
--cc=pombredanne@nexb.com \
--cc=poza@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.