All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [linux-sunxi] [PATCH 4/4] sunxi: enable EMAC for Banana Pi M3 board
Date: Thu, 6 Jul 2017 11:13:05 +0100	[thread overview]
Message-ID: <d86480ab-2a6d-4d08-3495-2ac86ebf2473@arm.com> (raw)
In-Reply-To: <20170702070244.10539-5-icenowy@aosc.io>

Hi,

when using the new binding support [1] (this time the link is for real
;-), you could/should adjust the binding to be Linux compatible:

On 02/07/17 08:02, Icenowy Zheng wrote:
> Banana Pi M3 board comes with the A83T EMAC connected to a Realtek
> RTL8211E PHY, with a TX delay of 600ps.
> 
> Add the necessary DT parts and enable sun8i_emac in the defconfig.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  arch/arm/dts/sun8i-a83t-sinovoip-bpi-m3.dts | 13 +++++++++++++
>  configs/Sinovoip_BPI_M3_defconfig           |  1 +
>  2 files changed, 14 insertions(+)
> 
> diff --git a/arch/arm/dts/sun8i-a83t-sinovoip-bpi-m3.dts b/arch/arm/dts/sun8i-a83t-sinovoip-bpi-m3.dts
> index dfc16a0272..8e74227ad6 100644
> --- a/arch/arm/dts/sun8i-a83t-sinovoip-bpi-m3.dts
> +++ b/arch/arm/dts/sun8i-a83t-sinovoip-bpi-m3.dts
> @@ -61,6 +61,19 @@
>  	status = "okay";
>  };
>  
> +&emac {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&emac_rgmii_pins>;
> +	phy-mode = "rgmii";
> +	phy = <&phy1>;

This is called phy-handle in Linux.

> +	allwinner,tx-delay-ps = <600>;
> +	status = "okay";
> +
> +	phy1: ethernet-phy at 1 {
> +		reg = <1>;
> +	};

This should be a child of the mdio node.

Cheers,
Andre.

[1] https://lists.denx.de/pipermail/u-boot/2017-July/296929.html

> +};
> +

>  &uart0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&uart0_pins_b>;
> diff --git a/configs/Sinovoip_BPI_M3_defconfig b/configs/Sinovoip_BPI_M3_defconfig
> index 45eadcb443..ff068900a5 100644
> --- a/configs/Sinovoip_BPI_M3_defconfig
> +++ b/configs/Sinovoip_BPI_M3_defconfig
> @@ -22,6 +22,7 @@ CONFIG_SPL=y
>  # CONFIG_SPL_DOS_PARTITION is not set
>  # CONFIG_SPL_ISO_PARTITION is not set
>  # CONFIG_SPL_EFI_PARTITION is not set
> +CONFIG_SUN8I_EMAC=y
>  CONFIG_AXP_DCDC5_VOLT=1200
>  CONFIG_AXP_DLDO3_VOLT=2500
>  CONFIG_AXP_SW_ON=y
> 

      reply	other threads:[~2017-07-06 10:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-02  7:02 [U-Boot] [PATCH 0/4] Allwinner A83T and Banana Pi M3 EMAC support Icenowy Zheng
2017-07-02  7:02 ` [U-Boot] [PATCH 1/4] sun8i_emac: disable build of EPHY clock code on non-H3/H5 platforms Icenowy Zheng
2017-07-02  7:02 ` [U-Boot] [PATCH 2/4] sun8i_emac: add support for setting EMAC TX/RX delay Icenowy Zheng
2017-07-02  7:02 ` [U-Boot] [PATCH 3/4] sunxi: add stub EMAC device node in A83T device tree Icenowy Zheng
2017-07-03  6:52   ` Maxime Ripard
2017-07-03  6:54     ` Icenowy Zheng
2017-07-03 20:46       ` Maxime Ripard
2017-07-04  0:07         ` [U-Boot] [linux-sunxi] " Icenowy Zheng
2017-07-04 21:21           ` Maxime Ripard
2017-07-06 10:09   ` [U-Boot] [linux-sunxi] " Andre Przywara
2017-07-02  7:02 ` [U-Boot] [PATCH 4/4] sunxi: enable EMAC for Banana Pi M3 board Icenowy Zheng
2017-07-06 10:13   ` Andre Przywara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d86480ab-2a6d-4d08-3495-2ac86ebf2473@arm.com \
    --to=andre.przywara@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.