* [PATCH] nvmet: use NVME_NSID_ALL
@ 2017-07-18 17:46 Christoph Hellwig
2017-07-18 21:21 ` Keith Busch
2017-07-19 9:58 ` Max Gurtovoy
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-07-18 17:46 UTC (permalink / raw)
Signed-off-by: Christoph Hellwig <hch at lst.de>
---
drivers/nvme/target/admin-cmd.c | 2 +-
drivers/nvme/target/configfs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index 2d7a98ab53fb..1a34290831db 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -100,7 +100,7 @@ static u16 nvmet_get_smart_log(struct nvmet_req *req,
u16 status;
WARN_ON(req == NULL || slog == NULL);
- if (req->cmd->get_log_page.nsid == cpu_to_le32(0xFFFFFFFF))
+ if (req->cmd->get_log_page.nsid == cpu_to_le32(NVME_NSID_ALL))
status = nvmet_get_smart_log_all(req, slog);
else
status = nvmet_get_smart_log_nsid(req, slog);
diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
index 0a0067e771f5..b6aeb1d70951 100644
--- a/drivers/nvme/target/configfs.c
+++ b/drivers/nvme/target/configfs.c
@@ -444,7 +444,7 @@ static struct config_group *nvmet_ns_make(struct config_group *group,
goto out;
ret = -EINVAL;
- if (nsid == 0 || nsid == 0xffffffff)
+ if (nsid == 0 || nsid == NVME_NSID_ALL)
goto out;
ret = -ENOMEM;
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] nvmet: use NVME_NSID_ALL
2017-07-18 17:46 [PATCH] nvmet: use NVME_NSID_ALL Christoph Hellwig
@ 2017-07-18 21:21 ` Keith Busch
2017-07-19 9:58 ` Max Gurtovoy
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2017-07-18 21:21 UTC (permalink / raw)
On Tue, Jul 18, 2017@07:46:50PM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch at lst.de>
Looks good.
Reviewed-by: Keith Busch <keith.busch at intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nvmet: use NVME_NSID_ALL
2017-07-18 17:46 [PATCH] nvmet: use NVME_NSID_ALL Christoph Hellwig
2017-07-18 21:21 ` Keith Busch
@ 2017-07-19 9:58 ` Max Gurtovoy
1 sibling, 0 replies; 3+ messages in thread
From: Max Gurtovoy @ 2017-07-19 9:58 UTC (permalink / raw)
On 7/18/2017 8:46 PM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch at lst.de>
Looks good,
Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-19 9:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-18 17:46 [PATCH] nvmet: use NVME_NSID_ALL Christoph Hellwig
2017-07-18 21:21 ` Keith Busch
2017-07-19 9:58 ` Max Gurtovoy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.