* [Intel-gfx] [PATCH] drm/i915: Fix a NULL vs IS_ERR() bug
@ 2023-06-06 8:23 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2023-06-06 8:23 UTC (permalink / raw)
To: Nirmoy Das
Cc: intel-gfx, kernel-janitors, Suren Baghdasaryan, Matthew Auld,
Daniel Vetter, Rodrigo Vivi, David Airlie
The mmap_offset_attach() function returns error pointers, it doesn't
return NULL.
Fixes: eaee1c085863 ("drm/i915: Add a function to mmap framebuffer obj")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index 4e7a838ab7bd..aa4d842d4c5a 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
@@ -1085,8 +1085,8 @@ int i915_gem_fb_mmap(struct drm_i915_gem_object *obj, struct vm_area_struct *vma
/* handle stolen and smem objects */
mmap_type = i915_ggtt_has_aperture(ggtt) ? I915_MMAP_TYPE_GTT : I915_MMAP_TYPE_WC;
mmo = mmap_offset_attach(obj, mmap_type, NULL);
- if (!mmo)
- return -ENODEV;
+ if (IS_ERR(mmo))
+ return PTR_ERR(mmo);
}
/*
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] drm/i915: Fix a NULL vs IS_ERR() bug
@ 2023-06-06 8:23 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2023-06-06 8:23 UTC (permalink / raw)
To: Nirmoy Das
Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
David Airlie, Daniel Vetter, Andi Shyti, Anshuman Gupta,
Matthew Auld, Suren Baghdasaryan, Fei Yang,
Niranjana Vishwanathapura, intel-gfx, kernel-janitors
The mmap_offset_attach() function returns error pointers, it doesn't
return NULL.
Fixes: eaee1c085863 ("drm/i915: Add a function to mmap framebuffer obj")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index 4e7a838ab7bd..aa4d842d4c5a 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
@@ -1085,8 +1085,8 @@ int i915_gem_fb_mmap(struct drm_i915_gem_object *obj, struct vm_area_struct *vma
/* handle stolen and smem objects */
mmap_type = i915_ggtt_has_aperture(ggtt) ? I915_MMAP_TYPE_GTT : I915_MMAP_TYPE_WC;
mmo = mmap_offset_attach(obj, mmap_type, NULL);
- if (!mmo)
- return -ENODEV;
+ if (IS_ERR(mmo))
+ return PTR_ERR(mmo);
}
/*
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915: Fix a NULL vs IS_ERR() bug
2023-06-06 8:23 ` Dan Carpenter
@ 2023-06-06 8:51 ` Nirmoy Das
-1 siblings, 0 replies; 10+ messages in thread
From: Nirmoy Das @ 2023-06-06 8:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
David Airlie, Daniel Vetter, Andi Shyti, Anshuman Gupta,
Matthew Auld, Suren Baghdasaryan, Fei Yang,
Niranjana Vishwanathapura, intel-gfx, kernel-janitors
On 6/6/2023 10:23 AM, Dan Carpenter wrote:
> The mmap_offset_attach() function returns error pointers, it doesn't
> return NULL.
>
> Fixes: eaee1c085863 ("drm/i915: Add a function to mmap framebuffer obj")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Thanks,
Nirmoy
> ---
> drivers/gpu/drm/i915/gem/i915_gem_mman.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> index 4e7a838ab7bd..aa4d842d4c5a 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> @@ -1085,8 +1085,8 @@ int i915_gem_fb_mmap(struct drm_i915_gem_object *obj, struct vm_area_struct *vma
> /* handle stolen and smem objects */
> mmap_type = i915_ggtt_has_aperture(ggtt) ? I915_MMAP_TYPE_GTT : I915_MMAP_TYPE_WC;
> mmo = mmap_offset_attach(obj, mmap_type, NULL);
> - if (!mmo)
> - return -ENODEV;
> + if (IS_ERR(mmo))
> + return PTR_ERR(mmo);
> }
>
> /*
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix a NULL vs IS_ERR() bug
@ 2023-06-06 8:51 ` Nirmoy Das
0 siblings, 0 replies; 10+ messages in thread
From: Nirmoy Das @ 2023-06-06 8:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: intel-gfx, kernel-janitors, Suren Baghdasaryan, Matthew Auld,
Daniel Vetter, Rodrigo Vivi, David Airlie
On 6/6/2023 10:23 AM, Dan Carpenter wrote:
> The mmap_offset_attach() function returns error pointers, it doesn't
> return NULL.
>
> Fixes: eaee1c085863 ("drm/i915: Add a function to mmap framebuffer obj")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Thanks,
Nirmoy
> ---
> drivers/gpu/drm/i915/gem/i915_gem_mman.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> index 4e7a838ab7bd..aa4d842d4c5a 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> @@ -1085,8 +1085,8 @@ int i915_gem_fb_mmap(struct drm_i915_gem_object *obj, struct vm_area_struct *vma
> /* handle stolen and smem objects */
> mmap_type = i915_ggtt_has_aperture(ggtt) ? I915_MMAP_TYPE_GTT : I915_MMAP_TYPE_WC;
> mmo = mmap_offset_attach(obj, mmap_type, NULL);
> - if (!mmo)
> - return -ENODEV;
> + if (IS_ERR(mmo))
> + return PTR_ERR(mmo);
> }
>
> /*
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915: Fix a NULL vs IS_ERR() bug
2023-06-06 8:23 ` Dan Carpenter
@ 2023-06-06 9:22 ` Andi Shyti
-1 siblings, 0 replies; 10+ messages in thread
From: Andi Shyti @ 2023-06-06 9:22 UTC (permalink / raw)
To: Dan Carpenter
Cc: Nirmoy Das, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
Tvrtko Ursulin, David Airlie, Daniel Vetter, Andi Shyti,
Anshuman Gupta, Matthew Auld, Suren Baghdasaryan, Fei Yang,
Niranjana Vishwanathapura, intel-gfx, kernel-janitors
Hi Dan,
On Tue, Jun 06, 2023 at 11:23:56AM +0300, Dan Carpenter wrote:
> The mmap_offset_attach() function returns error pointers, it doesn't
> return NULL.
>
> Fixes: eaee1c085863 ("drm/i915: Add a function to mmap framebuffer obj")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Thanks for this series of fixes!
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix a NULL vs IS_ERR() bug
@ 2023-06-06 9:22 ` Andi Shyti
0 siblings, 0 replies; 10+ messages in thread
From: Andi Shyti @ 2023-06-06 9:22 UTC (permalink / raw)
To: Dan Carpenter
Cc: intel-gfx, kernel-janitors, Suren Baghdasaryan, Matthew Auld,
Daniel Vetter, Rodrigo Vivi, David Airlie, Nirmoy Das
Hi Dan,
On Tue, Jun 06, 2023 at 11:23:56AM +0300, Dan Carpenter wrote:
> The mmap_offset_attach() function returns error pointers, it doesn't
> return NULL.
>
> Fixes: eaee1c085863 ("drm/i915: Add a function to mmap framebuffer obj")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Thanks for this series of fixes!
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix a NULL vs IS_ERR() bug
2023-06-06 8:23 ` Dan Carpenter
` (2 preceding siblings ...)
(?)
@ 2023-06-06 12:23 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-06-06 12:23 UTC (permalink / raw)
To: Dan Carpenter; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10066 bytes --]
== Series Details ==
Series: drm/i915: Fix a NULL vs IS_ERR() bug
URL : https://patchwork.freedesktop.org/series/118907/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13235 -> Patchwork_118907v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/index.html
Participating hosts (40 -> 40)
------------------------------
Additional (1): bat-atsm-1
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_118907v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap@basic:
- bat-atsm-1: NOTRUN -> [SKIP][1] ([i915#4083])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@gem_mmap@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-atsm-1: NOTRUN -> [SKIP][2] ([i915#4079]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-atsm-1: NOTRUN -> [SKIP][3] ([i915#4077]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@gem_tiled_fence_blits@basic.html
* igt@i915_pm_backlight@basic-brightness@edp-1:
- bat-rplp-1: NOTRUN -> [ABORT][4] ([i915#7077])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-rplp-1/igt@i915_pm_backlight@basic-brightness@edp-1.html
* igt@i915_pm_rps@basic-api:
- bat-atsm-1: NOTRUN -> [SKIP][5] ([i915#6621])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@i915_pm_rps@basic-api.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-atsm-1: NOTRUN -> [SKIP][6] ([i915#6645])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@i915_suspend@basic-s3-without-i915.html
- bat-rpls-1: NOTRUN -> [ABORT][7] ([i915#6687] / [i915#7978])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@size-max:
- bat-atsm-1: NOTRUN -> [SKIP][8] ([i915#6077]) +36 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@kms_addfb_basic@size-max.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-dg2-11: NOTRUN -> [SKIP][9] ([i915#7828])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-dg2-11/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- bat-atsm-1: NOTRUN -> [SKIP][10] ([i915#6078]) +19 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
* igt@kms_flip@basic-flip-vs-wf_vblank:
- bat-atsm-1: NOTRUN -> [SKIP][11] ([i915#6166]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@kms_flip@basic-flip-vs-wf_vblank.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-atsm-1: NOTRUN -> [SKIP][12] ([i915#6093]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence:
- bat-atsm-1: NOTRUN -> [SKIP][13] ([i915#1836]) +6 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence.html
* igt@kms_prop_blob@basic:
- bat-atsm-1: NOTRUN -> [SKIP][14] ([i915#7357])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@kms_prop_blob@basic.html
* igt@kms_psr@sprite_plane_onoff:
- bat-atsm-1: NOTRUN -> [SKIP][15] ([i915#1072]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-atsm-1: NOTRUN -> [SKIP][16] ([i915#6094])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-atsm-1: NOTRUN -> [SKIP][17] ([fdo#109295] / [i915#6078])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-gtt:
- bat-atsm-1: NOTRUN -> [SKIP][18] ([fdo#109295] / [i915#4077]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-write:
- bat-atsm-1: NOTRUN -> [SKIP][19] ([fdo#109295]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-atsm-1/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_lrc:
- bat-dg2-11: [INCOMPLETE][20] ([i915#7609] / [i915#7913]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@migrate:
- bat-adlp-9: [DMESG-FAIL][22] ([i915#7699] / [i915#7913]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/bat-adlp-9/igt@i915_selftest@live@migrate.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-adlp-9/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][24] ([i915#4983] / [i915#7911] / [i915#7920]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/bat-rpls-1/igt@i915_selftest@live@requests.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- bat-rpls-2: [DMESG-WARN][26] ([i915#6367]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/bat-rpls-2/igt@i915_selftest@live@slpc.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-rpls-2/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [FAIL][28] ([fdo#103375]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
#### Warnings ####
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: [ABORT][30] ([i915#4579] / [i915#8260]) -> [SKIP][31] ([i915#3555] / [i915#4579])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
Build changes
-------------
* Linux: CI_DRM_13235 -> Patchwork_118907v1
CI-20190529: 20190529
CI_DRM_13235: 98a84b63adc57ae6500c03f8076f94e5d5a1743b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7319: 2e1bcd49944452b5f9516eecee48e1fa3ae6a636 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118907v1: 98a84b63adc57ae6500c03f8076f94e5d5a1743b @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
a4412a911e64 drm/i915: Fix a NULL vs IS_ERR() bug
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/index.html
[-- Attachment #2: Type: text/html, Size: 11622 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix a NULL vs IS_ERR() bug
2023-06-06 8:23 ` Dan Carpenter
` (3 preceding siblings ...)
(?)
@ 2023-06-07 2:25 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-06-07 2:25 UTC (permalink / raw)
To: Dan Carpenter; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10288 bytes --]
== Series Details ==
Series: drm/i915: Fix a NULL vs IS_ERR() bug
URL : https://patchwork.freedesktop.org/series/118907/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13235_full -> Patchwork_118907v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (8 -> 7)
------------------------------
Missing (1): shard-rkl0
Known issues
------------
Here are the changes found in Patchwork_118907v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][1] -> [FAIL][2] ([i915#2842])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-glk: NOTRUN -> [FAIL][3] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-glk3/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-glk: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-glk3/igt@gem_lmem_swapping@parallel-random-verify-ccs.html
* igt@i915_suspend@forcewake:
- shard-apl: [PASS][5] -> [ABORT][6] ([i915#180])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/shard-apl3/igt@i915_suspend@forcewake.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-apl6/igt@i915_suspend@forcewake.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-4_tiled_mtl_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][7] ([fdo#109271]) +16 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-glk3/igt@kms_ccs@pipe-a-ccs-on-another-bo-4_tiled_mtl_mc_ccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-glk: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4579])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-glk3/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1:
- shard-apl: [PASS][9] -> [FAIL][10] ([i915#1188])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/shard-apl2/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-apl1/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4579]) +11 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-snb7/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-b-vga-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][12] ([fdo#109271]) +17 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-snb1/igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-a-hdmi-a-1.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- {shard-rkl}: [FAIL][13] ([i915#7742]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/shard-rkl-3/igt@drm_fdinfo@most-busy-check-all@rcs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-rkl-2/igt@drm_fdinfo@most-busy-check-all@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][15] ([i915#2842]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][17] ([i915#2842]) -> [PASS][18] +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/shard-rkl-3/igt@gem_exec_fair@basic-pace@rcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-rkl-2/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [DMESG-WARN][19] ([i915#4936] / [i915#5493]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/shard-dg1-13/igt@gem_lmem_swapping@smem-oom@lmem0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-dg1-13/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [ABORT][21] ([i915#5566]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/shard-glk3/igt@gen9_exec_parse@allowed-single.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-glk3/igt@gen9_exec_parse@allowed-single.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][23] ([i915#2346]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2:
- {shard-rkl}: [FAIL][25] ([i915#8292]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/shard-rkl-3/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-rkl-2/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2.html
* igt@prime_self_import@reimport-vs-gem_close-race:
- shard-apl: [FAIL][27] ([i915#7951]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13235/shard-apl1/igt@prime_self_import@reimport-vs-gem_close-race.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/shard-apl7/igt@prime_self_import@reimport-vs-gem_close-race.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7951]: https://gitlab.freedesktop.org/drm/intel/issues/7951
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8516]: https://gitlab.freedesktop.org/drm/intel/issues/8516
Build changes
-------------
* Linux: CI_DRM_13235 -> Patchwork_118907v1
CI-20190529: 20190529
CI_DRM_13235: 98a84b63adc57ae6500c03f8076f94e5d5a1743b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7319: 2e1bcd49944452b5f9516eecee48e1fa3ae6a636 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118907v1: 98a84b63adc57ae6500c03f8076f94e5d5a1743b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118907v1/index.html
[-- Attachment #2: Type: text/html, Size: 9603 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix a NULL vs IS_ERR() bug
2023-06-06 9:22 ` [Intel-gfx] " Andi Shyti
@ 2023-06-19 14:06 ` Nirmoy Das
-1 siblings, 0 replies; 10+ messages in thread
From: Nirmoy Das @ 2023-06-19 14:06 UTC (permalink / raw)
To: Andi Shyti, Dan Carpenter
Cc: intel-gfx, kernel-janitors, Suren Baghdasaryan, Matthew Auld,
Daniel Vetter, Rodrigo Vivi, David Airlie, Nirmoy Das
Pushed to gt-next.
Thanks,
Nirmoy
On 6/6/2023 11:22 AM, Andi Shyti wrote:
> Hi Dan,
>
> On Tue, Jun 06, 2023 at 11:23:56AM +0300, Dan Carpenter wrote:
>> The mmap_offset_attach() function returns error pointers, it doesn't
>> return NULL.
>>
>> Fixes: eaee1c085863 ("drm/i915: Add a function to mmap framebuffer obj")
>> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> Thanks for this series of fixes!
>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
>
> Andi
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix a NULL vs IS_ERR() bug
@ 2023-06-19 14:06 ` Nirmoy Das
0 siblings, 0 replies; 10+ messages in thread
From: Nirmoy Das @ 2023-06-19 14:06 UTC (permalink / raw)
To: Andi Shyti, Dan Carpenter
Cc: David Airlie, intel-gfx, kernel-janitors, Matthew Auld,
Daniel Vetter, Rodrigo Vivi, Suren Baghdasaryan, Nirmoy Das
Pushed to gt-next.
Thanks,
Nirmoy
On 6/6/2023 11:22 AM, Andi Shyti wrote:
> Hi Dan,
>
> On Tue, Jun 06, 2023 at 11:23:56AM +0300, Dan Carpenter wrote:
>> The mmap_offset_attach() function returns error pointers, it doesn't
>> return NULL.
>>
>> Fixes: eaee1c085863 ("drm/i915: Add a function to mmap framebuffer obj")
>> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> Thanks for this series of fixes!
>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
>
> Andi
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-06-19 14:08 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-06 8:23 [Intel-gfx] [PATCH] drm/i915: Fix a NULL vs IS_ERR() bug Dan Carpenter
2023-06-06 8:23 ` Dan Carpenter
2023-06-06 8:51 ` Nirmoy Das
2023-06-06 8:51 ` [Intel-gfx] " Nirmoy Das
2023-06-06 9:22 ` Andi Shyti
2023-06-06 9:22 ` [Intel-gfx] " Andi Shyti
2023-06-19 14:06 ` Nirmoy Das
2023-06-19 14:06 ` Nirmoy Das
2023-06-06 12:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-07 2:25 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.