RE: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

From: <Mario.Limonciello@dell.com>
To: <kai.heng.feng@canonical.com>, <davem@davemloft.net>
Cc: <hayeswang@realtek.com>, <gregkh@linuxfoundation.org>,
	<linux-usb@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <nic_swsd@realtek.com>
Subject: RE: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock
Date: Thu, 18 Jan 2018 17:06:34 +0000	[thread overview]
Message-ID: <d87ab8c6e8c24c69879288ba0d7032b3@ausx13mpc120.AMER.DELL.COM> (raw)
In-Reply-To: <55F628DA-8B95-4FA8-B160-4A3B9D03D6B8@canonical.com>

> -----Original Message-----
> From: Kai Heng Feng [mailto:kai.heng.feng@canonical.com]
> Sent: Thursday, January 18, 2018 10:57 AM
> To: David Miller <davem@davemloft.net>
> Cc: Hayes Wang <hayeswang@realtek.com>; gregkh@linuxfoundation.org; linux-
> usb@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> Limonciello, Mario <Mario_Limonciello@Dell.com>; nic_swsd@realtek.com
> Subject: Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock
> 
> 
> 
> > On 18 Jan 2018, at 10:50 PM, David Miller <davem@davemloft.net> wrote:
> >
> > From: Hayes Wang <hayeswang@realtek.com>
> > Date: Thu, 18 Jan 2018 03:04:08 +0000
> >
> >> [...]
> >>>> r8153 on Dell TB15/16 dock corrupts rx packets.
> >>>>
> >>>> This change is suggested by Realtek. They guess that the XHCI
> >>>> controller doesn't have enough buffer, and their guesswork is correct,
> >>>> once the RX aggregation gets disabled, the issue is gone.
> >>>>
> >>>> ASMedia is currently working on a real sulotion for this issue.
> >>>>
> >>>> Dell and ODM confirm the bcdDevice and iSerialNumber is unique for TB16.
> >>>>
> >>>> Note that TB15 has different bcdDevice and iSerialNumber, which are
> >>>> not unique values. If you still have TB15, please contact Dell to
> >>>> replace it with TB16.
> >>
> >> Excuse me. I don't understand why this patch is for specific USB nic rather than
> xHCI.
> >> It seems to make the specific USB nic working and the other ones keeping error.
> >
> > Well, are we sure that the device being in the TB16 dock doesn't
> > contribute to the issue as well?

Previous version of this patch checked the parent device to ensure it was in TB16.
I believe there was negative feedback to that approach, which prompted the discussion
to check bcdDevice and iSerialNumber with all vendors involved.

If it's still desirable to analyze parentage tree, I suppose bcdDevice, iSerialNumber
and parent's USB device VID/PID can be analyzed  all at the same time.

> 
> This is what vendors concluded for now. The very same NIC on WD15 doesn’t
> have the issue.

And just so it's extra clear to everyone on this list - WD15 has different bcdDevice
iSerialNumber, and doesn't connect to ASMedia host controller.