All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] dma/rc4030: fix a mixed declarations and code warning
@ 2017-03-14 17:11 Yongbok Kim
  2017-03-14 17:55 ` Hervé Poussineau
  0 siblings, 1 reply; 2+ messages in thread
From: Yongbok Kim @ 2017-03-14 17:11 UTC (permalink / raw)
  To: QEMU Developers; +Cc: Hervé Poussineau

Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
---
 hw/dma/rc4030.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c
index 8ad97f1..4dbb4fd 100644
--- a/hw/dma/rc4030.c
+++ b/hw/dma/rc4030.c
@@ -99,8 +99,8 @@ typedef struct rc4030State
 
 static void set_next_tick(rc4030State *s)
 {
-    qemu_irq_lower(s->timer_irq);
     uint32_t tm_hz;
+    qemu_irq_lower(s->timer_irq);
 
     tm_hz = 1000 / (s->itr + 1);
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] dma/rc4030: fix a mixed declarations and code warning
  2017-03-14 17:11 [Qemu-devel] [PATCH] dma/rc4030: fix a mixed declarations and code warning Yongbok Kim
@ 2017-03-14 17:55 ` Hervé Poussineau
  0 siblings, 0 replies; 2+ messages in thread
From: Hervé Poussineau @ 2017-03-14 17:55 UTC (permalink / raw)
  To: Yongbok Kim, QEMU Developers

Le 14/03/2017 à 18:11, Yongbok Kim a écrit :
> Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>

Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>

> ---
>  hw/dma/rc4030.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c
> index 8ad97f1..4dbb4fd 100644
> --- a/hw/dma/rc4030.c
> +++ b/hw/dma/rc4030.c
> @@ -99,8 +99,8 @@ typedef struct rc4030State
>
>  static void set_next_tick(rc4030State *s)
>  {
> -    qemu_irq_lower(s->timer_irq);
>      uint32_t tm_hz;
> +    qemu_irq_lower(s->timer_irq);
>
>      tm_hz = 1000 / (s->itr + 1);
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-14 17:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-14 17:11 [Qemu-devel] [PATCH] dma/rc4030: fix a mixed declarations and code warning Yongbok Kim
2017-03-14 17:55 ` Hervé Poussineau

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.