From: "Rafał Miłecki" <zajec5@gmail.com> To: Johannes Berg <johannes@sipsolutions.net>, linux-wireless@vger.kernel.org, Rob Herring <robh@kernel.org> Cc: "Martin Blumenstingl" <martin.blumenstingl@googlemail.com>, "Felix Fietkau" <nbd@nbd.name>, "Arend van Spriel" <arend@broadcom.com>, "Arnd Bergmann" <arnd@arndb.de>, devicetree@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl> Subject: Re: [PATCH V5 1/3] dt-bindings: document common IEEE 802.11 frequency limit property Date: Wed, 4 Jan 2017 07:20:48 +0100 [thread overview] Message-ID: <d90127bd-6a9e-2773-fdf9-527afdc004a6@gmail.com> (raw) In-Reply-To: <20170103225715.14072-1-zajec5@gmail.com> Hi Rob, On 01/03/2017 11:57 PM, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > This new file should be used for properties that apply to all wireless > devices. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > V2: Switch to a single ieee80211-freq-limit property that allows specifying > *multiple* ranges. This resolves problem with more complex rules as pointed > by Felx. > Make description implementation agnostic as pointed by Arend. > Rename node to wifi as suggested by Martin. > V3: Use more real-life frequencies in the example. > V5: Describe hardware design as possible use for this property > --- > .../devicetree/bindings/net/wireless/ieee80211.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/ieee80211.txt > > diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.txt b/Documentation/devicetree/bindings/net/wireless/ieee80211.txt > new file mode 100644 > index 0000000..1c82c16 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/ieee80211.txt > @@ -0,0 +1,20 @@ > +Common IEEE 802.11 properties > + > +This provides documentation of common properties that are valid for all wireless > +devices. > + > +Optional properties: > + - ieee80211-freq-limit : list of supported frequency ranges in KHz. This can be > + used to specify extra hardware limitations caused by e.g. used antennas > + or power amplifiers. Do you find this description sufficient now? I'm not sure how/if I could answer "Where would this data normally come from?" question. One vendor may hardcode choice of channels in their PHP web UI. Another one may do it in Andoid app. OpenWrt so far was describing this limitation on their wiki page. It doesn't sound like any valuable info if I understand this correctly. We also don't describe where to get information about amount o RAM. One may just check the hardware, one may use vendor firmware, one could check product data sheet. If I missed the point, could you help me get this? > +Example: > + > +pcie@0,0 { > + reg = <0x0000 0 0 0 0>; > + wifi@0,0 { > + reg = <0x0000 0 0 0 0>; > + ieee80211-freq-limit = <2402000 2482000>, > + <5170000 5250000>; > + }; > +}; >
WARNING: multiple messages have this Message-ID (diff)
From: "Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: "Martin Blumenstingl" <martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>, "Felix Fietkau" <nbd-Vt+b4OUoWG0@public.gmane.org>, "Arend van Spriel" <arend-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>, "Arnd Bergmann" <arnd-r2nGTMty4D4@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafał Miłecki" <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org> Subject: Re: [PATCH V5 1/3] dt-bindings: document common IEEE 802.11 frequency limit property Date: Wed, 4 Jan 2017 07:20:48 +0100 [thread overview] Message-ID: <d90127bd-6a9e-2773-fdf9-527afdc004a6@gmail.com> (raw) In-Reply-To: <20170103225715.14072-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Hi Rob, On 01/03/2017 11:57 PM, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org> > > This new file should be used for properties that apply to all wireless > devices. > > Signed-off-by: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org> > --- > V2: Switch to a single ieee80211-freq-limit property that allows specifying > *multiple* ranges. This resolves problem with more complex rules as pointed > by Felx. > Make description implementation agnostic as pointed by Arend. > Rename node to wifi as suggested by Martin. > V3: Use more real-life frequencies in the example. > V5: Describe hardware design as possible use for this property > --- > .../devicetree/bindings/net/wireless/ieee80211.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/ieee80211.txt > > diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.txt b/Documentation/devicetree/bindings/net/wireless/ieee80211.txt > new file mode 100644 > index 0000000..1c82c16 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/ieee80211.txt > @@ -0,0 +1,20 @@ > +Common IEEE 802.11 properties > + > +This provides documentation of common properties that are valid for all wireless > +devices. > + > +Optional properties: > + - ieee80211-freq-limit : list of supported frequency ranges in KHz. This can be > + used to specify extra hardware limitations caused by e.g. used antennas > + or power amplifiers. Do you find this description sufficient now? I'm not sure how/if I could answer "Where would this data normally come from?" question. One vendor may hardcode choice of channels in their PHP web UI. Another one may do it in Andoid app. OpenWrt so far was describing this limitation on their wiki page. It doesn't sound like any valuable info if I understand this correctly. We also don't describe where to get information about amount o RAM. One may just check the hardware, one may use vendor firmware, one could check product data sheet. If I missed the point, could you help me get this? > +Example: > + > +pcie@0,0 { > + reg = <0x0000 0 0 0 0>; > + wifi@0,0 { > + reg = <0x0000 0 0 0 0>; > + ieee80211-freq-limit = <2402000 2482000>, > + <5170000 5250000>; > + }; > +}; >
next prev parent reply other threads:[~2017-01-04 6:21 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-03 22:57 [PATCH V5 1/3] dt-bindings: document common IEEE 802.11 frequency limit property Rafał Miłecki 2017-01-03 22:57 ` Rafał Miłecki 2017-01-03 22:57 ` [PATCH V5 2/3] cfg80211: move function checking range fit to util.c Rafał Miłecki 2017-01-03 22:57 ` Rafał Miłecki 2017-01-03 22:57 ` [PATCH V5 3/3] cfg80211: support ieee80211-freq-limit DT property Rafał Miłecki 2017-01-03 22:57 ` Rafał Miłecki 2017-01-04 13:26 ` Johannes Berg 2017-01-04 13:26 ` Johannes Berg 2017-01-04 16:13 ` Rafał Miłecki 2017-01-04 16:13 ` Rafał Miłecki 2017-01-05 11:50 ` Johannes Berg 2017-01-05 11:50 ` Johannes Berg 2017-01-03 22:57 ` [PATCH V5 4/3] brcmfmac: use wiphy_read_of_freq_limits to respect extra limits Rafał Miłecki 2017-01-03 22:57 ` Rafał Miłecki 2017-01-04 14:20 ` Rob Herring 2017-01-04 14:20 ` Rob Herring 2017-01-04 6:20 ` Rafał Miłecki [this message] 2017-01-04 6:20 ` [PATCH V5 1/3] dt-bindings: document common IEEE 802.11 frequency limit property Rafał Miłecki 2017-01-04 10:02 ` Arend Van Spriel 2017-01-04 10:02 ` Arend Van Spriel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d90127bd-6a9e-2773-fdf9-527afdc004a6@gmail.com \ --to=zajec5@gmail.com \ --cc=arend@broadcom.com \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=johannes@sipsolutions.net \ --cc=linux-wireless@vger.kernel.org \ --cc=martin.blumenstingl@googlemail.com \ --cc=nbd@nbd.name \ --cc=rafal@milecki.pl \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.