From: Jason Wang <jasowang@redhat.com> To: Stefano Garzarella <sgarzare@redhat.com>, virtualization@lists.linux-foundation.org Cc: Stefan Hajnoczi <stefanha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Oren Duer <oren@nvidia.com>, Laurent Vivier <lvivier@redhat.com>, linux-kernel@vger.kernel.org, Max Gurtovoy <mgurtovoy@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>, Eli Cohen <elic@nvidia.com> Subject: Re: [PATCH v3 15/19] vdpa_sim: set vringh notify callback Date: Mon, 7 Dec 2020 13:30:59 +0800 [thread overview] Message-ID: <d9403e25-41a2-cfbe-efa9-8952b8e1b881@redhat.com> (raw) In-Reply-To: <20201203170511.216407-16-sgarzare@redhat.com> On 2020/12/4 上午1:05, Stefano Garzarella wrote: > Instead of calling the vq callback directly, we can leverage the > vringh_notify() function, adding vdpasim_vq_notify() and setting it > in the vringh notify callback. > > Suggested-by: Jason Wang <jasowang@redhat.com> > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> > --- > v3: > - cleared notify during reset [Jason] > --- > drivers/vdpa/vdpa_sim/vdpa_sim.c | 23 +++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c > index 03a8717f80ea..1243b02488f7 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c > @@ -123,6 +123,17 @@ static struct vdpasim *dev_to_sim(struct device *dev) > return vdpa_to_sim(vdpa); > } > > +static void vdpasim_vq_notify(struct vringh *vring) > +{ > + struct vdpasim_virtqueue *vq = > + container_of(vring, struct vdpasim_virtqueue, vring); > + > + if (!vq->cb) > + return; > + > + vq->cb(vq->private); > +} > + > static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx) > { > struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx]; > @@ -134,6 +145,8 @@ static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx) > (uintptr_t)vq->driver_addr, > (struct vring_used *) > (uintptr_t)vq->device_addr); > + > + vq->vring.notify = vdpasim_vq_notify; > } > > static void vdpasim_vq_reset(struct vdpasim *vdpasim, > @@ -147,6 +160,8 @@ static void vdpasim_vq_reset(struct vdpasim *vdpasim, > vq->private = NULL; > vringh_init_iotlb(&vq->vring, vdpasim->dev_attr.supported_features, > VDPASIM_QUEUE_MAX, false, NULL, NULL, NULL); > + > + vq->vring.notify = NULL; > } > > static void vdpasim_reset(struct vdpasim *vdpasim) > @@ -223,10 +238,10 @@ static void vdpasim_net_work(struct work_struct *work) > smp_wmb(); > > local_bh_disable(); > - if (txq->cb) > - txq->cb(txq->private); > - if (rxq->cb) > - rxq->cb(rxq->private); > + if (vringh_need_notify_iotlb(&txq->vring) > 0) > + vringh_notify(&txq->vring); > + if (vringh_need_notify_iotlb(&rxq->vring) > 0) > + vringh_notify(&rxq->vring); > local_bh_enable(); > > if (++pkts > 4) {
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Stefano Garzarella <sgarzare@redhat.com>, virtualization@lists.linux-foundation.org Cc: Laurent Vivier <lvivier@redhat.com>, Max Gurtovoy <mgurtovoy@nvidia.com>, "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org, Shahaf Shuler <shahafs@nvidia.com>, Stefan Hajnoczi <stefanha@redhat.com>, Eli Cohen <elic@nvidia.com>, Oren Duer <oren@nvidia.com> Subject: Re: [PATCH v3 15/19] vdpa_sim: set vringh notify callback Date: Mon, 7 Dec 2020 13:30:59 +0800 [thread overview] Message-ID: <d9403e25-41a2-cfbe-efa9-8952b8e1b881@redhat.com> (raw) In-Reply-To: <20201203170511.216407-16-sgarzare@redhat.com> On 2020/12/4 上午1:05, Stefano Garzarella wrote: > Instead of calling the vq callback directly, we can leverage the > vringh_notify() function, adding vdpasim_vq_notify() and setting it > in the vringh notify callback. > > Suggested-by: Jason Wang <jasowang@redhat.com> > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> > --- > v3: > - cleared notify during reset [Jason] > --- > drivers/vdpa/vdpa_sim/vdpa_sim.c | 23 +++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c > index 03a8717f80ea..1243b02488f7 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c > @@ -123,6 +123,17 @@ static struct vdpasim *dev_to_sim(struct device *dev) > return vdpa_to_sim(vdpa); > } > > +static void vdpasim_vq_notify(struct vringh *vring) > +{ > + struct vdpasim_virtqueue *vq = > + container_of(vring, struct vdpasim_virtqueue, vring); > + > + if (!vq->cb) > + return; > + > + vq->cb(vq->private); > +} > + > static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx) > { > struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx]; > @@ -134,6 +145,8 @@ static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx) > (uintptr_t)vq->driver_addr, > (struct vring_used *) > (uintptr_t)vq->device_addr); > + > + vq->vring.notify = vdpasim_vq_notify; > } > > static void vdpasim_vq_reset(struct vdpasim *vdpasim, > @@ -147,6 +160,8 @@ static void vdpasim_vq_reset(struct vdpasim *vdpasim, > vq->private = NULL; > vringh_init_iotlb(&vq->vring, vdpasim->dev_attr.supported_features, > VDPASIM_QUEUE_MAX, false, NULL, NULL, NULL); > + > + vq->vring.notify = NULL; > } > > static void vdpasim_reset(struct vdpasim *vdpasim) > @@ -223,10 +238,10 @@ static void vdpasim_net_work(struct work_struct *work) > smp_wmb(); > > local_bh_disable(); > - if (txq->cb) > - txq->cb(txq->private); > - if (rxq->cb) > - rxq->cb(rxq->private); > + if (vringh_need_notify_iotlb(&txq->vring) > 0) > + vringh_notify(&txq->vring); > + if (vringh_need_notify_iotlb(&rxq->vring) > 0) > + vringh_notify(&rxq->vring); > local_bh_enable(); > > if (++pkts > 4) { _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-12-07 5:33 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-03 17:04 [PATCH v3 00/19] vdpa: generalize vdpa simulator Stefano Garzarella 2020-12-03 17:04 ` Stefano Garzarella 2020-12-03 17:04 ` [PATCH v3 01/19] vdpa: remove unnecessary 'default n' in Kconfig entries Stefano Garzarella 2020-12-03 17:04 ` Stefano Garzarella 2020-12-03 17:04 ` [PATCH v3 02/19] vdpa_sim: remove unnecessary headers inclusion Stefano Garzarella 2020-12-03 17:04 ` Stefano Garzarella 2020-12-03 17:37 ` Randy Dunlap 2020-12-03 17:37 ` Randy Dunlap 2020-12-04 7:57 ` Stefano Garzarella 2020-12-04 7:57 ` Stefano Garzarella 2020-12-03 17:04 ` [PATCH v3 03/19] vdpa_sim: remove hard-coded virtq count Stefano Garzarella 2020-12-03 17:04 ` Stefano Garzarella 2020-12-03 17:04 ` [PATCH v3 04/19] vhost/iotlb: add VHOST_IOTLB_UNLIMITED macro Stefano Garzarella 2020-12-03 17:04 ` Stefano Garzarella 2020-12-07 3:55 ` Jason Wang 2020-12-07 3:55 ` Jason Wang 2020-12-03 17:04 ` [PATCH v3 05/19] vdpa_sim: remove the limit of IOTLB entries Stefano Garzarella 2020-12-03 17:04 ` Stefano Garzarella 2020-12-07 4:00 ` Jason Wang 2020-12-07 4:00 ` Jason Wang 2020-12-09 10:58 ` Stefano Garzarella 2020-12-09 10:58 ` Stefano Garzarella 2020-12-10 4:03 ` Jason Wang 2020-12-10 4:03 ` Jason Wang 2020-12-03 17:04 ` [PATCH v3 06/19] vdpa_sim: rename vdpasim_config_ops variables Stefano Garzarella 2020-12-03 17:04 ` Stefano Garzarella 2020-12-03 17:04 ` [PATCH v3 07/19] vdpa_sim: add struct vdpasim_dev_attr for device attributes Stefano Garzarella 2020-12-03 17:04 ` Stefano Garzarella 2020-12-03 17:05 ` [PATCH v3 08/19] vdpa_sim: add device id field in vdpasim_dev_attr Stefano Garzarella 2020-12-03 17:05 ` Stefano Garzarella 2020-12-03 17:05 ` [PATCH v3 09/19] vdpa_sim: add supported_features " Stefano Garzarella 2020-12-03 17:05 ` Stefano Garzarella 2020-12-03 17:05 ` [PATCH v3 10/19] vdpa_sim: add work_fn " Stefano Garzarella 2020-12-03 17:05 ` Stefano Garzarella 2020-12-03 17:05 ` [PATCH v3 11/19] vdpa_sim: store parsed MAC address in a buffer Stefano Garzarella 2020-12-03 17:05 ` Stefano Garzarella 2020-12-03 17:05 ` [PATCH v3 12/19] vdpa_sim: make 'config' generic and usable for any device type Stefano Garzarella 2020-12-03 17:05 ` Stefano Garzarella 2020-12-07 5:22 ` Jason Wang 2020-12-07 5:22 ` Jason Wang 2020-12-03 17:05 ` [PATCH v3 13/19] vdpa_sim: add get_config callback in vdpasim_dev_attr Stefano Garzarella 2020-12-03 17:05 ` Stefano Garzarella 2020-12-07 5:29 ` Jason Wang 2020-12-07 5:29 ` Jason Wang 2020-12-09 11:07 ` Stefano Garzarella 2020-12-09 11:07 ` Stefano Garzarella 2020-12-15 11:43 ` Stefano Garzarella 2020-12-15 11:43 ` Stefano Garzarella 2020-12-03 17:05 ` [PATCH v3 14/19] vdpa_sim: add set_config " Stefano Garzarella 2020-12-03 17:05 ` Stefano Garzarella 2020-12-07 5:30 ` Jason Wang 2020-12-07 5:30 ` Jason Wang 2020-12-03 17:05 ` [PATCH v3 15/19] vdpa_sim: set vringh notify callback Stefano Garzarella 2020-12-03 17:05 ` Stefano Garzarella 2020-12-07 5:30 ` Jason Wang [this message] 2020-12-07 5:30 ` Jason Wang 2020-12-03 17:05 ` [PATCH v3 16/19] vdpa_sim: use kvmalloc to allocate vdpasim->buffer Stefano Garzarella 2020-12-03 17:05 ` Stefano Garzarella 2020-12-03 17:05 ` [PATCH v3 17/19] vdpa_sim: make vdpasim->buffer size configurable Stefano Garzarella 2020-12-03 17:05 ` Stefano Garzarella 2020-12-03 17:05 ` [PATCH v3 18/19] vdpa_sim: split vdpasim_virtqueue's iov field in out_iov and in_iov Stefano Garzarella 2020-12-03 17:05 ` Stefano Garzarella 2020-12-03 17:05 ` [PATCH v3 19/19] vdpa: split vdpasim to core and net modules Stefano Garzarella 2020-12-03 17:05 ` Stefano Garzarella 2020-12-03 17:25 ` Randy Dunlap 2020-12-03 17:25 ` Randy Dunlap 2020-12-04 7:48 ` Stefano Garzarella 2020-12-04 7:48 ` Stefano Garzarella 2020-12-07 5:33 ` Jason Wang 2020-12-07 5:33 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d9403e25-41a2-cfbe-efa9-8952b8e1b881@redhat.com \ --to=jasowang@redhat.com \ --cc=elic@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lvivier@redhat.com \ --cc=mgurtovoy@nvidia.com \ --cc=mst@redhat.com \ --cc=oren@nvidia.com \ --cc=sgarzare@redhat.com \ --cc=shahafs@nvidia.com \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.