* [PATCH] megaraid-sas: request irqs later
@ 2016-11-01 16:32 Tomas Henzl
2016-11-02 13:47 ` Sumit Saxena
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Tomas Henzl @ 2016-11-01 16:32 UTC (permalink / raw)
To: linux-scsi; +Cc: sumit.saxena, kashyap.desai
It is not good when an irq arrives before
driver structures are allocated.
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index c3efcc7255..e207410150 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -5155,11 +5155,6 @@ static int megasas_init_fw(struct megasas_instance *instance)
tasklet_init(&instance->isr_tasklet, instance->instancet->tasklet,
(unsigned long)instance);
- if (instance->msix_vectors ?
- megasas_setup_irqs_msix(instance, 1) :
- megasas_setup_irqs_ioapic(instance))
- goto fail_setup_irqs;
-
instance->ctrl_info = kzalloc(sizeof(struct megasas_ctrl_info),
GFP_KERNEL);
if (instance->ctrl_info == NULL)
@@ -5175,6 +5170,10 @@ static int megasas_init_fw(struct megasas_instance *instance)
if (instance->instancet->init_adapter(instance))
goto fail_init_adapter;
+ if (instance->msix_vectors ?
+ megasas_setup_irqs_msix(instance, 1) :
+ megasas_setup_irqs_ioapic(instance))
+ goto fail_init_adapter;
instance->instancet->enable_intr(instance);
@@ -5314,9 +5313,8 @@ static int megasas_init_fw(struct megasas_instance *instance)
fail_get_pd_list:
instance->instancet->disable_intr(instance);
-fail_init_adapter:
megasas_destroy_irqs(instance);
-fail_setup_irqs:
+fail_init_adapter:
if (instance->msix_vectors)
pci_disable_msix(instance->pdev);
instance->msix_vectors = 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH] megaraid-sas: request irqs later
2016-11-01 16:32 [PATCH] megaraid-sas: request irqs later Tomas Henzl
@ 2016-11-02 13:47 ` Sumit Saxena
2016-11-14 23:48 ` Martin K. Petersen
2016-11-17 1:20 ` Martin K. Petersen
2 siblings, 0 replies; 5+ messages in thread
From: Sumit Saxena @ 2016-11-02 13:47 UTC (permalink / raw)
To: Tomas Henzl, linux-scsi; +Cc: Kashyap Desai
>-----Original Message-----
>From: Tomas Henzl [mailto:thenzl@redhat.com]
>Sent: Tuesday, November 01, 2016 10:02 PM
>To: linux-scsi@vger.kernel.org
>Cc: sumit.saxena@broadcom.com; kashyap.desai@broadcom.com
>Subject: [PATCH] megaraid-sas: request irqs later
>
>It is not good when an irq arrives before driver structures are
allocated.
>
>Signed-off-by: Tomas Henzl <thenzl@redhat.com>
>---
> drivers/scsi/megaraid/megaraid_sas_base.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
>diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>b/drivers/scsi/megaraid/megaraid_sas_base.c
>index c3efcc7255..e207410150 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_base.c
>+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>@@ -5155,11 +5155,6 @@ static int megasas_init_fw(struct megasas_instance
>*instance)
> tasklet_init(&instance->isr_tasklet, instance->instancet->tasklet,
> (unsigned long)instance);
>
>- if (instance->msix_vectors ?
>- megasas_setup_irqs_msix(instance, 1) :
>- megasas_setup_irqs_ioapic(instance))
>- goto fail_setup_irqs;
>-
> instance->ctrl_info = kzalloc(sizeof(struct megasas_ctrl_info),
> GFP_KERNEL);
> if (instance->ctrl_info == NULL)
>@@ -5175,6 +5170,10 @@ static int megasas_init_fw(struct megasas_instance
>*instance)
> if (instance->instancet->init_adapter(instance))
> goto fail_init_adapter;
>
>+ if (instance->msix_vectors ?
>+ megasas_setup_irqs_msix(instance, 1) :
>+ megasas_setup_irqs_ioapic(instance))
>+ goto fail_init_adapter;
>
> instance->instancet->enable_intr(instance);
>
>@@ -5314,9 +5313,8 @@ static int megasas_init_fw(struct megasas_instance
>*instance)
>
> fail_get_pd_list:
> instance->instancet->disable_intr(instance);
>-fail_init_adapter:
> megasas_destroy_irqs(instance);
>-fail_setup_irqs:
>+fail_init_adapter:
> if (instance->msix_vectors)
> pci_disable_msix(instance->pdev);
> instance->msix_vectors = 0;
Looks good to me. Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
>--
>2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] megaraid-sas: request irqs later
2016-11-01 16:32 [PATCH] megaraid-sas: request irqs later Tomas Henzl
2016-11-02 13:47 ` Sumit Saxena
@ 2016-11-14 23:48 ` Martin K. Petersen
2016-11-15 10:29 ` Sumit Saxena
2016-11-17 1:20 ` Martin K. Petersen
2 siblings, 1 reply; 5+ messages in thread
From: Martin K. Petersen @ 2016-11-14 23:48 UTC (permalink / raw)
To: Tomas Henzl; +Cc: linux-scsi, sumit.saxena, kashyap.desai
>>>>> "Tomas" == Tomas Henzl <thenzl@redhat.com> writes:
Tomas> It is not good when an irq arrives before driver structures are
Tomas> allocated.
Sumit, Kashyap: Please review!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] megaraid-sas: request irqs later
2016-11-14 23:48 ` Martin K. Petersen
@ 2016-11-15 10:29 ` Sumit Saxena
0 siblings, 0 replies; 5+ messages in thread
From: Sumit Saxena @ 2016-11-15 10:29 UTC (permalink / raw)
To: Martin K. Petersen, Tomas Henzl; +Cc: linux-scsi, Kashyap Desai
>-----Original Message-----
>From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
>Sent: Tuesday, November 15, 2016 5:18 AM
>To: Tomas Henzl
>Cc: linux-scsi@vger.kernel.org; sumit.saxena@broadcom.com;
>kashyap.desai@broadcom.com
>Subject: Re: [PATCH] megaraid-sas: request irqs later
>
>>>>>> "Tomas" == Tomas Henzl <thenzl@redhat.com> writes:
>
>Tomas> It is not good when an irq arrives before driver structures are
>Tomas> allocated.
>
>Sumit, Kashyap: Please review!
Looks good.. I think I have acked this patch earlier also.
Acked-by: Sumit Saxena<sumit.saxena@broadcom.com>
>
>--
>Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] megaraid-sas: request irqs later
2016-11-01 16:32 [PATCH] megaraid-sas: request irqs later Tomas Henzl
2016-11-02 13:47 ` Sumit Saxena
2016-11-14 23:48 ` Martin K. Petersen
@ 2016-11-17 1:20 ` Martin K. Petersen
2 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2016-11-17 1:20 UTC (permalink / raw)
To: Tomas Henzl; +Cc: linux-scsi, sumit.saxena, kashyap.desai
>>>>> "Tomas" == Tomas Henzl <thenzl@redhat.com> writes:
Tomas> It is not good when an irq arrives before driver structures are
Tomas> allocated.
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-17 1:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-01 16:32 [PATCH] megaraid-sas: request irqs later Tomas Henzl
2016-11-02 13:47 ` Sumit Saxena
2016-11-14 23:48 ` Martin K. Petersen
2016-11-15 10:29 ` Sumit Saxena
2016-11-17 1:20 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.