All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>,
	"Andreas K. Hüttel" <dilfridge@gentoo.org>,
	qemu-devel@nongnu.org
Cc: "Alex Bennee" <alex.bennee@linaro.org>,
	"WANG Xuerui" <xen0n@gentoo.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH for-7.0 v5] qemu-binfmt-conf.sh: mips: allow nonzero EI_ABIVERSION, distinguish o32 and n32
Date: Tue, 29 Mar 2022 13:35:19 +0200	[thread overview]
Message-ID: <d9884a2e-8122-3863-3d13-4be2e5f6bc62@vivier.eu> (raw)
In-Reply-To: <e3a30b1a-69ab-9e69-4722-c8aa056a8c97@gmail.com>

Le 29/03/2022 à 01:39, Philippe Mathieu-Daudé a écrit :
> On 28/3/22 22:49, Andreas K. Hüttel wrote:
>> With the command line flag -mplt and a recent toolchain, ELF binaries
>> generated by gcc can obtain EI_ABIVERSION=1, which makes, e.g., gcc
>> three-stage bootstrap in a mips-unknown-linux-gnu qemu-user chroot
>> fail since the binfmt-misc magic does not match anymore. Also other
>> values are technically possible. qemu executes these binaries just
>> fine, so relax the mask for the EI_ABIVERSION byte at offset 0x08.
>>
>> In addition, extend magic string to distinguish mips o32 and n32 ABI.
>> This information is given by the EF_MIPS_ABI2 (0x20) bit in the
>> e_flags field of the ELF header (a 4-byte value at offset 0x24 for
>> the here applicable ELFCLASS32).
>>
>> See-also: ace3d65459
>> Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> Reviewed-by: WANG Xuerui <xen0n@gentoo.org>
> 
> v5 changes are too different from v4 to keep these R-b tags IMO.
> 
> LGTM but I'd like Xuerui to double-check the R-b stands,
> and an Acked-by from Laurent would make me feel safer ;)

Sorry, I didn't see your email before.
It's more mips than linux-user, so there is no problem for me.

Thanks,
Laurent



      parent reply	other threads:[~2022-03-29 11:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 20:49 [PATCH for-7.0 v5] qemu-binfmt-conf.sh: mips: allow nonzero EI_ABIVERSION, distinguish o32 and n32 Andreas K. Hüttel
2022-03-28 23:39 ` Philippe Mathieu-Daudé
2022-03-29  2:05   ` WANG Xuerui
2022-03-29 10:30     ` Philippe Mathieu-Daudé
2022-03-29 11:35   ` Laurent Vivier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9884a2e-8122-3863-3d13-4be2e5f6bc62@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=alex.bennee@linaro.org \
    --cc=dilfridge@gentoo.org \
    --cc=f4bug@amsat.org \
    --cc=philippe.mathieu.daude@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=xen0n@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.