From: Shreeya Patel <shreeya.patel@collabora.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: lars@metafoo.de, heiko@sntech.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
sebastian.reichel@collabora.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
gustavo.padovan@collabora.com, kernel@collabora.com,
serge.broslavsky@collabora.com, Simon Xue <xxm@rock-chips.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
andy.shevchenko@gmail.com
Subject: Re: [PATCH v3 2/8] iio: adc: rockchip_saradc: Add support for RK3588
Date: Sun, 4 Jun 2023 15:54:24 +0530 [thread overview]
Message-ID: <d9b1e05a-6b32-3033-cbc4-c87bda711e4d@collabora.com> (raw)
In-Reply-To: <20230604112043.43b1ada0@jic23-huawei>
On 04/06/23 15:50, Jonathan Cameron wrote:
> On Sat, 3 Jun 2023 23:48:00 +0300
> andy.shevchenko@gmail.com wrote:
>
>> Sun, Jun 04, 2023 at 12:23:34AM +0530, Shreeya Patel kirjoitti:
>>> From: Simon Xue <xxm@rock-chips.com>
>>>
>>> Add new start and read functions to support rk3588 device.
>>> Also, add a device compatible string for the same.
>> ...
>>
>>> +/* v2 registers */
>>> +#define SARADC2_CONV_CON 0x0
>>> +#define SARADC_T_PD_SOC 0x4
>>> +#define SARADC_T_DAS_SOC 0xc
>> Can you use fixed-width values for all registers?
>>
>> 0x000
>> 0x004
>> 0x00c
>>
>>> +#define SARADC2_END_INT_EN 0x104
>>> +#define SARADC2_ST_CON 0x108
>>> +#define SARADC2_STATUS 0x10c
>>> +#define SARADC2_END_INT_ST 0x110
>>> +#define SARADC2_DATA_BASE 0x120
> I tidied this up whilst applying.
Ah, I was just about to send a v4 with the change. Thank you for
making the changes.
Regards,
Shreeya Patel
> Jonathan
WARNING: multiple messages have this Message-ID (diff)
From: Shreeya Patel <shreeya.patel@collabora.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: lars@metafoo.de, heiko@sntech.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
sebastian.reichel@collabora.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
gustavo.padovan@collabora.com, kernel@collabora.com,
serge.broslavsky@collabora.com, Simon Xue <xxm@rock-chips.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
andy.shevchenko@gmail.com
Subject: Re: [PATCH v3 2/8] iio: adc: rockchip_saradc: Add support for RK3588
Date: Sun, 4 Jun 2023 15:54:24 +0530 [thread overview]
Message-ID: <d9b1e05a-6b32-3033-cbc4-c87bda711e4d@collabora.com> (raw)
In-Reply-To: <20230604112043.43b1ada0@jic23-huawei>
On 04/06/23 15:50, Jonathan Cameron wrote:
> On Sat, 3 Jun 2023 23:48:00 +0300
> andy.shevchenko@gmail.com wrote:
>
>> Sun, Jun 04, 2023 at 12:23:34AM +0530, Shreeya Patel kirjoitti:
>>> From: Simon Xue <xxm@rock-chips.com>
>>>
>>> Add new start and read functions to support rk3588 device.
>>> Also, add a device compatible string for the same.
>> ...
>>
>>> +/* v2 registers */
>>> +#define SARADC2_CONV_CON 0x0
>>> +#define SARADC_T_PD_SOC 0x4
>>> +#define SARADC_T_DAS_SOC 0xc
>> Can you use fixed-width values for all registers?
>>
>> 0x000
>> 0x004
>> 0x00c
>>
>>> +#define SARADC2_END_INT_EN 0x104
>>> +#define SARADC2_ST_CON 0x108
>>> +#define SARADC2_STATUS 0x10c
>>> +#define SARADC2_END_INT_ST 0x110
>>> +#define SARADC2_DATA_BASE 0x120
> I tidied this up whilst applying.
Ah, I was just about to send a v4 with the change. Thank you for
making the changes.
Regards,
Shreeya Patel
> Jonathan
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Shreeya Patel <shreeya.patel@collabora.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: lars@metafoo.de, heiko@sntech.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
sebastian.reichel@collabora.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
gustavo.padovan@collabora.com, kernel@collabora.com,
serge.broslavsky@collabora.com, Simon Xue <xxm@rock-chips.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
andy.shevchenko@gmail.com
Subject: Re: [PATCH v3 2/8] iio: adc: rockchip_saradc: Add support for RK3588
Date: Sun, 4 Jun 2023 15:54:24 +0530 [thread overview]
Message-ID: <d9b1e05a-6b32-3033-cbc4-c87bda711e4d@collabora.com> (raw)
In-Reply-To: <20230604112043.43b1ada0@jic23-huawei>
On 04/06/23 15:50, Jonathan Cameron wrote:
> On Sat, 3 Jun 2023 23:48:00 +0300
> andy.shevchenko@gmail.com wrote:
>
>> Sun, Jun 04, 2023 at 12:23:34AM +0530, Shreeya Patel kirjoitti:
>>> From: Simon Xue <xxm@rock-chips.com>
>>>
>>> Add new start and read functions to support rk3588 device.
>>> Also, add a device compatible string for the same.
>> ...
>>
>>> +/* v2 registers */
>>> +#define SARADC2_CONV_CON 0x0
>>> +#define SARADC_T_PD_SOC 0x4
>>> +#define SARADC_T_DAS_SOC 0xc
>> Can you use fixed-width values for all registers?
>>
>> 0x000
>> 0x004
>> 0x00c
>>
>>> +#define SARADC2_END_INT_EN 0x104
>>> +#define SARADC2_ST_CON 0x108
>>> +#define SARADC2_STATUS 0x10c
>>> +#define SARADC2_END_INT_ST 0x110
>>> +#define SARADC2_DATA_BASE 0x120
> I tidied this up whilst applying.
Ah, I was just about to send a v4 with the change. Thank you for
making the changes.
Regards,
Shreeya Patel
> Jonathan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-04 10:24 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-03 18:53 [PATCH v3 0/8] RK3588 ADC support Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` [PATCH v3 1/8] iio: adc: rockchip_saradc: Add callback functions Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` [PATCH v3 2/8] iio: adc: rockchip_saradc: Add support for RK3588 Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 20:48 ` andy.shevchenko
2023-06-03 20:48 ` andy.shevchenko
2023-06-03 20:48 ` andy.shevchenko
2023-06-04 10:20 ` Jonathan Cameron
2023-06-04 10:20 ` Jonathan Cameron
2023-06-04 10:20 ` Jonathan Cameron
2023-06-04 10:24 ` Shreeya Patel [this message]
2023-06-04 10:24 ` Shreeya Patel
2023-06-04 10:24 ` Shreeya Patel
2023-06-03 18:53 ` [PATCH v3 3/8] iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` [PATCH v3 4/8] iio: adc: rockchip_saradc: Use of_device_get_match_data Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` [PATCH v3 5/8] iio: adc: rockchip_saradc: Match alignment with open parenthesis Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` [PATCH v3 6/8] iio: adc: rockchip_saradc: Use dev_err_probe Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` [PATCH v3 7/8] arm64: dts: rockchip: Add DT node for ADC support in RK3588 Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` [PATCH v3 8/8] dt-bindings: iio: adc: Add rockchip,rk3588-saradc string Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 18:53 ` Shreeya Patel
2023-06-03 20:50 ` [PATCH v3 0/8] RK3588 ADC support andy.shevchenko
2023-06-03 20:50 ` andy.shevchenko
2023-06-03 20:50 ` andy.shevchenko
2023-06-04 10:27 ` Jonathan Cameron
2023-06-04 10:27 ` Jonathan Cameron
2023-06-04 10:27 ` Jonathan Cameron
2023-06-06 17:07 ` (subset) " Heiko Stuebner
2023-06-06 17:07 ` Heiko Stuebner
2023-06-06 17:07 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9b1e05a-6b32-3033-cbc4-c87bda711e4d@collabora.com \
--to=shreeya.patel@collabora.com \
--cc=andy.shevchenko@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.padovan@collabora.com \
--cc=heiko@sntech.de \
--cc=jic23@kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=serge.broslavsky@collabora.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.