* [PATCH] drm/vmwgfx: Fix memory leak in vmw_mksstat_add_ioctl()
@ 2022-09-16 20:47 Rafael Mendonca
2022-09-17 6:35 ` Martin Krastev (VMware)
0 siblings, 1 reply; 3+ messages in thread
From: Rafael Mendonca @ 2022-09-16 20:47 UTC (permalink / raw)
To: Zack Rusin, VMware Graphics Reviewers, David Airlie,
Daniel Vetter, Martin Krastev
Cc: Rafael Mendonca, dri-devel, linux-kernel
If the copy of the description string from userspace fails, then the page
for the instance descriptor doesn't get freed before returning -EFAULT,
which leads to a memleak.
Fixes: 7a7a933edd6c ("drm/vmwgfx: Introduce VMware mks-guest-stats")
Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
---
drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
index 2aceac7856e2..089046fa21be 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
@@ -1076,6 +1076,7 @@ int vmw_mksstat_add_ioctl(struct drm_device *dev, void *data,
if (desc_len < 0) {
atomic_set(&dev_priv->mksstat_user_pids[slot], 0);
+ __free_page(page);
return -EFAULT;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/vmwgfx: Fix memory leak in vmw_mksstat_add_ioctl()
2022-09-16 20:47 [PATCH] drm/vmwgfx: Fix memory leak in vmw_mksstat_add_ioctl() Rafael Mendonca
@ 2022-09-17 6:35 ` Martin Krastev (VMware)
0 siblings, 0 replies; 3+ messages in thread
From: Martin Krastev (VMware) @ 2022-09-17 6:35 UTC (permalink / raw)
To: Rafael Mendonca, Zack Rusin, VMware Graphics Reviewers,
David Airlie, Daniel Vetter, Martin Krastev
Cc: dri-devel, linux-kernel
Thank you for the catch!
Reviewed-by: Martin Krastev <krastevm@vmware.com>
Regards,
Martin
On 16.09.22 г. 23:47 ч., Rafael Mendonca wrote:
> If the copy of the description string from userspace fails, then the page
> for the instance descriptor doesn't get freed before returning -EFAULT,
> which leads to a memleak.
>
> Fixes: 7a7a933edd6c ("drm/vmwgfx: Introduce VMware mks-guest-stats")
> Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
> index 2aceac7856e2..089046fa21be 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
> @@ -1076,6 +1076,7 @@ int vmw_mksstat_add_ioctl(struct drm_device *dev, void *data,
>
> if (desc_len < 0) {
> atomic_set(&dev_priv->mksstat_user_pids[slot], 0);
> + __free_page(page);
> return -EFAULT;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/vmwgfx: Fix memory leak in vmw_mksstat_add_ioctl()
@ 2022-09-17 6:35 ` Martin Krastev (VMware)
0 siblings, 0 replies; 3+ messages in thread
From: Martin Krastev (VMware) @ 2022-09-17 6:35 UTC (permalink / raw)
To: Rafael Mendonca, Zack Rusin, VMware Graphics Reviewers,
David Airlie, Daniel Vetter, Martin Krastev
Cc: linux-kernel, dri-devel
Thank you for the catch!
Reviewed-by: Martin Krastev <krastevm@vmware.com>
Regards,
Martin
On 16.09.22 г. 23:47 ч., Rafael Mendonca wrote:
> If the copy of the description string from userspace fails, then the page
> for the instance descriptor doesn't get freed before returning -EFAULT,
> which leads to a memleak.
>
> Fixes: 7a7a933edd6c ("drm/vmwgfx: Introduce VMware mks-guest-stats")
> Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
> index 2aceac7856e2..089046fa21be 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
> @@ -1076,6 +1076,7 @@ int vmw_mksstat_add_ioctl(struct drm_device *dev, void *data,
>
> if (desc_len < 0) {
> atomic_set(&dev_priv->mksstat_user_pids[slot], 0);
> + __free_page(page);
> return -EFAULT;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-17 6:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-16 20:47 [PATCH] drm/vmwgfx: Fix memory leak in vmw_mksstat_add_ioctl() Rafael Mendonca
2022-09-17 6:35 ` Martin Krastev (VMware)
2022-09-17 6:35 ` Martin Krastev (VMware)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.