[PATCH v3] ext4/048: Add new regression test

[PATCH v3] ext4/048: Add new regression test

[chenlong]

Check the block group zero and prevent initializing reserved inodes.
But in some special cases, the reserved inode may not all belong to
the group zero, it may exist into the second group if we format 
filesystem below.
mkfs.ext4 -b 4096 -g 8192 -N 1024 -I 4096 /dev/sda
So, it will end up triggering a false positive report of a corrupted
file system

It's a regression test for commit a149d2a5cabb.

Signed-off-by: Chen Long <chenlongcl.chen@huawei.com>
---
 tests/ext4/048     | 60 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/ext4/048.out |  5 ++++
 tests/ext4/group   |  1 +
 3 files changed, 66 insertions(+)
 create mode 100755 tests/ext4/048
 create mode 100644 tests/ext4/048.out

diff --git a/tests/ext4/048 b/tests/ext4/048
new file mode 100755
index 00000000..fbbd229a
--- /dev/null
+++ b/tests/ext4/048
@@ -0,0 +1,60 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2021 Huawei.  All Rights Reserved.
+#
+# FS QA Test 048
+#
+# Regression test for commit:
+# a149d2a5cabb(ext4: fix check to prevent false positive report of incorrect
+# used inodes)
+#
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+    cd /
+    rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
+# real QA test starts here
+_supported_fs ext4
+_require_scratch
+
+# default sleep interval
+sleep_time=5
+
+echo "+ create scratch fs"
+_scratch_mkfs_ext4 -b 4096 -g 8192 -N 1024 -I 4096 >> $seqres.full 2>&1
+
+echo "+ mount fs"
+_scratch_mount -o errors=remount-ro
+# The default maximum wake-up delay of the lazy init thread of ext4 is
+# EXT4_DEF_LI_MAX_START_DELAY (5s).
+# After mounting the file system, the lazy init thread will be awakened to
+# perform group initialization at 0~5s after the current time. If an error
+# is detected during the initialization process, it will be set to read-only,
+# so the test case needs to delay a little while waiting for the init thread
+# to execute.
+sleep $sleep_time
+
+echo "+ check mountpoint status"
+cat /proc/self/mounts | grep -w ${SCRATCH_MNT} | \
+    $AWK_PROG '{print $4}' | grep -oE '^rw,' | tee -a $seqres.full
+
+# success, all done
+status=0
+exit
diff --git a/tests/ext4/048.out b/tests/ext4/048.out
new file mode 100644
index 00000000..16e50e86
--- /dev/null
+++ b/tests/ext4/048.out
@@ -0,0 +1,5 @@
+QA output created by 048
++ create scratch fs
++ mount fs
++ check mountpoint status
+rw,
diff --git a/tests/ext4/group b/tests/ext4/group
index ceda2ba6..82b77efb 100644
--- a/tests/ext4/group
+++ b/tests/ext4/group
@@ -50,6 +50,7 @@
 045 auto dir
 046 auto prealloc quick
 047 auto quick dax
+048 auto quick
 271 auto rw quick
 301 aio auto ioctl rw stress defrag
 302 aio auto ioctl rw stress defrag
-- 
2.18.0.huawei.25

Re: [PATCH v3] ext4/048: Add new regression test

[Darrick J. Wong]

On Fri, May 21, 2021 at 08:00:38PM +0800, chenlong wrote:
> Check the block group zero and prevent initializing reserved inodes.
> But in some special cases, the reserved inode may not all belong to
> the group zero, it may exist into the second group if we format 
> filesystem below.
> mkfs.ext4 -b 4096 -g 8192 -N 1024 -I 4096 /dev/sda
> So, it will end up triggering a false positive report of a corrupted
> file system
> 
> It's a regression test for commit a149d2a5cabb.
> 
> Signed-off-by: Chen Long <chenlongcl.chen@huawei.com>
> ---
>  tests/ext4/048     | 60 ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/ext4/048.out |  5 ++++
>  tests/ext4/group   |  1 +
>  3 files changed, 66 insertions(+)
>  create mode 100755 tests/ext4/048
>  create mode 100644 tests/ext4/048.out
> 
> diff --git a/tests/ext4/048 b/tests/ext4/048
> new file mode 100755
> index 00000000..fbbd229a
> --- /dev/null
> +++ b/tests/ext4/048
> @@ -0,0 +1,60 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2021 Huawei.  All Rights Reserved.
> +#
> +# FS QA Test 048
> +#
> +# Regression test for commit:
> +# a149d2a5cabb(ext4: fix check to prevent false positive report of incorrect
> +# used inodes)
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1	# failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> +    cd /
> +    rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# remove previous $seqres.full before test
> +rm -f $seqres.full
> +
> +# real QA test starts here
> +_supported_fs ext4
> +_require_scratch
> +
> +# default sleep interval
> +sleep_time=5
> +
> +echo "+ create scratch fs"
> +_scratch_mkfs_ext4 -b 4096 -g 8192 -N 1024 -I 4096 >> $seqres.full 2>&1
> +
> +echo "+ mount fs"
> +_scratch_mount -o errors=remount-ro
> +# The default maximum wake-up delay of the lazy init thread of ext4 is
> +# EXT4_DEF_LI_MAX_START_DELAY (5s).
> +# After mounting the file system, the lazy init thread will be awakened to
> +# perform group initialization at 0~5s after the current time. If an error
> +# is detected during the initialization process, it will be set to read-only,
> +# so the test case needs to delay a little while waiting for the init thread
> +# to execute.
> +sleep $sleep_time
> +
> +echo "+ check mountpoint status"
> +cat /proc/self/mounts | grep -w ${SCRATCH_MNT} | \
> +    $AWK_PROG '{print $4}' | grep -oE '^rw,' | tee -a $seqres.full

Er, sorry to be a pain yet again, but I think the critical part of the
above line is checking that the mount is still in read-write mode,
correct?

If that's the case, couldn't this test check the writability of the
mountpoint?  e.g.

test -w $SCRATCH_MNT || echo "scratch mount should still be writable"

(Or is there some other complication here, such as a crashed ext4 fs
will return EROFS and then `test' does the wrong thing, hence the manual
check of /proc/self/mounts?)

--D

> +
> +# success, all done
> +status=0
> +exit
> diff --git a/tests/ext4/048.out b/tests/ext4/048.out
> new file mode 100644
> index 00000000..16e50e86
> --- /dev/null
> +++ b/tests/ext4/048.out
> @@ -0,0 +1,5 @@
> +QA output created by 048
> ++ create scratch fs
> ++ mount fs
> ++ check mountpoint status
> +rw,
> diff --git a/tests/ext4/group b/tests/ext4/group
> index ceda2ba6..82b77efb 100644
> --- a/tests/ext4/group
> +++ b/tests/ext4/group
> @@ -50,6 +50,7 @@
>  045 auto dir
>  046 auto prealloc quick
>  047 auto quick dax
> +048 auto quick
>  271 auto rw quick
>  301 aio auto ioctl rw stress defrag
>  302 aio auto ioctl rw stress defrag
> -- 
> 2.18.0.huawei.25
> 

Re: [PATCH v3] ext4/048: Add new regression test

[Chenlong (H)]

On 2021/5/21 23:14:40, Darrick J. Wong wrote:
> On Fri, May 21, 2021 at 08:00:38PM +0800, chenlong wrote:
>> Check the block group zero and prevent initializing reserved inodes.
>> But in some special cases, the reserved inode may not all belong to
>> the group zero, it may exist into the second group if we format
>> filesystem below.
>> mkfs.ext4 -b 4096 -g 8192 -N 1024 -I 4096 /dev/sda
>> So, it will end up triggering a false positive report of a corrupted
>> file system
>>
>> It's a regression test for commit a149d2a5cabb.
>>
>> Signed-off-by: Chen Long <chenlongcl.chen@huawei.com>
>> ---
>>   tests/ext4/048     | 60 ++++++++++++++++++++++++++++++++++++++++++++++
>>   tests/ext4/048.out |  5 ++++
>>   tests/ext4/group   |  1 +
>>   3 files changed, 66 insertions(+)
>>   create mode 100755 tests/ext4/048
>>   create mode 100644 tests/ext4/048.out
>>
>> diff --git a/tests/ext4/048 b/tests/ext4/048
>> new file mode 100755
>> index 00000000..fbbd229a
>> --- /dev/null
>> +++ b/tests/ext4/048
>> @@ -0,0 +1,60 @@
>> +#! /bin/bash
>> +# SPDX-License-Identifier: GPL-2.0
>> +# Copyright (c) 2021 Huawei.  All Rights Reserved.
>> +#
>> +# FS QA Test 048
>> +#
>> +# Regression test for commit:
>> +# a149d2a5cabb(ext4: fix check to prevent false positive report of incorrect
>> +# used inodes)
>> +#
>> +seq=`basename $0`
>> +seqres=$RESULT_DIR/$seq
>> +echo "QA output created by $seq"
>> +
>> +here=`pwd`
>> +tmp=/tmp/$$
>> +status=1	# failure is the default!
>> +trap "_cleanup; exit \$status" 0 1 2 3 15
>> +
>> +_cleanup()
>> +{
>> +    cd /
>> +    rm -f $tmp.*
>> +}
>> +
>> +# get standard environment, filters and checks
>> +. ./common/rc
>> +. ./common/filter
>> +
>> +# remove previous $seqres.full before test
>> +rm -f $seqres.full
>> +
>> +# real QA test starts here
>> +_supported_fs ext4
>> +_require_scratch
>> +
>> +# default sleep interval
>> +sleep_time=5
>> +
>> +echo "+ create scratch fs"
>> +_scratch_mkfs_ext4 -b 4096 -g 8192 -N 1024 -I 4096 >> $seqres.full 2>&1
>> +
>> +echo "+ mount fs"
>> +_scratch_mount -o errors=remount-ro
>> +# The default maximum wake-up delay of the lazy init thread of ext4 is
>> +# EXT4_DEF_LI_MAX_START_DELAY (5s).
>> +# After mounting the file system, the lazy init thread will be awakened to
>> +# perform group initialization at 0~5s after the current time. If an error
>> +# is detected during the initialization process, it will be set to read-only,
>> +# so the test case needs to delay a little while waiting for the init thread
>> +# to execute.
>> +sleep $sleep_time
>> +
>> +echo "+ check mountpoint status"
>> +cat /proc/self/mounts | grep -w ${SCRATCH_MNT} | \
>> +    $AWK_PROG '{print $4}' | grep -oE '^rw,' | tee -a $seqres.full
> 
> Er, sorry to be a pain yet again, but I think the critical part of the
> above line is checking that the mount is still in read-write mode,
> correct?
> 
> If that's the case, couldn't this test check the writability of the
> mountpoint?  e.g.
> 
> test -w $SCRATCH_MNT || echo "scratch mount should still be writable"
> 
> (Or is there some other complication here, such as a crashed ext4 fs
> will return EROFS and then `test' does the wrong thing, hence the manual
> check of /proc/self/mounts?)
> 
> --D
> 

It is necessary to strengthen checkpoints. when this bug is not fixed,
the phenomenon of the file system is that it is successfully mounted
first after new formated, and then automatically remounted as read-only.
so i think the checkpoint of this test case must observe this process.
thence add the following two checkpoints.

echo "+ check mountpoint writability"
test -w $SCRATCH_MNT || echo "scratch mount should still be writable"
echo "+ check dmesg"
_check_dmesg_for "\(${sdev}\): Remounting filesystem read-only" && \
     echo "scratch dev should not be remounted to read-only"
if this bug not fixed, Then there must be get a remount log in dmesg.

thank you for your review.

>> +
>> +# success, all done
>> +status=0
>> +exit
>> diff --git a/tests/ext4/048.out b/tests/ext4/048.out
>> new file mode 100644
>> index 00000000..16e50e86
>> --- /dev/null
>> +++ b/tests/ext4/048.out
>> @@ -0,0 +1,5 @@
>> +QA output created by 048
>> ++ create scratch fs
>> ++ mount fs
>> ++ check mountpoint status
>> +rw,
>> diff --git a/tests/ext4/group b/tests/ext4/group
>> index ceda2ba6..82b77efb 100644
>> --- a/tests/ext4/group
>> +++ b/tests/ext4/group
>> @@ -50,6 +50,7 @@
>>   045 auto dir
>>   046 auto prealloc quick
>>   047 auto quick dax
>> +048 auto quick
>>   271 auto rw quick
>>   301 aio auto ioctl rw stress defrag
>>   302 aio auto ioctl rw stress defrag
>> -- 
>> 2.18.0.huawei.25
>>
> .
>