All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jyri Sarha <jsarha@ti.com>
To: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	bcousson@baylibre.com, tony@atomide.com,
	linux-arm-kernel@lists.infradead.org
Cc: peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
	kbeldan@baylibre.com, laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v4 5/8] ARM: dts: am335x-boneblack: Add blue-and-red-wiring -property to LCDC node
Date: Thu, 15 Sep 2016 12:44:25 +0300	[thread overview]
Message-ID: <d9dcc43b-6884-aab1-ff82-c66ecf6e96b6@ti.com> (raw)
In-Reply-To: <fad833a6a4368196f4fc131a54d90f5b90169393.1472719892.git.jsarha@ti.com>

Tony,
The functional changes are now merged. But let's not merge this bbb dts
patch just yet, so we do not cause a conflict with the other bbb hdmi
audio dts change[1] that slipped into tda998x pull request. The patch
can very well wait until v4.10 if needed.

However, the other three dts patches[2] can be merged. Should I rebase
those on top of some branch and resend them?

Best regards,
Jyri

[1] https://lists.freedesktop.org/archives/dri-devel/2016-August/115269.html

[2]
https://lists.freedesktop.org/archives/dri-devel/2016-September/117282.html
https://lists.freedesktop.org/archives/dri-devel/2016-September/117283.html
https://lists.freedesktop.org/archives/dri-devel/2016-September/117284.html

On 09/01/16 12:09, Jyri Sarha wrote:
> Add blue-and-red-wiring -property to LCDC node. Also adds comments on
> how to get support 24 bit RGB mode. After this patch am335x-boneblack
> support RGB565, BGR888, and XBGR8888 color formats. See details in
> Documentation/devicetree/bindings/display/tilcdc/tilcdc.txt.
> 
> The BBB has straight color wiring from am335x to tda19988, however the
> tda19988 can be configured to cross the blue and red wires. The
> comments show how to do that with video-ports property of tda19988
> node and how to tell LCDC that blue and red wires are crossed, with
> blue-and-red-wiring LCDC node property. This changes supported color
> formats from 16 bit RGB and 24 bit BGR to 16 bit BGR and 24 bit RGB.
> 
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> ---
>  arch/arm/boot/dts/am335x-boneblack.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts
> index 528559b..a32d73a 100644
> --- a/arch/arm/boot/dts/am335x-boneblack.dts
> +++ b/arch/arm/boot/dts/am335x-boneblack.dts
> @@ -90,6 +90,14 @@
>  
>  &lcdc {
>  	status = "okay";
> +
> +	/* If you want to get 24 bit RGB and 16 BGR mode instead of
> +	 * current 16 bit RGB and 24 BGR modes, set the propety
> +	 * below to "crossed" and uncomment the video-ports -property
> +	 * in tda19988 node.
> +	 */
> +	blue-and-red-wiring = "straight";
> +
>  	port {
>  		lcdc_0: endpoint@0 {
>  			remote-endpoint = <&hdmi_0>;
> @@ -106,6 +114,9 @@
>  		pinctrl-0 = <&nxp_hdmi_bonelt_pins>;
>  		pinctrl-1 = <&nxp_hdmi_bonelt_off_pins>;
>  
> +		/* Convert 24bit BGR to RGB, e.g. cross red and blue wiring */
> +		/* video-ports = <0x234501>; */
> +
>  		#sound-dai-cells = <0>;
>  		audio-ports = <	TDA998x_I2S	0x03>;
>  
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: jsarha@ti.com (Jyri Sarha)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/8] ARM: dts: am335x-boneblack: Add blue-and-red-wiring -property to LCDC node
Date: Thu, 15 Sep 2016 12:44:25 +0300	[thread overview]
Message-ID: <d9dcc43b-6884-aab1-ff82-c66ecf6e96b6@ti.com> (raw)
In-Reply-To: <fad833a6a4368196f4fc131a54d90f5b90169393.1472719892.git.jsarha@ti.com>

Tony,
The functional changes are now merged. But let's not merge this bbb dts
patch just yet, so we do not cause a conflict with the other bbb hdmi
audio dts change[1] that slipped into tda998x pull request. The patch
can very well wait until v4.10 if needed.

However, the other three dts patches[2] can be merged. Should I rebase
those on top of some branch and resend them?

Best regards,
Jyri

[1] https://lists.freedesktop.org/archives/dri-devel/2016-August/115269.html

[2]
https://lists.freedesktop.org/archives/dri-devel/2016-September/117282.html
https://lists.freedesktop.org/archives/dri-devel/2016-September/117283.html
https://lists.freedesktop.org/archives/dri-devel/2016-September/117284.html

On 09/01/16 12:09, Jyri Sarha wrote:
> Add blue-and-red-wiring -property to LCDC node. Also adds comments on
> how to get support 24 bit RGB mode. After this patch am335x-boneblack
> support RGB565, BGR888, and XBGR8888 color formats. See details in
> Documentation/devicetree/bindings/display/tilcdc/tilcdc.txt.
> 
> The BBB has straight color wiring from am335x to tda19988, however the
> tda19988 can be configured to cross the blue and red wires. The
> comments show how to do that with video-ports property of tda19988
> node and how to tell LCDC that blue and red wires are crossed, with
> blue-and-red-wiring LCDC node property. This changes supported color
> formats from 16 bit RGB and 24 bit BGR to 16 bit BGR and 24 bit RGB.
> 
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> ---
>  arch/arm/boot/dts/am335x-boneblack.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts
> index 528559b..a32d73a 100644
> --- a/arch/arm/boot/dts/am335x-boneblack.dts
> +++ b/arch/arm/boot/dts/am335x-boneblack.dts
> @@ -90,6 +90,14 @@
>  
>  &lcdc {
>  	status = "okay";
> +
> +	/* If you want to get 24 bit RGB and 16 BGR mode instead of
> +	 * current 16 bit RGB and 24 BGR modes, set the propety
> +	 * below to "crossed" and uncomment the video-ports -property
> +	 * in tda19988 node.
> +	 */
> +	blue-and-red-wiring = "straight";
> +
>  	port {
>  		lcdc_0: endpoint at 0 {
>  			remote-endpoint = <&hdmi_0>;
> @@ -106,6 +114,9 @@
>  		pinctrl-0 = <&nxp_hdmi_bonelt_pins>;
>  		pinctrl-1 = <&nxp_hdmi_bonelt_off_pins>;
>  
> +		/* Convert 24bit BGR to RGB, e.g. cross red and blue wiring */
> +		/* video-ports = <0x234501>; */
> +
>  		#sound-dai-cells = <0>;
>  		audio-ports = <	TDA998x_I2S	0x03>;
>  
> 

  reply	other threads:[~2016-09-15  9:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01  9:09 [PATCH v4 0/8] drm/tilcdc: Address LCDC rev 2 color errata + other fixes Jyri Sarha
2016-09-01  9:09 ` Jyri Sarha
2016-09-01  9:09 ` [PATCH v4 1/8] drm/tilcdc: Remove drm_helper_disable_unused_functions() call Jyri Sarha
2016-09-01  9:09   ` Jyri Sarha
2016-09-01  9:09 ` [PATCH v4 2/8] drm/tilcdc: Write DMA base and ceiling address with single instruction Jyri Sarha
2016-09-01  9:09   ` Jyri Sarha
2016-09-01  9:09 ` [PATCH v4 3/8] drm/tilcdc: Add blue-and-red-crossed devicetree property Jyri Sarha
2016-09-01  9:09   ` Jyri Sarha
2016-09-12 12:58   ` Rob Herring
2016-09-12 12:58     ` Rob Herring
2016-09-01  9:09 ` [PATCH v4 4/8] drm/tilcdc: Choose console BPP that supports RGB Jyri Sarha
2016-09-01  9:09   ` Jyri Sarha
2016-09-01  9:09 ` [PATCH v4 5/8] ARM: dts: am335x-boneblack: Add blue-and-red-wiring -property to LCDC node Jyri Sarha
2016-09-01  9:09   ` Jyri Sarha
2016-09-15  9:44   ` Jyri Sarha [this message]
2016-09-15  9:44     ` Jyri Sarha
     [not found]     ` <d9dcc43b-6884-aab1-ff82-c66ecf6e96b6-l0cyMroinI0@public.gmane.org>
2016-09-15 19:22       ` Tony Lindgren
2016-09-15 19:22         ` Tony Lindgren
2016-09-01  9:09 ` [PATCH v4 6/8] ARM: dts: am335x-evm: Add blue-and-red-wiring -property to lcdc node Jyri Sarha
2016-09-01  9:09   ` Jyri Sarha
2016-09-01  9:09 ` [PATCH v4 7/8] ARM: dts: am335x-evmsk: Whitespace cleanup of lcdc related nodes Jyri Sarha
2016-09-01  9:09   ` Jyri Sarha
2016-09-01  9:09 ` [PATCH v4 8/8] ARM: dts: am335x-evmsk: Add blue-and-red-wiring -property to lcdc node Jyri Sarha
2016-09-01  9:09   ` Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9dcc43b-6884-aab1-ff82-c66ecf6e96b6@ti.com \
    --to=jsarha@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kbeldan@baylibre.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.