From: "Wang, Haiyue" <haiyue.wang@linux.intel.com>
To: Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed@lists.ozlabs.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
Date: Fri, 25 May 2018 19:33:42 +0800 [thread overview]
Message-ID: <d9f9bd48-7b2c-9f48-0515-50e0a5e55259@linux.intel.com> (raw)
In-Reply-To: <CACPK8Xdhmrwfj6tGZ_o_JeoxdOii_5OD5oz80FJFRasvGd1L9w@mail.gmail.com>
Hi Joel & Andrew
This patch is out of date. ;-)
New: https://patchwork.ozlabs.org/patch/893720/
On 2018-05-25 12:34, Joel Stanley wrote:
> Hello Andrew,
>
> On 16 March 2018 at 11:17, Wang, Haiyue <haiyue.wang@linux.intel.com> wrote:
>> Hi Joel and Andrew,
>>
>> Have time to review this patch ? Hope for your comments. :-)
>>
>> BR,
>> Haiyue
>>
>>
>> On 2018-03-07 13:04, Haiyue Wang wrote:
>>> The IPMI KCS device part of the LPC interface and is used for
>>> communication with the host processor.
>>>
>>> Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
> Do you have time to take a look at these? The device tree doesn't make
> sense to me.
>
> Cheers,
>
> Joel
>
>>> ---
>>> arch/arm/boot/dts/aspeed-g5.dtsi | 43
>>> +++++++++++++++++++++++++++++++++++++++-
>>> 1 file changed, 42 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi
>>> b/arch/arm/boot/dts/aspeed-g5.dtsi
>>> index 8eac57c..f443169 100644
>>> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
>>> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
>>> @@ -267,8 +267,40 @@
>>> ranges = <0x0 0x1e789000 0x1000>;
>>> lpc_bmc: lpc-bmc@0 {
>>> - compatible =
>>> "aspeed,ast2500-lpc-bmc";
>>> + compatible =
>>> "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
>>> reg = <0x0 0x80>;
>>> + reg-io-width = <4>;
>>> +
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + ranges = <0x0 0x0 0x80>;
>>> +
>>> + kcs1: kcs1@0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0x80>;
>>> + interrupts = <8>;
>>> + kcs_chan = <1>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> +
>>> + kcs2: kcs2@0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0x80>;
>>> + interrupts = <8>;
>>> + kcs_chan = <2>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> +
>>> + kcs3: kcs3@0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0x80>;
>>> + interrupts = <8>;
>>> + kcs_chan = <3>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> };
>>> lpc_host: lpc-host@80 {
>>> @@ -294,6 +326,15 @@
>>> status = "disabled";
>>> };
>>> + kcs4: kcs4@0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0xa0>;
>>> + interrupts = <8>;
>>> + kcs_chan = <4>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> +
>>> lhc: lhc@20 {
>>> compatible =
>>> "aspeed,ast2500-lhc";
>>> reg = <0x20 0x24 0x48
>>> 0x8>;
>>
WARNING: multiple messages have this Message-ID (diff)
From: haiyue.wang@linux.intel.com (Wang, Haiyue)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
Date: Fri, 25 May 2018 19:33:42 +0800 [thread overview]
Message-ID: <d9f9bd48-7b2c-9f48-0515-50e0a5e55259@linux.intel.com> (raw)
In-Reply-To: <CACPK8Xdhmrwfj6tGZ_o_JeoxdOii_5OD5oz80FJFRasvGd1L9w@mail.gmail.com>
Hi Joel & Andrew
This patch is out of date. ;-)
New: https://patchwork.ozlabs.org/patch/893720/
On 2018-05-25 12:34, Joel Stanley wrote:
> Hello Andrew,
>
> On 16 March 2018 at 11:17, Wang, Haiyue <haiyue.wang@linux.intel.com> wrote:
>> Hi Joel and Andrew,
>>
>> Have time to review this patch ? Hope for your comments. :-)
>>
>> BR,
>> Haiyue
>>
>>
>> On 2018-03-07 13:04, Haiyue Wang wrote:
>>> The IPMI KCS device part of the LPC interface and is used for
>>> communication with the host processor.
>>>
>>> Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
> Do you have time to take a look at these? The device tree doesn't make
> sense to me.
>
> Cheers,
>
> Joel
>
>>> ---
>>> arch/arm/boot/dts/aspeed-g5.dtsi | 43
>>> +++++++++++++++++++++++++++++++++++++++-
>>> 1 file changed, 42 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi
>>> b/arch/arm/boot/dts/aspeed-g5.dtsi
>>> index 8eac57c..f443169 100644
>>> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
>>> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
>>> @@ -267,8 +267,40 @@
>>> ranges = <0x0 0x1e789000 0x1000>;
>>> lpc_bmc: lpc-bmc at 0 {
>>> - compatible =
>>> "aspeed,ast2500-lpc-bmc";
>>> + compatible =
>>> "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
>>> reg = <0x0 0x80>;
>>> + reg-io-width = <4>;
>>> +
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + ranges = <0x0 0x0 0x80>;
>>> +
>>> + kcs1: kcs1 at 0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0x80>;
>>> + interrupts = <8>;
>>> + kcs_chan = <1>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> +
>>> + kcs2: kcs2 at 0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0x80>;
>>> + interrupts = <8>;
>>> + kcs_chan = <2>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> +
>>> + kcs3: kcs3 at 0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0x80>;
>>> + interrupts = <8>;
>>> + kcs_chan = <3>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> };
>>> lpc_host: lpc-host at 80 {
>>> @@ -294,6 +326,15 @@
>>> status = "disabled";
>>> };
>>> + kcs4: kcs4 at 0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0xa0>;
>>> + interrupts = <8>;
>>> + kcs_chan = <4>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> +
>>> lhc: lhc at 20 {
>>> compatible =
>>> "aspeed,ast2500-lhc";
>>> reg = <0x20 0x24 0x48
>>> 0x8>;
>>
next prev parent reply other threads:[~2018-05-25 11:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 5:04 [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node Haiyue Wang
2018-03-07 5:04 ` Haiyue Wang
2018-03-16 0:47 ` Wang, Haiyue
2018-03-16 0:47 ` Wang, Haiyue
2018-05-25 4:34 ` Joel Stanley
2018-05-25 4:34 ` Joel Stanley
2018-05-25 11:33 ` Wang, Haiyue [this message]
2018-05-25 11:33 ` Wang, Haiyue
-- strict thread matches above, loose matches on Subject: below --
2018-03-04 5:03 Haiyue Wang
2018-03-07 3:56 ` Joel Stanley
2018-03-07 3:56 ` Joel Stanley
2018-03-07 4:41 ` Wang, Haiyue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9f9bd48-7b2c-9f48-0515-50e0a5e55259@linux.intel.com \
--to=haiyue.wang@linux.intel.com \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.