All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] exfat: replace 'time_ms' with 'time_cs'
@ 2020-04-16  8:51 ` Tetsuhiro Kohada
  2020-04-17  2:39   ` Namjae Jeon
  0 siblings, 1 reply; 6+ messages in thread
From: Tetsuhiro Kohada @ 2020-04-16  8:51 UTC (permalink / raw)
  To: Kohada.Tetsuhiro
  Cc: Mori.Takahiro, motai.hirotaka, Namjae Jeon, Sungjong Seo,
	linux-fsdevel, linux-kernel

Replace "time_ms"  with "time_cs" in the file directory entry structure
and related functions.

The unit of create_time_ms/modify_time_ms in File Directory Entry are not
'milli-second', but 'centi-second'.
The exfat specification uses the term '10ms', but instead use 'cs' as in
"msdos_fs.h".

Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
---
Changes in v3:
 - change time_10ms to time_cs
 - revert calculation formula to original
 - change subject & commit-log
 - rebase to 'linkinjeon/exfat.git' dev branch 
Changes in v2:
 - fix spelling mistakes in commit-log.

fs/exfat/dir.c       |  8 ++++----
 fs/exfat/exfat_fs.h  |  4 ++--
 fs/exfat/exfat_raw.h |  4 ++--
 fs/exfat/file.c      |  2 +-
 fs/exfat/inode.c     |  4 ++--
 fs/exfat/misc.c      | 18 +++++++++---------
 fs/exfat/namei.c     |  4 ++--
 7 files changed, 22 insertions(+), 22 deletions(-)

diff --git a/fs/exfat/dir.c b/fs/exfat/dir.c
index 53ae965da..b5a237c33 100644
--- a/fs/exfat/dir.c
+++ b/fs/exfat/dir.c
@@ -137,12 +137,12 @@ static int exfat_readdir(struct inode *inode, struct exfat_dir_entry *dir_entry)
 					ep->dentry.file.create_tz,
 					ep->dentry.file.create_time,
 					ep->dentry.file.create_date,
-					ep->dentry.file.create_time_ms);
+					ep->dentry.file.create_time_cs);
 			exfat_get_entry_time(sbi, &dir_entry->mtime,
 					ep->dentry.file.modify_tz,
 					ep->dentry.file.modify_time,
 					ep->dentry.file.modify_date,
-					ep->dentry.file.modify_time_ms);
+					ep->dentry.file.modify_time_cs);
 			exfat_get_entry_time(sbi, &dir_entry->atime,
 					ep->dentry.file.access_tz,
 					ep->dentry.file.access_time,
@@ -461,12 +461,12 @@ int exfat_init_dir_entry(struct inode *inode, struct exfat_chain *p_dir,
 			&ep->dentry.file.create_tz,
 			&ep->dentry.file.create_time,
 			&ep->dentry.file.create_date,
-			&ep->dentry.file.create_time_ms);
+			&ep->dentry.file.create_time_cs);
 	exfat_set_entry_time(sbi, &ts,
 			&ep->dentry.file.modify_tz,
 			&ep->dentry.file.modify_time,
 			&ep->dentry.file.modify_date,
-			&ep->dentry.file.modify_time_ms);
+			&ep->dentry.file.modify_time_cs);
 	exfat_set_entry_time(sbi, &ts,
 			&ep->dentry.file.access_tz,
 			&ep->dentry.file.access_time,
diff --git a/fs/exfat/exfat_fs.h b/fs/exfat/exfat_fs.h
index 4ced4c0d9..f619b9250 100644
--- a/fs/exfat/exfat_fs.h
+++ b/fs/exfat/exfat_fs.h
@@ -511,9 +511,9 @@ void exfat_msg(struct super_block *sb, const char *lv, const char *fmt, ...)
 	exfat_msg(sb, KERN_INFO, fmt, ##__VA_ARGS__)
 
 void exfat_get_entry_time(struct exfat_sb_info *sbi, struct timespec64 *ts,
-		u8 tz, __le16 time, __le16 date, u8 time_ms);
+		u8 tz, __le16 time, __le16 date, u8 time_cs);
 void exfat_set_entry_time(struct exfat_sb_info *sbi, struct timespec64 *ts,
-		u8 *tz, __le16 *time, __le16 *date, u8 *time_ms);
+		u8 *tz, __le16 *time, __le16 *date, u8 *time_cs);
 unsigned short exfat_calc_chksum_2byte(void *data, int len,
 		unsigned short chksum, int type);
 void exfat_update_bh(struct super_block *sb, struct buffer_head *bh, int sync);
diff --git a/fs/exfat/exfat_raw.h b/fs/exfat/exfat_raw.h
index 2a841010e..8d6c64a75 100644
--- a/fs/exfat/exfat_raw.h
+++ b/fs/exfat/exfat_raw.h
@@ -136,8 +136,8 @@ struct exfat_dentry {
 			__le16 modify_date;
 			__le16 access_time;
 			__le16 access_date;
-			__u8 create_time_ms;
-			__u8 modify_time_ms;
+			__u8 create_time_cs;
+			__u8 modify_time_cs;
 			__u8 create_tz;
 			__u8 modify_tz;
 			__u8 access_tz;
diff --git a/fs/exfat/file.c b/fs/exfat/file.c
index 483f68375..5eff50afd 100644
--- a/fs/exfat/file.c
+++ b/fs/exfat/file.c
@@ -165,7 +165,7 @@ int __exfat_truncate(struct inode *inode, loff_t new_size)
 				&ep->dentry.file.modify_tz,
 				&ep->dentry.file.modify_time,
 				&ep->dentry.file.modify_date,
-				&ep->dentry.file.modify_time_ms);
+				&ep->dentry.file.modify_time_cs);
 		ep->dentry.file.attr = cpu_to_le16(ei->attr);
 
 		/* File size should be zero if there is no cluster allocated */
diff --git a/fs/exfat/inode.c b/fs/exfat/inode.c
index 06887492f..3f367d081 100644
--- a/fs/exfat/inode.c
+++ b/fs/exfat/inode.c
@@ -56,12 +56,12 @@ static int __exfat_write_inode(struct inode *inode, int sync)
 			&ep->dentry.file.create_tz,
 			&ep->dentry.file.create_time,
 			&ep->dentry.file.create_date,
-			&ep->dentry.file.create_time_ms);
+			&ep->dentry.file.create_time_cs);
 	exfat_set_entry_time(sbi, &inode->i_mtime,
 			&ep->dentry.file.modify_tz,
 			&ep->dentry.file.modify_time,
 			&ep->dentry.file.modify_date,
-			&ep->dentry.file.modify_time_ms);
+			&ep->dentry.file.modify_time_cs);
 	exfat_set_entry_time(sbi, &inode->i_atime,
 			&ep->dentry.file.access_tz,
 			&ep->dentry.file.access_time,
diff --git a/fs/exfat/misc.c b/fs/exfat/misc.c
index d32beb172..0d521ca24 100644
--- a/fs/exfat/misc.c
+++ b/fs/exfat/misc.c
@@ -75,7 +75,7 @@ static void exfat_adjust_tz(struct timespec64 *ts, u8 tz_off)
 
 /* Convert a EXFAT time/date pair to a UNIX date (seconds since 1 1 70). */
 void exfat_get_entry_time(struct exfat_sb_info *sbi, struct timespec64 *ts,
-		u8 tz, __le16 time, __le16 date, u8 time_ms)
+		u8 tz, __le16 time, __le16 date, u8 time_cs)
 {
 	u16 t = le16_to_cpu(time);
 	u16 d = le16_to_cpu(date);
@@ -84,10 +84,10 @@ void exfat_get_entry_time(struct exfat_sb_info *sbi, struct timespec64 *ts,
 			      t >> 11, (t >> 5) & 0x003F, (t & 0x001F) << 1);
 
 
-	/* time_ms field represent 0 ~ 199(1990 ms) */
-	if (time_ms) {
-		ts->tv_sec += time_ms / 100;
-		ts->tv_nsec = (time_ms % 100) * 10 * NSEC_PER_MSEC;
+	/* time_cs field represent 0 ~ 199cs(1990 ms) */
+	if (time_cs) {
+		ts->tv_sec += time_cs / 100;
+		ts->tv_nsec = (time_cs % 100) * 10 * NSEC_PER_MSEC;
 	}
 
 	if (tz & EXFAT_TZ_VALID)
@@ -100,7 +100,7 @@ void exfat_get_entry_time(struct exfat_sb_info *sbi, struct timespec64 *ts,
 
 /* Convert linear UNIX date to a EXFAT time/date pair. */
 void exfat_set_entry_time(struct exfat_sb_info *sbi, struct timespec64 *ts,
-		u8 *tz, __le16 *time, __le16 *date, u8 *time_ms)
+		u8 *tz, __le16 *time, __le16 *date, u8 *time_cs)
 {
 	struct tm tm;
 	u16 t, d;
@@ -112,9 +112,9 @@ void exfat_set_entry_time(struct exfat_sb_info *sbi, struct timespec64 *ts,
 	*time = cpu_to_le16(t);
 	*date = cpu_to_le16(d);
 
-	/* time_ms field represent 0 ~ 199(1990 ms) */
-	if (time_ms)
-		*time_ms = (tm.tm_sec & 1) * 100 +
+	/* time_cs field represent 0 ~ 199cs(1990 ms) */
+	if (time_cs)
+		*time_cs = (tm.tm_sec & 1) * 100 +
 			ts->tv_nsec / (10 * NSEC_PER_MSEC);
 
 	/*
diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c
index 549274fef..27c0fe5c1 100644
--- a/fs/exfat/namei.c
+++ b/fs/exfat/namei.c
@@ -687,12 +687,12 @@ static int exfat_find(struct inode *dir, struct qstr *qname,
 				ep->dentry.file.create_tz,
 				ep->dentry.file.create_time,
 				ep->dentry.file.create_date,
-				ep->dentry.file.create_time_ms);
+				ep->dentry.file.create_time_cs);
 		exfat_get_entry_time(sbi, &info->mtime,
 				ep->dentry.file.modify_tz,
 				ep->dentry.file.modify_time,
 				ep->dentry.file.modify_date,
-				ep->dentry.file.modify_time_ms);
+				ep->dentry.file.modify_time_cs);
 		exfat_get_entry_time(sbi, &info->atime,
 				ep->dentry.file.access_tz,
 				ep->dentry.file.access_time,
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* RE: [PATCH v3] exfat: replace 'time_ms' with 'time_cs'
  2020-04-16  8:51 ` [PATCH v3] exfat: replace 'time_ms' with 'time_cs' Tetsuhiro Kohada
@ 2020-04-17  2:39   ` Namjae Jeon
  2020-04-20  1:31     ` Tetsuhiro Kohada
  0 siblings, 1 reply; 6+ messages in thread
From: Namjae Jeon @ 2020-04-17  2:39 UTC (permalink / raw)
  To: 'Tetsuhiro Kohada'
  Cc: Mori.Takahiro, motai.hirotaka, 'Sungjong Seo',
	linux-fsdevel, linux-kernel

> Replace "time_ms"  with "time_cs" in the file directory entry structure
> and related functions.
> 
> The unit of create_time_ms/modify_time_ms in File Directory Entry are not
> 'milli-second', but 'centi-second'.
> The exfat specification uses the term '10ms', but instead use 'cs' as in
> "msdos_fs.h".
> 
> Signed-off-by: Tetsuhiro Kohada
> <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
> ---
I have run checkpatch.pl on your patch.
It give a following warning.

WARNING: Missing Signed-off-by: line by nominal patch author 'Tetsuhiro
Kohada <Kohada.Tetsuhiro@dc.mitsubishielectric.co.jp>'
total: 0 errors, 1 warnings, 127 lines checked

Please fix it.
Thanks!


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v3] exfat: replace 'time_ms' with 'time_cs'
  2020-04-17  2:39   ` Namjae Jeon
@ 2020-04-20  1:31     ` Tetsuhiro Kohada
  2020-04-20  2:51       ` Namjae Jeon
  0 siblings, 1 reply; 6+ messages in thread
From: Tetsuhiro Kohada @ 2020-04-20  1:31 UTC (permalink / raw)
  To: Namjae Jeon, 'Tetsuhiro Kohada'
  Cc: Mori.Takahiro, motai.hirotaka, 'Sungjong Seo',
	linux-fsdevel, linux-kernel

On 2020/04/17 11:39, Namjae Jeon wrote:
>> Replace "time_ms"  with "time_cs" in the file directory entry structure
>> and related functions.
>>
>> The unit of create_time_ms/modify_time_ms in File Directory Entry are not
>> 'milli-second', but 'centi-second'.
>> The exfat specification uses the term '10ms', but instead use 'cs' as in
>> "msdos_fs.h".
>>
>> Signed-off-by: Tetsuhiro Kohada
>> <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
>> ---
> I have run checkpatch.pl on your patch.
> It give a following warning.
> 
> WARNING: Missing Signed-off-by: line by nominal patch author 'Tetsuhiro
> Kohada <Kohada.Tetsuhiro@dc.mitsubishielectric.co.jp>'
> total: 0 errors, 1 warnings, 127 lines checked
> 
> Please fix it.

I want to fix it, but I'm not sure what's wrong.
The my patch has the following line:

Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>

Both my real name and email address are correct.
Can you give me some advice?

*** Currently I can't use office email, so I'm sending it from private email instead.


-- 
このEメールはアバスト アンチウイルスによりウイルススキャンされています。
https://www.avast.com/antivirus


^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH v3] exfat: replace 'time_ms' with 'time_cs'
  2020-04-20  1:31     ` Tetsuhiro Kohada
@ 2020-04-20  2:51       ` Namjae Jeon
  2020-04-20  8:10         ` AW: " Schmid, Carsten
  2020-04-20 22:32         ` Tetsuhiro Kohada
  0 siblings, 2 replies; 6+ messages in thread
From: Namjae Jeon @ 2020-04-20  2:51 UTC (permalink / raw)
  To: 'Tetsuhiro Kohada', 'Tetsuhiro Kohada'
  Cc: Mori.Takahiro, motai.hirotaka, 'Sungjong Seo',
	linux-fsdevel, linux-kernel

> On 2020/04/17 11:39, Namjae Jeon wrote:
> >> Replace "time_ms"  with "time_cs" in the file directory entry
> >> structure and related functions.
> >>
> >> The unit of create_time_ms/modify_time_ms in File Directory Entry are
> >> not 'milli-second', but 'centi-second'.
> >> The exfat specification uses the term '10ms', but instead use 'cs' as
> >> in "msdos_fs.h".
> >>
> >> Signed-off-by: Tetsuhiro Kohada
> >> <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
> >> ---
> > I have run checkpatch.pl on your patch.
> > It give a following warning.
> >
> > WARNING: Missing Signed-off-by: line by nominal patch author
> > 'Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.mitsubishielectric.co.jp>'
> > total: 0 errors, 1 warnings, 127 lines checked
> >
> > Please fix it.
> 
> I want to fix it, but I'm not sure what's wrong.
> The my patch has the following line:
> 
> Signed-off-by: Tetsuhiro Kohada
> <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
> 
> Both my real name and email address are correct.
> Can you give me some advice?
Your address in author line of this patch seems to be different with Your Signed-off-by.

From: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.mitsubishielectric.co.jp>
!=
Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>

What is correct one between the two?
I guess you should fix your mail address in your .gitconfig
Or manually add From: your address under subject in your patch like this.
-------------------------------------------------------------------------------
Subject: [PATCH v3] exfat: replace 'time_ms' with 'time_cs'
From: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>

Replace "time_ms"  with "time_cs" in the file directory entry structure
and related functions.

The unit of create_time_ms/modify_time_ms in File Directory Entry are not
'milli-second', but 'centi-second'.
The exfat specification uses the term '10ms', but instead use 'cs' as in
"msdos_fs.

Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
--------------------------------------------------------------------------------

> 
> *** Currently I can't use office email, so I'm sending it from private
> email instead.
> 
> 
> --
> このEメールはアバスト アンチウイルスによりウイルススキャンされています。
> https://www.avast.com/antivirus




^ permalink raw reply	[flat|nested] 6+ messages in thread
* AW: [PATCH v3] exfat: replace 'time_ms' with 'time_cs'
  2020-04-20  2:51       ` Namjae Jeon
@ 2020-04-20  8:10         ` Schmid, Carsten
  2020-04-20 22:32         ` Tetsuhiro Kohada
  1 sibling, 0 replies; 6+ messages in thread
From: Schmid, Carsten @ 2020-04-20  8:10 UTC (permalink / raw)
  To: Namjae Jeon, 'Tetsuhiro Kohada', 'Tetsuhiro Kohada'
  Cc: Mori.Takahiro, motai.hirotaka, 'Sungjong Seo',
	linux-fsdevel, linux-kernel

>
> From: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.mitsubishielectric.co.jp>
> !=
> Signed-off-by: Tetsuhiro Kohada
> <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
>
MitsubishiElectric != mitsubishielectric

Capital letters matter????

-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v3] exfat: replace 'time_ms' with 'time_cs'
  2020-04-20  2:51       ` Namjae Jeon
  2020-04-20  8:10         ` AW: " Schmid, Carsten
@ 2020-04-20 22:32         ` Tetsuhiro Kohada
  1 sibling, 0 replies; 6+ messages in thread
From: Tetsuhiro Kohada @ 2020-04-20 22:32 UTC (permalink / raw)
  To: Namjae Jeon, 'Tetsuhiro Kohada'
  Cc: Mori.Takahiro, motai.hirotaka, 'Sungjong Seo',
	linux-fsdevel, linux-kernel

Thanks for your advise.

On 2020/04/20 11:51, Namjae Jeon wrote:
>> Can you give me some advice?
> Your address in author line of this patch seems to be different with Your Signed-off-by.
> 
> From: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.mitsubishielectric.co.jp>
> !=
> Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
> 
> What is correct one between the two?

"dc.MitsubishiElectric.co.jp" is the correct domain name.

> I guess you should fix your mail address in your .gitconfig
> Or manually add From: your address under subject in your patch like this.

Both user.email of .gitconfig and from field in patch use "dc.MitsubishiElectric.co.jp".
I don't know why it changed to lower case.

For now, change to private gmail and post again.

Thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-20 22:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20200416085144epcas1p1527b8df86453c7566b1a4d5a85689e69@epcas1p1.samsung.com>
2020-04-16  8:51 ` [PATCH v3] exfat: replace 'time_ms' with 'time_cs' Tetsuhiro Kohada
2020-04-17  2:39   ` Namjae Jeon
2020-04-20  1:31     ` Tetsuhiro Kohada
2020-04-20  2:51       ` Namjae Jeon
2020-04-20  8:10         ` AW: " Schmid, Carsten
2020-04-20 22:32         ` Tetsuhiro Kohada

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.