All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Any reason AID is not in the NL80211_STA_INFO enumeration?
Date: Tue, 03 Mar 2020 15:08:51 +0100	[thread overview]
Message-ID: <da15dc015f2992a702cc585c510e009a83b8fdb1.camel@sipsolutions.net> (raw)
In-Reply-To: <29006a9e-4de2-1733-1a8a-a5aae686fd42@candelatech.com>

On Fri, 2020-02-28 at 07:26 -0800, Ben Greear wrote:
> 
> On 02/28/2020 02:06 AM, Johannes Berg wrote:
> > On Mon, 2020-02-17 at 17:11 -0800, Ben Greear wrote:
> > > To sniff /AX stations, it is helpful to know their AID.  So, any problems
> > > with adding it to 'iw station dump' output?
> > 
> > No, no problem at all. I guess it was just never added because it
> > originally comes from userspace (hostapd), and so didn't really need to
> > be sent back. But yeah, we have trivial infrastructure to send it back,
> > so sure, why not.
> 
> Ok, thanks for the response.
> 
>  From looking at debugfs for a station device, there is the netdev AID:
> 
> cat /debug/ieee80211/wiphy0/netdev\:wlan0/aid
> 1
> 
> And there is a peer AID:
> 
> cat /debug/ieee80211/wiphy0/netdev\:wlan0/stations/04\:f0\:21\:c2\:fd\:b0/aid
> 0
> 
> For sniffing AX, I'd need to use '1' here as far as I can tell.  Maybe for station
> devices the peer is always zero?  And for AP devices, the peer IDs are what is useful
> and the netdev AID is not?

Yeah. The first is u.mgd.aid (i.e. the netdev data), and the latter is
the STA AID.

It makes sense the latter is not assigned in the client-side case.

Arguably, only the *latter* should be in nl80211 per STA, since in the
client-side case it's *our* AID, not the APs.

johannes


  reply	other threads:[~2020-03-03 14:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18  1:11 Any reason AID is not in the NL80211_STA_INFO enumeration? Ben Greear
2020-02-28 10:06 ` Johannes Berg
2020-02-28 15:26   ` Ben Greear
2020-03-03 14:08     ` Johannes Berg [this message]
2020-03-03 14:57       ` Ben Greear
2020-03-03 14:59         ` Johannes Berg
2020-03-03 15:02           ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da15dc015f2992a702cc585c510e009a83b8fdb1.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.