* [PATCH] target/s390x: fix meson.build issue
@ 2020-08-21 15:52 Paolo Bonzini
2020-08-21 18:07 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2020-08-21 15:52 UTC (permalink / raw)
To: qemu-devel; +Cc: cohuck, philmd
files() is needed to avoid
../meson.build:977:2: ERROR: File tcg-stub.c does not exist.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/s390x/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/meson.build b/target/s390x/meson.build
index d2a3315903..c42eadb7d2 100644
--- a/target/s390x/meson.build
+++ b/target/s390x/meson.build
@@ -21,7 +21,7 @@ s390x_ss.add(when: 'CONFIG_TCG', if_true: files(
'vec_helper.c',
'vec_int_helper.c',
'vec_string_helper.c',
-), if_false: 'tcg-stub.c')
+), if_false: files('tcg-stub.c'))
s390x_ss.add(when: 'CONFIG_KVM', if_true: files('kvm.c'), if_false: files('kvm-stub.c'))
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] target/s390x: fix meson.build issue
2020-08-21 15:52 [PATCH] target/s390x: fix meson.build issue Paolo Bonzini
@ 2020-08-21 18:07 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-08-21 18:07 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: cohuck
On 8/21/20 5:52 PM, Paolo Bonzini wrote:
> files() is needed to avoid
>
> ../meson.build:977:2: ERROR: File tcg-stub.c does not exist.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> target/s390x/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/meson.build b/target/s390x/meson.build
> index d2a3315903..c42eadb7d2 100644
> --- a/target/s390x/meson.build
> +++ b/target/s390x/meson.build
> @@ -21,7 +21,7 @@ s390x_ss.add(when: 'CONFIG_TCG', if_true: files(
> 'vec_helper.c',
> 'vec_int_helper.c',
> 'vec_string_helper.c',
> -), if_false: 'tcg-stub.c')
> +), if_false: files('tcg-stub.c'))
>
> s390x_ss.add(when: 'CONFIG_KVM', if_true: files('kvm.c'), if_false: files('kvm-stub.c'))
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-21 18:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-21 15:52 [PATCH] target/s390x: fix meson.build issue Paolo Bonzini
2020-08-21 18:07 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.