[U-Boot] [RFC PATCH] Kconfig: cmd: Make networking command dependent on NET

[U-Boot] [RFC PATCH] Kconfig: cmd: Make networking command dependent on NET

[Michal Simek]

Enable networking command only when NET is enabled.
And remove selecting NET for CMD_NET

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

There is a huge impact on defconfigs because of select NET.
But this change makes sense to do but it just needs to be syncup
properly. Do we have a tool for this kind of change?

---
 cmd/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 790c40456de5..aedfd03c68ef 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -970,9 +970,10 @@ endmenu
 
 menu "Network commands"
 
+if NET
+
 config CMD_NET
 	bool "bootp, tftpboot"
-        select NET
 	default y
 	help
 	  Network commands.
@@ -1049,6 +1050,8 @@ config CMD_ETHSW
 	  operations such as enabling / disabling a port and
 	  viewing/maintaining the filtering database (FDB)
 
+endif
+
 endmenu
 
 menu "Misc commands"
-- 
1.9.1

[U-Boot] [U-Boot, RFC] Kconfig: cmd: Make networking command dependent on NET

[Tom Rini]

On Tue, Feb 06, 2018 at 01:26:52PM +0100, Michal Simek wrote:

> Enable networking command only when NET is enabled.
> And remove selecting NET for CMD_NET
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

I tried taking this, but as-is, now we have a big problem due to
"everyone" getting NET selected here.  Making NET default y fixes _most_
things except for the following boards that blow up related to EFI
loader:
   aarch64:  +   thunderx_88xx
       arm:  +   at91sam9rlek_mmc warp zynq_zc770_xm011_x16 mx23evk bcm23550_w1d s5pc210_univer
sal cairo topic_miamilite omap3_pandora topic_miami origen bcm28155_ap tricorder zynq_zc770_xm0
11 tricorder_flash s5p_goni trats aspenite at91sam9rlek_nandflash trats2 at91sam9rlek_dataflash

At this point, I'm going to defer this back to you.  I think the concept
of the patch is right but it needs a bit more work.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180214/ee0cf912/attachment.sig>

[U-Boot] [U-Boot, RFC] Kconfig: cmd: Make networking command dependent on NET

[Michal Simek]

Hi Tom,

On 14.2.2018 21:41, Tom Rini wrote:
> On Tue, Feb 06, 2018 at 01:26:52PM +0100, Michal Simek wrote:
> 
>> Enable networking command only when NET is enabled.
>> And remove selecting NET for CMD_NET
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> 
> I tried taking this, but as-is, now we have a big problem due to
> "everyone" getting NET selected here.  Making NET default y fixes _most_
> things except for the following boards that blow up related to EFI
> loader:
>    aarch64:  +   thunderx_88xx
>        arm:  +   at91sam9rlek_mmc warp zynq_zc770_xm011_x16 mx23evk bcm23550_w1d s5pc210_univer
> sal cairo topic_miamilite omap3_pandora topic_miami origen bcm28155_ap tricorder zynq_zc770_xm0
> 11 tricorder_flash s5p_goni trats aspenite at91sam9rlek_nandflash trats2 at91sam9rlek_dataflash
> 
> At this point, I'm going to defer this back to you.  I think the concept
> of the patch is right but it needs a bit more work.  Thanks!
> 

I have sent v2 of this with fixing above boards. I expect you have nice
system for building. If there is any issue please let me know I will
look at that boards.

Thanks,
Michal