From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Thierry Reding <thierry.reding@gmail.com>, Sam Ravnborg <sam@ravnborg.org>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch> Cc: Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Vinod Koul <vkoul@kernel.org> Subject: Re: [PATCH 1/3] drm/mipi-dsi: pass DSC data through the struct mipi_dsi_device Date: Wed, 15 Jun 2022 15:04:16 +0300 [thread overview] Message-ID: <da71cb6c-7512-d187-6ec0-d2d1a4eeaeba@linaro.org> (raw) In-Reply-To: <20220501151220.3999164-2-dmitry.baryshkov@linaro.org> On 01/05/2022 18:12, Dmitry Baryshkov wrote: > The commit 0f40ba48de3b ("drm/msm/dsi: Pass DSC params to drm_panel") > added a pointer to the DSC data to the struct drm_panel. However DSC > support is not limited to the DSI panels. MIPI DSI bridges can also > consume DSC command streams. Thus add struct drm_dsc_config pointer to > the struct mipi_dsi_device. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Gracious ping for the review from the drm core > --- > include/drm/drm_mipi_dsi.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 147e51b6d241..8b1c9be9b2a7 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -177,6 +177,7 @@ struct mipi_dsi_device_info { > * @lp_rate: maximum lane frequency for low power mode in hertz, this should > * be set to the real limits of the hardware, zero is only accepted for > * legacy drivers > + * @dsc: panel/bridge DSC pps payload to be sent > */ > struct mipi_dsi_device { > struct mipi_dsi_host *host; > @@ -189,6 +190,7 @@ struct mipi_dsi_device { > unsigned long mode_flags; > unsigned long hs_rate; > unsigned long lp_rate; > + struct drm_dsc_config *dsc; > }; > > #define MIPI_DSI_MODULE_PREFIX "mipi-dsi:" -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Thierry Reding <thierry.reding@gmail.com>, Sam Ravnborg <sam@ravnborg.org>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch> Cc: Vinod Koul <vkoul@kernel.org>, linux-arm-msm@vger.kernel.org, Abhinav Kumar <quic_abhinavk@quicinc.com>, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH 1/3] drm/mipi-dsi: pass DSC data through the struct mipi_dsi_device Date: Wed, 15 Jun 2022 15:04:16 +0300 [thread overview] Message-ID: <da71cb6c-7512-d187-6ec0-d2d1a4eeaeba@linaro.org> (raw) In-Reply-To: <20220501151220.3999164-2-dmitry.baryshkov@linaro.org> On 01/05/2022 18:12, Dmitry Baryshkov wrote: > The commit 0f40ba48de3b ("drm/msm/dsi: Pass DSC params to drm_panel") > added a pointer to the DSC data to the struct drm_panel. However DSC > support is not limited to the DSI panels. MIPI DSI bridges can also > consume DSC command streams. Thus add struct drm_dsc_config pointer to > the struct mipi_dsi_device. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Gracious ping for the review from the drm core > --- > include/drm/drm_mipi_dsi.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 147e51b6d241..8b1c9be9b2a7 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -177,6 +177,7 @@ struct mipi_dsi_device_info { > * @lp_rate: maximum lane frequency for low power mode in hertz, this should > * be set to the real limits of the hardware, zero is only accepted for > * legacy drivers > + * @dsc: panel/bridge DSC pps payload to be sent > */ > struct mipi_dsi_device { > struct mipi_dsi_host *host; > @@ -189,6 +190,7 @@ struct mipi_dsi_device { > unsigned long mode_flags; > unsigned long hs_rate; > unsigned long lp_rate; > + struct drm_dsc_config *dsc; > }; > > #define MIPI_DSI_MODULE_PREFIX "mipi-dsi:" -- With best wishes Dmitry
next prev parent reply other threads:[~2022-06-15 12:04 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-01 15:12 [PATCH 0/3] drm: move dsc data pointer from drm_panel to mipi_dsi_device Dmitry Baryshkov 2022-05-01 15:12 ` Dmitry Baryshkov 2022-05-01 15:12 ` [PATCH 1/3] drm/mipi-dsi: pass DSC data through the struct mipi_dsi_device Dmitry Baryshkov 2022-05-01 15:12 ` Dmitry Baryshkov 2022-06-15 12:04 ` Dmitry Baryshkov [this message] 2022-06-15 12:04 ` Dmitry Baryshkov 2022-05-01 15:12 ` [PATCH 2/3] drm/msm/dsi: fetch DSC pps payload from " Dmitry Baryshkov 2022-05-01 15:12 ` Dmitry Baryshkov 2022-05-01 15:12 ` [PATCH 3/3] drm/panel: drop DSC pps pointer Dmitry Baryshkov 2022-05-01 15:12 ` Dmitry Baryshkov 2022-05-04 13:04 ` [PATCH 0/3] drm: move dsc data pointer from drm_panel to mipi_dsi_device Vinod Koul 2022-05-04 13:04 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=da71cb6c-7512-d187-6ec0-d2d1a4eeaeba@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sam@ravnborg.org \ --cc=thierry.reding@gmail.com \ --cc=tzimmermann@suse.de \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.