All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikita Yushchenko <nikita.yushchenko@virtuozzo.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it, kernel@openvz.org, linux-nfs@vger.kernel.org,
	Steve Dickson <SteveD@redhat.com>, NeilBrown <neilb@suse.de>
Subject: Re: [PATCH] rpc_lib.sh: fix portmapper detection in case of socket activation
Date: Fri, 21 Jan 2022 07:57:49 +0300	[thread overview]
Message-ID: <da777e8f-ca8a-e1c6-d005-792114b78f84@virtuozzo.com> (raw)
In-Reply-To: <YenNsuS1gcA9tDe3@pevik>

21.01.2022 00:01, Petr Vorel wrote:
> Hi Nikita,
> 
> [ Cc: Steve as user-space maintainer, also Neil and whole linux-nfs ]
> 
>> On systemd-based linux hosts, rpcbind service is typically started via
>> socket activation, when the first client connects. If no client has
>> connected before LTP rpc test starts, rpcbind process will not be
>> running at the time of check_portmap_rpcbind() execution, causing
>> check_portmap_rpcbind() to report TCONF error.
> 
>> Fix that by adding a quiet invocation of 'rpcinfo' before checking for
>> rpcbind.
> 
> Looks reasonable, but I'd prefer to have confirmation from NFS experts.

NFS is not involved here, this is about sunrpc tests.

I had to add this patch to make 'runltp -f net.rpc' pass just after container is started - that happens 
in container autotests here.

Nikita

WARNING: multiple messages have this Message-ID (diff)
From: Nikita Yushchenko via ltp <ltp@lists.linux.it>
To: Petr Vorel <pvorel@suse.cz>
Cc: NeilBrown <neilb@suse.de>,
	linux-nfs@vger.kernel.org, kernel@openvz.org,
	Steve Dickson <SteveD@redhat.com>,
	ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] rpc_lib.sh: fix portmapper detection in case of socket activation
Date: Fri, 21 Jan 2022 07:57:49 +0300	[thread overview]
Message-ID: <da777e8f-ca8a-e1c6-d005-792114b78f84@virtuozzo.com> (raw)
In-Reply-To: <YenNsuS1gcA9tDe3@pevik>

21.01.2022 00:01, Petr Vorel wrote:
> Hi Nikita,
> 
> [ Cc: Steve as user-space maintainer, also Neil and whole linux-nfs ]
> 
>> On systemd-based linux hosts, rpcbind service is typically started via
>> socket activation, when the first client connects. If no client has
>> connected before LTP rpc test starts, rpcbind process will not be
>> running at the time of check_portmap_rpcbind() execution, causing
>> check_portmap_rpcbind() to report TCONF error.
> 
>> Fix that by adding a quiet invocation of 'rpcinfo' before checking for
>> rpcbind.
> 
> Looks reasonable, but I'd prefer to have confirmation from NFS experts.

NFS is not involved here, this is about sunrpc tests.

I had to add this patch to make 'runltp -f net.rpc' pass just after container is started - that happens 
in container autotests here.

Nikita

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-01-21  4:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-20 14:37 [LTP] [PATCH] rpc_lib.sh: fix portmapper detection in case of socket activation Nikita Yushchenko via ltp
2022-01-20 21:01 ` Petr Vorel
2022-01-20 21:01   ` [LTP] " Petr Vorel
2022-01-21  4:57   ` Nikita Yushchenko [this message]
2022-01-21  4:57     ` Nikita Yushchenko via ltp
2022-01-21  5:29     ` Petr Vorel
2022-01-21  5:29       ` [LTP] " Petr Vorel
2022-01-21  5:41       ` Nikita Yushchenko
2022-01-21  5:41         ` [LTP] " Nikita Yushchenko via ltp
2022-01-21  6:30         ` Petr Vorel
2022-01-21  6:30           ` [LTP] " Petr Vorel
2022-01-21  6:50           ` Nikita Yushchenko
2022-01-21  6:50             ` [LTP] " Nikita Yushchenko via ltp
2022-01-21 20:44   ` NeilBrown
2022-01-21 20:44     ` [LTP] " NeilBrown
2022-01-24  6:09     ` Petr Vorel
2022-01-24  6:09       ` [LTP] " Petr Vorel
2022-01-24 21:11 ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da777e8f-ca8a-e1c6-d005-792114b78f84@virtuozzo.com \
    --to=nikita.yushchenko@virtuozzo.com \
    --cc=SteveD@redhat.com \
    --cc=kernel@openvz.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=ltp@lists.linux.it \
    --cc=neilb@suse.de \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.