* [PATCH 1/1] usb: typec: altmodes/displayport: reorder dp_altmode_configured()
@ 2021-10-06 4:32 ` lindsey.stanpoor
0 siblings, 0 replies; 8+ messages in thread
From: lindsey.stanpoor @ 2021-10-06 4:32 UTC (permalink / raw)
To: intel-gfx, linux-usb; +Cc: hdegoede, heikki.krogerus, gregkh, cnemo
From: Cameron Nemo <cnemo@tutanota.com>
A recent commit [1] introduced an unintended behavioral change by
reordering certain function calls. The sysfs_notify call for
pin_assignment should only be invoked when the dp_altmode_notify call
returns 0, and in the dp->data.conf == 0 case.
[1] https://lore.kernel.org/r/20210817215201.795062-8-hdegoede@redhat.com
Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
---
drivers/usb/typec/altmodes/displayport.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
index c1d8c23baa39..a15ae78066e3 100644
--- a/drivers/usb/typec/altmodes/displayport.c
+++ b/drivers/usb/typec/altmodes/displayport.c
@@ -154,10 +154,17 @@ static int dp_altmode_status_update(struct dp_altmode *dp)
static int dp_altmode_configured(struct dp_altmode *dp)
{
+ int ret;
+
sysfs_notify(&dp->alt->dev.kobj, "displayport", "configuration");
+
+ ret = dp_altmode_notify(dp);
+ if (ret || !dp->data.conf)
+ return ret;
+
sysfs_notify(&dp->alt->dev.kobj, "displayport", "pin_assignment");
- return dp_altmode_notify(dp);
+ return 0;
}
static int dp_altmode_configure_vdm(struct dp_altmode *dp, u32 conf)
--
2.33.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH 1/1] usb: typec: altmodes/displayport: reorder dp_altmode_configured()
@ 2021-10-06 4:32 ` lindsey.stanpoor
0 siblings, 0 replies; 8+ messages in thread
From: lindsey.stanpoor @ 2021-10-06 4:32 UTC (permalink / raw)
To: intel-gfx, linux-usb; +Cc: hdegoede, heikki.krogerus, gregkh, cnemo
From: Cameron Nemo <cnemo@tutanota.com>
A recent commit [1] introduced an unintended behavioral change by
reordering certain function calls. The sysfs_notify call for
pin_assignment should only be invoked when the dp_altmode_notify call
returns 0, and in the dp->data.conf == 0 case.
[1] https://lore.kernel.org/r/20210817215201.795062-8-hdegoede@redhat.com
Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
---
drivers/usb/typec/altmodes/displayport.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
index c1d8c23baa39..a15ae78066e3 100644
--- a/drivers/usb/typec/altmodes/displayport.c
+++ b/drivers/usb/typec/altmodes/displayport.c
@@ -154,10 +154,17 @@ static int dp_altmode_status_update(struct dp_altmode *dp)
static int dp_altmode_configured(struct dp_altmode *dp)
{
+ int ret;
+
sysfs_notify(&dp->alt->dev.kobj, "displayport", "configuration");
+
+ ret = dp_altmode_notify(dp);
+ if (ret || !dp->data.conf)
+ return ret;
+
sysfs_notify(&dp->alt->dev.kobj, "displayport", "pin_assignment");
- return dp_altmode_notify(dp);
+ return 0;
}
static int dp_altmode_configure_vdm(struct dp_altmode *dp, u32 conf)
--
2.33.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] usb: typec: altmodes/displayport: reorder dp_altmode_configured()
2021-10-06 4:32 ` [Intel-gfx] " lindsey.stanpoor
(?)
@ 2021-10-06 9:36 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-10-06 9:36 UTC (permalink / raw)
To: lindsey.stanpoor; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 7773 bytes --]
== Series Details ==
Series: series starting with [1/1] usb: typec: altmodes/displayport: reorder dp_altmode_configured()
URL : https://patchwork.freedesktop.org/series/95499/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10687 -> Patchwork_21263
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/index.html
Known issues
------------
Here are the changes found in Patchwork_21263 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-tgl-1115g4: NOTRUN -> [SKIP][1] ([fdo#109315])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-tgl-1115g4/igt@amdgpu/amd_basic@query-info.html
* igt@amdgpu/amd_cs_nop@nop-gfx0:
- fi-tgl-1115g4: NOTRUN -> [SKIP][2] ([fdo#109315] / [i915#2575]) +16 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-tgl-1115g4/igt@amdgpu/amd_cs_nop@nop-gfx0.html
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-snb-2600: NOTRUN -> [SKIP][3] ([fdo#109271]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-snb-2600/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-soraka: [PASS][4] -> [INCOMPLETE][5] ([i915#155])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0.html
* igt@gem_huc_copy@huc-copy:
- fi-tgl-1115g4: NOTRUN -> [SKIP][6] ([i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html
* igt@i915_pm_backlight@basic-brightness:
- fi-tgl-1115g4: NOTRUN -> [SKIP][7] ([i915#1155])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-n3050: [PASS][8] -> [DMESG-FAIL][9] ([i915#2927] / [i915#3428])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/fi-bsw-n3050/igt@i915_selftest@live@late_gt_pm.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-bsw-n3050/igt@i915_selftest@live@late_gt_pm.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-tgl-1115g4: NOTRUN -> [SKIP][10] ([fdo#111827]) +8 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-tgl-1115g4/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-tgl-1115g4: NOTRUN -> [SKIP][11] ([i915#4103]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_flip@basic-flip-vs-modeset@d-dp1:
- fi-tgl-1115g4: NOTRUN -> [FAIL][12] ([i915#1385]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-tgl-1115g4/igt@kms_flip@basic-flip-vs-modeset@d-dp1.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-1115g4: NOTRUN -> [SKIP][13] ([fdo#109285])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [PASS][14] -> [DMESG-WARN][15] ([i915#95])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
- fi-cfl-8109u: [PASS][16] -> [FAIL][17] ([i915#2546])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-tgl-1115g4: NOTRUN -> [DMESG-WARN][18] ([i915#4002]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-tgl-1115g4/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_mmap_gtt:
- fi-tgl-1115g4: NOTRUN -> [SKIP][19] ([i915#1072]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html
* igt@prime_vgem@basic-userptr:
- fi-tgl-1115g4: NOTRUN -> [SKIP][20] ([i915#3301])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-bsw-n3050: NOTRUN -> [FAIL][21] ([fdo#109271] / [i915#1436] / [i915#3428])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-bsw-n3050/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [INCOMPLETE][22] ([i915#3921]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1385]: https://gitlab.freedesktop.org/drm/intel/issues/1385
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4002]: https://gitlab.freedesktop.org/drm/intel/issues/4002
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (45 -> 37)
------------------------------
Additional (1): fi-tgl-1115g4
Missing (9): fi-ilk-m540 bat-dg1-6 fi-tgl-u2 fi-hsw-4200u fi-bsw-cyan fi-apl-guc bat-adlp-4 fi-ctg-p8600 bat-jsl-1
Build changes
-------------
* Linux: CI_DRM_10687 -> Patchwork_21263
CI-20190529: 20190529
CI_DRM_10687: 15f212b309cb3e64a5effdd72ed98aa3e3899111 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6232: effad6af5678be711a2c3e58e182319de784de54 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21263: d630e524bcb600ba48a3292f062a5ebaeb5b282d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d630e524bcb6 usb: typec: altmodes/displayport: reorder dp_altmode_configured()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/index.html
[-- Attachment #2: Type: text/html, Size: 8954 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/1] usb: typec: altmodes/displayport: reorder dp_altmode_configured()
2021-10-06 4:32 ` [Intel-gfx] " lindsey.stanpoor
(?)
(?)
@ 2021-10-06 12:18 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-10-06 12:18 UTC (permalink / raw)
To: lindsey.stanpoor; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30315 bytes --]
== Series Details ==
Series: series starting with [1/1] usb: typec: altmodes/displayport: reorder dp_altmode_configured()
URL : https://patchwork.freedesktop.org/series/95499/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10687_full -> Patchwork_21263_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21263_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21263_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21263_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_async_flips@crc:
- shard-skl: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-skl3/igt@kms_async_flips@crc.html
Known issues
------------
Here are the changes found in Patchwork_21263_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][2] -> [SKIP][3] ([i915#658])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-iclb2/igt@feature_discovery@psr2.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb5/igt@feature_discovery@psr2.html
* igt@gem_ctx_persistence@smoketest:
- shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +4 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-snb6/igt@gem_ctx_persistence@smoketest.html
* igt@gem_ctx_sseu@invalid-args:
- shard-tglb: NOTRUN -> [SKIP][5] ([i915#280])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@gem_ctx_sseu@invalid-args.html
* igt@gem_eio@unwedge-stress:
- shard-snb: NOTRUN -> [FAIL][6] ([i915#3354])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-snb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2842]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-kbl1/igt@gem_exec_fair@basic-none-vip@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-kbl7/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][9] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb2/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-tglb: NOTRUN -> [FAIL][10] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_whisper@basic-fds-priority:
- shard-glk: [PASS][11] -> [DMESG-WARN][12] ([i915#118] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-glk2/igt@gem_exec_whisper@basic-fds-priority.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-glk4/igt@gem_exec_whisper@basic-fds-priority.html
* igt@gem_pread@exhaustion:
- shard-snb: NOTRUN -> [WARN][13] ([i915#2658])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-snb6/igt@gem_pread@exhaustion.html
* igt@gem_render_copy@y-tiled-ccs-to-yf-tiled-mc-ccs:
- shard-iclb: NOTRUN -> [SKIP][14] ([i915#768])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb6/igt@gem_render_copy@y-tiled-ccs-to-yf-tiled-mc-ccs.html
* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-iclb: NOTRUN -> [SKIP][15] ([i915#3297])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb6/igt@gem_userptr_blits@readonly-pwrite-unsync.html
* igt@gen3_render_linear_blits:
- shard-tglb: NOTRUN -> [SKIP][16] ([fdo#109289]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb6/igt@gen3_render_linear_blits.html
* igt@gen9_exec_parse@bb-start-cmd:
- shard-tglb: NOTRUN -> [SKIP][17] ([i915#2856]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@gen9_exec_parse@bb-start-cmd.html
* igt@kms_big_fb@yf-tiled-64bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][18] ([fdo#111615]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@kms_big_fb@yf-tiled-64bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#3777]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl3/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
- shard-skl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#3777])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-skl3/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#3886]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-kbl7/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][22] ([i915#3689]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][23] ([i915#3689] / [i915#3886])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][24] ([fdo#109278] / [i915#3886])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb6/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3886]) +10 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl3/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html
- shard-skl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3886]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-skl3/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][27] ([fdo#109271]) +88 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-kbl7/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cdclk@mode-transition:
- shard-apl: NOTRUN -> [SKIP][28] ([fdo#109271]) +216 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl2/igt@kms_cdclk@mode-transition.html
* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +12 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl6/igt@kms_chamelium@dp-mode-timings.html
* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-tglb: NOTRUN -> [SKIP][30] ([fdo#109284] / [fdo#111827]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@kms_chamelium@vga-hpd-for-each-pipe.html
* igt@kms_color_chamelium@pipe-b-ctm-blue-to-red:
- shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-skl3/igt@kms_color_chamelium@pipe-b-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-c-ctm-red-to-blue:
- shard-snb: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827]) +12 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-snb6/igt@kms_color_chamelium@pipe-c-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-d-ctm-max:
- shard-kbl: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +6 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-kbl2/igt@kms_color_chamelium@pipe-d-ctm-max.html
* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][34] ([i915#1319])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl1/igt@kms_content_protection@lic.html
- shard-kbl: NOTRUN -> [TIMEOUT][35] ([i915#1319])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-kbl2/igt@kms_content_protection@lic.html
* igt@kms_content_protection@uevent:
- shard-kbl: NOTRUN -> [FAIL][36] ([i915#2105])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-kbl7/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-apl: [PASS][37] -> [DMESG-WARN][38] ([i915#180])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-apl8/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl8/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-512x170-random:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#109279] / [i915#3359]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@kms_cursor_crc@pipe-b-cursor-512x170-random.html
* igt@kms_cursor_crc@pipe-c-cursor-max-size-offscreen:
- shard-tglb: NOTRUN -> [SKIP][40] ([i915#3359]) +5 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@kms_cursor_crc@pipe-c-cursor-max-size-offscreen.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271]) +46 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-skl3/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
* igt@kms_cursor_legacy@pipe-d-torture-move:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109278]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb6/igt@kms_cursor_legacy@pipe-d-torture-move.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle:
- shard-tglb: NOTRUN -> [SKIP][43] ([i915#4103])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle.html
* igt@kms_flip@2x-flip-vs-rmfb:
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#111825]) +9 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@kms_flip@2x-flip-vs-rmfb.html
* igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109274])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb6/igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][46] -> [DMESG-WARN][47] ([i915#180]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: NOTRUN -> [DMESG-WARN][48] ([i915#180] / [i915#1982])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl6/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: NOTRUN -> [DMESG-WARN][49] ([i915#180])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl6/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile:
- shard-iclb: [PASS][50] -> [SKIP][51] ([i915#3701]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-iclb8/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt:
- shard-snb: NOTRUN -> [SKIP][52] ([fdo#109271]) +285 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-snb6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109280]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-apl: NOTRUN -> [FAIL][54] ([fdo#108145] / [i915#265]) +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][55] ([fdo#108145] / [i915#265])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-kbl2/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
* igt@kms_plane_lowres@pipe-d-tiling-none:
- shard-tglb: NOTRUN -> [SKIP][56] ([i915#3536])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@kms_plane_lowres@pipe-d-tiling-none.html
* igt@kms_plane_multiple@atomic-pipe-d-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][57] ([fdo#112054])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@kms_plane_multiple@atomic-pipe-d-tiling-yf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-tglb: NOTRUN -> [SKIP][58] ([i915#2920])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#658]) +4 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
- shard-skl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#658])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-skl3/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-kbl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#658]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-kbl7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [PASS][62] -> [SKIP][63] ([fdo#109441])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#533]) +2 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-kbl2/igt@kms_vblank@pipe-d-wait-idle.html
- shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#533]) +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl1/igt@kms_vblank@pipe-d-wait-idle.html
* igt@nouveau_crc@pipe-c-source-rg:
- shard-tglb: NOTRUN -> [SKIP][66] ([i915#2530])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@nouveau_crc@pipe-c-source-rg.html
* igt@prime_nv_test@i915_blt_fill_nv_read:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109291])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb6/igt@prime_nv_test@i915_blt_fill_nv_read.html
* igt@prime_vgem@fence-read-hang:
- shard-tglb: NOTRUN -> [SKIP][68] ([fdo#109295])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@prime_vgem@fence-read-hang.html
* igt@sysfs_clients@fair-0:
- shard-skl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#2994]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-skl3/igt@sysfs_clients@fair-0.html
- shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#2994]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl3/igt@sysfs_clients@fair-0.html
* igt@sysfs_clients@fair-1:
- shard-kbl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#2994])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-kbl2/igt@sysfs_clients@fair-1.html
* igt@sysfs_clients@pidname:
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#2994])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@sysfs_clients@pidname.html
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-skl: [INCOMPLETE][73] ([i915#146] / [i915#198]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-skl5/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-skl7/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][75] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-tglb6/igt@gem_eio@unwedge-stress.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][77] ([i915#2846]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-glk6/igt@gem_exec_fair@basic-deadline.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-glk1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][79] ([i915#2842]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][81] ([i915#2842]) -> [PASS][82] +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-kbl4/igt@gem_exec_fair@basic-none@vcs0.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][83] ([i915#2842]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [DMESG-WARN][85] ([i915#180]) -> [PASS][86] +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-kbl1/igt@gem_exec_suspend@basic-s3.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-kbl7/igt@gem_exec_suspend@basic-s3.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][87] ([i915#1436] / [i915#716]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-skl3/igt@gen9_exec_parse@allowed-single.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-skl5/igt@gen9_exec_parse@allowed-single.html
* igt@kms_big_fb@linear-32bpp-rotate-0:
- shard-glk: [DMESG-WARN][89] ([i915#118] / [i915#95]) -> [PASS][90] +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-glk6/igt@kms_big_fb@linear-32bpp-rotate-0.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-glk1/igt@kms_big_fb@linear-32bpp-rotate-0.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-tglb: [INCOMPLETE][91] ([i915#2828] / [i915#456]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-tglb: [INCOMPLETE][93] ([i915#456]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-tglb7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-tglb6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][95] ([i915#2346] / [i915#533]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@dpms-off-confusion@a-edp1:
- shard-skl: [DMESG-WARN][97] ([i915#1982]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-skl4/igt@kms_flip@dpms-off-confusion@a-edp1.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-skl7/igt@kms_flip@dpms-off-confusion@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1:
- shard-kbl: [FAIL][99] ([i915#79]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-kbl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-kbl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html
* igt@kms_flip@plain-flip-fb-recreate@c-edp1:
- shard-skl: [FAIL][101] ([i915#2122]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-skl1/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-skl7/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-glk: [FAIL][103] ([i915#2546]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-glk6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-glk1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][105] ([fdo#109441]) -> [PASS][106] +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
#### Warnings ####
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][107] ([i915#2920]) -> [SKIP][108] ([i915#658]) +2 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-iclb: [SKIP][109] ([i915#658]) -> [SKIP][110] ([i915#2920]) +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-iclb3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
* igt@runner@aborted:
- shard-apl: ([FAIL][111], [FAIL][112], [FAIL][113], [FAIL][114]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][115], [FAIL][116], [FAIL][117]) ([i915#180] / [i915#1814] / [i915#3363])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-apl7/igt@runner@aborted.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-apl3/igt@runner@aborted.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-apl2/igt@runner@aborted.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-apl6/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl8/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl6/igt@runner@aborted.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-apl8/igt@runner@aborted.html
- shard-skl: ([FAIL][118], [FAIL][119], [FAIL][120]) ([i915#1436] / [i915#3002] / [i915#3363]) -> ([FAIL][121], [FAIL][122]) ([i915#3002] / [i915#3363])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-skl3/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-skl10/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10687/shard-skl8/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-skl10/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/shard-skl10/igt@runner@aborted.html
### Piglit changes ###
#### Warnings ####
* spec@ext_framebuffer_multisample_blit_scaled@blit-scaled samples=2:
- pig-glk-j5005: [WARN][123] ([i915#3105] / [mesa#1797]) -> [WARN][124] ([mesa#1797]) +1 similar issue
[123]: None
[124]: None
* spec@ext_framebuffer_multisample_blit_scaled@blit-scaled samples=2 with gl_texture_2d_multisample_array:
- pig-skl-6260u: [WARN][125] ([i915#3105] / [mesa#1797]) -> [WARN][126] ([mesa#1797]) +1 similar issue
[125]: None
[126]: None
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2828]: https://gitlab.freedesktop.org/drm/intel/issues/2828
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3105]: https://gitlab.freedesktop.org/drm/intel/issues/3105
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3354]: https://gitlab.freedesktop.org/drm/intel/issues/3354
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21263/index.html
[-- Attachment #2: Type: text/html, Size: 37222 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] usb: typec: altmodes/displayport: reorder dp_altmode_configured()
2021-10-06 4:32 ` [Intel-gfx] " lindsey.stanpoor
@ 2021-10-08 8:09 ` Heikki Krogerus
-1 siblings, 0 replies; 8+ messages in thread
From: Heikki Krogerus @ 2021-10-08 8:09 UTC (permalink / raw)
To: lindsey.stanpoor; +Cc: intel-gfx, linux-usb, hdegoede, gregkh, cnemo
On Tue, Oct 05, 2021 at 09:32:57PM -0700, lindsey.stanpoor@gmail.com wrote:
> From: Cameron Nemo <cnemo@tutanota.com>
>
> A recent commit [1] introduced an unintended behavioral change by
> reordering certain function calls. The sysfs_notify call for
> pin_assignment should only be invoked when the dp_altmode_notify call
> returns 0, and in the dp->data.conf == 0 case.
>
> [1] https://lore.kernel.org/r/20210817215201.795062-8-hdegoede@redhat.com
You should refer the commit, not the mail. I think you could also use
the Fixes tag in this case, but then I guess Hans should pick this:
Fixes: fc27e04630e9 ("usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic")
Either way, this is OK by me, so once you have cleaned the commit
message, please feel free to include my:
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
> ---
> drivers/usb/typec/altmodes/displayport.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
> index c1d8c23baa39..a15ae78066e3 100644
> --- a/drivers/usb/typec/altmodes/displayport.c
> +++ b/drivers/usb/typec/altmodes/displayport.c
> @@ -154,10 +154,17 @@ static int dp_altmode_status_update(struct dp_altmode *dp)
>
> static int dp_altmode_configured(struct dp_altmode *dp)
> {
> + int ret;
> +
> sysfs_notify(&dp->alt->dev.kobj, "displayport", "configuration");
> +
> + ret = dp_altmode_notify(dp);
> + if (ret || !dp->data.conf)
> + return ret;
> +
> sysfs_notify(&dp->alt->dev.kobj, "displayport", "pin_assignment");
>
> - return dp_altmode_notify(dp);
> + return 0;
> }
>
> static int dp_altmode_configure_vdm(struct dp_altmode *dp, u32 conf)
> --
> 2.33.0
--
heikki
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] usb: typec: altmodes/displayport: reorder dp_altmode_configured()
@ 2021-10-08 8:09 ` Heikki Krogerus
0 siblings, 0 replies; 8+ messages in thread
From: Heikki Krogerus @ 2021-10-08 8:09 UTC (permalink / raw)
To: lindsey.stanpoor; +Cc: intel-gfx, linux-usb, hdegoede, gregkh, cnemo
On Tue, Oct 05, 2021 at 09:32:57PM -0700, lindsey.stanpoor@gmail.com wrote:
> From: Cameron Nemo <cnemo@tutanota.com>
>
> A recent commit [1] introduced an unintended behavioral change by
> reordering certain function calls. The sysfs_notify call for
> pin_assignment should only be invoked when the dp_altmode_notify call
> returns 0, and in the dp->data.conf == 0 case.
>
> [1] https://lore.kernel.org/r/20210817215201.795062-8-hdegoede@redhat.com
You should refer the commit, not the mail. I think you could also use
the Fixes tag in this case, but then I guess Hans should pick this:
Fixes: fc27e04630e9 ("usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic")
Either way, this is OK by me, so once you have cleaned the commit
message, please feel free to include my:
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
> ---
> drivers/usb/typec/altmodes/displayport.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
> index c1d8c23baa39..a15ae78066e3 100644
> --- a/drivers/usb/typec/altmodes/displayport.c
> +++ b/drivers/usb/typec/altmodes/displayport.c
> @@ -154,10 +154,17 @@ static int dp_altmode_status_update(struct dp_altmode *dp)
>
> static int dp_altmode_configured(struct dp_altmode *dp)
> {
> + int ret;
> +
> sysfs_notify(&dp->alt->dev.kobj, "displayport", "configuration");
> +
> + ret = dp_altmode_notify(dp);
> + if (ret || !dp->data.conf)
> + return ret;
> +
> sysfs_notify(&dp->alt->dev.kobj, "displayport", "pin_assignment");
>
> - return dp_altmode_notify(dp);
> + return 0;
> }
>
> static int dp_altmode_configure_vdm(struct dp_altmode *dp, u32 conf)
> --
> 2.33.0
--
heikki
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] usb: typec: altmodes/displayport: reorder dp_altmode_configured()
2021-10-06 4:32 ` [Intel-gfx] " lindsey.stanpoor
@ 2021-10-08 8:52 ` Hans de Goede
-1 siblings, 0 replies; 8+ messages in thread
From: Hans de Goede @ 2021-10-08 8:52 UTC (permalink / raw)
To: lindsey.stanpoor, intel-gfx, linux-usb; +Cc: heikki.krogerus, gregkh, cnemo
Hi,
On 10/6/21 6:32 AM, lindsey.stanpoor@gmail.com wrote:
> From: Cameron Nemo <cnemo@tutanota.com>
>
> A recent commit [1] introduced an unintended behavioral change by
> reordering certain function calls. The sysfs_notify call for
> pin_assignment should only be invoked when the dp_altmode_notify call
> returns 0, and in the dp->data.conf == 0 case.
>
> [1] https://lore.kernel.org/r/20210817215201.795062-8-hdegoede@redhat.com
>
> Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
You are right that my commit changed the behavior I should have added
something about that to the commit message, *but* I believe
that the new behavior is correct and should be kept.
Even if the dp_altmode_notify() fails, then reading from
the pin_assignment sysfs file will still show the new pin-assignment,
so the contents of the sysfs file has changed and thus the notify is
the correct thing to do independent of the dp_altmode_notify()
return value.
Likewise if we have selected a pin_assignment ourselves and the
user tries to change this by writing to the pin_assignment sysfs
file, then we may get an async (so not signalled as an error
on the sysfs write syscall) CMDT_RSP_NAK to the new pin_assignment
at which point we set dp->data.conf = 0; and then call
dp_altmode_configured() and in this case again the
sysfs file "contents" has changed so we should do a notify.
More-over doing a syfs-notify when nothing has changed is really
not the end of the world, it is not like we are going to do this
100s of times per second.
IOW I believe that the new behavior although different is
correct (and the new code is also a lot more straight forward).
So NACK from me for this change.
Question, does this patch fix an actual problem which you were
seeing, or did you just notice this while reviewing the change ?
Regards,
Hans
> ---
> drivers/usb/typec/altmodes/displayport.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
> index c1d8c23baa39..a15ae78066e3 100644
> --- a/drivers/usb/typec/altmodes/displayport.c
> +++ b/drivers/usb/typec/altmodes/displayport.c
> @@ -154,10 +154,17 @@ static int dp_altmode_status_update(struct dp_altmode *dp)
>
> static int dp_altmode_configured(struct dp_altmode *dp)
> {
> + int ret;
> +
> sysfs_notify(&dp->alt->dev.kobj, "displayport", "configuration");
> +
> + ret = dp_altmode_notify(dp);
> + if (ret || !dp->data.conf)
> + return ret;
> +
> sysfs_notify(&dp->alt->dev.kobj, "displayport", "pin_assignment");
>
> - return dp_altmode_notify(dp);
> + return 0;
> }
>
> static int dp_altmode_configure_vdm(struct dp_altmode *dp, u32 conf)
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] usb: typec: altmodes/displayport: reorder dp_altmode_configured()
@ 2021-10-08 8:52 ` Hans de Goede
0 siblings, 0 replies; 8+ messages in thread
From: Hans de Goede @ 2021-10-08 8:52 UTC (permalink / raw)
To: lindsey.stanpoor, intel-gfx, linux-usb; +Cc: heikki.krogerus, gregkh, cnemo
Hi,
On 10/6/21 6:32 AM, lindsey.stanpoor@gmail.com wrote:
> From: Cameron Nemo <cnemo@tutanota.com>
>
> A recent commit [1] introduced an unintended behavioral change by
> reordering certain function calls. The sysfs_notify call for
> pin_assignment should only be invoked when the dp_altmode_notify call
> returns 0, and in the dp->data.conf == 0 case.
>
> [1] https://lore.kernel.org/r/20210817215201.795062-8-hdegoede@redhat.com
>
> Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
You are right that my commit changed the behavior I should have added
something about that to the commit message, *but* I believe
that the new behavior is correct and should be kept.
Even if the dp_altmode_notify() fails, then reading from
the pin_assignment sysfs file will still show the new pin-assignment,
so the contents of the sysfs file has changed and thus the notify is
the correct thing to do independent of the dp_altmode_notify()
return value.
Likewise if we have selected a pin_assignment ourselves and the
user tries to change this by writing to the pin_assignment sysfs
file, then we may get an async (so not signalled as an error
on the sysfs write syscall) CMDT_RSP_NAK to the new pin_assignment
at which point we set dp->data.conf = 0; and then call
dp_altmode_configured() and in this case again the
sysfs file "contents" has changed so we should do a notify.
More-over doing a syfs-notify when nothing has changed is really
not the end of the world, it is not like we are going to do this
100s of times per second.
IOW I believe that the new behavior although different is
correct (and the new code is also a lot more straight forward).
So NACK from me for this change.
Question, does this patch fix an actual problem which you were
seeing, or did you just notice this while reviewing the change ?
Regards,
Hans
> ---
> drivers/usb/typec/altmodes/displayport.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
> index c1d8c23baa39..a15ae78066e3 100644
> --- a/drivers/usb/typec/altmodes/displayport.c
> +++ b/drivers/usb/typec/altmodes/displayport.c
> @@ -154,10 +154,17 @@ static int dp_altmode_status_update(struct dp_altmode *dp)
>
> static int dp_altmode_configured(struct dp_altmode *dp)
> {
> + int ret;
> +
> sysfs_notify(&dp->alt->dev.kobj, "displayport", "configuration");
> +
> + ret = dp_altmode_notify(dp);
> + if (ret || !dp->data.conf)
> + return ret;
> +
> sysfs_notify(&dp->alt->dev.kobj, "displayport", "pin_assignment");
>
> - return dp_altmode_notify(dp);
> + return 0;
> }
>
> static int dp_altmode_configure_vdm(struct dp_altmode *dp, u32 conf)
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-10-08 8:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06 4:32 [PATCH 1/1] usb: typec: altmodes/displayport: reorder dp_altmode_configured() lindsey.stanpoor
2021-10-06 4:32 ` [Intel-gfx] " lindsey.stanpoor
2021-10-06 9:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] " Patchwork
2021-10-06 12:18 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-08 8:09 ` [PATCH 1/1] " Heikki Krogerus
2021-10-08 8:09 ` [Intel-gfx] " Heikki Krogerus
2021-10-08 8:52 ` Hans de Goede
2021-10-08 8:52 ` [Intel-gfx] " Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.