From: Hans de Goede <hdegoede@redhat.com> To: Geert Uytterhoeven <geert@linux-m68k.org>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] drm/modes: Command line mode selection fixes and improvements Date: Fri, 8 Jul 2022 21:36:20 +0200 [thread overview] Message-ID: <da9636ac-9455-75a6-7284-8c601d23a37e@redhat.com> (raw) In-Reply-To: <cover.1657301107.git.geert@linux-m68k.org> Hi Geert, On 7/8/22 20:21, Geert Uytterhoeven wrote: > Hi all, > > This patch series contains fixes and improvements for specifying video > modes on the kernel command line. > > This has been tested on ARAnyM using a work-in-progress Atari DRM driver > (more info and related patches can be found in [1]). > > Thanks for your comments! > > [1] "[PATCH v3 00/10] drm: Add support for low-color frame buffer formats" > https://lore.kernel.org/r/cover.1657294931.git.geert@linux-m68k.org > > Geert Uytterhoeven (5): > drm/modes: parse_cmdline: Handle empty mode name part > drm/modes: Extract drm_mode_parse_cmdline_named_mode() > drm/modes: parse_cmdline: Make mode->*specified handling more uniform > drm/modes: Add support for driver-specific named modes > drm/modes: parse_cmdline: Add support for named modes containing > dashes Thanks, I have some remarks on patches 1/5 and 2/5 the rest looks good to me. For 1/5 and 2/5 with my remarks addressed: Reviewed-by: Hans de Goede <hdegoede@redhat.com> For 3/5, 4/5 and 5/5: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > > drivers/gpu/drm/drm_modes.c | 57 ++++++++++++++++++++++++++----------- > include/drm/drm_connector.h | 10 +++++++ > 2 files changed, 50 insertions(+), 17 deletions(-) >
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com> To: Geert Uytterhoeven <geert@linux-m68k.org>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch> Cc: linux-fbdev@vger.kernel.org, linux-m68k@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] drm/modes: Command line mode selection fixes and improvements Date: Fri, 8 Jul 2022 21:36:20 +0200 [thread overview] Message-ID: <da9636ac-9455-75a6-7284-8c601d23a37e@redhat.com> (raw) In-Reply-To: <cover.1657301107.git.geert@linux-m68k.org> Hi Geert, On 7/8/22 20:21, Geert Uytterhoeven wrote: > Hi all, > > This patch series contains fixes and improvements for specifying video > modes on the kernel command line. > > This has been tested on ARAnyM using a work-in-progress Atari DRM driver > (more info and related patches can be found in [1]). > > Thanks for your comments! > > [1] "[PATCH v3 00/10] drm: Add support for low-color frame buffer formats" > https://lore.kernel.org/r/cover.1657294931.git.geert@linux-m68k.org > > Geert Uytterhoeven (5): > drm/modes: parse_cmdline: Handle empty mode name part > drm/modes: Extract drm_mode_parse_cmdline_named_mode() > drm/modes: parse_cmdline: Make mode->*specified handling more uniform > drm/modes: Add support for driver-specific named modes > drm/modes: parse_cmdline: Add support for named modes containing > dashes Thanks, I have some remarks on patches 1/5 and 2/5 the rest looks good to me. For 1/5 and 2/5 with my remarks addressed: Reviewed-by: Hans de Goede <hdegoede@redhat.com> For 3/5, 4/5 and 5/5: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > > drivers/gpu/drm/drm_modes.c | 57 ++++++++++++++++++++++++++----------- > include/drm/drm_connector.h | 10 +++++++ > 2 files changed, 50 insertions(+), 17 deletions(-) >
next prev parent reply other threads:[~2022-07-08 19:36 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-08 18:21 [PATCH 0/5] drm/modes: Command line mode selection fixes and improvements Geert Uytterhoeven 2022-07-08 18:21 ` Geert Uytterhoeven 2022-07-08 18:21 ` [PATCH 1/5] drm/modes: parse_cmdline: Handle empty mode name part Geert Uytterhoeven 2022-07-08 18:21 ` Geert Uytterhoeven 2022-07-08 19:28 ` Hans de Goede 2022-07-08 19:28 ` Hans de Goede 2022-07-08 20:06 ` Geert Uytterhoeven 2022-07-08 20:06 ` Geert Uytterhoeven 2022-07-08 20:09 ` Geert Uytterhoeven 2022-07-08 20:09 ` Geert Uytterhoeven 2022-07-08 18:21 ` [PATCH 2/5] drm/modes: Extract drm_mode_parse_cmdline_named_mode() Geert Uytterhoeven 2022-07-08 18:21 ` Geert Uytterhoeven 2022-07-08 19:45 ` Hans de Goede 2022-07-08 19:45 ` Hans de Goede 2022-07-08 20:14 ` Geert Uytterhoeven 2022-07-08 20:14 ` Geert Uytterhoeven 2022-07-08 18:21 ` [PATCH 3/5] drm/modes: parse_cmdline: Make mode->*specified handling more uniform Geert Uytterhoeven 2022-07-08 18:21 ` Geert Uytterhoeven 2022-07-08 18:21 ` [PATCH 4/5] drm/modes: Add support for driver-specific named modes Geert Uytterhoeven 2022-07-08 18:21 ` Geert Uytterhoeven 2022-07-11 9:03 ` Thomas Zimmermann 2022-07-11 9:03 ` Thomas Zimmermann 2022-07-11 9:35 ` Maxime Ripard 2022-07-11 9:35 ` Maxime Ripard 2022-07-11 11:11 ` Thomas Zimmermann 2022-07-11 11:11 ` Thomas Zimmermann 2022-07-11 11:42 ` Maxime Ripard 2022-07-11 11:42 ` Maxime Ripard 2022-07-11 11:59 ` Geert Uytterhoeven 2022-07-11 11:59 ` Geert Uytterhoeven 2022-07-11 12:02 ` Maxime Ripard 2022-07-11 12:02 ` Maxime Ripard 2022-07-11 12:08 ` Geert Uytterhoeven 2022-07-11 12:08 ` Geert Uytterhoeven 2022-07-13 9:37 ` Maxime Ripard 2022-07-13 9:37 ` Maxime Ripard 2022-07-14 8:42 ` Geert Uytterhoeven 2022-07-14 8:42 ` Geert Uytterhoeven 2022-07-11 9:35 ` Geert Uytterhoeven 2022-07-11 9:35 ` Geert Uytterhoeven 2022-07-11 11:03 ` Thomas Zimmermann 2022-07-11 11:03 ` Thomas Zimmermann 2022-07-08 18:21 ` [PATCH 5/5] drm/modes: parse_cmdline: Add support for named modes containing dashes Geert Uytterhoeven 2022-07-08 18:21 ` Geert Uytterhoeven 2022-07-08 19:36 ` Hans de Goede [this message] 2022-07-08 19:36 ` [PATCH 0/5] drm/modes: Command line mode selection fixes and improvements Hans de Goede 2022-07-11 9:04 ` Thomas Zimmermann 2022-07-11 9:04 ` Thomas Zimmermann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=da9636ac-9455-75a6-7284-8c601d23a37e@redhat.com \ --to=hdegoede@redhat.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-m68k@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.