* Re: [PATCH] ASoC: atmel-classd: sync regcache when resuming
2017-05-15 8:36 [PATCH] ASoC: atmel-classd: sync regcache when resuming Quentin Schulz
@ 2017-05-15 9:46 ` Alexandre Belloni
2017-05-15 12:59 ` Nicolas Ferre
2017-05-17 9:51 ` Mark Brown
2 siblings, 0 replies; 7+ messages in thread
From: Alexandre Belloni @ 2017-05-15 9:46 UTC (permalink / raw)
To: Quentin Schulz
Cc: nicolas.ferre, lgirdwood, broonie, perex, tiwai,
thomas.petazzoni, alsa-devel, linux-kernel
On 15/05/2017 at 10:36:17 +0200, Quentin Schulz wrote:
> The PM functions used in this driver are the ones defined in
> sounc/soc/soc-core.c.
>
> When suspending (using snd_soc_suspend), the regcache is marked dirty
> but is never synced on resume.
>
> Sync regcache on resume of Atmel ClassD device.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> sound/soc/atmel/atmel-classd.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c
> index 7ae46c2647d4..b7ef8c59b49a 100644
> --- a/sound/soc/atmel/atmel-classd.c
> +++ b/sound/soc/atmel/atmel-classd.c
> @@ -301,6 +301,14 @@ static int atmel_classd_codec_probe(struct snd_soc_codec *codec)
> return 0;
> }
>
> +static int atmel_classd_codec_resume(struct snd_soc_codec *codec)
> +{
> + struct snd_soc_card *card = snd_soc_codec_get_drvdata(codec);
> + struct atmel_classd *dd = snd_soc_card_get_drvdata(card);
> +
> + return regcache_sync(dd->regmap);
> +}
> +
> static struct regmap *atmel_classd_codec_get_remap(struct device *dev)
> {
> return dev_get_regmap(dev, NULL);
> @@ -308,6 +316,7 @@ static struct regmap *atmel_classd_codec_get_remap(struct device *dev)
>
> static struct snd_soc_codec_driver soc_codec_dev_classd = {
> .probe = atmel_classd_codec_probe,
> + .resume = atmel_classd_codec_resume,
> .get_regmap = atmel_classd_codec_get_remap,
> .component_driver = {
> .controls = atmel_classd_snd_controls,
> --
> 2.11.0
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ASoC: atmel-classd: sync regcache when resuming
@ 2017-05-15 9:46 ` Alexandre Belloni
0 siblings, 0 replies; 7+ messages in thread
From: Alexandre Belloni @ 2017-05-15 9:46 UTC (permalink / raw)
To: Quentin Schulz
Cc: thomas.petazzoni, alsa-devel, lgirdwood, linux-kernel,
nicolas.ferre, tiwai, broonie
On 15/05/2017 at 10:36:17 +0200, Quentin Schulz wrote:
> The PM functions used in this driver are the ones defined in
> sounc/soc/soc-core.c.
>
> When suspending (using snd_soc_suspend), the regcache is marked dirty
> but is never synced on resume.
>
> Sync regcache on resume of Atmel ClassD device.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> sound/soc/atmel/atmel-classd.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c
> index 7ae46c2647d4..b7ef8c59b49a 100644
> --- a/sound/soc/atmel/atmel-classd.c
> +++ b/sound/soc/atmel/atmel-classd.c
> @@ -301,6 +301,14 @@ static int atmel_classd_codec_probe(struct snd_soc_codec *codec)
> return 0;
> }
>
> +static int atmel_classd_codec_resume(struct snd_soc_codec *codec)
> +{
> + struct snd_soc_card *card = snd_soc_codec_get_drvdata(codec);
> + struct atmel_classd *dd = snd_soc_card_get_drvdata(card);
> +
> + return regcache_sync(dd->regmap);
> +}
> +
> static struct regmap *atmel_classd_codec_get_remap(struct device *dev)
> {
> return dev_get_regmap(dev, NULL);
> @@ -308,6 +316,7 @@ static struct regmap *atmel_classd_codec_get_remap(struct device *dev)
>
> static struct snd_soc_codec_driver soc_codec_dev_classd = {
> .probe = atmel_classd_codec_probe,
> + .resume = atmel_classd_codec_resume,
> .get_regmap = atmel_classd_codec_get_remap,
> .component_driver = {
> .controls = atmel_classd_snd_controls,
> --
> 2.11.0
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: atmel-classd: sync regcache when resuming
2017-05-15 8:36 [PATCH] ASoC: atmel-classd: sync regcache when resuming Quentin Schulz
@ 2017-05-15 12:59 ` Nicolas Ferre
2017-05-15 12:59 ` Nicolas Ferre
2017-05-17 9:51 ` Mark Brown
2 siblings, 0 replies; 7+ messages in thread
From: Nicolas Ferre @ 2017-05-15 12:59 UTC (permalink / raw)
To: Quentin Schulz, lgirdwood, broonie, perex, tiwai
Cc: alexandre.belloni, thomas.petazzoni, alsa-devel, linux-kernel
Le 15/05/2017 à 10:36, Quentin Schulz a écrit :
> The PM functions used in this driver are the ones defined in
> sounc/soc/soc-core.c.
>
> When suspending (using snd_soc_suspend), the regcache is marked dirty
> but is never synced on resume.
>
> Sync regcache on resume of Atmel ClassD device.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks
> ---
> sound/soc/atmel/atmel-classd.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c
> index 7ae46c2647d4..b7ef8c59b49a 100644
> --- a/sound/soc/atmel/atmel-classd.c
> +++ b/sound/soc/atmel/atmel-classd.c
> @@ -301,6 +301,14 @@ static int atmel_classd_codec_probe(struct snd_soc_codec *codec)
> return 0;
> }
>
> +static int atmel_classd_codec_resume(struct snd_soc_codec *codec)
> +{
> + struct snd_soc_card *card = snd_soc_codec_get_drvdata(codec);
> + struct atmel_classd *dd = snd_soc_card_get_drvdata(card);
> +
> + return regcache_sync(dd->regmap);
> +}
> +
> static struct regmap *atmel_classd_codec_get_remap(struct device *dev)
> {
> return dev_get_regmap(dev, NULL);
> @@ -308,6 +316,7 @@ static struct regmap *atmel_classd_codec_get_remap(struct device *dev)
>
> static struct snd_soc_codec_driver soc_codec_dev_classd = {
> .probe = atmel_classd_codec_probe,
> + .resume = atmel_classd_codec_resume,
> .get_regmap = atmel_classd_codec_get_remap,
> .component_driver = {
> .controls = atmel_classd_snd_controls,
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ASoC: atmel-classd: sync regcache when resuming
@ 2017-05-15 12:59 ` Nicolas Ferre
0 siblings, 0 replies; 7+ messages in thread
From: Nicolas Ferre @ 2017-05-15 12:59 UTC (permalink / raw)
To: Quentin Schulz, lgirdwood, broonie, perex, tiwai
Cc: alexandre.belloni, thomas.petazzoni, alsa-devel, linux-kernel
Le 15/05/2017 à 10:36, Quentin Schulz a écrit :
> The PM functions used in this driver are the ones defined in
> sounc/soc/soc-core.c.
>
> When suspending (using snd_soc_suspend), the regcache is marked dirty
> but is never synced on resume.
>
> Sync regcache on resume of Atmel ClassD device.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks
> ---
> sound/soc/atmel/atmel-classd.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c
> index 7ae46c2647d4..b7ef8c59b49a 100644
> --- a/sound/soc/atmel/atmel-classd.c
> +++ b/sound/soc/atmel/atmel-classd.c
> @@ -301,6 +301,14 @@ static int atmel_classd_codec_probe(struct snd_soc_codec *codec)
> return 0;
> }
>
> +static int atmel_classd_codec_resume(struct snd_soc_codec *codec)
> +{
> + struct snd_soc_card *card = snd_soc_codec_get_drvdata(codec);
> + struct atmel_classd *dd = snd_soc_card_get_drvdata(card);
> +
> + return regcache_sync(dd->regmap);
> +}
> +
> static struct regmap *atmel_classd_codec_get_remap(struct device *dev)
> {
> return dev_get_regmap(dev, NULL);
> @@ -308,6 +316,7 @@ static struct regmap *atmel_classd_codec_get_remap(struct device *dev)
>
> static struct snd_soc_codec_driver soc_codec_dev_classd = {
> .probe = atmel_classd_codec_probe,
> + .resume = atmel_classd_codec_resume,
> .get_regmap = atmel_classd_codec_get_remap,
> .component_driver = {
> .controls = atmel_classd_snd_controls,
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 7+ messages in thread
* Applied "ASoC: atmel-classd: sync regcache when resuming" to the asoc tree
2017-05-15 8:36 [PATCH] ASoC: atmel-classd: sync regcache when resuming Quentin Schulz
@ 2017-05-17 9:51 ` Mark Brown
2017-05-15 12:59 ` Nicolas Ferre
2017-05-17 9:51 ` Mark Brown
2 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2017-05-17 9:51 UTC (permalink / raw)
To: Quentin Schulz
Cc: Alexandre Belloni, Nicolas Ferre, Mark Brown, nicolas.ferre,
lgirdwood, broonie, perex, tiwai, thomas.petazzoni, alsa-devel,
alexandre.belloni, linux-kernel, alsa-devel
The patch
ASoC: atmel-classd: sync regcache when resuming
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 61abce1312bf97eac62eef704260ce9a8f9b85f6 Mon Sep 17 00:00:00 2001
From: Quentin Schulz <quentin.schulz@free-electrons.com>
Date: Mon, 15 May 2017 10:36:17 +0200
Subject: [PATCH] ASoC: atmel-classd: sync regcache when resuming
The PM functions used in this driver are the ones defined in
sounc/soc/soc-core.c.
When suspending (using snd_soc_suspend), the regcache is marked dirty
but is never synced on resume.
Sync regcache on resume of Atmel ClassD device.
Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/atmel/atmel-classd.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c
index 7ae46c2647d4..b7ef8c59b49a 100644
--- a/sound/soc/atmel/atmel-classd.c
+++ b/sound/soc/atmel/atmel-classd.c
@@ -301,6 +301,14 @@ static int atmel_classd_codec_probe(struct snd_soc_codec *codec)
return 0;
}
+static int atmel_classd_codec_resume(struct snd_soc_codec *codec)
+{
+ struct snd_soc_card *card = snd_soc_codec_get_drvdata(codec);
+ struct atmel_classd *dd = snd_soc_card_get_drvdata(card);
+
+ return regcache_sync(dd->regmap);
+}
+
static struct regmap *atmel_classd_codec_get_remap(struct device *dev)
{
return dev_get_regmap(dev, NULL);
@@ -308,6 +316,7 @@ static struct regmap *atmel_classd_codec_get_remap(struct device *dev)
static struct snd_soc_codec_driver soc_codec_dev_classd = {
.probe = atmel_classd_codec_probe,
+ .resume = atmel_classd_codec_resume,
.get_regmap = atmel_classd_codec_get_remap,
.component_driver = {
.controls = atmel_classd_snd_controls,
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Applied "ASoC: atmel-classd: sync regcache when resuming" to the asoc tree
@ 2017-05-17 9:51 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2017-05-17 9:51 UTC (permalink / raw)
To: Quentin Schulz; +Cc: Alexandre Belloni, Nicolas Ferre, Mark Brown
The patch
ASoC: atmel-classd: sync regcache when resuming
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 61abce1312bf97eac62eef704260ce9a8f9b85f6 Mon Sep 17 00:00:00 2001
From: Quentin Schulz <quentin.schulz@free-electrons.com>
Date: Mon, 15 May 2017 10:36:17 +0200
Subject: [PATCH] ASoC: atmel-classd: sync regcache when resuming
The PM functions used in this driver are the ones defined in
sounc/soc/soc-core.c.
When suspending (using snd_soc_suspend), the regcache is marked dirty
but is never synced on resume.
Sync regcache on resume of Atmel ClassD device.
Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/atmel/atmel-classd.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c
index 7ae46c2647d4..b7ef8c59b49a 100644
--- a/sound/soc/atmel/atmel-classd.c
+++ b/sound/soc/atmel/atmel-classd.c
@@ -301,6 +301,14 @@ static int atmel_classd_codec_probe(struct snd_soc_codec *codec)
return 0;
}
+static int atmel_classd_codec_resume(struct snd_soc_codec *codec)
+{
+ struct snd_soc_card *card = snd_soc_codec_get_drvdata(codec);
+ struct atmel_classd *dd = snd_soc_card_get_drvdata(card);
+
+ return regcache_sync(dd->regmap);
+}
+
static struct regmap *atmel_classd_codec_get_remap(struct device *dev)
{
return dev_get_regmap(dev, NULL);
@@ -308,6 +316,7 @@ static struct regmap *atmel_classd_codec_get_remap(struct device *dev)
static struct snd_soc_codec_driver soc_codec_dev_classd = {
.probe = atmel_classd_codec_probe,
+ .resume = atmel_classd_codec_resume,
.get_regmap = atmel_classd_codec_get_remap,
.component_driver = {
.controls = atmel_classd_snd_controls,
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread