All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code
@ 2019-11-18 12:07 ` zhengbin
  0 siblings, 0 replies; 12+ messages in thread
From: zhengbin @ 2019-11-18 12:07 UTC (permalink / raw)
  To: tomi.valkeinen, airlied, daniel, sebastian.reichel,
	laurent.pinchart, dri-devel
  Cc: zhengbin13

zhengbin (4):
  drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
    hdmi_audio_register
  drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
    hdmi4_core_init
  drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
    hdmi5_core_init
  drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi_phy_init

 drivers/gpu/drm/omapdrm/dss/hdmi4.c      | 5 +----
 drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 5 +----
 drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 5 +----
 drivers/gpu/drm/omapdrm/dss/hdmi_phy.c   | 5 +----
 4 files changed, 4 insertions(+), 16 deletions(-)

--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 0/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code
@ 2019-11-18 12:07 ` zhengbin
  0 siblings, 0 replies; 12+ messages in thread
From: zhengbin @ 2019-11-18 12:07 UTC (permalink / raw)
  To: tomi.valkeinen, airlied, daniel, sebastian.reichel,
	laurent.pinchart, dri-devel
  Cc: zhengbin13

zhengbin (4):
  drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
    hdmi_audio_register
  drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
    hdmi4_core_init
  drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
    hdmi5_core_init
  drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi_phy_init

 drivers/gpu/drm/omapdrm/dss/hdmi4.c      | 5 +----
 drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 5 +----
 drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 5 +----
 drivers/gpu/drm/omapdrm/dss/hdmi_phy.c   | 5 +----
 4 files changed, 4 insertions(+), 16 deletions(-)

--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 1/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi_audio_register
@ 2019-11-18 12:07   ` zhengbin
  0 siblings, 0 replies; 12+ messages in thread
From: zhengbin @ 2019-11-18 12:07 UTC (permalink / raw)
  To: tomi.valkeinen, airlied, daniel, sebastian.reichel,
	laurent.pinchart, dri-devel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/gpu/drm/omapdrm/dss/hdmi4.c:590:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/omapdrm/dss/hdmi4.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
index 0f557fa..eb71bae 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
@@ -587,10 +587,7 @@ static int hdmi_audio_register(struct omap_hdmi *hdmi)
 		&hdmi->pdev->dev, "omap-hdmi-audio", PLATFORM_DEVID_AUTO,
 		&pdata, sizeof(pdata));

-	if (IS_ERR(hdmi->audio_pdev))
-		return PTR_ERR(hdmi->audio_pdev);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(hdmi->audio_pdev);
 }

 /* -----------------------------------------------------------------------------
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 1/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi_audio_register
@ 2019-11-18 12:07   ` zhengbin
  0 siblings, 0 replies; 12+ messages in thread
From: zhengbin @ 2019-11-18 12:07 UTC (permalink / raw)
  To: tomi.valkeinen, airlied, daniel, sebastian.reichel,
	laurent.pinchart, dri-devel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/gpu/drm/omapdrm/dss/hdmi4.c:590:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/omapdrm/dss/hdmi4.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
index 0f557fa..eb71bae 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
@@ -587,10 +587,7 @@ static int hdmi_audio_register(struct omap_hdmi *hdmi)
 		&hdmi->pdev->dev, "omap-hdmi-audio", PLATFORM_DEVID_AUTO,
 		&pdata, sizeof(pdata));

-	if (IS_ERR(hdmi->audio_pdev))
-		return PTR_ERR(hdmi->audio_pdev);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(hdmi->audio_pdev);
 }

 /* -----------------------------------------------------------------------------
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 2/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi4_core_init
@ 2019-11-18 12:07   ` zhengbin
  0 siblings, 0 replies; 12+ messages in thread
From: zhengbin @ 2019-11-18 12:07 UTC (permalink / raw)
  To: tomi.valkeinen, airlied, daniel, sebastian.reichel,
	laurent.pinchart, dri-devel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/gpu/drm/omapdrm/dss/hdmi4_core.c:927:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c
index ea5d5c2..ba512f8 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c
@@ -924,8 +924,5 @@ int hdmi4_core_init(struct platform_device *pdev, struct hdmi_core_data *core)

 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core");
 	core->base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(core->base))
-		return PTR_ERR(core->base);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(core->base);
 }
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 2/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi4_core_init
@ 2019-11-18 12:07   ` zhengbin
  0 siblings, 0 replies; 12+ messages in thread
From: zhengbin @ 2019-11-18 12:07 UTC (permalink / raw)
  To: tomi.valkeinen, airlied, daniel, sebastian.reichel,
	laurent.pinchart, dri-devel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/gpu/drm/omapdrm/dss/hdmi4_core.c:927:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c
index ea5d5c2..ba512f8 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c
@@ -924,8 +924,5 @@ int hdmi4_core_init(struct platform_device *pdev, struct hdmi_core_data *core)

 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core");
 	core->base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(core->base))
-		return PTR_ERR(core->base);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(core->base);
 }
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 3/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi5_core_init
@ 2019-11-18 12:07   ` zhengbin
  0 siblings, 0 replies; 12+ messages in thread
From: zhengbin @ 2019-11-18 12:07 UTC (permalink / raw)
  To: tomi.valkeinen, airlied, daniel, sebastian.reichel,
	laurent.pinchart, dri-devel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/gpu/drm/omapdrm/dss/hdmi5_core.c:911:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
index ff4d35c..b577969 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
@@ -908,8 +908,5 @@ int hdmi5_core_init(struct platform_device *pdev, struct hdmi_core_data *core)

 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core");
 	core->base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(core->base))
-		return PTR_ERR(core->base);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(core->base);
 }
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 3/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi5_core_init
@ 2019-11-18 12:07   ` zhengbin
  0 siblings, 0 replies; 12+ messages in thread
From: zhengbin @ 2019-11-18 12:07 UTC (permalink / raw)
  To: tomi.valkeinen, airlied, daniel, sebastian.reichel,
	laurent.pinchart, dri-devel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/gpu/drm/omapdrm/dss/hdmi5_core.c:911:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
index ff4d35c..b577969 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
@@ -908,8 +908,5 @@ int hdmi5_core_init(struct platform_device *pdev, struct hdmi_core_data *core)

 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core");
 	core->base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(core->base))
-		return PTR_ERR(core->base);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(core->base);
 }
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 4/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi_phy_init
@ 2019-11-18 12:07   ` zhengbin
  0 siblings, 0 replies; 12+ messages in thread
From: zhengbin @ 2019-11-18 12:07 UTC (permalink / raw)
  To: tomi.valkeinen, airlied, daniel, sebastian.reichel,
	laurent.pinchart, dri-devel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/gpu/drm/omapdrm/dss/hdmi_phy.c:194:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/omapdrm/dss/hdmi_phy.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c b/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c
index 00bbf24..408b2e0 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c
@@ -191,8 +191,5 @@ int hdmi_phy_init(struct platform_device *pdev, struct hdmi_phy_data *phy,

 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy");
 	phy->base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(phy->base))
-		return PTR_ERR(phy->base);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(phy->base);
 }
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 4/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi_phy_init
@ 2019-11-18 12:07   ` zhengbin
  0 siblings, 0 replies; 12+ messages in thread
From: zhengbin @ 2019-11-18 12:07 UTC (permalink / raw)
  To: tomi.valkeinen, airlied, daniel, sebastian.reichel,
	laurent.pinchart, dri-devel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/gpu/drm/omapdrm/dss/hdmi_phy.c:194:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/omapdrm/dss/hdmi_phy.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c b/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c
index 00bbf24..408b2e0 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c
@@ -191,8 +191,5 @@ int hdmi_phy_init(struct platform_device *pdev, struct hdmi_phy_data *phy,

 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy");
 	phy->base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(phy->base))
-		return PTR_ERR(phy->base);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(phy->base);
 }
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH 0/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code
@ 2019-11-18 12:09   ` Tomi Valkeinen
  0 siblings, 0 replies; 12+ messages in thread
From: Tomi Valkeinen @ 2019-11-18 12:09 UTC (permalink / raw)
  To: zhengbin, airlied, daniel, sebastian.reichel, laurent.pinchart,
	dri-devel

Hi zhengbin,

On 18/11/2019 14:07, zhengbin wrote:
> zhengbin (4):
>    drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
>      hdmi_audio_register
>    drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
>      hdmi4_core_init
>    drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
>      hdmi5_core_init
>    drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi_phy_init
> 
>   drivers/gpu/drm/omapdrm/dss/hdmi4.c      | 5 +----
>   drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 5 +----
>   drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 5 +----
>   drivers/gpu/drm/omapdrm/dss/hdmi_phy.c   | 5 +----
>   4 files changed, 4 insertions(+), 16 deletions(-)

Thanks, but I don't like PTR_ERR_OR_ZERO, I think it makes the code more 
difficult to read and manage.

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH 0/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code
@ 2019-11-18 12:09   ` Tomi Valkeinen
  0 siblings, 0 replies; 12+ messages in thread
From: Tomi Valkeinen @ 2019-11-18 12:09 UTC (permalink / raw)
  To: zhengbin, airlied, daniel, sebastian.reichel, laurent.pinchart,
	dri-devel

Hi zhengbin,

On 18/11/2019 14:07, zhengbin wrote:
> zhengbin (4):
>    drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
>      hdmi_audio_register
>    drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
>      hdmi4_core_init
>    drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
>      hdmi5_core_init
>    drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi_phy_init
> 
>   drivers/gpu/drm/omapdrm/dss/hdmi4.c      | 5 +----
>   drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 5 +----
>   drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 5 +----
>   drivers/gpu/drm/omapdrm/dss/hdmi_phy.c   | 5 +----
>   4 files changed, 4 insertions(+), 16 deletions(-)

Thanks, but I don't like PTR_ERR_OR_ZERO, I think it makes the code more 
difficult to read and manage.

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-11-19  8:06 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 12:07 [PATCH 0/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code zhengbin
2019-11-18 12:07 ` zhengbin
2019-11-18 12:07 ` [PATCH 1/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi_audio_register zhengbin
2019-11-18 12:07   ` zhengbin
2019-11-18 12:07 ` [PATCH 2/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi4_core_init zhengbin
2019-11-18 12:07   ` zhengbin
2019-11-18 12:07 ` [PATCH 3/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi5_core_init zhengbin
2019-11-18 12:07   ` zhengbin
2019-11-18 12:07 ` [PATCH 4/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi_phy_init zhengbin
2019-11-18 12:07   ` zhengbin
2019-11-18 12:09 ` [PATCH 0/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code Tomi Valkeinen
2019-11-18 12:09   ` Tomi Valkeinen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.