All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/3] selftests: do not require bash to run bpf tests
@ 2016-12-14 10:58 Rolf Eike Beer
  2016-12-14 11:03 ` Daniel Borkmann
  0 siblings, 1 reply; 3+ messages in thread
From: Rolf Eike Beer @ 2016-12-14 10:58 UTC (permalink / raw)
  To: linux-kselftest
  Cc: Daniel Borkmann, David S. Miller, netdev, Alexei Starovoitov,
	linux-kernel, Shuah Khan, Shuah Khan

>From b9d6c1b7427d708ef2d4d57aac17b700b3694d71 Mon Sep 17 00:00:00 2001
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
Date: Wed, 14 Dec 2016 09:58:12 +0100
Subject: [PATCH 2/3] selftests: do not require bash to run bpf tests

Nothing in this minimal script seems to require bash. We often run these tests
on embedded devices where the only shell available is the busybox ash.

Signed-off-by: Rolf Eike Beer <eb@emlix.com>
---
 tools/testing/selftests/bpf/test_kmod.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/test_kmod.sh b/tools/testing/selftests/bpf/test_kmod.sh
index 92e627a..6d58cca 100755
--- a/tools/testing/selftests/bpf/test_kmod.sh
+++ b/tools/testing/selftests/bpf/test_kmod.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 SRC_TREE=../../../../
 
-- 
2.8.3


-- 
Rolf Eike Beer, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11
Bertha-von-Suttner-Str. 9, 37085 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055

emlix – smart embedded open source

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/3] selftests: do not require bash to run bpf tests
  2016-12-14 10:58 [PATCH 2/3] selftests: do not require bash to run bpf tests Rolf Eike Beer
@ 2016-12-14 11:03 ` Daniel Borkmann
  2016-12-14 14:22   ` Shuah Khan
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Borkmann @ 2016-12-14 11:03 UTC (permalink / raw)
  To: Rolf Eike Beer, linux-kselftest
  Cc: David S. Miller, netdev, Alexei Starovoitov, linux-kernel,
	Shuah Khan, Shuah Khan

On 12/14/2016 11:58 AM, Rolf Eike Beer wrote:
>  From b9d6c1b7427d708ef2d4d57aac17b700b3694d71 Mon Sep 17 00:00:00 2001
> From: Rolf Eike Beer <eike-kernel@sf-tec.de>
> Date: Wed, 14 Dec 2016 09:58:12 +0100
> Subject: [PATCH 2/3] selftests: do not require bash to run bpf tests
>
> Nothing in this minimal script seems to require bash. We often run these tests
> on embedded devices where the only shell available is the busybox ash.
>
> Signed-off-by: Rolf Eike Beer <eb@emlix.com>

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/3] selftests: do not require bash to run bpf tests
  2016-12-14 11:03 ` Daniel Borkmann
@ 2016-12-14 14:22   ` Shuah Khan
  0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2016-12-14 14:22 UTC (permalink / raw)
  To: Daniel Borkmann, Rolf Eike Beer, linux-kselftest
  Cc: David S. Miller, netdev, Alexei Starovoitov, linux-kernel,
	Shuah Khan, Shuah Khan

On 12/14/2016 04:03 AM, Daniel Borkmann wrote:
> On 12/14/2016 11:58 AM, Rolf Eike Beer wrote:
>>  From b9d6c1b7427d708ef2d4d57aac17b700b3694d71 Mon Sep 17 00:00:00 2001
>> From: Rolf Eike Beer <eike-kernel@sf-tec.de>
>> Date: Wed, 14 Dec 2016 09:58:12 +0100
>> Subject: [PATCH 2/3] selftests: do not require bash to run bpf tests
>>
>> Nothing in this minimal script seems to require bash. We often run these tests
>> on embedded devices where the only shell available is the busybox ash.
>>
>> Signed-off-by: Rolf Eike Beer <eb@emlix.com>
> 
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>

Thanks. I will get these into 4.10-rc1 or rc2

-- Shuah

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-12-14 14:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-14 10:58 [PATCH 2/3] selftests: do not require bash to run bpf tests Rolf Eike Beer
2016-12-14 11:03 ` Daniel Borkmann
2016-12-14 14:22   ` Shuah Khan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.