* [Buildroot] [PATCH v2] package/ffmpeg: fix build on mips
@ 2021-09-22 21:09 Giulio Benetti
2021-10-06 19:24 ` Arnout Vandecappelle
2021-10-07 7:37 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Giulio Benetti @ 2021-09-22 21:09 UTC (permalink / raw)
To: Arnout Vandecappelle, buildroot
Cc: Bernd Kuhls, Giulio Benetti, Mahyar Koshkouei
mips_32 is not supported by ffmpeg and it tries to build with loongson3
SIMD support that leads to build failure due to:
/tmp/ccFO2LRa.s: Assembler messages:
/tmp/ccFO2LRa.s:15314: Error: opcode not supported on this processor: mips32 (mips32) `dmult $2,$6'
/tmp/ccFO2LRa.s:15316: Error: opcode not supported on this processor: mips32 (mips32) `dsrl $2,$2,32'
So let's --disable-asm to prevent using those unsupported opcodes for every
mips architecture according to Arnout.
Fixes:
http://autobuild.buildroot.net/results/f01/f01d9cedec8e1b371308d0f7af561a75883fa27c/
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/ffmpeg/ffmpeg.mk | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk
index 8ff8ea8c6c..b3ce4c0656 100644
--- a/package/ffmpeg/ffmpeg.mk
+++ b/package/ffmpeg/ffmpeg.mk
@@ -507,10 +507,8 @@ else
FFMPEG_CONF_OPTS += --enable-mipsfpu
endif
-# Fix build failure on "addi opcode not supported"
-ifeq ($(BR2_mips_32r6)$(BR2_mips_64r6),y)
+# Fix build failure on several missing assembly instructions
FFMPEG_CONF_OPTS += --disable-asm
-endif
endif # MIPS
ifeq ($(BR2_POWERPC_CPU_HAS_ALTIVEC),y)
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v2] package/ffmpeg: fix build on mips
2021-09-22 21:09 [Buildroot] [PATCH v2] package/ffmpeg: fix build on mips Giulio Benetti
@ 2021-10-06 19:24 ` Arnout Vandecappelle
2021-10-07 7:37 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2021-10-06 19:24 UTC (permalink / raw)
To: Giulio Benetti, buildroot; +Cc: Bernd Kuhls, Mahyar Koshkouei
On 22/09/2021 23:09, Giulio Benetti wrote:
> mips_32 is not supported by ffmpeg and it tries to build with loongson3
> SIMD support that leads to build failure due to:
> /tmp/ccFO2LRa.s: Assembler messages:
> /tmp/ccFO2LRa.s:15314: Error: opcode not supported on this processor: mips32 (mips32) `dmult $2,$6'
> /tmp/ccFO2LRa.s:15316: Error: opcode not supported on this processor: mips32 (mips32) `dsrl $2,$2,32'
>
> So let's --disable-asm to prevent using those unsupported opcodes for every
> mips architecture according to Arnout.
>
> Fixes:
> http://autobuild.buildroot.net/results/f01/f01d9cedec8e1b371308d0f7af561a75883fa27c/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Applied to master, thanks.
Regards,
Arnout
> ---
> package/ffmpeg/ffmpeg.mk | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk
> index 8ff8ea8c6c..b3ce4c0656 100644
> --- a/package/ffmpeg/ffmpeg.mk
> +++ b/package/ffmpeg/ffmpeg.mk
> @@ -507,10 +507,8 @@ else
> FFMPEG_CONF_OPTS += --enable-mipsfpu
> endif
>
> -# Fix build failure on "addi opcode not supported"
> -ifeq ($(BR2_mips_32r6)$(BR2_mips_64r6),y)
> +# Fix build failure on several missing assembly instructions
> FFMPEG_CONF_OPTS += --disable-asm
> -endif
> endif # MIPS
>
> ifeq ($(BR2_POWERPC_CPU_HAS_ALTIVEC),y)
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v2] package/ffmpeg: fix build on mips
2021-09-22 21:09 [Buildroot] [PATCH v2] package/ffmpeg: fix build on mips Giulio Benetti
2021-10-06 19:24 ` Arnout Vandecappelle
@ 2021-10-07 7:37 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-10-07 7:37 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Bernd Kuhls, Mahyar Koshkouei, buildroot
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> mips_32 is not supported by ffmpeg and it tries to build with loongson3
> SIMD support that leads to build failure due to:
> /tmp/ccFO2LRa.s: Assembler messages:
> /tmp/ccFO2LRa.s:15314: Error: opcode not supported on this processor: mips32 (mips32) `dmult $2,$6'
> /tmp/ccFO2LRa.s:15316: Error: opcode not supported on this processor: mips32 (mips32) `dsrl $2,$2,32'
> So let's --disable-asm to prevent using those unsupported opcodes for every
> mips architecture according to Arnout.
> Fixes:
> http://autobuild.buildroot.net/results/f01/f01d9cedec8e1b371308d0f7af561a75883fa27c/
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Committed to 2021.05.x and 2021.08.x, thanks. We don't have any
autobuilder failues on 2021.02.x, and I cannot reproduce it either here
so it may be related to ffmpeg 4.4.x.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-07 7:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-22 21:09 [Buildroot] [PATCH v2] package/ffmpeg: fix build on mips Giulio Benetti
2021-10-06 19:24 ` Arnout Vandecappelle
2021-10-07 7:37 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.