From: "Enrico Weigelt, metux IT consult" <lkml@metux.net> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: Jason Wang <jasowang@redhat.com>, "Enrico Weigelt, metux IT consult" <info@metux.net>, linux-kernel@vger.kernel.org, corbet@lwn.net, linus.walleij@linaro.org, bgolaszewski@baylibre.com, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-riscv@lists.infradead.org, stefanha@redhat.com, msuchanek@suse.de Subject: Re: [PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver Date: Mon, 7 Dec 2020 21:34:55 +0100 [thread overview] Message-ID: <dadc99c5-dd63-9b3e-aa00-c9dc0b622134@metux.net> (raw) In-Reply-To: <20201206075131-mutt-send-email-mst@kernel.org> On 07.12.20 14:52, Michael S. Tsirkin wrote: >> See above: NAK. because it can't even be enabled directly (by the user). >> If it wasn't meant otherwise, we'd have to add an menu text. > > The point is that user enables one of the bindings. > That in turn enables drivers. If we merely select VIRTIO > there's a chance user won't remember to select any bindings > and will be surprised not to see any devices. Not sure what you mean by "bindings" ... transports ? IMHO, transports and device drivers are entirely orthogonal. Both *use* the core, but I don't think they shall only show up, after the core was enabled explicitly. Any combination of transports is valid (having none at all, of course, isn't actually useful). >> When using other transports ? > > Any transport selects VIRTIO so if you enable that, you get > VIRTIO and thus it's enough to depend on it. The combination of 'select VIRTIO' and 'depends on VIRTIO' is what caused the recursive dependency. Chaning everything to 'select VIRTIO' fixed that. >> I don't thinkt that would be good - instead everybody should just select >> VIRTIO, never depend on it (maybe depend on VIRTIO_MENU instead) > > GPU depends on VIRTIO and on VIRTIO_MENU ... which seems even messier > ... See: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2404871.html --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287
WARNING: multiple messages have this Message-ID (diff)
From: "Enrico Weigelt, metux IT consult" <lkml@metux.net> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: stefanha@redhat.com, corbet@lwn.net, Jason Wang <jasowang@redhat.com>, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org, msuchanek@suse.de, "Enrico Weigelt, metux IT consult" <info@metux.net>, linus.walleij@linaro.org Subject: Re: [PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver Date: Mon, 7 Dec 2020 21:34:55 +0100 [thread overview] Message-ID: <dadc99c5-dd63-9b3e-aa00-c9dc0b622134@metux.net> (raw) In-Reply-To: <20201206075131-mutt-send-email-mst@kernel.org> On 07.12.20 14:52, Michael S. Tsirkin wrote: >> See above: NAK. because it can't even be enabled directly (by the user). >> If it wasn't meant otherwise, we'd have to add an menu text. > > The point is that user enables one of the bindings. > That in turn enables drivers. If we merely select VIRTIO > there's a chance user won't remember to select any bindings > and will be surprised not to see any devices. Not sure what you mean by "bindings" ... transports ? IMHO, transports and device drivers are entirely orthogonal. Both *use* the core, but I don't think they shall only show up, after the core was enabled explicitly. Any combination of transports is valid (having none at all, of course, isn't actually useful). >> When using other transports ? > > Any transport selects VIRTIO so if you enable that, you get > VIRTIO and thus it's enough to depend on it. The combination of 'select VIRTIO' and 'depends on VIRTIO' is what caused the recursive dependency. Chaning everything to 'select VIRTIO' fixed that. >> I don't thinkt that would be good - instead everybody should just select >> VIRTIO, never depend on it (maybe depend on VIRTIO_MENU instead) > > GPU depends on VIRTIO and on VIRTIO_MENU ... which seems even messier > ... See: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2404871.html --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2020-12-07 20:37 UTC|newest] Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-03 19:11 [PATCH v2 1/2] drivers: gpio: put virtual gpio device into their own submenu Enrico Weigelt, metux IT consult 2020-12-03 19:11 ` Enrico Weigelt, metux IT consult 2020-12-03 19:11 ` [PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver Enrico Weigelt, metux IT consult 2020-12-03 19:11 ` Enrico Weigelt, metux IT consult 2020-12-04 3:35 ` Jason Wang 2020-12-04 3:35 ` Jason Wang 2020-12-04 3:35 ` Jason Wang 2020-12-04 9:36 ` Enrico Weigelt, metux IT consult 2020-12-04 9:36 ` Enrico Weigelt, metux IT consult 2020-12-07 3:48 ` Jason Wang 2020-12-07 3:48 ` Jason Wang 2020-12-07 3:48 ` Jason Wang 2020-12-07 9:33 ` Enrico Weigelt, metux IT consult 2020-12-07 9:33 ` Enrico Weigelt, metux IT consult 2020-12-08 2:49 ` Jason Wang 2020-12-08 2:49 ` Jason Wang 2020-12-08 2:49 ` Jason Wang 2021-04-13 11:07 ` Alex Bennée 2021-04-13 11:07 ` Alex Bennée 2021-04-13 11:07 ` Alex Bennée 2020-12-05 7:59 ` Enrico Weigelt, metux IT consult 2020-12-05 7:59 ` Enrico Weigelt, metux IT consult 2020-12-05 19:32 ` Michael S. Tsirkin 2020-12-05 19:32 ` Michael S. Tsirkin 2020-12-05 19:32 ` Michael S. Tsirkin 2020-12-05 20:05 ` Enrico Weigelt, metux IT consult 2020-12-05 20:05 ` Enrico Weigelt, metux IT consult 2020-12-07 3:16 ` Jason Wang 2020-12-07 3:16 ` Jason Wang 2020-12-07 3:16 ` Jason Wang 2020-12-07 13:52 ` Michael S. Tsirkin 2020-12-07 13:52 ` Michael S. Tsirkin 2020-12-07 13:52 ` Michael S. Tsirkin 2020-12-07 20:34 ` Enrico Weigelt, metux IT consult [this message] 2020-12-07 20:34 ` Enrico Weigelt, metux IT consult 2020-12-07 3:12 ` Jason Wang 2020-12-07 3:12 ` Jason Wang 2020-12-07 3:12 ` Jason Wang 2020-12-07 13:53 ` Michael S. Tsirkin 2020-12-07 13:53 ` Michael S. Tsirkin 2020-12-07 13:53 ` Michael S. Tsirkin 2020-12-08 2:36 ` Jason Wang 2020-12-08 2:36 ` Jason Wang 2020-12-08 2:36 ` Jason Wang 2020-12-08 7:02 ` Enrico Weigelt, metux IT consult 2020-12-08 7:02 ` Enrico Weigelt, metux IT consult 2020-12-09 9:31 ` Jason Wang 2020-12-09 9:31 ` Jason Wang 2020-12-09 9:31 ` Jason Wang 2020-12-09 10:33 ` Enrico Weigelt, metux IT consult 2020-12-09 10:33 ` Enrico Weigelt, metux IT consult 2020-12-08 10:10 ` Michal Suchánek 2020-12-08 10:10 ` Michal Suchánek 2020-12-08 12:33 ` Enrico Weigelt, metux IT consult 2020-12-08 12:33 ` Enrico Weigelt, metux IT consult 2020-12-09 10:34 ` Michal Suchánek 2020-12-09 10:34 ` Michal Suchánek 2020-12-05 20:15 ` Howto listen to/handle gpio state changes ? " Enrico Weigelt, metux IT consult 2020-12-05 20:15 ` Enrico Weigelt, metux IT consult 2020-12-08 9:38 ` Linus Walleij 2020-12-08 9:38 ` Linus Walleij 2020-12-08 9:38 ` Linus Walleij 2020-12-08 14:04 ` Enrico Weigelt, metux IT consult 2020-12-08 14:04 ` Enrico Weigelt, metux IT consult 2020-12-08 16:15 ` Grygorii Strashko 2020-12-08 16:15 ` Grygorii Strashko 2020-12-09 8:51 ` Linus Walleij 2020-12-09 8:51 ` Linus Walleij 2020-12-09 8:51 ` Linus Walleij 2020-12-09 11:19 ` Arnd Bergmann 2020-12-09 11:19 ` Arnd Bergmann 2020-12-09 12:53 ` Linus Walleij 2020-12-09 12:53 ` Linus Walleij 2020-12-09 12:53 ` Linus Walleij 2020-12-09 20:22 ` Grygorii Strashko 2020-12-09 20:22 ` Grygorii Strashko 2020-12-09 20:38 ` Arnd Bergmann 2020-12-09 20:38 ` Arnd Bergmann 2020-12-10 13:32 ` Grygorii Strashko 2020-12-10 13:32 ` Grygorii Strashko 2021-05-24 11:27 ` Viresh Kumar 2021-05-24 11:27 ` Viresh Kumar 2021-05-25 12:59 ` Enrico Weigelt, metux IT consult 2021-05-25 12:59 ` Enrico Weigelt, metux IT consult 2021-05-26 3:32 ` Viresh Kumar 2021-05-26 3:32 ` Viresh Kumar 2021-07-03 8:05 ` Michael S. Tsirkin 2021-07-03 8:05 ` Michael S. Tsirkin 2021-07-03 8:05 ` Michael S. Tsirkin 2021-07-05 3:51 ` Viresh Kumar 2021-07-05 3:51 ` Viresh Kumar 2021-07-05 3:51 ` Viresh Kumar 2020-12-07 9:55 ` [PATCH v2 1/2] drivers: gpio: put virtual gpio device into their own submenu Andy Shevchenko 2020-12-07 9:55 ` Andy Shevchenko 2020-12-07 9:55 ` Andy Shevchenko 2020-12-07 10:31 ` Bartosz Golaszewski 2020-12-07 10:31 ` Bartosz Golaszewski 2020-12-07 11:22 ` Enrico Weigelt, metux IT consult 2020-12-07 11:22 ` Enrico Weigelt, metux IT consult
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=dadc99c5-dd63-9b3e-aa00-c9dc0b622134@metux.net \ --to=lkml@metux.net \ --cc=bgolaszewski@baylibre.com \ --cc=corbet@lwn.net \ --cc=info@metux.net \ --cc=jasowang@redhat.com \ --cc=linus.walleij@linaro.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=mst@redhat.com \ --cc=msuchanek@suse.de \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.