Re: [PATCH v13 4/9] x86: add multiboot2 protocol support for EFI platforms

[Doug Goldstein <cardoe@cardoe.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1429 bytes --]

On 1/25/17 4:11 PM, Daniel Kiper wrote:
> This way Xen can be loaded on EFI platforms using GRUB2 and
> other boot loaders which support multiboot2 protocol.
> 
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> ---
> v13 - suggestions/fixes:
>     - move vga_text_buffer and efi_platform to .init.data section
>       (suggested by Jan Beulich),
>     - reduce number of error branches in EFI code in xen/arch/x86/boot/head.S
>       (suggested by Jan Beulich),
>     - rename run_bs label to .Lrun_bs
>       (suggested by Jan Beulich),
>     - align the stack as UEFI spec requires
>       (suggested by Jan Beulich),
>     - change trampoline region memory layout
>       (suggested by Jan Beulich),
>     - revert changes in efi_arch_pre_exit_boot()
>       (suggested by Jan Beulich),
>     - relocate_trampoline() must set trampoline_phys for all bootloaders;
>       otherwise fallback allocator is always used if Xen was loaded with
>       Multiboot2 protocol,
>     - change err type in efi_multiboot2() to "static const CHAR16 __initconst"
>       (suggested by Jan Beulich),
>     - change asm "g" constraint to "rm" in efi_multiboot2()
>       (suggested by Jan Beulich),
>     - improve comments
>       (suggested by Jan Beulich and Doug Goldstein).

This is a huge change and would really be helpful to have the diff of
what's changed to work from.

-- 
Doug Goldstein


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel