[PATCH wpan-next] ieee802154: 6lowpan: set IFF_NO_QUEUE

[PATCH wpan-next] ieee802154: 6lowpan: set IFF_NO_QUEUE

[Alexander Aring]

This patch sets the IFF_NO_QUEUE for IEEE 802.15.4 6lowpan interfaces. As
commit 24dcbf662205 ("6lowpan: Don't set IFF_NO_QUEUE") removes it for
"reasons" from the bluetooth 6lowpan subsystem. In IEEE 802.15.4 the lower
interface deals with one qdisc for the real hardware, 6LoWPAN does the
protocol adaption only and no second queuing on top.

Signed-off-by: Alexander Aring <aring@mojatatu.com>
---
 net/ieee802154/6lowpan/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
index 974765b7d92a..e4f305320519 100644
--- a/net/ieee802154/6lowpan/core.c
+++ b/net/ieee802154/6lowpan/core.c
@@ -104,6 +104,7 @@ static void lowpan_setup(struct net_device *ldev)
 	/* We need an ipv6hdr as minimum len when calling xmit */
 	ldev->hard_header_len	= sizeof(struct ipv6hdr);
 	ldev->flags		= IFF_BROADCAST | IFF_MULTICAST;
+	ldev->priv_flags	|= IFF_NO_QUEUE;
 
 	ldev->netdev_ops	= &lowpan_netdev_ops;
 	ldev->header_ops	= &lowpan_header_ops;
-- 
2.11.0

Re: [PATCH wpan-next] ieee802154: 6lowpan: set IFF_NO_QUEUE

[Stefan Schmidt]

Hello.


On 02/12/2018 04:50 AM, Alexander Aring wrote:
> This patch sets the IFF_NO_QUEUE for IEEE 802.15.4 6lowpan interfaces. As
> commit 24dcbf662205 ("6lowpan: Don't set IFF_NO_QUEUE") removes it for
> "reasons" from the bluetooth 6lowpan subsystem. In IEEE 802.15.4 the lower
> interface deals with one qdisc for the real hardware, 6LoWPAN does the
> protocol adaption only and no second queuing on top.
>
> Signed-off-by: Alexander Aring <aring@mojatatu.com>
> ---
>  net/ieee802154/6lowpan/core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
> index 974765b7d92a..e4f305320519 100644
> --- a/net/ieee802154/6lowpan/core.c
> +++ b/net/ieee802154/6lowpan/core.c
> @@ -104,6 +104,7 @@ static void lowpan_setup(struct net_device *ldev)
>  	/* We need an ipv6hdr as minimum len when calling xmit */
>  	ldev->hard_header_len	= sizeof(struct ipv6hdr);
>  	ldev->flags		= IFF_BROADCAST | IFF_MULTICAST;
> +	ldev->priv_flags	|= IFF_NO_QUEUE;
>  
>  	ldev->netdev_ops	= &lowpan_netdev_ops;
>  	ldev->header_ops	= &lowpan_header_ops;

This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt