All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Marcelo Tosatti <mtosatti@redhat.com>
Subject: [PATCH 30/37] kvm: x86: Prepare VCPU loop for in-kernel irqchip
Date: Mon, 14 Feb 2011 13:22:59 -0200	[thread overview]
Message-ID: <db1669bcca7cc67d7301394d7d59dffb4c0fc9b0.1297696986.git.mtosatti@redhat.com> (raw)
In-Reply-To: <cover.1297696986.git.mtosatti@redhat.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

Effectively no functional change yet as kvm_irqchip_in_kernel still only
returns 0, but this patch will allow qemu-kvm to adopt the VCPU loop of
upsteam KVM.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
 target-i386/kvm.c |   69 +++++++++++++++++++++++++++++-----------------------
 1 files changed, 38 insertions(+), 31 deletions(-)

diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 377a0a3..f02f478 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -1442,11 +1442,6 @@ int kvm_arch_get_registers(CPUState *env)
 
 int kvm_arch_pre_run(CPUState *env, struct kvm_run *run)
 {
-    /* Force the VCPU out of its inner loop to process the INIT request */
-    if (env->interrupt_request & CPU_INTERRUPT_INIT) {
-        env->exit_request = 1;
-    }
-
     /* Inject NMI */
     if (env->interrupt_request & CPU_INTERRUPT_NMI) {
         env->interrupt_request &= ~CPU_INTERRUPT_NMI;
@@ -1454,35 +1449,43 @@ int kvm_arch_pre_run(CPUState *env, struct kvm_run *run)
         kvm_vcpu_ioctl(env, KVM_NMI);
     }
 
-    /* Try to inject an interrupt if the guest can accept it */
-    if (run->ready_for_interrupt_injection &&
-        (env->interrupt_request & CPU_INTERRUPT_HARD) &&
-        (env->eflags & IF_MASK)) {
-        int irq;
-
-        env->interrupt_request &= ~CPU_INTERRUPT_HARD;
-        irq = cpu_get_pic_interrupt(env);
-        if (irq >= 0) {
-            struct kvm_interrupt intr;
-            intr.irq = irq;
-            /* FIXME: errors */
-            DPRINTF("injected interrupt %d\n", irq);
-            kvm_vcpu_ioctl(env, KVM_INTERRUPT, &intr);
+    if (!kvm_irqchip_in_kernel()) {
+        /* Force the VCPU out of its inner loop to process the INIT request */
+        if (env->interrupt_request & CPU_INTERRUPT_INIT) {
+            env->exit_request = 1;
         }
-    }
 
-    /* If we have an interrupt but the guest is not ready to receive an
-     * interrupt, request an interrupt window exit.  This will
-     * cause a return to userspace as soon as the guest is ready to
-     * receive interrupts. */
-    if ((env->interrupt_request & CPU_INTERRUPT_HARD)) {
-        run->request_interrupt_window = 1;
-    } else {
-        run->request_interrupt_window = 0;
-    }
+        /* Try to inject an interrupt if the guest can accept it */
+        if (run->ready_for_interrupt_injection &&
+            (env->interrupt_request & CPU_INTERRUPT_HARD) &&
+            (env->eflags & IF_MASK)) {
+            int irq;
+
+            env->interrupt_request &= ~CPU_INTERRUPT_HARD;
+            irq = cpu_get_pic_interrupt(env);
+            if (irq >= 0) {
+                struct kvm_interrupt intr;
+
+                intr.irq = irq;
+                /* FIXME: errors */
+                DPRINTF("injected interrupt %d\n", irq);
+                kvm_vcpu_ioctl(env, KVM_INTERRUPT, &intr);
+            }
+        }
 
-    DPRINTF("setting tpr\n");
-    run->cr8 = cpu_get_apic_tpr(env->apic_state);
+        /* If we have an interrupt but the guest is not ready to receive an
+         * interrupt, request an interrupt window exit.  This will
+         * cause a return to userspace as soon as the guest is ready to
+         * receive interrupts. */
+        if ((env->interrupt_request & CPU_INTERRUPT_HARD)) {
+            run->request_interrupt_window = 1;
+        } else {
+            run->request_interrupt_window = 0;
+        }
+
+        DPRINTF("setting tpr\n");
+        run->cr8 = cpu_get_apic_tpr(env->apic_state);
+    }
 
     return 0;
 }
@@ -1502,6 +1505,10 @@ int kvm_arch_post_run(CPUState *env, struct kvm_run *run)
 
 int kvm_arch_process_irqchip_events(CPUState *env)
 {
+    if (kvm_irqchip_in_kernel()) {
+        return 0;
+    }
+
     if (env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI)) {
         env->halted = 0;
     }
-- 
1.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH 30/37] kvm: x86: Prepare VCPU loop for in-kernel irqchip
Date: Mon, 14 Feb 2011 13:22:59 -0200	[thread overview]
Message-ID: <db1669bcca7cc67d7301394d7d59dffb4c0fc9b0.1297696986.git.mtosatti@redhat.com> (raw)
In-Reply-To: <cover.1297696986.git.mtosatti@redhat.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

Effectively no functional change yet as kvm_irqchip_in_kernel still only
returns 0, but this patch will allow qemu-kvm to adopt the VCPU loop of
upsteam KVM.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
 target-i386/kvm.c |   69 +++++++++++++++++++++++++++++-----------------------
 1 files changed, 38 insertions(+), 31 deletions(-)

diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 377a0a3..f02f478 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -1442,11 +1442,6 @@ int kvm_arch_get_registers(CPUState *env)
 
 int kvm_arch_pre_run(CPUState *env, struct kvm_run *run)
 {
-    /* Force the VCPU out of its inner loop to process the INIT request */
-    if (env->interrupt_request & CPU_INTERRUPT_INIT) {
-        env->exit_request = 1;
-    }
-
     /* Inject NMI */
     if (env->interrupt_request & CPU_INTERRUPT_NMI) {
         env->interrupt_request &= ~CPU_INTERRUPT_NMI;
@@ -1454,35 +1449,43 @@ int kvm_arch_pre_run(CPUState *env, struct kvm_run *run)
         kvm_vcpu_ioctl(env, KVM_NMI);
     }
 
-    /* Try to inject an interrupt if the guest can accept it */
-    if (run->ready_for_interrupt_injection &&
-        (env->interrupt_request & CPU_INTERRUPT_HARD) &&
-        (env->eflags & IF_MASK)) {
-        int irq;
-
-        env->interrupt_request &= ~CPU_INTERRUPT_HARD;
-        irq = cpu_get_pic_interrupt(env);
-        if (irq >= 0) {
-            struct kvm_interrupt intr;
-            intr.irq = irq;
-            /* FIXME: errors */
-            DPRINTF("injected interrupt %d\n", irq);
-            kvm_vcpu_ioctl(env, KVM_INTERRUPT, &intr);
+    if (!kvm_irqchip_in_kernel()) {
+        /* Force the VCPU out of its inner loop to process the INIT request */
+        if (env->interrupt_request & CPU_INTERRUPT_INIT) {
+            env->exit_request = 1;
         }
-    }
 
-    /* If we have an interrupt but the guest is not ready to receive an
-     * interrupt, request an interrupt window exit.  This will
-     * cause a return to userspace as soon as the guest is ready to
-     * receive interrupts. */
-    if ((env->interrupt_request & CPU_INTERRUPT_HARD)) {
-        run->request_interrupt_window = 1;
-    } else {
-        run->request_interrupt_window = 0;
-    }
+        /* Try to inject an interrupt if the guest can accept it */
+        if (run->ready_for_interrupt_injection &&
+            (env->interrupt_request & CPU_INTERRUPT_HARD) &&
+            (env->eflags & IF_MASK)) {
+            int irq;
+
+            env->interrupt_request &= ~CPU_INTERRUPT_HARD;
+            irq = cpu_get_pic_interrupt(env);
+            if (irq >= 0) {
+                struct kvm_interrupt intr;
+
+                intr.irq = irq;
+                /* FIXME: errors */
+                DPRINTF("injected interrupt %d\n", irq);
+                kvm_vcpu_ioctl(env, KVM_INTERRUPT, &intr);
+            }
+        }
 
-    DPRINTF("setting tpr\n");
-    run->cr8 = cpu_get_apic_tpr(env->apic_state);
+        /* If we have an interrupt but the guest is not ready to receive an
+         * interrupt, request an interrupt window exit.  This will
+         * cause a return to userspace as soon as the guest is ready to
+         * receive interrupts. */
+        if ((env->interrupt_request & CPU_INTERRUPT_HARD)) {
+            run->request_interrupt_window = 1;
+        } else {
+            run->request_interrupt_window = 0;
+        }
+
+        DPRINTF("setting tpr\n");
+        run->cr8 = cpu_get_apic_tpr(env->apic_state);
+    }
 
     return 0;
 }
@@ -1502,6 +1505,10 @@ int kvm_arch_post_run(CPUState *env, struct kvm_run *run)
 
 int kvm_arch_process_irqchip_events(CPUState *env)
 {
+    if (kvm_irqchip_in_kernel()) {
+        return 0;
+    }
+
     if (env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI)) {
         env->halted = 0;
     }
-- 
1.7.4

  parent reply	other threads:[~2011-02-14 15:25 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14 15:22 [PATCH 00/37] [PULL] qemu-kvm.git uq/master queue Marcelo Tosatti
2011-02-14 15:22 ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 01/37] Prevent abortion on multiple VCPU kicks Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 02/37] Stop current VCPU on synchronous reset requests Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 03/37] Process vmstop requests in IO thread Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 04/37] Trigger exit from cpu_exec_all on pending IO events Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 05/37] Leave inner main_loop faster on pending requests Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 06/37] Flatten the main loop Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 07/37] kvm: Report proper error on GET_VCPU_MMAP_SIZE failures Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 08/37] kvm: Drop redundant kvm_enabled from kvm_cpu_thread_fn Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 09/37] kvm: Handle kvm_init_vcpu errors Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 10/37] kvm: Provide sigbus services arch-independently Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 11/37] Refactor signal setup functions in cpus.c Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 12/37] kvm: Set up signal mask also for !CONFIG_IOTHREAD Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 13/37] kvm: Refactor qemu_kvm_eat_signals Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 14/37] kvm: Call qemu_kvm_eat_signals also under !CONFIG_IOTHREAD Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 15/37] Set up signalfd " Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 16/37] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 17/37] kvm: Add MCE signal support for !CONFIG_IOTHREAD Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 18/37] Introduce VCPU self-signaling service Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 19/37] kvm: Unconditionally reenter kernel after IO exits Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 20/37] kvm: Remove static return code of kvm_handle_io Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 21/37] kvm: Leave kvm_cpu_exec directly after KVM_EXIT_SHUTDOWN Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 22/37] kvm: make tsc stable over migration and machine start Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 23/37] Refactor kvm&tcg function names in cpus.c Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 24/37] Refactor cpu_has_work/any_cpu_has_work " Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 25/37] Fix a few coding style violations " Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 26/37] Improve vm_stop reason declarations Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 27/37] Refactor debug and vmstop request interface Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` [PATCH 28/37] Move debug exception handling out of cpu_exec Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-03-07  1:52   ` TeLeMan
2011-03-07  1:52     ` TeLeMan
2011-03-07  8:26     ` Jan Kiszka
2011-03-07  8:26       ` Jan Kiszka
2011-03-07  8:54       ` Jan Kiszka
2011-03-07  8:54         ` Jan Kiszka
2011-03-07 10:12         ` TeLeMan
2011-03-07 10:12           ` TeLeMan
2011-02-14 15:22 ` [PATCH 29/37] kvm: Separate TCG from KVM cpu execution Marcelo Tosatti
2011-02-14 15:22   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:22 ` Marcelo Tosatti [this message]
2011-02-14 15:22   ` [Qemu-devel] [PATCH 30/37] kvm: x86: Prepare VCPU loop for in-kernel irqchip Marcelo Tosatti
2011-02-14 15:23 ` [PATCH 31/37] kvm: Drop return values from kvm_arch_pre/post_run Marcelo Tosatti
2011-02-14 15:23   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:23 ` [PATCH 32/37] kvm: x86: Catch and report failing IRQ and NMI injections Marcelo Tosatti
2011-02-14 15:23   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:23 ` [PATCH 33/37] kvm: Remove unneeded memory slot reservation Marcelo Tosatti
2011-02-14 15:23   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:23 ` [PATCH 34/37] Introduce log_start/log_stop in CPUPhysMemoryClient Marcelo Tosatti
2011-02-14 15:23   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:23 ` [PATCH 35/37] cirrus: Remove obsolete kvm.h include Marcelo Tosatti
2011-02-14 15:23   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:23 ` [PATCH 36/37] kvm: Make kvm_state globally available Marcelo Tosatti
2011-02-14 15:23   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 15:23 ` [PATCH 37/37] kvm: x86: Introduce kvmclock device to save/restore its state Marcelo Tosatti
2011-02-14 15:23   ` [Qemu-devel] " Marcelo Tosatti
2011-02-14 20:17 ` [Qemu-devel] [PATCH 00/37] [PULL] qemu-kvm.git uq/master queue Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db1669bcca7cc67d7301394d7d59dffb4c0fc9b0.1297696986.git.mtosatti@redhat.com \
    --to=mtosatti@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.