* [PATCH] ARM: dma-mapping: add in missing white space in error message text
@ 2016-09-12 12:52 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2016-09-12 12:52 UTC (permalink / raw)
To: Russell King, Vineet Gupta, Hans-Christian Noren Egtvedt,
Joerg Roedel, Robin Murphy, Jesper Nilsson, Krzysztof Kozlowski,
linux-arm-kernel
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
A dev_warn message spans two lines and the literal string is missing
a white space between words. Add the white space.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/arm/common/dmabounce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
index 3012816..f47767b 100644
--- a/arch/arm/common/dmabounce.c
+++ b/arch/arm/common/dmabounce.c
@@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
if (!device_info) {
dev_warn(dev,
- "Never registered with dmabounce but attempting"
+ "Never registered with dmabounce but attempting "
"to unregister!\n");
return;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ARM: dma-mapping: add in missing white space in error message text
@ 2016-09-12 12:52 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2016-09-12 12:52 UTC (permalink / raw)
To: linux-arm-kernel
From: Colin Ian King <colin.king@canonical.com>
A dev_warn message spans two lines and the literal string is missing
a white space between words. Add the white space.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/arm/common/dmabounce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
index 3012816..f47767b 100644
--- a/arch/arm/common/dmabounce.c
+++ b/arch/arm/common/dmabounce.c
@@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
if (!device_info) {
dev_warn(dev,
- "Never registered with dmabounce but attempting"
+ "Never registered with dmabounce but attempting "
"to unregister!\n");
return;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text
2016-09-12 12:52 ` Colin King
@ 2016-09-12 13:06 ` Robin Murphy
-1 siblings, 0 replies; 8+ messages in thread
From: Robin Murphy @ 2016-09-12 13:06 UTC (permalink / raw)
To: Colin King, Russell King, Vineet Gupta,
Hans-Christian Noren Egtvedt, Joerg Roedel, Jesper Nilsson,
Krzysztof Kozlowski, linux-arm-kernel
Cc: linux-kernel
On 12/09/16 13:52, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A dev_warn message spans two lines and the literal string is missing
> a white space between words. Add the white space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/arm/common/dmabounce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
> index 3012816..f47767b 100644
> --- a/arch/arm/common/dmabounce.c
> +++ b/arch/arm/common/dmabounce.c
> @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
>
> if (!device_info) {
> dev_warn(dev,
> - "Never registered with dmabounce but attempting"
> + "Never registered with dmabounce but attempting "
> "to unregister!\n");
Per Documentation/CodingStyle, better to put the whole thing onto one
line so that, say, "git grep 'attempting to unregister'" doesn't leave
one scratching ones head in confusion.
Of course, even better would be to get rid of the whole thing and
convert ARM to use SWIOTLB, but hey, one thing at a time ;)
Robin.
> return;
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: dma-mapping: add in missing white space in error message text
@ 2016-09-12 13:06 ` Robin Murphy
0 siblings, 0 replies; 8+ messages in thread
From: Robin Murphy @ 2016-09-12 13:06 UTC (permalink / raw)
To: linux-arm-kernel
On 12/09/16 13:52, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A dev_warn message spans two lines and the literal string is missing
> a white space between words. Add the white space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/arm/common/dmabounce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
> index 3012816..f47767b 100644
> --- a/arch/arm/common/dmabounce.c
> +++ b/arch/arm/common/dmabounce.c
> @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
>
> if (!device_info) {
> dev_warn(dev,
> - "Never registered with dmabounce but attempting"
> + "Never registered with dmabounce but attempting "
> "to unregister!\n");
Per Documentation/CodingStyle, better to put the whole thing onto one
line so that, say, "git grep 'attempting to unregister'" doesn't leave
one scratching ones head in confusion.
Of course, even better would be to get rid of the whole thing and
convert ARM to use SWIOTLB, but hey, one thing at a time ;)
Robin.
> return;
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text
2016-09-12 13:06 ` Robin Murphy
@ 2016-09-12 14:33 ` Russell King - ARM Linux
-1 siblings, 0 replies; 8+ messages in thread
From: Russell King - ARM Linux @ 2016-09-12 14:33 UTC (permalink / raw)
To: Robin Murphy
Cc: Colin King, Vineet Gupta, Hans-Christian Noren Egtvedt,
Joerg Roedel, Jesper Nilsson, Krzysztof Kozlowski,
linux-arm-kernel, linux-kernel
On Mon, Sep 12, 2016 at 02:06:09PM +0100, Robin Murphy wrote:
> On 12/09/16 13:52, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > A dev_warn message spans two lines and the literal string is missing
> > a white space between words. Add the white space.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > arch/arm/common/dmabounce.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
> > index 3012816..f47767b 100644
> > --- a/arch/arm/common/dmabounce.c
> > +++ b/arch/arm/common/dmabounce.c
> > @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
> >
> > if (!device_info) {
> > dev_warn(dev,
> > - "Never registered with dmabounce but attempting"
> > + "Never registered with dmabounce but attempting "
> > "to unregister!\n");
>
> Per Documentation/CodingStyle, better to put the whole thing onto one
> line so that, say, "git grep 'attempting to unregister'" doesn't leave
> one scratching ones head in confusion.
>
> Of course, even better would be to get rid of the whole thing and
> convert ARM to use SWIOTLB, but hey, one thing at a time ;)
I doubt that can happen - dmabounce does a little more than swiotlb
because it copes with DMA masks that are _not_ a number of zeros
followed by one bits. It was written to support things like SA1111
DMA, where the device has a bug in that it can't drive certain
SDRAM address bits correctly.
It also gets used for ITE8512 PCI controllers and IXP4xx platforms,
although these should probably be converted to SWIOTLB. However,
without having test systems, I'd recommend leaving them as-is.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: dma-mapping: add in missing white space in error message text
@ 2016-09-12 14:33 ` Russell King - ARM Linux
0 siblings, 0 replies; 8+ messages in thread
From: Russell King - ARM Linux @ 2016-09-12 14:33 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Sep 12, 2016 at 02:06:09PM +0100, Robin Murphy wrote:
> On 12/09/16 13:52, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > A dev_warn message spans two lines and the literal string is missing
> > a white space between words. Add the white space.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > arch/arm/common/dmabounce.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
> > index 3012816..f47767b 100644
> > --- a/arch/arm/common/dmabounce.c
> > +++ b/arch/arm/common/dmabounce.c
> > @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
> >
> > if (!device_info) {
> > dev_warn(dev,
> > - "Never registered with dmabounce but attempting"
> > + "Never registered with dmabounce but attempting "
> > "to unregister!\n");
>
> Per Documentation/CodingStyle, better to put the whole thing onto one
> line so that, say, "git grep 'attempting to unregister'" doesn't leave
> one scratching ones head in confusion.
>
> Of course, even better would be to get rid of the whole thing and
> convert ARM to use SWIOTLB, but hey, one thing at a time ;)
I doubt that can happen - dmabounce does a little more than swiotlb
because it copes with DMA masks that are _not_ a number of zeros
followed by one bits. It was written to support things like SA1111
DMA, where the device has a bug in that it can't drive certain
SDRAM address bits correctly.
It also gets used for ITE8512 PCI controllers and IXP4xx platforms,
although these should probably be converted to SWIOTLB. However,
without having test systems, I'd recommend leaving them as-is.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text
2016-09-12 14:33 ` Russell King - ARM Linux
@ 2016-09-12 14:52 ` Colin Ian King
-1 siblings, 0 replies; 8+ messages in thread
From: Colin Ian King @ 2016-09-12 14:52 UTC (permalink / raw)
To: Russell King - ARM Linux, Robin Murphy
Cc: Vineet Gupta, Hans-Christian Noren Egtvedt, Joerg Roedel,
Jesper Nilsson, Krzysztof Kozlowski, linux-arm-kernel,
linux-kernel
On 12/09/16 15:33, Russell King - ARM Linux wrote:
> On Mon, Sep 12, 2016 at 02:06:09PM +0100, Robin Murphy wrote:
>> On 12/09/16 13:52, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> A dev_warn message spans two lines and the literal string is missing
>>> a white space between words. Add the white space.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> arch/arm/common/dmabounce.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
>>> index 3012816..f47767b 100644
>>> --- a/arch/arm/common/dmabounce.c
>>> +++ b/arch/arm/common/dmabounce.c
>>> @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
>>>
>>> if (!device_info) {
>>> dev_warn(dev,
>>> - "Never registered with dmabounce but attempting"
>>> + "Never registered with dmabounce but attempting "
>>> "to unregister!\n");
>>
>> Per Documentation/CodingStyle, better to put the whole thing onto one
>> line so that, say, "git grep 'attempting to unregister'" doesn't leave
>> one scratching ones head in confusion.
>>
>> Of course, even better would be to get rid of the whole thing and
>> convert ARM to use SWIOTLB, but hey, one thing at a time ;)
>
> I doubt that can happen - dmabounce does a little more than swiotlb
> because it copes with DMA masks that are _not_ a number of zeros
> followed by one bits. It was written to support things like SA1111
> DMA, where the device has a bug in that it can't drive certain
> SDRAM address bits correctly.
>
> It also gets used for ITE8512 PCI controllers and IXP4xx platforms,
> although these should probably be converted to SWIOTLB. However,
> without having test systems, I'd recommend leaving them as-is.
>
OK, nevermind this patch, drop it into /dev/null
Colin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: dma-mapping: add in missing white space in error message text
@ 2016-09-12 14:52 ` Colin Ian King
0 siblings, 0 replies; 8+ messages in thread
From: Colin Ian King @ 2016-09-12 14:52 UTC (permalink / raw)
To: linux-arm-kernel
On 12/09/16 15:33, Russell King - ARM Linux wrote:
> On Mon, Sep 12, 2016 at 02:06:09PM +0100, Robin Murphy wrote:
>> On 12/09/16 13:52, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> A dev_warn message spans two lines and the literal string is missing
>>> a white space between words. Add the white space.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> arch/arm/common/dmabounce.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
>>> index 3012816..f47767b 100644
>>> --- a/arch/arm/common/dmabounce.c
>>> +++ b/arch/arm/common/dmabounce.c
>>> @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
>>>
>>> if (!device_info) {
>>> dev_warn(dev,
>>> - "Never registered with dmabounce but attempting"
>>> + "Never registered with dmabounce but attempting "
>>> "to unregister!\n");
>>
>> Per Documentation/CodingStyle, better to put the whole thing onto one
>> line so that, say, "git grep 'attempting to unregister'" doesn't leave
>> one scratching ones head in confusion.
>>
>> Of course, even better would be to get rid of the whole thing and
>> convert ARM to use SWIOTLB, but hey, one thing at a time ;)
>
> I doubt that can happen - dmabounce does a little more than swiotlb
> because it copes with DMA masks that are _not_ a number of zeros
> followed by one bits. It was written to support things like SA1111
> DMA, where the device has a bug in that it can't drive certain
> SDRAM address bits correctly.
>
> It also gets used for ITE8512 PCI controllers and IXP4xx platforms,
> although these should probably be converted to SWIOTLB. However,
> without having test systems, I'd recommend leaving them as-is.
>
OK, nevermind this patch, drop it into /dev/null
Colin
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-09-12 14:53 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-12 12:52 [PATCH] ARM: dma-mapping: add in missing white space in error message text Colin King
2016-09-12 12:52 ` Colin King
2016-09-12 13:06 ` Robin Murphy
2016-09-12 13:06 ` Robin Murphy
2016-09-12 14:33 ` Russell King - ARM Linux
2016-09-12 14:33 ` Russell King - ARM Linux
2016-09-12 14:52 ` Colin Ian King
2016-09-12 14:52 ` Colin Ian King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.