* [PATCH 1/2] dt-bindings: input: sun4i-lradc-keys: add R329 LRADC binding
@ 2022-04-22 16:07 ` icenowy
0 siblings, 0 replies; 6+ messages in thread
From: icenowy @ 2022-04-22 16:07 UTC (permalink / raw)
To: Hans de Goede, Dmitry Torokhov, Rob Herring, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Maxime Ripard
Cc: linux-input, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel, Icenowy Zheng
From: Icenowy Zheng <icenowy@sipeed.com>
R329 has similar LRADC with previous Allwinner SoCs, but with bus clock
and reset.
Add binding for it.
Signed-off-by: Icenowy Zheng <icenowy@sipeed.com>
---
.../input/allwinner,sun4i-a10-lradc-keys.yaml | 21 +++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
index d74f2002409e..e16f01510ea7 100644
--- a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
+++ b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
@@ -15,6 +15,7 @@ properties:
oneOf:
- const: allwinner,sun4i-a10-lradc-keys
- const: allwinner,sun8i-a83t-r-lradc
+ - const: allwinner,sun50i-r329-lradc
- items:
- const: allwinner,sun50i-a64-lradc
- const: allwinner,sun8i-a83t-r-lradc
@@ -31,6 +32,26 @@ properties:
wakeup-source: true
+if:
+ properties:
+ compatible:
+ const: allwinner,sun50i-r329-lradc
+then:
+ properties:
+ clocks:
+ description:
+ Bus clock gate for LRADC.
+ maxItems: 1
+
+ resets:
+ description:
+ Bus reset for LRADC.
+ maxItems: 1
+
+ required:
+ - clocks
+ - resets
+
patternProperties:
"^button-[0-9]+$":
type: object
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/2] dt-bindings: input: sun4i-lradc-keys: add R329 LRADC binding
@ 2022-04-22 16:07 ` icenowy
0 siblings, 0 replies; 6+ messages in thread
From: icenowy @ 2022-04-22 16:07 UTC (permalink / raw)
To: Hans de Goede, Dmitry Torokhov, Rob Herring, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Maxime Ripard
Cc: linux-input, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel, Icenowy Zheng
From: Icenowy Zheng <icenowy@sipeed.com>
R329 has similar LRADC with previous Allwinner SoCs, but with bus clock
and reset.
Add binding for it.
Signed-off-by: Icenowy Zheng <icenowy@sipeed.com>
---
.../input/allwinner,sun4i-a10-lradc-keys.yaml | 21 +++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
index d74f2002409e..e16f01510ea7 100644
--- a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
+++ b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
@@ -15,6 +15,7 @@ properties:
oneOf:
- const: allwinner,sun4i-a10-lradc-keys
- const: allwinner,sun8i-a83t-r-lradc
+ - const: allwinner,sun50i-r329-lradc
- items:
- const: allwinner,sun50i-a64-lradc
- const: allwinner,sun8i-a83t-r-lradc
@@ -31,6 +32,26 @@ properties:
wakeup-source: true
+if:
+ properties:
+ compatible:
+ const: allwinner,sun50i-r329-lradc
+then:
+ properties:
+ clocks:
+ description:
+ Bus clock gate for LRADC.
+ maxItems: 1
+
+ resets:
+ description:
+ Bus reset for LRADC.
+ maxItems: 1
+
+ required:
+ - clocks
+ - resets
+
patternProperties:
"^button-[0-9]+$":
type: object
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: input: sun4i-lradc-keys: add R329 LRADC binding
2022-04-22 16:07 ` icenowy
@ 2022-04-22 21:10 ` Rob Herring
-1 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-04-22 21:10 UTC (permalink / raw)
To: icenowy
Cc: Maxime Ripard, Hans de Goede, Jernej Skrabec, Chen-Yu Tsai,
devicetree, linux-arm-kernel, linux-sunxi, linux-input,
Icenowy Zheng, Dmitry Torokhov, Rob Herring, Samuel Holland,
linux-kernel
On Sat, 23 Apr 2022 00:07:43 +0800, icenowy@outlook.com wrote:
> From: Icenowy Zheng <icenowy@sipeed.com>
>
> R329 has similar LRADC with previous Allwinner SoCs, but with bus clock
> and reset.
>
> Add binding for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@sipeed.com>
> ---
> .../input/allwinner,sun4i-a10-lradc-keys.yaml | 21 +++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml: then:properties:required: ['clocks', 'resets'] is not of type 'object', 'boolean'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml: ignoring, error in schema: then: properties: required
Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.example.dtb:0:0: /example-0/lradc@1c22800: failed to match any schema with compatible: ['allwinner,sun4i-a10-lradc-keys']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: input: sun4i-lradc-keys: add R329 LRADC binding
@ 2022-04-22 21:10 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-04-22 21:10 UTC (permalink / raw)
To: icenowy
Cc: Maxime Ripard, Hans de Goede, Jernej Skrabec, Chen-Yu Tsai,
devicetree, linux-arm-kernel, linux-sunxi, linux-input,
Icenowy Zheng, Dmitry Torokhov, Rob Herring, Samuel Holland,
linux-kernel
On Sat, 23 Apr 2022 00:07:43 +0800, icenowy@outlook.com wrote:
> From: Icenowy Zheng <icenowy@sipeed.com>
>
> R329 has similar LRADC with previous Allwinner SoCs, but with bus clock
> and reset.
>
> Add binding for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@sipeed.com>
> ---
> .../input/allwinner,sun4i-a10-lradc-keys.yaml | 21 +++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml: then:properties:required: ['clocks', 'resets'] is not of type 'object', 'boolean'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml: ignoring, error in schema: then: properties: required
Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.example.dtb:0:0: /example-0/lradc@1c22800: failed to match any schema with compatible: ['allwinner,sun4i-a10-lradc-keys']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: input: sun4i-lradc-keys: add R329 LRADC binding
2022-04-22 16:07 ` icenowy
@ 2022-04-22 23:28 ` Samuel Holland
-1 siblings, 0 replies; 6+ messages in thread
From: Samuel Holland @ 2022-04-22 23:28 UTC (permalink / raw)
To: Icenowy Zheng, Hans de Goede, Dmitry Torokhov, Rob Herring,
Chen-Yu Tsai, Jernej Skrabec, Maxime Ripard
Cc: linux-input, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel, Icenowy Zheng
Hi Icenowy,
On 4/22/22 11:07 AM, icenowy@outlook.com wrote:
> From: Icenowy Zheng <icenowy@sipeed.com>
>
> R329 has similar LRADC with previous Allwinner SoCs, but with bus clock
> and reset.
>
> Add binding for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@sipeed.com>
I sent this binding/driver update (also with D1 support) last week:
https://lore.kernel.org/lkml/20220414002349.24332-1-samuel@sholland.org/T/
Please see if it works for you.
Regards,
Samuel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: input: sun4i-lradc-keys: add R329 LRADC binding
@ 2022-04-22 23:28 ` Samuel Holland
0 siblings, 0 replies; 6+ messages in thread
From: Samuel Holland @ 2022-04-22 23:28 UTC (permalink / raw)
To: Icenowy Zheng, Hans de Goede, Dmitry Torokhov, Rob Herring,
Chen-Yu Tsai, Jernej Skrabec, Maxime Ripard
Cc: linux-input, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel, Icenowy Zheng
Hi Icenowy,
On 4/22/22 11:07 AM, icenowy@outlook.com wrote:
> From: Icenowy Zheng <icenowy@sipeed.com>
>
> R329 has similar LRADC with previous Allwinner SoCs, but with bus clock
> and reset.
>
> Add binding for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@sipeed.com>
I sent this binding/driver update (also with D1 support) last week:
https://lore.kernel.org/lkml/20220414002349.24332-1-samuel@sholland.org/T/
Please see if it works for you.
Regards,
Samuel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-22 23:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22 16:07 [PATCH 1/2] dt-bindings: input: sun4i-lradc-keys: add R329 LRADC binding icenowy
2022-04-22 16:07 ` icenowy
2022-04-22 21:10 ` Rob Herring
2022-04-22 21:10 ` Rob Herring
2022-04-22 23:28 ` Samuel Holland
2022-04-22 23:28 ` Samuel Holland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.